[two_dimensional_scrollables] Fix tableview janks when first row/column pinned by wangfeihang · Pull Request #180563 · flutter/flutter

wangfeihang · 2026-01-06T09:31:11Z

Description

This PR addresses a critical performance issue where the TableView component experiences severe lag when scrolling to row 15,000 with both the first row and first column pinned.

Root Cause

The _reifyChildren method in RenderTwoDimensionalViewport was consuming excessive CPU resources due to inefficient iteration logic:
It used nested for-loops starting from index 0, iterating through all rows (0 ~ 15K) even when only 4 rows/columns were visible on screen
The pinned first row/column caused unnecessary full-range iteration instead of limiting to the visible viewport

Solution

Optimized the iteration logic in _reifyChildren:
Store only viewport-visible children in _currentChildVicinities
Restrict ParentData calculations in _reifyChildren to only the children within _currentChildVicinities
Eliminated full-range (0 ~ 15K) iterations and focused only on visible elements

Fixes:#138271

Important Note: This fix exclusively resolves the jank associated with pinned rows and columns; the jank in non-pinned scenarios stems from a different root cause and is not included in this commit.

Video performance comparison

before：
https://github.com/user-attachments/assets/b0892dd5-858b-44a6-8f26-37803ce50452

after：
https://github.com/user-attachments/assets/7a6cddf2-04bf-465d-9997-3fdcab5692f7

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

fluttergithubbot · 2026-01-06T09:31:16Z

An existing Git SHA, 31a62a0cccf7f7578d39b1d817329bc802551b4b, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

gemini-code-assist

Code Review

This pull request effectively addresses a performance issue in RenderTwoDimensionalViewport by optimizing the child iteration logic in _reifyChildren. Instead of iterating over all children, the new implementation collects only the visible ones and processes them, which significantly improves performance for large tables with pinned rows or columns. The accompanying test case thoroughly validates that the sorting order of children remains correct after this refactoring. The changes are well-implemented and directly target the described problem. I have one minor suggestion to improve code conciseness.

wangfeihang · 2026-01-07T08:05:43Z

@Piinks Hi Piinks, I've submitted a PR to fix the jank issue that occurs when the first row and first column of the tableview are pinned. Could you please help review it? Thanks a lot!

Piinks

Thanks for the contribution! 💙

wangfeihang · 2026-01-10T12:48:20Z

@Piinks Hi Piinks, I’ve updated the code according to the review feedback. I noticed that there hasn’t been any new progress on this PR lately. Is there anything I can do to help get it merged? Sorry for the bother.

Piinks · 2026-01-14T23:35:02Z

I noticed that there hasn’t been any new progress on this PR lately. Is there anything I can do to help get it merged? Sorry for the bother.

No worries at all. We're still catching up on the PR backlog from the holidays.

Piinks

Thank you for the updates and your patience. This LGTM. It will need a second reviewer, I have requested one. 💙

Renzo-Olivares

LGTM w/ small nits, thank you for the contribution!

Renzo-Olivares

RE-LGTM

…ing lag when scrolling to row 15,000 with pinned first row and column

…ing lag when scrolling to row 15,000 with pinned first row and column, fix flutter analisys failure.

…ing lag when scrolling to row 15,000 with pinned first row and column, fix format

…ing lag when scrolling to row 15,000 with pinned first row and column, unused member variables.

…ing lag when scrolling to row 15,000 with pinned first row and column, remove unused import.

…ing lag when scrolling to row 15,000 with pinned first row and column, add period to comments

…t row/column pinned (flutter/flutter#180563)

Roll Flutter from 46fb7210422d to d3dd7744e81f (33 revisions) flutter/flutter@46fb721...d3dd774 2026-03-04 15619084+vashworth@users.noreply.github.com Show warning when plugins do not support SwiftPM (flutter/flutter#182506) 2026-03-04 15619084+vashworth@users.noreply.github.com Give guided message when project is not compatible with SwiftPM (flutter/flutter#182394) 2026-03-04 danny@tuppeny.com Pass --web-define through to web runner when using --machine mode (flutter/flutter#183228) 2026-03-04 104147021+MohammedTarigg@users.noreply.github.com Improve SwiftPM minimum platform mismatch diagnostics (flutter/flutter#182375) 2026-03-04 vegorov@google.com Use dart::bin::SetupDartIo to setup dart:io (flutter/flutter#176714) 2026-03-04 engine-flutter-autoroll@skia.org Roll Skia from 3197848b14ad to ada0b7628c79 (5 revisions) (flutter/flutter#183221) 2026-03-04 engine-flutter-autoroll@skia.org Roll Skia from fe9e9f22c531 to 3197848b14ad (15 revisions) (flutter/flutter#183198) 2026-03-04 34465683+rkishan516@users.noreply.github.com refactor: remove material in reorderable_list_test, scroll_notification_test, scroll_physics_test, shortcuts_test, sliver_floating_header_test, snapshot_widget_test (flutter/flutter#182698) 2026-03-04 34465683+rkishan516@users.noreply.github.com refactor: remove material in pop_scope_test, route_notification_message_test, two_dimensional_utils, two_dimensional_viewport_test (flutter/flutter#182699) 2026-03-04 737941+loic-sharma@users.noreply.github.com Add dev/benchmarks/README.md (flutter/flutter#182976) 2026-03-03 jason-simmons@users.noreply.github.com Roll RapidJSON to a branch based on the current upstream head (flutter/flutter#183048) 2026-03-03 flar@google.com [Impeller] Update comments to reflect new info about 2-pass rendering (flutter/flutter#183050) 2026-03-03 47866232+chunhtai@users.noreply.github.com Add vmservices for accessibilityEvaluation (flutter/flutter#182791) 2026-03-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0dCDM2oORHwDf_pyb... to JJw5EJ87vLGqFVl4h... (flutter/flutter#183177) 2026-03-03 lukas.klingsbo@gmail.com Support mixed color spaces in `Color.lerp` (flutter/flutter#182934) 2026-03-03 36861262+QuncCccccc@users.noreply.github.com Add warning when there is a widget with color between `Material` and `ListTile` (flutter/flutter#181402) 2026-03-03 41930132+hellohuanlin@users.noreply.github.com [ios]uitest for admob banner in scrollable list gesture issue (flutter/flutter#183128) 2026-03-03 engine-flutter-autoroll@skia.org Roll Packages from faa4e22 to 9083bc9 (4 revisions) (flutter/flutter#183164) 2026-03-03 15619084+vashworth@users.noreply.github.com Build App and native asset frameworks for Add to App FlutterPluginRegistrant (flutter/flutter#183136) 2026-03-03 engine-flutter-autoroll@skia.org Roll Skia from f886711f180d to fe9e9f22c531 (4 revisions) (flutter/flutter#183155) 2026-03-03 engine-flutter-autoroll@skia.org Roll Dart SDK from e86dbe9aa742 to c597ef90d2dc (2 revisions) (flutter/flutter#183147) 2026-03-03 codefu@google.com fix: bump matcher (flutter/flutter#183167) 2026-03-02 58529443+srujzs@users.noreply.github.com Use isA to test for exceptions (flutter/flutter#183129) 2026-03-02 dpxhfxywang@163.com [two_dimensional_scrollables] Fix tableview janks when first row/column pinned (flutter/flutter#180563) 2026-03-02 victorsanniay@gmail.com Add await to callsites of BasicMessageChannel.send (flutter/flutter#182868) 2026-03-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#183133) 2026-03-02 robert.ancell@canonical.com Improve FFI code for windowing (flutter/flutter#183098) 2026-03-02 kevinjchisholm@google.com [workflow] Update the changelog merge action to fetch the stable branch (flutter/flutter#183132) 2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from e180358b7a7a to f886711f180d (2 revisions) (flutter/flutter#183130) 2026-03-02 jacksongardner@google.com Merge changelog from 3.41.3. (flutter/flutter#183131) 2026-03-02 50985133+SpiralMomentum@users.noreply.github.com Make TextDecoration final and unify maskValue across platforms (flutter/flutter#183070) 2026-03-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#182640) 2026-03-02 15619084+vashworth@users.noreply.github.com Enable SwiftPM by default on master and beta (flutter/flutter#182923) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...

…mn pinned (flutter#180563) ### Description This PR addresses a critical performance issue where the TableView component experiences severe lag when scrolling to row 15,000 with both the first row and first column pinned. ### Root Cause The _reifyChildren method in RenderTwoDimensionalViewport was consuming excessive CPU resources due to inefficient iteration logic: It used nested for-loops starting from index 0, iterating through all rows (0 ~ 15K) even when only 4 rows/columns were visible on screen The pinned first row/column caused unnecessary full-range iteration instead of limiting to the visible viewport ### Solution Optimized the iteration logic in _reifyChildren: Store only viewport-visible children in _currentChildVicinities Restrict ParentData calculations in _reifyChildren to only the children within _currentChildVicinities Eliminated full-range (0 ~ 15K) iterations and focused only on visible elements ### Fixes:flutter#138271 Important Note: This fix exclusively resolves the jank associated with pinned rows and columns; the jank in non-pinned scenarios stems from a different root cause and is not included in this commit. ### Video performance comparison before： https://github.com/user-attachments/assets/b0892dd5-858b-44a6-8f26-37803ce50452 after： https://github.com/user-attachments/assets/7a6cddf2-04bf-465d-9997-3fdcab5692f7 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

…r#11182) Roll Flutter from 46fb7210422d to d3dd7744e81f (33 revisions) flutter/flutter@46fb721...d3dd774 2026-03-04 15619084+vashworth@users.noreply.github.com Show warning when plugins do not support SwiftPM (flutter/flutter#182506) 2026-03-04 15619084+vashworth@users.noreply.github.com Give guided message when project is not compatible with SwiftPM (flutter/flutter#182394) 2026-03-04 danny@tuppeny.com Pass --web-define through to web runner when using --machine mode (flutter/flutter#183228) 2026-03-04 104147021+MohammedTarigg@users.noreply.github.com Improve SwiftPM minimum platform mismatch diagnostics (flutter/flutter#182375) 2026-03-04 vegorov@google.com Use dart::bin::SetupDartIo to setup dart:io (flutter/flutter#176714) 2026-03-04 engine-flutter-autoroll@skia.org Roll Skia from 3197848b14ad to ada0b7628c79 (5 revisions) (flutter/flutter#183221) 2026-03-04 engine-flutter-autoroll@skia.org Roll Skia from fe9e9f22c531 to 3197848b14ad (15 revisions) (flutter/flutter#183198) 2026-03-04 34465683+rkishan516@users.noreply.github.com refactor: remove material in reorderable_list_test, scroll_notification_test, scroll_physics_test, shortcuts_test, sliver_floating_header_test, snapshot_widget_test (flutter/flutter#182698) 2026-03-04 34465683+rkishan516@users.noreply.github.com refactor: remove material in pop_scope_test, route_notification_message_test, two_dimensional_utils, two_dimensional_viewport_test (flutter/flutter#182699) 2026-03-04 737941+loic-sharma@users.noreply.github.com Add dev/benchmarks/README.md (flutter/flutter#182976) 2026-03-03 jason-simmons@users.noreply.github.com Roll RapidJSON to a branch based on the current upstream head (flutter/flutter#183048) 2026-03-03 flar@google.com [Impeller] Update comments to reflect new info about 2-pass rendering (flutter/flutter#183050) 2026-03-03 47866232+chunhtai@users.noreply.github.com Add vmservices for accessibilityEvaluation (flutter/flutter#182791) 2026-03-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0dCDM2oORHwDf_pyb... to JJw5EJ87vLGqFVl4h... (flutter/flutter#183177) 2026-03-03 lukas.klingsbo@gmail.com Support mixed color spaces in `Color.lerp` (flutter/flutter#182934) 2026-03-03 36861262+QuncCccccc@users.noreply.github.com Add warning when there is a widget with color between `Material` and `ListTile` (flutter/flutter#181402) 2026-03-03 41930132+hellohuanlin@users.noreply.github.com [ios]uitest for admob banner in scrollable list gesture issue (flutter/flutter#183128) 2026-03-03 engine-flutter-autoroll@skia.org Roll Packages from faa4e22 to 9083bc9 (4 revisions) (flutter/flutter#183164) 2026-03-03 15619084+vashworth@users.noreply.github.com Build App and native asset frameworks for Add to App FlutterPluginRegistrant (flutter/flutter#183136) 2026-03-03 engine-flutter-autoroll@skia.org Roll Skia from f886711f180d to fe9e9f22c531 (4 revisions) (flutter/flutter#183155) 2026-03-03 engine-flutter-autoroll@skia.org Roll Dart SDK from e86dbe9aa742 to c597ef90d2dc (2 revisions) (flutter/flutter#183147) 2026-03-03 codefu@google.com fix: bump matcher (flutter/flutter#183167) 2026-03-02 58529443+srujzs@users.noreply.github.com Use isA to test for exceptions (flutter/flutter#183129) 2026-03-02 dpxhfxywang@163.com [two_dimensional_scrollables] Fix tableview janks when first row/column pinned (flutter/flutter#180563) 2026-03-02 victorsanniay@gmail.com Add await to callsites of BasicMessageChannel.send (flutter/flutter#182868) 2026-03-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#183133) 2026-03-02 robert.ancell@canonical.com Improve FFI code for windowing (flutter/flutter#183098) 2026-03-02 kevinjchisholm@google.com [workflow] Update the changelog merge action to fetch the stable branch (flutter/flutter#183132) 2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from e180358b7a7a to f886711f180d (2 revisions) (flutter/flutter#183130) 2026-03-02 jacksongardner@google.com Merge changelog from 3.41.3. (flutter/flutter#183131) 2026-03-02 50985133+SpiralMomentum@users.noreply.github.com Make TextDecoration final and unify maskValue across platforms (flutter/flutter#183070) 2026-03-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#182640) 2026-03-02 15619084+vashworth@users.noreply.github.com Enable SwiftPM by default on master and beta (flutter/flutter#182923) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...

…mn pinned (flutter#180563) ### Description This PR addresses a critical performance issue where the TableView component experiences severe lag when scrolling to row 15,000 with both the first row and first column pinned. ### Root Cause The _reifyChildren method in RenderTwoDimensionalViewport was consuming excessive CPU resources due to inefficient iteration logic: It used nested for-loops starting from index 0, iterating through all rows (0 ~ 15K) even when only 4 rows/columns were visible on screen The pinned first row/column caused unnecessary full-range iteration instead of limiting to the visible viewport ### Solution Optimized the iteration logic in _reifyChildren: Store only viewport-visible children in _currentChildVicinities Restrict ParentData calculations in _reifyChildren to only the children within _currentChildVicinities Eliminated full-range (0 ~ 15K) iterations and focused only on visible elements ### Fixes:flutter#138271 Important Note: This fix exclusively resolves the jank associated with pinned rows and columns; the jank in non-pinned scenarios stems from a different root cause and is not included in this commit. ### Video performance comparison before： https://github.com/user-attachments/assets/b0892dd5-858b-44a6-8f26-37803ce50452 after： https://github.com/user-attachments/assets/7a6cddf2-04bf-465d-9997-3fdcab5692f7 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

…r#11182) Roll Flutter from 46fb7210422d to d3dd7744e81f (33 revisions) flutter/flutter@46fb721...d3dd774 2026-03-04 15619084+vashworth@users.noreply.github.com Show warning when plugins do not support SwiftPM (flutter/flutter#182506) 2026-03-04 15619084+vashworth@users.noreply.github.com Give guided message when project is not compatible with SwiftPM (flutter/flutter#182394) 2026-03-04 danny@tuppeny.com Pass --web-define through to web runner when using --machine mode (flutter/flutter#183228) 2026-03-04 104147021+MohammedTarigg@users.noreply.github.com Improve SwiftPM minimum platform mismatch diagnostics (flutter/flutter#182375) 2026-03-04 vegorov@google.com Use dart::bin::SetupDartIo to setup dart:io (flutter/flutter#176714) 2026-03-04 engine-flutter-autoroll@skia.org Roll Skia from 3197848b14ad to ada0b7628c79 (5 revisions) (flutter/flutter#183221) 2026-03-04 engine-flutter-autoroll@skia.org Roll Skia from fe9e9f22c531 to 3197848b14ad (15 revisions) (flutter/flutter#183198) 2026-03-04 34465683+rkishan516@users.noreply.github.com refactor: remove material in reorderable_list_test, scroll_notification_test, scroll_physics_test, shortcuts_test, sliver_floating_header_test, snapshot_widget_test (flutter/flutter#182698) 2026-03-04 34465683+rkishan516@users.noreply.github.com refactor: remove material in pop_scope_test, route_notification_message_test, two_dimensional_utils, two_dimensional_viewport_test (flutter/flutter#182699) 2026-03-04 737941+loic-sharma@users.noreply.github.com Add dev/benchmarks/README.md (flutter/flutter#182976) 2026-03-03 jason-simmons@users.noreply.github.com Roll RapidJSON to a branch based on the current upstream head (flutter/flutter#183048) 2026-03-03 flar@google.com [Impeller] Update comments to reflect new info about 2-pass rendering (flutter/flutter#183050) 2026-03-03 47866232+chunhtai@users.noreply.github.com Add vmservices for accessibilityEvaluation (flutter/flutter#182791) 2026-03-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0dCDM2oORHwDf_pyb... to JJw5EJ87vLGqFVl4h... (flutter/flutter#183177) 2026-03-03 lukas.klingsbo@gmail.com Support mixed color spaces in `Color.lerp` (flutter/flutter#182934) 2026-03-03 36861262+QuncCccccc@users.noreply.github.com Add warning when there is a widget with color between `Material` and `ListTile` (flutter/flutter#181402) 2026-03-03 41930132+hellohuanlin@users.noreply.github.com [ios]uitest for admob banner in scrollable list gesture issue (flutter/flutter#183128) 2026-03-03 engine-flutter-autoroll@skia.org Roll Packages from faa4e22 to 9083bc9 (4 revisions) (flutter/flutter#183164) 2026-03-03 15619084+vashworth@users.noreply.github.com Build App and native asset frameworks for Add to App FlutterPluginRegistrant (flutter/flutter#183136) 2026-03-03 engine-flutter-autoroll@skia.org Roll Skia from f886711f180d to fe9e9f22c531 (4 revisions) (flutter/flutter#183155) 2026-03-03 engine-flutter-autoroll@skia.org Roll Dart SDK from e86dbe9aa742 to c597ef90d2dc (2 revisions) (flutter/flutter#183147) 2026-03-03 codefu@google.com fix: bump matcher (flutter/flutter#183167) 2026-03-02 58529443+srujzs@users.noreply.github.com Use isA to test for exceptions (flutter/flutter#183129) 2026-03-02 dpxhfxywang@163.com [two_dimensional_scrollables] Fix tableview janks when first row/column pinned (flutter/flutter#180563) 2026-03-02 victorsanniay@gmail.com Add await to callsites of BasicMessageChannel.send (flutter/flutter#182868) 2026-03-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#183133) 2026-03-02 robert.ancell@canonical.com Improve FFI code for windowing (flutter/flutter#183098) 2026-03-02 kevinjchisholm@google.com [workflow] Update the changelog merge action to fetch the stable branch (flutter/flutter#183132) 2026-03-02 engine-flutter-autoroll@skia.org Roll Skia from e180358b7a7a to f886711f180d (2 revisions) (flutter/flutter#183130) 2026-03-02 jacksongardner@google.com Merge changelog from 3.41.3. (flutter/flutter#183131) 2026-03-02 50985133+SpiralMomentum@users.noreply.github.com Make TextDecoration final and unify maskValue across platforms (flutter/flutter#183070) 2026-03-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#182640) 2026-03-02 15619084+vashworth@users.noreply.github.com Enable SwiftPM by default on master and beta (flutter/flutter#182923) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Jan 6, 2026

gemini-code-assist Bot reviewed Jan 6, 2026

View reviewed changes

Comment thread packages/flutter/lib/src/widgets/two_dimensional_viewport.dart

wangfeihang changed the title ~~Fix tableview janks~~ [two_dimensional_scrollables] Fix tableview janks when first row/column pinned Jan 7, 2026

Piinks reviewed Jan 7, 2026

View reviewed changes

Comment thread packages/flutter/test/widgets/two_dimensional_viewport_test.dart Outdated

Piinks reviewed Jan 7, 2026

View reviewed changes

Comment thread packages/flutter/lib/src/widgets/two_dimensional_viewport.dart Outdated

Piinks reviewed Jan 7, 2026

View reviewed changes

wangfeihang requested a review from Piinks January 8, 2026 04:44

wangfeihang mentioned this pull request Jan 9, 2026

Tableview widget janks execessively with >250k rows #138271

Closed

2 tasks

Piinks reviewed Jan 14, 2026

View reviewed changes

Comment thread packages/flutter/lib/src/widgets/two_dimensional_viewport.dart

wangfeihang requested a review from Piinks January 15, 2026 06:16

Piinks force-pushed the fix_tableview_janks branch from c350efa to cb2b83e Compare February 3, 2026 18:16

Piinks approved these changes Feb 3, 2026

View reviewed changes

justinmc requested a review from Renzo-Olivares February 10, 2026 23:09

Renzo-Olivares approved these changes Feb 12, 2026

View reviewed changes

Comment thread packages/flutter/test/widgets/two_dimensional_viewport_test.dart Outdated

Comment thread packages/flutter/test/widgets/two_dimensional_viewport_test.dart Outdated

Renzo-Olivares approved these changes Mar 2, 2026

View reviewed changes

wangfeihang added 8 commits March 2, 2026 11:55

Fix performance issue: TwoDimensionalViewport causes TableView scroll…

be53d17

…ing lag when scrolling to row 15,000 with pinned first row and column

Fix performance issue: TwoDimensionalViewport causes TableView scroll…

e29ce37

…ing lag when scrolling to row 15,000 with pinned first row and column

Fix performance issue: TwoDimensionalViewport causes TableView scroll…

cabce35

…ing lag when scrolling to row 15,000 with pinned first row and column

Fix performance issue: TwoDimensionalViewport causes TableView scroll…

da80f5e

…ing lag when scrolling to row 15,000 with pinned first row and column, fix flutter analisys failure.

Fix performance issue: TwoDimensionalViewport causes TableView scroll…

e6db927

…ing lag when scrolling to row 15,000 with pinned first row and column, fix format

Fix performance issue: TwoDimensionalViewport causes TableView scroll…

44b1bd7

…ing lag when scrolling to row 15,000 with pinned first row and column, unused member variables.

Fix performance issue: TwoDimensionalViewport causes TableView scroll…

51bb6bd

…ing lag when scrolling to row 15,000 with pinned first row and column, remove unused import.

Fix performance issue: TwoDimensionalViewport causes TableView scroll…

7cef22e

…ing lag when scrolling to row 15,000 with pinned first row and column, add period to comments

Renzo-Olivares force-pushed the fix_tableview_janks branch from a5b826f to 7cef22e Compare March 2, 2026 19:55

Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 2, 2026

engine-flutter-autoroll mentioned this pull request Mar 3, 2026

Roll Flutter from 46fb7210422d to 6593592c450e (11 revisions) flutter/packages#11170

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2026

8f2e7b71d [two_dimensional_scrollables] Fix tableview janks when firs…

2e70ac8

…t row/column pinned (flutter/flutter#180563)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2026

8f2e7b71d [two_dimensional_scrollables] Fix tableview janks when firs…

d1cbc40

…t row/column pinned (flutter/flutter#180563)

This was referenced Mar 3, 2026

Roll Flutter from 46fb7210422d to 915a972eb2d6 (12 revisions) flutter/packages#11174

Closed

Roll Flutter from 46fb7210422d to eb0b756f6e05 (29 revisions) flutter/packages#11176

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2026

8f2e7b71d [two_dimensional_scrollables] Fix tableview janks when firs…

22107e2

…t row/column pinned (flutter/flutter#180563)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2026

8f2e7b71d [two_dimensional_scrollables] Fix tableview janks when firs…

cdadcbb

…t row/column pinned (flutter/flutter#180563)

engine-flutter-autoroll mentioned this pull request Mar 4, 2026

Roll Flutter from 46fb7210422d to eb0b756f6e05 (29 revisions) flutter/packages#11177

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2026

8f2e7b71d [two_dimensional_scrollables] Fix tableview janks when firs…

b197ec6

…t row/column pinned (flutter/flutter#180563)

engine-flutter-autoroll mentioned this pull request Mar 4, 2026

Roll Flutter from 46fb7210422d to 6ec6dd191477 (30 revisions) flutter/packages#11178

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2026

8f2e7b71d [two_dimensional_scrollables] Fix tableview janks when firs…

6ea9c86

…t row/column pinned (flutter/flutter#180563)

engine-flutter-autoroll mentioned this pull request Mar 4, 2026

Roll Flutter from 46fb7210422d to b5afa98fc52b (31 revisions) flutter/packages#11179

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2026

8f2e7b71d [two_dimensional_scrollables] Fix tableview janks when firs…

d90d8c3

…t row/column pinned (flutter/flutter#180563)

engine-flutter-autoroll mentioned this pull request Mar 4, 2026

Roll Flutter from 46fb7210422d to 9895434fc2a4 (32 revisions) flutter/packages#11181

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2026

8f2e7b71d [two_dimensional_scrollables] Fix tableview janks when firs…

e852244

…t row/column pinned (flutter/flutter#180563)

engine-flutter-autoroll mentioned this pull request Mar 4, 2026

Roll Flutter from 46fb7210422d to d3dd7744e81f (33 revisions) flutter/packages#11182

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2026

8f2e7b71d [two_dimensional_scrollables] Fix tableview janks when firs…

ebf4f9c

…t row/column pinned (flutter/flutter#180563)

engine-flutter-autoroll mentioned this pull request Mar 5, 2026

Roll Flutter from 46fb7210422d to 308649c0cd1b (43 revisions) flutter/packages#11183

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2026

8f2e7b71d [two_dimensional_scrollables] Fix tableview janks when firs…

f7a7fe8

…t row/column pinned (flutter/flutter#180563)

engine-flutter-autoroll mentioned this pull request Mar 5, 2026

Roll Flutter from 46fb7210422d to 308649c0cd1b (43 revisions) flutter/packages#11184

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2026

8f2e7b71d [two_dimensional_scrollables] Fix tableview janks when firs…

a3b1d85

…t row/column pinned (flutter/flutter#180563)

engine-flutter-autoroll mentioned this pull request Mar 5, 2026

Roll Flutter from 46fb7210422d to 3c323fb06507 (44 revisions) flutter/packages#11186

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2026

8f2e7b71d [two_dimensional_scrollables] Fix tableview janks when firs…

1342dd6

…t row/column pinned (flutter/flutter#180563)

engine-flutter-autoroll mentioned this pull request Mar 5, 2026

Roll Flutter from 46fb7210422d to 1488fd4783de (45 revisions) flutter/packages#11187

Closed

Piinks mentioned this pull request Mar 6, 2026

Flutter Notable Commits - 2026 #181433

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[two_dimensional_scrollables] Fix tableview janks when first row/column pinned#180563

[two_dimensional_scrollables] Fix tableview janks when first row/column pinned#180563
auto-submit[bot] merged 8 commits into
flutter:masterfrom
wangfeihang:fix_tableview_janks

wangfeihang commented Jan 6, 2026 •

edited

Loading

Uh oh!

fluttergithubbot commented Jan 6, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

wangfeihang commented Jan 7, 2026

Uh oh!

Uh oh!

Uh oh!

Piinks left a comment

Uh oh!

wangfeihang commented Jan 10, 2026

Uh oh!

Piinks commented Jan 14, 2026

Uh oh!

Uh oh!

Piinks left a comment

Uh oh!

Renzo-Olivares left a comment

Uh oh!

Uh oh!

Uh oh!

Renzo-Olivares left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

wangfeihang commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Root Cause

Solution

Fixes:#138271

Video performance comparison

Pre-launch Checklist

Uh oh!

fluttergithubbot commented Jan 6, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

wangfeihang commented Jan 7, 2026

Uh oh!

Uh oh!

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

wangfeihang commented Jan 10, 2026

Uh oh!

Piinks commented Jan 14, 2026

Uh oh!

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Renzo-Olivares left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wangfeihang commented Jan 6, 2026 •

edited

Loading