Update engine.version for 3.38.10 stable hotfix release#182095
Conversation
…sh > bin/internal/engine.version
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
There was a problem hiding this comment.
Code Review
This pull request appears to be a hotfix release that incorporates a wide range of changes, including dependency updates for CI and Android projects, engine fixes for various platforms, and significant improvements to the Flutter tool's reliability and user experience. Key changes include more robust crash handling, improved diagnostics for Xcode and Gradle builds, and substantial enhancements to the widget preview feature. My review found one area for improvement in path validation logic to make it more robust.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/flutter_tools/lib/src/widget_preview/preview_detector.dart (133)
Using String.contains for path validation can be unreliable. For instance, if a user's project is located at a path like /Users/me/my_build/my_app, this check would incorrectly ignore file events within the project because 'build' is a common name for an ephemeral directory.
Using fs.path.isWithin provides a more robust way to check if a path is contained within another.
project.ephemeralDirectories.any((dir) => fs.path.isWithin(dir.path, eventPath))) {
c6f67de
into
flutter:flutter-3.38-candidate.0
I messed up thinking that I didn't need to do this since no cherry pick affected the engine. Instead, I need to update it with the SHA from #181926.