Update DEPS for 3.38.10 stable hotfix release#181926
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
camsim99
left a comment
There was a problem hiding this comment.
The changes lgtm so wondering what is causing the errors. Were the Dart dependencies updated correctly?
|
It's unlikely that that many deps changed since the last stable dart, so you probably forgot to do a |
This reverts commit 1a2efb6.
|
It looks like I had the wrong dart_revision. The docs led me astray so I've updated them in cl/866138353. Now I guess there are no changes at all 🤷 . |
cafcda5
into
flutter:flutter-3.38-candidate.0
I messed up thinking that I didn't need to do this since no cherry pick affected the engine. Instead, I need to update it with the SHA from #181926.
Only one cherry pick: #181607. It doesn't touch the engine, so no need to change engine.version.