Reverts "Fix capitalization of the path to FlutterWindowControllerTest.mm in the macOS platform build script (#181045)"#181091
Merged
auto-submit[bot] merged 1 commit intoJan 16, 2026
Conversation
fluttergithubbot
approved these changes
Jan 16, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 17, 2026
…trollerTest.mm in the macOS platform build script (#181045)" (flutter/flutter#181091)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 17, 2026
…trollerTest.mm in the macOS platform build script (#181045)" (flutter/flutter#181091)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 17, 2026
…trollerTest.mm in the macOS platform build script (#181045)" (flutter/flutter#181091)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 18, 2026
…trollerTest.mm in the macOS platform build script (#181045)" (flutter/flutter#181091)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 18, 2026
…trollerTest.mm in the macOS platform build script (#181045)" (flutter/flutter#181091)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 19, 2026
…trollerTest.mm in the macOS platform build script (#181045)" (flutter/flutter#181091)
calltekk
pushed a commit
to calltekk/flutter
that referenced
this pull request
Jan 19, 2026
…t.mm in the macOS platform build script (flutter#181045)" (flutter#181091) <!-- start_original_pr_link --> Reverts: flutter#181045 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: jason-simmons <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: `FlutterWindowControllerTest.mm` has clang-tidy warnings. The clang_tidy script did not previously process this file because the capitalization of the file's path in `compile_commands.json` (derived from `BUILD.gn`) did not match the path in the source tree. <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: jason-simmons <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {jtmcdole, jmagman} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: Fixes flutter#180963 <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 19, 2026
…trollerTest.mm in the macOS platform build script (#181045)" (flutter/flutter#181091)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 19, 2026
…trollerTest.mm in the macOS platform build script (#181045)" (flutter/flutter#181091)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 20, 2026
…trollerTest.mm in the macOS platform build script (#181045)" (flutter/flutter#181091)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 20, 2026
…trollerTest.mm in the macOS platform build script (#181045)" (flutter/flutter#181091)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 20, 2026
…trollerTest.mm in the macOS platform build script (#181045)" (flutter/flutter#181091)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 20, 2026
…trollerTest.mm in the macOS platform build script (#181045)" (flutter/flutter#181091)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 20, 2026
…trollerTest.mm in the macOS platform build script (#181045)" (flutter/flutter#181091)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 21, 2026
…trollerTest.mm in the macOS platform build script (#181045)" (flutter/flutter#181091)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 21, 2026
…trollerTest.mm in the macOS platform build script (#181045)" (flutter/flutter#181091)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 21, 2026
…trollerTest.mm in the macOS platform build script (#181045)" (flutter/flutter#181091)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 22, 2026
…trollerTest.mm in the macOS platform build script (#181045)" (flutter/flutter#181091)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 22, 2026
…trollerTest.mm in the macOS platform build script (#181045)" (flutter/flutter#181091)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 22, 2026
…trollerTest.mm in the macOS platform build script (#181045)" (flutter/flutter#181091)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 23, 2026
…trollerTest.mm in the macOS platform build script (#181045)" (flutter/flutter#181091)
flutter-zl
pushed a commit
to flutter-zl/flutter
that referenced
this pull request
Feb 10, 2026
…t.mm in the macOS platform build script (flutter#181045)" (flutter#181091) <!-- start_original_pr_link --> Reverts: flutter#181045 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: jason-simmons <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: `FlutterWindowControllerTest.mm` has clang-tidy warnings. The clang_tidy script did not previously process this file because the capitalization of the file's path in `compile_commands.json` (derived from `BUILD.gn`) did not match the path in the source tree. <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: jason-simmons <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {jtmcdole, jmagman} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: Fixes flutter#180963 <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts: #181045
Initiated by: jason-simmons
Reason for reverting:
FlutterWindowControllerTest.mmhas clang-tidy warnings.The clang_tidy script did not previously process this file because the capitalization of the file's path in
compile_commands.json(derived fromBUILD.gn) did not match the path in the source tree.Original PR Author: jason-simmons
Reviewed By: {jtmcdole, jmagman}
This change reverts the following previous change:
Fixes #180963