Skip to content

Fix capitalization of the path to FlutterWindowControllerTest.mm in the macOS platform build script#181045

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
jason-simmons:bug_180963
Jan 16, 2026
Merged

Fix capitalization of the path to FlutterWindowControllerTest.mm in the macOS platform build script#181045
auto-submit[bot] merged 1 commit into
flutter:masterfrom
jason-simmons:bug_180963

Conversation

@jason-simmons

@jason-simmons jason-simmons commented Jan 15, 2026

Copy link
Copy Markdown
Member

Fixes #180963

@github-actions github-actions Bot added engine flutter/engine related. See also e: labels. a: desktop Running on desktop platform-macos labels Jan 15, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jan 15, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes the capitalization of a file path in the BUILD.gn file for macOS unit tests. The path for FlutterWindowControllerTest.mm was using a lowercase source directory, which has been corrected to Source. Additionally, the file has been moved to its correct alphabetical position within the sources list.

@jmagman

jmagman commented Jan 15, 2026

Copy link
Copy Markdown
Member

@jason-simmons is the problem that we aren't gn formating (or whatever gn linting) in CI? Or just that the CI bot isn't case-sensitive?

@jason-simmons

jason-simmons commented Jan 15, 2026

Copy link
Copy Markdown
Member Author

We do not have any macOS CI environment that uses a case-sensitive filesystem which would catch this.

The CI scripts do check the formatting of GN files.

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 16, 2026
@auto-submit auto-submit Bot added this pull request to the merge queue Jan 16, 2026
Merged via the queue into flutter:master with commit 3ca6ba1 Jan 16, 2026
179 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 16, 2026
@victorsanni

victorsanni commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

This PR might be closing the tree.

Logs:

❌ Failures for clang-tidy on /Volumes/Work/s/w/ir/cache/builder/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterWindowControllerTest.mm:
/Volumes/Work/s/w/ir/cache/builder/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterWindowControllerTest.mm:33:5: error: Address of stack memory associated with local variable 'signalled' is still referred to by the static variable 'closure' upon returning to the caller.  This will be a dangling reference [clang-analyzer-core.StackAddressEscape,-warnings-as-errors]
   26 |     bool signalled = false;
      |     ~~~~~~~~~~~~~~~~~~~~~~
   27 | 
   28 |     AddNativeCallback("SignalNativeTest", CREATE_NATIVE_ENTRY([&](Dart_NativeArguments args) {
   29 |                         isolate_ = Isolate::Current();
   30 |                         signalled = true;
   31 |                       }));
   32 | 
   33 |     while (!signalled) {
      |     ^
/Volumes/Work/s/w/ir/cache/builder/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterWindowControllerTest.mm:33:12: note: Assuming 'signalled' is true
   33 |     while (!signalled) {
      |            ^~~~~~~~~~
/Volumes/Work/s/w/ir/cache/builder/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterWindowControllerTest.mm:33:5: note: Loop condition is false. Execution jumps to the end of the function
   33 |     while (!signalled) {
      |     ^
/Volumes/Work/s/w/ir/cache/builder/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterWindowControllerTest.mm:33:5: note: Address of stack memory associated with local variable 'signalled' is still referred to by the static variable 'closure' upon returning to the caller.  This will be a dangling reference
   26 |     bool signalled = false;
      |     ~~~~~~~~~~~~~~~~~~~~~~
   27 | 
   28 |     AddNativeCallback("SignalNativeTest", CREATE_NATIVE_ENTRY([&](Dart_NativeArguments args) {
   29 |                         isolate_ = Isolate::Current();
   30 |                         signalled = true;
   31 |                       }));
   32 | 
   33 |     while (!signalled) {
      |     ^
/Volumes/Work/s/w/ir/cache/builder/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterWindowControllerTest.mm:147:37: error: avoid using "_" in test name "InternalFlutter_Window_GetHandle" according to Googletest FAQ [google-readability-avoid-underscore-in-googletest-name,-warnings-as-errors]
  147 | TEST_F(FlutterWindowControllerTest, InternalFlutter_Window_GetHandle) {
      |                                     ^
Suppressed 3529 warnings (3371 in non-user code, 158 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2 warnings treated as errors

@victorsanni

victorsanni commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

This PR might be closing the tree.

Maybe not, but the error logs and this PR both reference FlutterWindowControllerTest.mm.

@jason-simmons

jason-simmons commented Jan 16, 2026

Copy link
Copy Markdown
Member Author

Reason for revert:
FlutterWindowControllerTest.mm has clang-tidy warnings.

The clang_tidy script did not previously process this file because the capitalization of the file's path in compile_commands.json (derived from BUILD.gn) did not match the path in the source tree.

@jason-simmons jason-simmons added the revert Autorevert PR (with "Reason for revert:" comment) label Jan 16, 2026
auto-submit Bot pushed a commit that referenced this pull request Jan 16, 2026
Revert "Fix capitalization of the path to FlutterWindowControllerTest…
c5abd15 
….mm in the macOS platform build script (#181045)"

This reverts commit 3ca6ba1.
@auto-submit auto-submit Bot mentioned this pull request Jan 16, 2026
Merged
@auto-submit auto-submit Bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jan 16, 2026
github-merge-queue Bot pushed a commit that referenced this pull request Jan 16, 2026
@auto-submit
Reverts "Fix capitalization of the path to FlutterWindowControllerTes…
af121ba 
…t.mm in the macOS platform build script (#181045)" (#181091)

<!-- start_original_pr_link -->
Reverts: #181045
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jason-simmons
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: `FlutterWindowControllerTest.mm` has clang-tidy
warnings.

The clang_tidy script did not previously process this file because the
capitalization of the file's path in `compile_commands.json` (derived
from `BUILD.gn`) did not match the path in the source tree.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jason-simmons
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jtmcdole, jmagman}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Fixes #180963
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 17, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2026
@engine-flutter-autoroll
3ca6ba179 Fix capitalization of the path to FlutterWindowControllerTe…
3fca1dc 
…st.mm in the macOS platform build script (flutter/flutter#181045)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 17, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2026
@engine-flutter-autoroll
3ca6ba179 Fix capitalization of the path to FlutterWindowControllerTe…
f8be5d2 
…st.mm in the macOS platform build script (flutter/flutter#181045)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 17, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2026
@engine-flutter-autoroll
3ca6ba179 Fix capitalization of the path to FlutterWindowControllerTe…
f083248 
…st.mm in the macOS platform build script (flutter/flutter#181045)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 18, 2026
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 18, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2026
@engine-flutter-autoroll
3ca6ba179 Fix capitalization of the path to FlutterWindowControllerTe…
7f89ea9 
…st.mm in the macOS platform build script (flutter/flutter#181045)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 19, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2026
@engine-flutter-autoroll
3ca6ba179 Fix capitalization of the path to FlutterWindowControllerTe…
d736357 
…st.mm in the macOS platform build script (flutter/flutter#181045)
calltekk pushed a commit to calltekk/flutter that referenced this pull request Jan 19, 2026
@jason-simmons @calltekk
Fix capitalization of the path to FlutterWindowControllerTest.mm in t…
738ccfa 
…he macOS platform build script (flutter#181045)

Fixes flutter#180963
calltekk pushed a commit to calltekk/flutter that referenced this pull request Jan 19, 2026
@auto-submit @calltekk
Reverts "Fix capitalization of the path to FlutterWindowControllerTes…
04a5e3c 
…t.mm in the macOS platform build script (flutter#181045)" (flutter#181091)

<!-- start_original_pr_link -->
Reverts: flutter#181045
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jason-simmons
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: `FlutterWindowControllerTest.mm` has clang-tidy
warnings.

The clang_tidy script did not previously process this file because the
capitalization of the file's path in `compile_commands.json` (derived
from `BUILD.gn`) did not match the path in the source tree.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jason-simmons
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jtmcdole, jmagman}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Fixes flutter#180963
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 19, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2026
@engine-flutter-autoroll
3ca6ba179 Fix capitalization of the path to FlutterWindowControllerTe…
54e59fd 
…st.mm in the macOS platform build script (flutter/flutter#181045)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 19, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2026
@engine-flutter-autoroll
3ca6ba179 Fix capitalization of the path to FlutterWindowControllerTe…
5e6fd78 
…st.mm in the macOS platform build script (flutter/flutter#181045)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 20, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026
@engine-flutter-autoroll
3ca6ba179 Fix capitalization of the path to FlutterWindowControllerTe…
ec8358c 
…st.mm in the macOS platform build script (flutter/flutter#181045)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 20, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026
@engine-flutter-autoroll
3ca6ba179 Fix capitalization of the path to FlutterWindowControllerTe…
29cf99f 
…st.mm in the macOS platform build script (flutter/flutter#181045)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 20, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026
@engine-flutter-autoroll
3ca6ba179 Fix capitalization of the path to FlutterWindowControllerTe…
8226a18 
…st.mm in the macOS platform build script (flutter/flutter#181045)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 20, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026
@engine-flutter-autoroll
3ca6ba179 Fix capitalization of the path to FlutterWindowControllerTe…
5d82d63 
…st.mm in the macOS platform build script (flutter/flutter#181045)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2026
@engine-flutter-autoroll
3ca6ba179 Fix capitalization of the path to FlutterWindowControllerTe…
5e7b873 
…st.mm in the macOS platform build script (flutter/flutter#181045)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2026
@engine-flutter-autoroll
3ca6ba179 Fix capitalization of the path to FlutterWindowControllerTe…
cfef4ab 
…st.mm in the macOS platform build script (flutter/flutter#181045)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2026
@engine-flutter-autoroll
3ca6ba179 Fix capitalization of the path to FlutterWindowControllerTe…
65fd574 
…st.mm in the macOS platform build script (flutter/flutter#181045)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 21, 2026
@engine-flutter-autoroll
3ca6ba179 Fix capitalization of the path to FlutterWindowControllerTe…
a0c817d 
…st.mm in the macOS platform build script (flutter/flutter#181045)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026
@engine-flutter-autoroll
3ca6ba179 Fix capitalization of the path to FlutterWindowControllerTe…
9291180 
…st.mm in the macOS platform build script (flutter/flutter#181045)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026
@engine-flutter-autoroll
3ca6ba179 Fix capitalization of the path to FlutterWindowControllerTe…
3254309 
…st.mm in the macOS platform build script (flutter/flutter#181045)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2026
@engine-flutter-autoroll
3ca6ba179 Fix capitalization of the path to FlutterWindowControllerTe…
33f0c4c 
…st.mm in the macOS platform build script (flutter/flutter#181045)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2026
@engine-flutter-autoroll
3ca6ba179 Fix capitalization of the path to FlutterWindowControllerTe…
d1e535d 
…st.mm in the macOS platform build script (flutter/flutter#181045)
flutter-zl pushed a commit to flutter-zl/flutter that referenced this pull request Feb 10, 2026
@jason-simmons @flutter-zl
Fix capitalization of the path to FlutterWindowControllerTest.mm in t…
9ed7d3e 
…he macOS platform build script (flutter#181045)

Fixes flutter#180963
flutter-zl pushed a commit to flutter-zl/flutter that referenced this pull request Feb 10, 2026
@auto-submit @flutter-zl
Reverts "Fix capitalization of the path to FlutterWindowControllerTes…
5f6212c 
…t.mm in the macOS platform build script (flutter#181045)" (flutter#181091)

<!-- start_original_pr_link -->
Reverts: flutter#181045
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jason-simmons
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: `FlutterWindowControllerTest.mm` has clang-tidy
warnings.

The clang_tidy script did not previously process this file because the
capitalization of the file's path in `compile_commands.json` (derived
from `BUILD.gn`) did not match the path in the source tree.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jason-simmons
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jtmcdole, jmagman}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Fixes flutter#180963
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
@stuartmorgan-g stuartmorgan-g added platform-macos Building on or for macOS specifically and removed platform-macos labels Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes
@jtmcdole jtmcdole jtmcdole approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: desktop Running on desktop engine flutter/engine related. See also e: labels. platform-macos Building on or for macOS specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build error: Incorrect file path casing on case-sensitive filesystem prevents macOS build

5 participants

@jason-simmons @jmagman @victorsanni @jtmcdole @stuartmorgan-g