Make HCPP upgrading work for vd/tlhc by gmackall · Pull Request #181024 · flutter/flutter

gmackall · 2026-01-15T06:48:54Z

Before the change we get a NPE when trying to cast the return of the create message as an int.

There are also some more changes needed on top of the change to the cast, making the TextureAndroidViewController aware of if it is using HCPP and exposing that bool for use in packages/flutter/lib/src/rendering/platform_view.dart

This is untested because it currently isn't possible to use HCPP without uncommenting the code block here:

flutter/engine/src/flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/PlatformViewsChannel.java

Line 95 in 2beceb6

// TODO(gmackall): Enable hcpp path in a follow up PR to

It will be tested in the follow up pr which adds the cli flag, uncomments the block, and adds golden tests that we can upgrade each of the 3 legacy modes.

Fixes #181000

gemini-code-assist

Code Review

This pull request correctly implements the fallback mechanism to HCPP for TextureAndroidViewController, addressing a potential null pointer exception. The changes are logical and well-contained. The modifications in RenderAndroidView to handle composition-based views are also appropriate.

The pull request description mentions that these changes are currently untested, with a plan for testing in a follow-up PR. While untested changes are generally a concern, the plan to add tests in a subsequent PR is noted. Please ensure that the follow-up testing is comprehensive.

reidbaker · 2026-02-05T16:01:35Z

  @override
  void paint(PaintingContext context, Offset offset) {
-    if (_viewController.textureId == null || _currentTextureSize == null) {
+    if ((_viewController.textureId == null && !_viewController.requiresViewComposition) ||


Double check on this logic change is your intent
(Null texture id and does not require view composition) or (null texture size)?

Yes, otherwise we would return early from paint in all cases in the hcpp flow, which is not what we would want (because texture id is always null in that case).

reidbaker · 2026-02-05T16:03:47Z


  @override
  Future<Size> _sendResizeMessage(Size size) {
+    if (_internals.requiresViewComposition) {


Can you add a comment explaining why this does not need to send the resize message?

reidbaker · 2026-02-05T16:04:00Z


  @override
  Future<void> setOffset(Offset off) {
+    if (_internals.requiresViewComposition) {


same here for offset

Before the change we get a NPE when trying to cast the return of the create message as an int. There are also some more changes needed on top of the change to the cast, making the `TextureAndroidViewController` aware of if it is using HCPP and exposing that bool for use in `packages/flutter/lib/src/rendering/platform_view.dart` This is untested because it currently isn't possible to use HCPP without uncommenting the code block here: https://github.com/flutter/flutter/blob/2beceb6b1c0701ce0d3289dec41c7fa7f8678b9e/engine/src/flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/PlatformViewsChannel.java#L95 It will be tested in the follow up pr which adds the cli flag, uncomments the block, and adds golden tests that we can upgrade each of the 3 legacy modes. Fixes flutter#181000 --------- Co-authored-by: Gray Mackall <mackall@google.com>

This reverts commit a191754.

This reverts commits a191754 and 242d4f9 as a fix for b/483943343 and a speculative fix for b/489613062. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…ter#183310) This reverts commit b53c2e6.

…er#183310) This reverts commits flutter@a191754 and flutter@242d4f9 as a fix for b/483943343 and a speculative fix for b/489613062. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…183360) Undo the revert, as it was not the problem. Co-authored-by: Gray Mackall <mackall@google.com> Co-authored-by: Jenn Magder <magder@google.com>

Before the change we get a NPE when trying to cast the return of the create message as an int. There are also some more changes needed on top of the change to the cast, making the `TextureAndroidViewController` aware of if it is using HCPP and exposing that bool for use in `packages/flutter/lib/src/rendering/platform_view.dart` This is untested because it currently isn't possible to use HCPP without uncommenting the code block here: https://github.com/flutter/flutter/blob/2beceb6b1c0701ce0d3289dec41c7fa7f8678b9e/engine/src/flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/PlatformViewsChannel.java#L95 It will be tested in the follow up pr which adds the cli flag, uncomments the block, and adds golden tests that we can upgrade each of the 3 legacy modes. Fixes flutter#181000 --------- Co-authored-by: Gray Mackall <mackall@google.com>

…er#183310) This reverts commits flutter@a191754 and flutter@242d4f9 as a fix for b/483943343 and a speculative fix for b/489613062. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…ter#183310) (flutter#183360) Undo the revert, as it was not the problem. Co-authored-by: Gray Mackall <mackall@google.com> Co-authored-by: Jenn Magder <magder@google.com>

…er#183310) This reverts commits flutter@a191754 and flutter@242d4f9 as a fix for b/483943343 and a speculative fix for b/489613062. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…ter#183310) (flutter#183360) Undo the revert, as it was not the problem. Co-authored-by: Gray Mackall <mackall@google.com> Co-authored-by: Jenn Magder <magder@google.com>

mackall-work added 2 commits January 14, 2026 22:03

make the vd/tlhc path not npe when doing the hcpp upgrade

35554ca

more

c196038

github-actions Bot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 15, 2026

mackall-work and others added 2 commits January 15, 2026 12:25

format

b980948

Merge branch 'master' into hcpp_upgrading_for_vd_or_tlhc

e783c66

gmackall marked this pull request as ready for review February 4, 2026 20:38

gmackall requested a review from a team February 4, 2026 20:38

gemini-code-assist Bot reviewed Feb 4, 2026

View reviewed changes

reidbaker approved these changes Feb 5, 2026

View reviewed changes

mackall-work and others added 2 commits February 5, 2026 09:28

remove comment

0225237

Merge branch 'master' into hcpp_upgrading_for_vd_or_tlhc

491994f

gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 11, 2026

auto-submit Bot added this pull request to the merge queue Feb 11, 2026

Merged via the queue into flutter:master with commit a191754 Feb 11, 2026
71 of 72 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 11, 2026

engine-flutter-autoroll mentioned this pull request Feb 12, 2026

Roll Flutter from 9bda20a11f1e to 4d0d113b7574 (42 revisions) flutter/packages#11006

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2026

a191754c3 Make HCPP upgrading work for vd/tlhc (flutter/flutter#181024)

e7b4e9b

engine-flutter-autoroll mentioned this pull request Feb 12, 2026

Roll Flutter from 9bda20a11f1e to 6e459a386031 (43 revisions) flutter/packages#11007

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2026

a191754c3 Make HCPP upgrading work for vd/tlhc (flutter/flutter#181024)

7faf6e4

engine-flutter-autoroll mentioned this pull request Feb 12, 2026

Roll Flutter from 9bda20a11f1e to 0b3185c77d6a (44 revisions) flutter/packages#11008

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2026

a191754c3 Make HCPP upgrading work for vd/tlhc (flutter/flutter#181024)

37de7de

engine-flutter-autoroll mentioned this pull request Feb 13, 2026

Roll Flutter from 9bda20a11f1e to 57bc7aa5b667 (56 revisions) flutter/packages#11013

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2026

a191754c3 Make HCPP upgrading work for vd/tlhc (flutter/flutter#181024)

d2dbdef

engine-flutter-autoroll mentioned this pull request Feb 13, 2026

Roll Flutter from 9bda20a11f1e to 4875f505c54b (57 revisions) flutter/packages#11016

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2026

a191754c3 Make HCPP upgrading work for vd/tlhc (flutter/flutter#181024)

4213a38

engine-flutter-autoroll mentioned this pull request Feb 13, 2026

Roll Flutter from 9bda20a11f1e to 2cef9c556453 (58 revisions) flutter/packages#11019

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2026

a191754c3 Make HCPP upgrading work for vd/tlhc (flutter/flutter#181024)

9f06d78

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2026

a191754c3 Make HCPP upgrading work for vd/tlhc (flutter/flutter#181024)

aa70114

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2026

a191754c3 Make HCPP upgrading work for vd/tlhc (flutter/flutter#181024)

454d89f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2026

a191754c3 Make HCPP upgrading work for vd/tlhc (flutter/flutter#181024)

3f7ca6b

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2026

a191754c3 Make HCPP upgrading work for vd/tlhc (flutter/flutter#181024)

1587636

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2026

a191754c3 Make HCPP upgrading work for vd/tlhc (flutter/flutter#181024)

400c4a7

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2026

a191754c3 Make HCPP upgrading work for vd/tlhc (flutter/flutter#181024)

c96f8ef

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2026

a191754c3 Make HCPP upgrading work for vd/tlhc (flutter/flutter#181024)

65785fc

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2026

a191754c3 Make HCPP upgrading work for vd/tlhc (flutter/flutter#181024)

0def75b

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2026

a191754c3 Make HCPP upgrading work for vd/tlhc (flutter/flutter#181024)

35900cc

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2026

a191754c3 Make HCPP upgrading work for vd/tlhc (flutter/flutter#181024)

84a99b0

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2026

a191754c3 Make HCPP upgrading work for vd/tlhc (flutter/flutter#181024)

e05dbb9

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2026

a191754c3 Make HCPP upgrading work for vd/tlhc (flutter/flutter#181024)

c074862

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2026

a191754c3 Make HCPP upgrading work for vd/tlhc (flutter/flutter#181024)

5b5ad37

camsim99 added a commit to camsim99/flutter that referenced this pull request Mar 6, 2026

Revert "Make HCPP upgrading work for vd/tlhc (flutter#181024)"

30a60a6

This reverts commit a191754.

gmackall pushed a commit to gmackall/flutter that referenced this pull request Mar 7, 2026

Reapply "Make HCPP upgrading work for vd/tlhc (flutter#181024)" (flut…

c26650d

…ter#183310) This reverts commit b53c2e6.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make HCPP upgrading work for vd/tlhc#181024

Make HCPP upgrading work for vd/tlhc#181024
auto-submit[bot] merged 6 commits into
flutter:masterfrom
gmackall:hcpp_upgrading_for_vd_or_tlhc

gmackall commented Jan 15, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

reidbaker Feb 5, 2026

Uh oh!

gmackall Feb 5, 2026

Uh oh!

Uh oh!

reidbaker Feb 5, 2026

Uh oh!

reidbaker Feb 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

gmackall commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

reidbaker Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

gmackall Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

reidbaker Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

reidbaker Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gmackall commented Jan 15, 2026 •

edited

Loading