Skip to content

HCPP auto upgrade mechanism does not work for VD/TLHC due to expected return value #181000

Description

@gmackall

Currently we are attempting to launch HCPP as a universal upgrade, where when a manifest flag is set, all PVs are auto upgraded to HCPP.

Mechanically this is done by intercepting the create request in PlatformViewsChannel.java
https://github.com/flutter/flutter/blob/master/engine/src/flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/PlatformViewsChannel.java#L94
Inspecting the state of HCPP support, and returning HCPP if it is supported/enabled. However, this currently results in a NPE because the return is null.

This works with HC, but the other modes expect a texture id return, and then do stuff with that texture id. Returning null results in a NPE. Need to fix this.

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listplatform-androidAndroid applications specificallyplatform-views: hcppIssues which affect the HCPP platform views backendteam-androidOwned by Android platform teamtriaged-androidTriaged by Android platform team

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions