[ Tool ] Handle DartDevelopmentServiceException when launching web applications
#180905
+32
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…applications DWDS can throw `DartDvelopmentServiceException` if DDS fails to connect to DWDS due to the target application shutting down immediately after launch. This change adds logic to catch this exception and exit gracefully. Fixes flutter#178151
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces handling for DartDevelopmentServiceException when launching web applications, preventing crashes when the application shuts down during DDS startup. This is achieved by adding a new catch block to gracefully exit. A regression test is included to verify this new behavior. Additionally, error logging for several other exception types has been refactored to use error.toString() for consistency and safety. My review includes a suggestion to refactor the new catch block to reduce code duplication.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
flutteractionsbot
pushed a commit
to flutteractionsbot/flutter
that referenced
this pull request
Jan 13, 2026
…applications (flutter#180905) DWDS can throw `DartDvelopmentServiceException` if DDS fails to connect to DWDS due to the target application shutting down immediately after launch. This change adds logic to catch this exception and exit gracefully. Fixes flutter#178151 --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
flutteractionsbot
pushed a commit
to flutteractionsbot/flutter
that referenced
this pull request
Jan 13, 2026
…applications (flutter#180905) DWDS can throw `DartDvelopmentServiceException` if DDS fails to connect to DWDS due to the target application shutting down immediately after launch. This change adds logic to catch this exception and exit gracefully. Fixes flutter#178151 --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 14, 2026
…ing web applications (flutter/flutter#180905)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 14, 2026
…ing web applications (flutter/flutter#180905)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 14, 2026
…ing web applications (flutter/flutter#180905)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 14, 2026
…ching web applications (flutter/flutter#180905)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 14, 2026
…ing web applications (flutter/flutter#180905)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
…ing web applications (flutter/flutter#180905)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
…ing web applications (flutter/flutter#180905)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
…ing web applications (flutter/flutter#180905)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
…ing web applications (flutter/flutter#180905)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
…ing web applications (flutter/flutter#180905)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
…ing web applications (flutter/flutter#180905)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
…ing web applications (flutter/flutter#180905)
ikramhasan
pushed a commit
to ikramhasan/flutter
that referenced
this pull request
Jan 15, 2026
…applications (flutter#180905) DWDS can throw `DartDvelopmentServiceException` if DDS fails to connect to DWDS due to the target application shutting down immediately after launch. This change adds logic to catch this exception and exit gracefully. Fixes flutter#178151 --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
…ing web applications (flutter/flutter#180905)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 16, 2026
…ing web applications (flutter/flutter#180905)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 16, 2026
…ing web applications (flutter/flutter#180905)
tarrinneal
pushed a commit
to flutter/packages
that referenced
this pull request
Jan 16, 2026
Manual roll requested by tarrinneal@google.com flutter/flutter@b45a73b...5a2067b 2026-01-13 engine-flutter-autoroll@skia.org Roll Packages from e57e7f4 to eb9e1dc (6 revisions) (flutter/flutter#180907) 2026-01-13 ahmedsameha1@gmail.com Make sure that a FocusScope doesn't crash in 0x0 environment (flutter/flutter#180715) 2026-01-13 bkonyi@google.com [ Tool ] Handle `DartDevelopmentServiceException` when launching web applications (flutter/flutter#180905) 2026-01-13 116356835+AbdeMohlbi@users.noreply.github.com Removes `RequiresApi 23` (flutter/flutter#180629) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 16, 2026
…ing web applications (flutter/flutter#180905)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 16, 2026
…ing web applications (flutter/flutter#180905)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jan 16, 2026
Manual roll requested by tarrinneal@google.com flutter/flutter@b45a73b...48c2475 2026-01-13 ahmedsameha1@gmail.com Make sure that a FocusScope doesn't crash in 0x0 environment (flutter/flutter#180715) 2026-01-13 bkonyi@google.com [ Tool ] Handle `DartDevelopmentServiceException` when launching web applications (flutter/flutter#180905) 2026-01-13 116356835+AbdeMohlbi@users.noreply.github.com Removes `RequiresApi 23` (flutter/flutter#180629) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DWDS can throw
DartDvelopmentServiceExceptionif DDS fails to connect to DWDS due to the target application shutting down immediately after launch.This change adds logic to catch this exception and exit gracefully.
Fixes #178151