Make sure that a FocusScope doesn't crash in 0x0 environment #180715
Merged
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a regression test for an issue where FocusScope would crash in a zero-sized environment. The new test case correctly sets up this scenario to prevent future regressions. My feedback focuses on improving the test's teardown logic to ensure better test isolation.
Comment on lines
+1086
to
+1089
| tester.view.physicalSize = Size.zero; | ||
| final focusScopeNode = FocusScopeNode(); | ||
| addTearDown(tester.view.reset); | ||
| addTearDown(focusScopeNode.dispose); |
Contributor
There was a problem hiding this comment.
To ensure test isolation, it's better to restore the original physicalSize of the view in a teardown block rather than calling tester.view.reset(). This prevents side effects on other tests that might rely on a default view size. The suggested change saves the original size and restores it after the test, ensuring a clean state for subsequent tests.
Suggested change
| tester.view.physicalSize = Size.zero; | |
| final focusScopeNode = FocusScopeNode(); | |
| addTearDown(tester.view.reset); | |
| addTearDown(focusScopeNode.dispose); | |
| final Size originalSize = tester.view.physicalSize; | |
| addTearDown(() => tester.view.physicalSize = originalSize); | |
| tester.view.physicalSize = Size.zero; | |
| final focusScopeNode = FocusScopeNode(); | |
| addTearDown(focusScopeNode.dispose); |
victorsanni
reviewed
Jan 9, 2026
Contributor
victorsanni
left a comment
There was a problem hiding this comment.
Does FocusScope have its own renderbox? I took a look at the source code and it just wraps its child in an InheritedNotifier + Semantics. cc @dkwingsmt
dkwingsmt
approved these changes
Jan 13, 2026
Contributor
dkwingsmt
left a comment
There was a problem hiding this comment.
LGTM. I think it's fine. It's to guarantee that we don't make any significant changes that involve layout in the future.
victorsanni
approved these changes
Jan 13, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 14, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 14, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 14, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 14, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 14, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
ikramhasan
pushed a commit
to ikramhasan/flutter
that referenced
this pull request
Jan 15, 2026
…#180715) This is my attempt to handle flutter#6537 for the FocusScope widget.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 15, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 16, 2026
tarrinneal
pushed a commit
to flutter/packages
that referenced
this pull request
Jan 16, 2026
Manual roll requested by tarrinneal@google.com flutter/flutter@b45a73b...5a2067b 2026-01-13 engine-flutter-autoroll@skia.org Roll Packages from e57e7f4 to eb9e1dc (6 revisions) (flutter/flutter#180907) 2026-01-13 ahmedsameha1@gmail.com Make sure that a FocusScope doesn't crash in 0x0 environment (flutter/flutter#180715) 2026-01-13 bkonyi@google.com [ Tool ] Handle `DartDevelopmentServiceException` when launching web applications (flutter/flutter#180905) 2026-01-13 116356835+AbdeMohlbi@users.noreply.github.com Removes `RequiresApi 23` (flutter/flutter#180629) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 16, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 16, 2026
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jan 16, 2026
Manual roll requested by tarrinneal@google.com flutter/flutter@b45a73b...48c2475 2026-01-13 ahmedsameha1@gmail.com Make sure that a FocusScope doesn't crash in 0x0 environment (flutter/flutter#180715) 2026-01-13 bkonyi@google.com [ Tool ] Handle `DartDevelopmentServiceException` when launching web applications (flutter/flutter#180905) 2026-01-13 116356835+AbdeMohlbi@users.noreply.github.com Removes `RequiresApi 23` (flutter/flutter#180629) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to handle #6537 for the FocusScope widget.