Revert "Directly generate a Mach-O dynamic library using gen_snapshot [reland] (#174870) #180639
+328
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. [reland] (flutter#174870)" This reverts commit 4b6e0bd.
Contributor
There was a problem hiding this comment.
Code Review
This pull request reverts a previous change that directly generated Mach-O dynamic libraries from gen_snapshot. The revert restores the two-step process of generating assembly first, then compiling and linking, to fix an issue with bitcode generation. My review confirms the revert is implemented correctly across the tool and its tests. I've identified one minor omission where the minimum deployment target for macOS was not being set in the restored logic, and I have provided a suggestion to address this. Otherwise, the changes look good.
Comment on lines
+261
to
+265
| if (isIOS) | ||
| // When the minimum version is updated, remember to update | ||
| // template MinimumOSVersion. | ||
| // https://github.com/flutter/flutter/pull/62902 | ||
| '-miphoneos-version-min=${FlutterDarwinPlatform.ios.deploymentTarget()}', |
Contributor
There was a problem hiding this comment.
The minimum deployment target for macOS builds appears to be missing. The previous implementation that was reverted used --macho-min-os-version for both iOS and macOS. This logic should be preserved by adding -mmacosx-version-min for macOS builds to ensure the generated binary has the correct deployment target set.
Suggested change
| if (isIOS) | |
| // When the minimum version is updated, remember to update | |
| // template MinimumOSVersion. | |
| // https://github.com/flutter/flutter/pull/62902 | |
| '-miphoneos-version-min=${FlutterDarwinPlatform.ios.deploymentTarget()}', | |
| // When the minimum version is updated, remember to update | |
| // template MinimumOSVersion. | |
| // https://github.com/flutter/flutter/pull/62902 | |
| isIOS | |
| ? '-miphoneos-version-min=${FlutterDarwinPlatform.ios.deploymentTarget()}' | |
| : '-mmacosx-version-min=${FlutterDarwinPlatform.macos.deploymentTarget()}', |
Contributor
Author
There was a problem hiding this comment.
Technically this sounds right, but this is a revert to fix a urgent issue so I don't want to change anything.
jmagman
approved these changes
Jan 7, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 8, 2026
…snapshot [reland] (#174870) (flutter/flutter#180639)
flutteractionsbot
pushed a commit
to flutteractionsbot/flutter
that referenced
this pull request
Jan 8, 2026
… [reland] (flutter#174870) (flutter#180639) This reverts commit 4b6e0bd. Fixes flutter#178602. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 8, 2026
…n_snapshot [reland] (#174870) (flutter/flutter#180639)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 8, 2026
…snapshot [reland] (#174870) (flutter/flutter#180639)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 8, 2026
…snapshot [reland] (#174870) (flutter/flutter#180639)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 9, 2026
…snapshot [reland] (#174870) (flutter/flutter#180639)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 9, 2026
…snapshot [reland] (#174870) (flutter/flutter#180639)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 9, 2026
…snapshot [reland] (#174870) (flutter/flutter#180639)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 9, 2026
…n_snapshot [reland] (#174870) (flutter/flutter#180639)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 10, 2026
…snapshot [reland] (#174870) (flutter/flutter#180639)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 10, 2026
…snapshot [reland] (#174870) (flutter/flutter#180639)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 10, 2026
…snapshot [reland] (#174870) (flutter/flutter#180639)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4b6e0bd.
Fixes #178602.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.