Directly generate a Mach-O dynamic library using gen_snapshot. [reland] #174870
+111
−328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f6ea3a4 to
aaadbc7
Compare
aaadbc7 to
6eca4f5
Compare
Instead of generating assembly code that is then compiled to a Mach-O dynamic library, use the new app-aot-macho-dylib output option for gen_snapshot to generate the Mach-O dynamic library without the assembly step.
902dc53 to
0085ad4
Compare
40db7fe to
b6b852d
Compare
Contributor
Author
|
As mentioned in the PR description, the only commit that differs from the original PR that @bkonyi reviewed is the last one that adds the |
bkonyi
approved these changes
Nov 24, 2025
jmagman
approved these changes
Dec 1, 2025
Member
jmagman
left a comment
There was a problem hiding this comment.
LGTM, thanks for re-landing with the fix.
Contributor
|
autosubmit label was removed for flutter/flutter/174870, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 2, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 2, 2025
flutter/flutter@05d6005...5545bb3 2025-12-02 engine-flutter-autoroll@skia.org Roll Skia from 4371ed0ce49e to 45337c4e919d (1 revision) (flutter/flutter#179342) 2025-12-02 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from sTk6OB7a4yudbfdZg... to l0DvmZrMHlF12frrX... (flutter/flutter#179338) 2025-12-02 huy@nevercode.io Unfocus search anchor bar when the view is closed (flutter/flutter#178910) 2025-12-02 sstrickl@google.com Directly generate a Mach-O dynamic library using gen_snapshot. [reland] (flutter/flutter#174870) 2025-12-02 engine-flutter-autoroll@skia.org Roll Skia from 1fc59bf5cbb1 to 4371ed0ce49e (3 revisions) (flutter/flutter#179326) 2025-12-02 matej.knopp@gmail.com [win32] Replace threadpool timer with custom background thread timer (flutter/flutter#179249) 2025-12-02 engine-flutter-autoroll@skia.org Roll Skia from 61257a1036fb to 1fc59bf5cbb1 (1 revision) (flutter/flutter#179321) 2025-12-02 engine-flutter-autoroll@skia.org Roll Skia from ef52cf952211 to 61257a1036fb (2 revisions) (flutter/flutter#179319) 2025-12-02 engine-flutter-autoroll@skia.org Roll Skia from 8887653a773e to ef52cf952211 (1 revision) (flutter/flutter#179316) 2025-12-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#179313) 2025-12-02 katelovett@google.com Update customer tests (flutter/flutter#179309) 2025-12-01 fluttergithubbot@gmail.com Marks Linux_pixel_7pro new_gallery__transition_perf to be unflaky (flutter/flutter#176339) 2025-12-01 feinstein@users.noreply.github.com Fix typo (flutter/flutter#179200) 2025-12-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 5.0.1 to 6.0.0 in the all-github-actions group (flutter/flutter#179308) 2025-12-01 engine-flutter-autoroll@skia.org Roll Dart SDK from c54108eeb2c1 to eb743a1d4ade (1 revision) (flutter/flutter#179304) 2025-12-01 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#179280) 2025-12-01 engine-flutter-autoroll@skia.org Roll Skia from 68cc3257e734 to 8887653a773e (4 revisions) (flutter/flutter#179302) 2025-12-01 97480502+b-luk@users.noreply.github.com Support round caps for the fast arc stroke generator (flutter/flutter#178269) 2025-12-01 31510811+jwlilly@users.noreply.github.com Fix for PR #174374 - Fix - TalkBack does not announce list information (flutter/flutter#177622) 2025-12-01 116356835+AbdeMohlbi@users.noreply.github.com Small cleanup in `AccessibilityBridge.java` (flutter/flutter#179226) 2025-12-01 engine-flutter-autoroll@skia.org Roll Skia from 925c311f4b37 to 68cc3257e734 (44 revisions) (flutter/flutter#179294) 2025-12-01 bkonyi@google.com [ Widget Preview ] Ignore changes under `ios/.symlinks` (flutter/flutter#179290) 2025-12-01 jesswon@google.com Delete unecessary lockfile (flutter/flutter#179052) 2025-12-01 matt.kosarek@canonical.com Resolving and piping the view ID through the WidgetController and the TestPointer so that clicks wind up on the right view (flutter/flutter#178941) 2025-12-01 116356835+AbdeMohlbi@users.noreply.github.com Fix link specified as plain text `FlutterApplication.java` (flutter/flutter#178573) 2025-12-01 bruno.leroux@gmail.com Update some comments to reflect theme normalization (flutter/flutter#179013) 2025-12-01 engine-flutter-autoroll@skia.org Roll Dart SDK from 51fe8cd01fbe to c54108eeb2c1 (1 revision) (flutter/flutter#179267) 2025-12-01 bungeman@chromium.org Explicitly use FreeType font scanner with Fuchsia (flutter/flutter#179055) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Dec 2, 2025
…d] (flutter#174870) Instead of generating assembly code that is then compiled to a Mach-O dynamic library, use the new app-aot-macho-dylib output option for gen_snapshot to generate the Mach-O dynamic library without the assembly step. This is a reland of flutter#171626, with the necessary changes to avoid the issue found in flutter#174393 where DWARF information was being retained in the final snapshot. The initial PR state are the original commits landed in the previous PR, with a followup commit containing the fix for that issue: the DWARF information is moved into an associated relocatable object, so the information is still accessible by dsymutil before the snapshot is stripped. Related issues: * dart-lang/sdk#43299 * dart-lang/sdk#60307 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing.
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…d] (flutter#174870) Instead of generating assembly code that is then compiled to a Mach-O dynamic library, use the new app-aot-macho-dylib output option for gen_snapshot to generate the Mach-O dynamic library without the assembly step. This is a reland of flutter#171626, with the necessary changes to avoid the issue found in flutter#174393 where DWARF information was being retained in the final snapshot. The initial PR state are the original commits landed in the previous PR, with a followup commit containing the fix for that issue: the DWARF information is moved into an associated relocatable object, so the information is still accessible by dsymutil before the snapshot is stripped. Related issues: * dart-lang/sdk#43299 * dart-lang/sdk#60307 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing.
vashworth
added a commit
to vashworth/flutter
that referenced
this pull request
Jan 7, 2026
…. [reland] (flutter#174870)" This reverts commit 4b6e0bd.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 7, 2026
… [reland] (#174870) (#180639) This reverts commit 4b6e0bd. Fixes #178602. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
flutteractionsbot
pushed a commit
to flutteractionsbot/flutter
that referenced
this pull request
Jan 8, 2026
… [reland] (flutter#174870) (flutter#180639) This reverts commit 4b6e0bd. Fixes flutter#178602. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of generating assembly code that is then compiled to a Mach-O dynamic library, use the new app-aot-macho-dylib output option for gen_snapshot to generate the Mach-O dynamic library without the assembly step.
This is a reland of #171626, with the necessary changes to avoid the issue found in #174393 where DWARF information was being retained in the final snapshot. The initial PR state are the original commits landed in the previous PR, with a followup commit containing the fix for that issue: the DWARF information is moved into an associated relocatable object, so the information is still accessible by dsymutil before the snapshot is stripped.
Related issues:
Pre-launch Checklist
///).