Skip to content

Filter out FrameEvents/updateAcquireFence log spam from adb logcat #179884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Dec 16, 2025
Merged

Filter out FrameEvents/updateAcquireFence log spam from adb logcat #179884

auto-submit merged 2 commits into from
Dec 16, 2025

Conversation

@shindonghwi
Copy link
Contributor

@shindonghwi shindonghwi commented Dec 15, 2025 •
edited
Loading

Problem

When using platform views like Google Maps on Android, the console gets flooded with messages like:

E/FrameEvents(26685): updateAcquireFence: Did not find frame.
E/FrameEvents(26685): updateAcquireFence: Did not find frame.
E/FrameEvents(26685): updateAcquireFence: Did not find frame.
... (repeats many times)

This makes it hard to see actual errors and warnings in the console.

Cause

This is a HWUI bug in Android, not an actual error. The message doesn't indicate any problem with the application.

Fix

Add a regex filter to _filteredMessagees in AdbLogReader to suppress these messages, following the same pattern used for similar spam messages like SurfaceSyncer and ViewPostIme pointer.

Fixes

#104268

Pre-launch Checklist

@shindonghwi
Filter out FrameEvents/updateAcquireFence log spam from adb logcat
01e518b 
When using platform views like Google Maps on Android, the console gets
flooded with "E/FrameEvents: updateAcquireFence: Did not find frame."
messages. This is a HWUI bug that doesn't indicate any actual problem
with the application.

This change adds a filter to suppress these messages, improving the
developer experience by keeping the console output clean and readable.

Fixes flutter#104268
@shindonghwi shindonghwi requested a review from a team as a code owner December 15, 2025 14:49
@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. team-android Owned by Android platform team labels Dec 15, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 15, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request filters out spammy FrameEvents/updateAcquireFence logs from adb logcat by adding a new regular expression to the AdbLogReader. This is a good fix for a known Android HWUI bug that clutters the console. The change is accompanied by a new test case to verify the filtering works as expected. I have one suggestion to make the regular expression more precise.

@reidbaker reidbaker requested a review from a team December 15, 2025 15:02
@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 16, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Dec 16, 2025
Merged via the queue into flutter:master with commit 2b61b85 Dec 16, 2025
141 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 16, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
73e67ce 
…ogcat (flutter/flutter#179884)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
1e4babd 
…ogcat (flutter/flutter#179884)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
120e5ff 
…ogcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
9f78bd8 
…ogcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
9d670f5 
…ogcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
e54d630 
…ogcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
bc2d637 
…ogcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
4c904d3 
…ogcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2025
@engine-flutter-autoroll
2b61b85c6 Filter out FrameEvents/updateAcquireFence log spam from adb…
1d798a0 
… logcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
ff24caf 
…ogcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
97e2cf1 
…ogcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
fc55ace 
…ogcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
888af1b 
…ogcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 19, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
a97e866 
…ogcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 20, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
0b7d57a 
…ogcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 20, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
cf22e36 
…ogcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 21, 2025
@engine-flutter-autoroll
2b61b85c6 Filter out FrameEvents/updateAcquireFence log spam from adb…
30114f0 
… logcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 21, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
b3d7902 
…ogcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 21, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
965c11a 
…ogcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
c01f103 
…ogcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
78c1da1 
…ogcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 22, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
1ae5fbd 
…ogcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
7b84d7f 
…ogcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
d8e8f2b 
…ogcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
5a9fe47 
…ogcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
ce9c184 
…ogcat (flutter/flutter#179884)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 23, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
8c31a05 
…ogcat (flutter/flutter#179884)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2025
@engine-flutter-autoroll
2b61b85 Filter out FrameEvents/updateAcquireFence log spam from adb l…
732095a 
…ogcat (flutter/flutter#179884)
stuartmorgan-g pushed a commit to flutter/packages that referenced this pull request Dec 23, 2025
@engine-flutter-autoroll
Manual roll Flutter from d81baab to 57c3f8b (38 revisions) (#10671)
c7478fb 
Manual roll Flutter from d81baab to 57c3f8b (38 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@d81baab...57c3f8b

2025-12-17 bruno.leroux@gmail.com Add FloatingActionButtonTheme
(flutter/flutter#179736)
2025-12-17 engine-flutter-autoroll@skia.org Roll Skia from b1569739f431
to fb576bd6827a (1 revision) (flutter/flutter#179989)
2025-12-17 bruno.leroux@gmail.com Update more comments related to theme
normalization (flutter/flutter#179682)
2025-12-17 engine-flutter-autoroll@skia.org Roll Skia from cce9b86bda7d
to b1569739f431 (1 revision) (flutter/flutter#179979)
2025-12-17 jobguldemeester@gmail.com Adds property passthrough for
CheckboxListTile, SwitchListTile and RadioListTile
(flutter/flutter#178098)
2025-12-17 engine-flutter-autoroll@skia.org Roll Dart SDK from
ca949b915846 to 3793f3d2d0c4 (2 revisions) (flutter/flutter#179973)
2025-12-17 engine-flutter-autoroll@skia.org Roll Skia from 318400199beb
to cce9b86bda7d (1 revision) (flutter/flutter#179976)
2025-12-17 ahmedsameha1@gmail.com Make sure that a
CupertinoTextFormFieldRow doesn't crash in 0x0 envir…
(flutter/flutter#179932)
2025-12-17 ahmedsameha1@gmail.com Make sure that a CupertinoTabView
doesn't crash in 0x0 environment (flutter/flutter#179845)
2025-12-17 ahmedsameha1@gmail.com Make sure that a CupertinoTextField
doesn't crash in 0x0 environment (flutter/flutter#179865)
2025-12-17 ahmedsameha1@gmail.com Make sure that a CupertinoSwitch
doesn't crash in 0x0 environment (flutter/flutter#179748)
2025-12-17 116356835+AbdeMohlbi@users.noreply.github.com Update
`BuildContext` docs to make it easier to understand
(flutter/flutter#178616)
2025-12-17 41930132+hellohuanlin@users.noreply.github.com [ios][pv]
quick fix to enable and re-enable web view's gesture recognizer
(flutter/flutter#179908)
2025-12-17 biggs0125@gmail.com Deduplicate wasm dry run entries in
analytics. (flutter/flutter#179970)
2025-12-17 engine-flutter-autoroll@skia.org Roll Skia from 99899cbb415b
to 318400199beb (1 revision) (flutter/flutter#179969)
2025-12-17 engine-flutter-autoroll@skia.org Roll Skia from 2ac4a8709bc9
to 99899cbb415b (1 revision) (flutter/flutter#179968)
2025-12-17 engine-flutter-autoroll@skia.org Roll Dart SDK from
95a92bc705d3 to ca949b915846 (6 revisions) (flutter/flutter#179967)
2025-12-17 biggs0125@gmail.com Add package info to wasm dry run events.
(flutter/flutter#179826)
2025-12-17 matt.boetger@gmail.com Platform View Hide/Show Integration
test (flutter/flutter#179902)
2025-12-16 engine-flutter-autoroll@skia.org Roll Skia from 61162d72343f
to 2ac4a8709bc9 (14 revisions) (flutter/flutter#179961)
2025-12-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
433KtmJvbMyaDMJvD... to fAoyBAT99XxwPE5hL... (flutter/flutter#179960)
2025-12-16 bkonyi@google.com [ Tool ] Fix update-packages not accounting
for path dependencies (flutter/flutter#179951)
2025-12-16 45459898+RamonFarizel@users.noreply.github.com ListTile fix
MinIntrinsicHeight calculation (flutter/flutter#179515)
2025-12-16 108678139+manu-sncf@users.noreply.github.com Fix pinned
header in NestedScrollView (flutter/flutter#179210)
2025-12-16 bruno.leroux@gmail.com Update some comments related to theme
normalization (flutter/flutter#179624)
2025-12-16 iliyazelenkog@gmail.com Add Cyrillic keyboard layout support
for flutter_tools terminal commands (flutter/flutter#177855)
2025-12-16 lauren@selfisekai.rocks Minor fixes for libstdc++ 15
(flutter/flutter#178601)
2025-12-16 34465683+rkishan516@users.noreply.github.com Feat: Add top
gap for cupertino sheet (flutter/flutter#171348)
2025-12-16 116356835+AbdeMohlbi@users.noreply.github.com Align
`Build.API_LEVELS` usage in `FlutterImageDecoder.java‎` with existing
usage (flutter/flutter#179868)
2025-12-16 41930132+hellohuanlin@users.noreply.github.com Revert
"[ios][pv] accept/reject gesture based on hitTest (with new wi…
(flutter/flutter#179895)
2025-12-16 codefu@google.com fix: line endings for
flutter/dart/flutter-dev (flutter/flutter#179912)
2025-12-16 22373191+Hari-07@users.noreply.github.com Platform view blur
clipping - Rounded Rect (iOS) (flutter/flutter#177551)
2025-12-16 engine-flutter-autoroll@skia.org Roll Dart SDK from
20d114f951db to 95a92bc705d3 (1 revision) (flutter/flutter#179909)
2025-12-16 34871572+gmackall@users.noreply.github.com [Reland]
Unmodified android sdk bundle (flutter/flutter#179920)
2025-12-16 engine-flutter-autoroll@skia.org Roll Skia from 6903a4e65c3f
to 61162d72343f (2 revisions) (flutter/flutter#179915)
2025-12-16 engine-flutter-autoroll@skia.org Roll Packages from
2cd921c to 57725eb (1 revision) (flutter/flutter#179942)
2025-12-16 45490440+shindonghwi@users.noreply.github.com Filter out
FrameEvents/updateAcquireFence log spam from adb logcat
(flutter/flutter#179884)
2025-12-16 30870216+gaaclarke@users.noreply.github.com `flutter
update-packages --force-upgrade --update-hashes`
(flutter/flutter#179950)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to
ensure that a human
is aware of the problem.
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mboetger mboetger mboetger approved these changes

@reidbaker reidbaker reidbaker approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

team-android Owned by Android platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shindonghwi @mboetger @reidbaker @camsim99