Make tree green again by fixing lints #179186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
sigurdm
approved these changes
Nov 27, 2025
Contributor
There was a problem hiding this comment.
Code Review
This pull request contains fixes for linting issues in two test files. In packages/flutter/test/widgets/localizations_test.dart, local variables are updated to use type inference (var/final without explicit types). In packages/flutter_tools/test/general.shard/isolated/native_assets_test.dart, a class field is given an explicit type annotation. Both changes align with Dart's style guide and appear to be correct lint fixes.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 27, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 27, 2025
flutter/flutter@7b98d50...022b155 2025-11-27 goderbauer@google.com Make tree green again by fixing lints (flutter/flutter#179186) 2025-11-26 okorohelijah@google.com Add shared Darwin implementation for plugins (flutter/flutter#176495) 2025-11-26 77888283+shivanuj13@users.noreply.github.com Fixed changing supportedLocales fails to update the locale (flutter/flutter#178526) 2025-11-26 bkonyi@google.com [ Tool ] Remove --no-sandbox when launching web apps on Chrome device (flutter/flutter#178670) 2025-11-26 simon@journeyapps.com Build hooks: Don't require toolchain for unit tests (flutter/flutter#178954) 2025-11-26 116356835+AbdeMohlbi@users.noreply.github.com Fix a small typo in `HandlerCompat.java` docs (flutter/flutter#178595) 2025-11-26 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from nzuAxCJGeJbkZCTkr... to _e9MNK4nfBOrERVP_... (flutter/flutter#179130) 2025-11-26 ahmedsameha1@gmail.com Make sure that a CupertinoActivityIndicator doesn't crash in 0x0 envi… (flutter/flutter#178565) 2025-11-26 dacoharkes@google.com [native assets] Bump minimum iOS version from 12 to 13 (flutter/flutter#179079) 2025-11-26 30870216+gaaclarke@users.noreply.github.com Documents and fixes behavior when clipping background filter fragment shader (flutter/flutter#178940) 2025-11-26 116356835+AbdeMohlbi@users.noreply.github.com Replace the hardcoded link with an actual link tag in `PlatformChannel.java` docs (flutter/flutter#178588) 2025-11-26 engine-flutter-autoroll@skia.org Roll Packages from cc3dca6 to 5d8d954 (5 revisions) (flutter/flutter#179140) 2025-11-26 15619084+vashworth@users.noreply.github.com Add more templates that the UIScene migrator can match against (flutter/flutter#179044) 2025-11-26 116356835+AbdeMohlbi@users.noreply.github.com Remove deprecated activeColor in `dynamic_content_color.0.dart` example (flutter/flutter#178961) 2025-11-26 116356835+AbdeMohlbi@users.noreply.github.com Remove deprecated `activeColor` in `decorated_sliver.1.dart` example (flutter/flutter#178959) 2025-11-26 116356835+AbdeMohlbi@users.noreply.github.com Small refactor in `PlayStoreDeferredComponentManager.java` (flutter/flutter#178586) 2025-11-26 engine-flutter-autoroll@skia.org Roll Dart SDK from 9e605f706cdf to 1d8dc04bd1d7 (4 revisions) (flutter/flutter#179080) 2025-11-26 mr-peipei@web.de Fix error when generating pt_BR localizations (flutter/flutter#175832) 2025-11-26 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from JUeFbA8y0E-_pj-bg... to MHF-UAfO6sVKqSEYk... (flutter/flutter#179151) 2025-11-26 737941+loic-sharma@users.noreply.github.com Add flutter_lints to samples (flutter/flutter#179091) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Dec 2, 2025
Fallout from flutter#178827 and merging PRs that weren't updated.
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
Fallout from flutter#178827 and merging PRs that weren't updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fallout from #178827 and merging PRs that weren't updated.