[ Tool ] Remove --no-sandbox when launching web apps on Chrome device #178670
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the --no-sandbox flag when launching Chrome for web applications. This change is motivated by the fact that this flag is no longer necessary and might be causing issues on ChromeOS. The change is correctly applied in packages/flutter_tools/lib/src/web/chrome.dart, and the corresponding test constant in packages/flutter_tools/test/web.shard/chrome_test.dart is updated to reflect this change. The changes are correct and look good.
|
Is |
I think it is, I just missed moving |
| version: "2.2.2" | ||
| sdks: | ||
| dart: ">=3.9.0 <4.0.0" | ||
| dart: ">=3.11.0-88.0.dev <4.0.0" |
There was a problem hiding this comment.
Is this change intentional?
There was a problem hiding this comment.
Nope. I thought I had reverted it 🤦
|
autosubmit label was removed for flutter/flutter/178670, because - The status or check suite Mac run_debug_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
|
autosubmit label was removed for flutter/flutter/178670, because - The status or check suite Linux web_long_running_tests_3_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
autosubmit label was removed for flutter/flutter/178670, because - The status or check suite Mac tool_integration_tests_5_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
autosubmit label was removed for flutter/flutter/178670, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
flutter/flutter@7b98d50...022b155 2025-11-27 goderbauer@google.com Make tree green again by fixing lints (flutter/flutter#179186) 2025-11-26 okorohelijah@google.com Add shared Darwin implementation for plugins (flutter/flutter#176495) 2025-11-26 77888283+shivanuj13@users.noreply.github.com Fixed changing supportedLocales fails to update the locale (flutter/flutter#178526) 2025-11-26 bkonyi@google.com [ Tool ] Remove --no-sandbox when launching web apps on Chrome device (flutter/flutter#178670) 2025-11-26 simon@journeyapps.com Build hooks: Don't require toolchain for unit tests (flutter/flutter#178954) 2025-11-26 116356835+AbdeMohlbi@users.noreply.github.com Fix a small typo in `HandlerCompat.java` docs (flutter/flutter#178595) 2025-11-26 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from nzuAxCJGeJbkZCTkr... to _e9MNK4nfBOrERVP_... (flutter/flutter#179130) 2025-11-26 ahmedsameha1@gmail.com Make sure that a CupertinoActivityIndicator doesn't crash in 0x0 envi… (flutter/flutter#178565) 2025-11-26 dacoharkes@google.com [native assets] Bump minimum iOS version from 12 to 13 (flutter/flutter#179079) 2025-11-26 30870216+gaaclarke@users.noreply.github.com Documents and fixes behavior when clipping background filter fragment shader (flutter/flutter#178940) 2025-11-26 116356835+AbdeMohlbi@users.noreply.github.com Replace the hardcoded link with an actual link tag in `PlatformChannel.java` docs (flutter/flutter#178588) 2025-11-26 engine-flutter-autoroll@skia.org Roll Packages from cc3dca6 to 5d8d954 (5 revisions) (flutter/flutter#179140) 2025-11-26 15619084+vashworth@users.noreply.github.com Add more templates that the UIScene migrator can match against (flutter/flutter#179044) 2025-11-26 116356835+AbdeMohlbi@users.noreply.github.com Remove deprecated activeColor in `dynamic_content_color.0.dart` example (flutter/flutter#178961) 2025-11-26 116356835+AbdeMohlbi@users.noreply.github.com Remove deprecated `activeColor` in `decorated_sliver.1.dart` example (flutter/flutter#178959) 2025-11-26 116356835+AbdeMohlbi@users.noreply.github.com Small refactor in `PlayStoreDeferredComponentManager.java` (flutter/flutter#178586) 2025-11-26 engine-flutter-autoroll@skia.org Roll Dart SDK from 9e605f706cdf to 1d8dc04bd1d7 (4 revisions) (flutter/flutter#179080) 2025-11-26 mr-peipei@web.de Fix error when generating pt_BR localizations (flutter/flutter#175832) 2025-11-26 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from JUeFbA8y0E-_pj-bg... to MHF-UAfO6sVKqSEYk... (flutter/flutter#179151) 2025-11-26 737941+loic-sharma@users.noreply.github.com Add flutter_lints to samples (flutter/flutter#179091) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Fixes #175227