Delete disabled workflow and add missing permissions key to workflow #178911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly sets permissions for contents, pull-requests, and actions in the GitHub Actions workflow to improve security and clarify required access levels. contents: read - Required for actions/checkout@v5 to clone the repository pull-requests: read - Required to access github.event.pull_request.base.sha and other PR context actions: write - Required for actions/upload-artifact@v5 to upload workflow artifacts
Explicitly sets 'contents: read' permissions in the GitHub Actions workflow for generating a content-aware hash for the Flutter Engine.
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Member
|
@jtmcdole is most familiar with these workflows and should be the one to review. |
Member
|
Generate Changed Files JSON: has been disabled since March. Is probably safe to remove. The content hashing workflow looks safe since we only calculate (from reading) and emit to runner logs. |
Member
Author
Yeah, deleted. |
jtmcdole
approved these changes
Dec 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 3, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 3, 2025
flutter/flutter@5545bb3...e274574 2025-12-03 engine-flutter-autoroll@skia.org Roll Skia from 20829e37dfb8 to db4c79d41513 (1 revision) (flutter/flutter#179401) 2025-12-03 engine-flutter-autoroll@skia.org Roll Skia from adc7ea94cada to 20829e37dfb8 (6 revisions) (flutter/flutter#179385) 2025-12-03 pateltirth454@gmail.com Refactor GetShaderClipDepth for clarity (flutter/flutter#179110) 2025-12-03 engine-flutter-autoroll@skia.org Roll Skia from 3b339a83959b to adc7ea94cada (1 revision) (flutter/flutter#179376) 2025-12-03 engine-flutter-autoroll@skia.org Roll Dart SDK from eb743a1d4ade to 0bb365d7ac74 (7 revisions) (flutter/flutter#179372) 2025-12-03 nebkat@gmail.com feat: Add `mainAxisExtent` parameter to `GridView` constructors (flutter/flutter#176927) 2025-12-03 engine-flutter-autoroll@skia.org Roll Skia from eb01fff20df8 to 3b339a83959b (4 revisions) (flutter/flutter#179371) 2025-12-02 rmolivares@renzo-olivares.dev Fix crash when text editing value changes between scrolls (flutter/flutter#179163) 2025-12-02 engine-flutter-autoroll@skia.org Roll Skia from 6bd3b06b1e08 to eb01fff20df8 (3 revisions) (flutter/flutter#179362) 2025-12-02 timmaffett@gmail.com Adds Impellerc flatbuffer format versioning. (flutter/flutter#175470) 2025-12-02 30870216+gaaclarke@users.noreply.github.com Adds format argument to Picture.toImageSync (flutter/flutter#178691) 2025-12-02 6655696+guidezpl@users.noreply.github.com Delete disabled workflow and add missing permissions key to workflow (flutter/flutter#178911) 2025-12-02 mdebbar@google.com [web] Fix some gn warnings (flutter/flutter#178313) 2025-12-02 engine-flutter-autoroll@skia.org Roll Skia from 45337c4e919d to 6bd3b06b1e08 (4 revisions) (flutter/flutter#179353) 2025-12-02 louisehsu@google.com [ios] Reland Dynamic Content Resizing (flutter/flutter#179153) 2025-12-02 sokolovskyi.konstantin@gmail.com [web] Fix onTextScaleFactorChanged not getting called. (flutter/flutter#178862) 2025-12-02 engine-flutter-autoroll@skia.org Roll Packages from c8be05d to 148dcd2 (9 revisions) (flutter/flutter#179343) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/flutter/flutter/security/code-scanning/41
Fixes https://github.com/flutter/flutter/security/code-scanning/42