Adds format argument to Picture.toImageSync #178691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1bc825 to
1714a6b
Compare
…make the drawing take up the full screen
60122bd to
a8b932c
Compare
chinmaygarde
approved these changes
Nov 21, 2025
Contributor
chinmaygarde
left a comment
There was a problem hiding this comment.
Just some minor nits.
| render_target_size.height *= scale_factor; | ||
| } | ||
|
|
||
| std::optional<impeller::PixelFormat> impeller_pixel_format; |
Contributor
There was a problem hiding this comment.
Nit: Hoist into a little helper.
| const std::shared_ptr<Texture>& existing_depth_stencil_texture = | ||
| nullptr) override; | ||
| const std::shared_ptr<Texture>& existing_depth_stencil_texture = nullptr, | ||
| std::optional<PixelFormat> target_pixel_format = std::nullopt) override; |
Contributor
There was a problem hiding this comment.
Oof. These argument lists are getting kinda large aren't they? I remember having a bug for to create a RenderTargetBuilder. I think we even added one but had to back it out because it didn't quite do the right thing.
Member
Author
There was a problem hiding this comment.
Yea, I thought the same thing. I have a few other things I want to get to so I didn't incorporate as much refactoring here as I was thinking.
| color0_tex_desc.storage_mode = color_attachment_config.storage_mode; | ||
| color0_tex_desc.format = pixel_format; | ||
| color0_tex_desc.format = | ||
| target_pixel_format.has_value() |
Contributor
There was a problem hiding this comment.
Nit: target_pixel_format.value_or(context.GetCapabilities()->GetDefaultColorFormat());
Contributor
|
autosubmit label was removed for flutter/flutter/178691, because - The status or check suite Linux linux_web_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
ccfe34f to
f79ae2a
Compare
Contributor
|
autosubmit label was removed for flutter/flutter/178691, because - The status or check suite Linux analyzer_benchmark has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
|
CI had a failure that stopped further tests from running. We need to investigate to determine the root cause. SHA at time of execution: 33368de. Possible causes:
A blank commit, or merging to head, will be required to resume running CI for this PR. Error Details: Stack trace: |
Contributor
|
autosubmit label was removed for flutter/flutter/178691, because - The status or check suite Windows tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
autosubmit label was removed for flutter/flutter/178691, because - The status or check suite Linux analyzer_benchmark has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
Member
Author
|
Merging main to hopefully help with presubmit tasks that were stuck queued. |
Contributor
|
autosubmit label was removed for flutter/flutter/178691, because - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 3, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 3, 2025
flutter/flutter@5545bb3...e274574 2025-12-03 engine-flutter-autoroll@skia.org Roll Skia from 20829e37dfb8 to db4c79d41513 (1 revision) (flutter/flutter#179401) 2025-12-03 engine-flutter-autoroll@skia.org Roll Skia from adc7ea94cada to 20829e37dfb8 (6 revisions) (flutter/flutter#179385) 2025-12-03 pateltirth454@gmail.com Refactor GetShaderClipDepth for clarity (flutter/flutter#179110) 2025-12-03 engine-flutter-autoroll@skia.org Roll Skia from 3b339a83959b to adc7ea94cada (1 revision) (flutter/flutter#179376) 2025-12-03 engine-flutter-autoroll@skia.org Roll Dart SDK from eb743a1d4ade to 0bb365d7ac74 (7 revisions) (flutter/flutter#179372) 2025-12-03 nebkat@gmail.com feat: Add `mainAxisExtent` parameter to `GridView` constructors (flutter/flutter#176927) 2025-12-03 engine-flutter-autoroll@skia.org Roll Skia from eb01fff20df8 to 3b339a83959b (4 revisions) (flutter/flutter#179371) 2025-12-02 rmolivares@renzo-olivares.dev Fix crash when text editing value changes between scrolls (flutter/flutter#179163) 2025-12-02 engine-flutter-autoroll@skia.org Roll Skia from 6bd3b06b1e08 to eb01fff20df8 (3 revisions) (flutter/flutter#179362) 2025-12-02 timmaffett@gmail.com Adds Impellerc flatbuffer format versioning. (flutter/flutter#175470) 2025-12-02 30870216+gaaclarke@users.noreply.github.com Adds format argument to Picture.toImageSync (flutter/flutter#178691) 2025-12-02 6655696+guidezpl@users.noreply.github.com Delete disabled workflow and add missing permissions key to workflow (flutter/flutter#178911) 2025-12-02 mdebbar@google.com [web] Fix some gn warnings (flutter/flutter#178313) 2025-12-02 engine-flutter-autoroll@skia.org Roll Skia from 45337c4e919d to 6bd3b06b1e08 (4 revisions) (flutter/flutter#179353) 2025-12-02 louisehsu@google.com [ios] Reland Dynamic Content Resizing (flutter/flutter#179153) 2025-12-02 sokolovskyi.konstantin@gmail.com [web] Fix onTextScaleFactorChanged not getting called. (flutter/flutter#178862) 2025-12-02 engine-flutter-autoroll@skia.org Roll Packages from c8be05d to 148dcd2 (9 revisions) (flutter/flutter#179343) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
fixes flutter#178539 This allows users to chain together fragment shaders with pixel formats other than rgba8. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #178539
This allows users to chain together fragment shaders with pixel formats other than rgba8.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.