[ Widget Preview ] Improve IDE integration support #176114

bkonyi · 2025-09-26T19:47:46Z

This change adds support for two DTD Editor service RPCs and makes functionality that's dependent on the availability of the Editor service reactive to the service availability changing.

The newly added getActiveLocation Editor RPC now allows for us to properly determine which source file is selected at startup, removing the need for special casing around initializing the filtered preview set.

The navigateToCode Editor RPC is now supported, and URIs in stack traces can now be clicked to navigate to the source location in the IDE.

Both filtering previews by selected file and stack frame navigation links are only enabled when the Editor service is available.

Fixes #176113

This change adds support for two DTD Editor service RPCs and makes functionality that's dependent on the availability of the Editor service reactive to the service availability changing. The newly added `getActiveLocation` Editor RPC now allows for us to properly determine which source file is selected at startup, removing the need for special casing around initializing the filtered preview set. The `navigateToCode` Editor RPC is now supported, and URIs in stack traces can now be clicked to navigate to the source location in the IDE. Both filtering previews by selected file and stack frame navigation links are only enabled when the Editor service is available. Fixes #176113

gemini-code-assist

Code Review

This pull request significantly improves IDE integration for widget previews by adding support for getActiveLocation and navigateToCode DTD Editor service RPCs. This enables features like filtering previews by the selected file and navigating to source code from stack traces, which are now reactive to the editor service's availability. The changes are well-structured and include corresponding test updates. I've identified one critical logic bug in an error handling condition and a few areas where documentation for new public APIs is missing, which would improve maintainability.

packages/flutter_tools/templates/widget_preview_scaffold/lib/src/dtd/utils.dart.tmpl

packages/flutter_tools/templates/widget_preview_scaffold/lib/src/dtd/editor_service.dart.tmpl

…ntegration

bkonyi · 2025-09-26T20:05:26Z

@DanTup would you be okay to review this? No pressure if not!

packages/flutter_tools/templates/widget_preview_scaffold/lib/src/dtd/editor_service.dart.tmpl

...s/flutter_tools/templates/widget_preview_scaffold/lib/src/widget_preview_rendering.dart.tmpl

packages/flutter_tools/test/commands.shard/permeable/widget_preview/dtd_services_test.dart

DanTup · 2025-09-26T20:44:14Z

packages/flutter_tools/templates/widget_preview_scaffold/lib/src/dtd/editor_service.dart.tmpl

+        case DTDEvent(
+          kind: kServiceRegistered,
+          data: {DtdParameters.service: kEditorService},
+        ):
+          _editorServiceAvailable.value = true;


This additional check added in the last commit might affect already-shipped versions of Dart-Code (where people have enabled the preview), since those versions register many Editor services, but neither getActiveLocation or navigateToCode (they are only currently in pre-releases).

I don't know if that's a big deal though (it's an opt-in experiment, the update will ship next week, and you might have error handling that handles them not existing), but I'll let you decide :-)

Yeah, I'm not too concerned here, especially with VSCode auto-updating the Dart-Code plugin. I don't think this would cause any noticeable breakages :)

auto-submit · 2025-09-29T13:56:28Z

autosubmit label was removed for flutter/flutter/176114, because - The status or check suite Mac_arm64 tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.

…lutter#176114)

Roll Flutter from 6cc976e to 96fe3b3 (32 revisions) flutter/flutter@6cc976e...96fe3b3 2025-09-29 engine-flutter-autoroll@skia.org Roll Packages from 389c678 to 34eec78 (6 revisions) (flutter/flutter#176205) 2025-09-29 engine-flutter-autoroll@skia.org Roll Skia from 9b2b942d1eb1 to bb3b6bd4be0d (4 revisions) (flutter/flutter#176201) 2025-09-29 bkonyi@google.com [ Widget Preview ] Improve IDE integration support (flutter/flutter#176114) 2025-09-29 robert.ancell@canonical.com Fix name of driver file (flutter/flutter#176186) 2025-09-29 engine-flutter-autoroll@skia.org Roll Skia from beb673968802 to 9b2b942d1eb1 (3 revisions) (flutter/flutter#176190) 2025-09-28 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0Z45OXT_Wb8aWI3a0... to 8zjcJic_DtvB2Bo2x... (flutter/flutter#176158) 2025-09-28 flar@google.com Revert "[Impeller] Optimize scale translate rectangle transforms" (flutter/flutter#176161) 2025-09-27 engine-flutter-autoroll@skia.org Roll Skia from 2e5da5c0a9cd to beb673968802 (1 revision) (flutter/flutter#176145) 2025-09-27 flar@google.com [Impeller] Optimize scale translate rectangle transforms (flutter/flutter#176123) 2025-09-27 engine-flutter-autoroll@skia.org Roll Skia from d8422aaf8f89 to 2e5da5c0a9cd (2 revisions) (flutter/flutter#176141) 2025-09-27 mdebbar@google.com [web] Remove mention of non-existent `canvaskit_lock.yaml` (flutter/flutter#176108) 2025-09-27 engine-flutter-autoroll@skia.org Roll Skia from 96b73f61fe61 to d8422aaf8f89 (2 revisions) (flutter/flutter#176118) 2025-09-27 sokolovskyi.konstantin@gmail.com [a11y] Add `expanded` flag support to Android. (flutter/flutter#174981) 2025-09-26 ahmedsameha1@gmail.com Make sure that a DesktopTextSelectionToolbar doesn't crash in 0x0 env… (flutter/flutter#173928) 2025-09-26 engine-flutter-autoroll@skia.org Roll Dart SDK from 899c7340cc4c to af31d2637b6b (11 revisions) (flutter/flutter#176056) 2025-09-26 1063596+reidbaker@users.noreply.github.com Update java version ranges with the top end limitation for java pre 17 (flutter/flutter#176049) 2025-09-26 1063596+reidbaker@users.noreply.github.com Add warn java evaluation to android_workflow (flutter/flutter#176097) 2025-09-26 katelovett@google.com Removes type annotations in templates (flutter/flutter#176106) 2025-09-26 fluttergithubbot@gmail.com Marks Linux_pixel_7pro static_path_stroke_tessellation_perf__timeline_summary to be unflaky (flutter/flutter#175917) 2025-09-26 1063596+reidbaker@users.noreply.github.com Add kotlin/kgp 2.2.* evaluation criteria. (flutter/flutter#176094) 2025-09-26 32538273+ValentinVignal@users.noreply.github.com Migrate to `WidgetStateMouseCursor` (flutter/flutter#175981) 2025-09-26 engine-flutter-autoroll@skia.org Roll Packages from 117bf63 to 389c678 (4 revisions) (flutter/flutter#176092) 2025-09-26 34871572+gmackall@users.noreply.github.com Fix link to .gclient setup instructions (flutter/flutter#176046) 2025-09-26 matt.kosarek@canonical.com Implement Regular Windows for the win32 framework + add an example application for regular windows (flutter/flutter#173715) 2025-09-26 engine-flutter-autoroll@skia.org Roll Skia from 5d99c3fc7c83 to 96b73f61fe61 (3 revisions) (flutter/flutter#176075) 2025-09-26 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from naeytagBIBEpKgZNZ... to 0Z45OXT_Wb8aWI3a0... (flutter/flutter#176068) 2025-09-26 100504385+AlsoShantanuBorkar@users.noreply.github.com Add itemClipBehavior property for CarouselView's children (flutter/flutter#175324) 2025-09-26 engine-flutter-autoroll@skia.org Roll Skia from 55436d87e414 to 5d99c3fc7c83 (4 revisions) (flutter/flutter#176060) 2025-09-26 flar@google.com Revert "[Impeller] Optimize scale translate rectangle transforms" (flutter/flutter#176061) 2025-09-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reapply "Update the AccessibilityPlugin::Announce method to account f… (#174365)" (flutter/flutter#176059) 2025-09-25 ahmedsameha1@gmail.com Make sure that a CupertinoDesktopTextSelectionToolbarButton doesn't c… (flutter/flutter#173894) 2025-09-25 mohellebiabdessalem@gmail.com Improve code quality in `SensitiveContentPluginTest.java` (flutter/flutter#175721) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...

…/flutter#176114)

This change adds support for two DTD Editor service RPCs and makes functionality that's dependent on the availability of the Editor service reactive to the service availability changing. The newly added `getActiveLocation` Editor RPC now allows for us to properly determine which source file is selected at startup, removing the need for special casing around initializing the filtered preview set. The `navigateToCode` Editor RPC is now supported, and URIs in stack traces can now be clicked to navigate to the source location in the IDE. Both filtering previews by selected file and stack frame navigation links are only enabled when the Editor service is available. Fixes flutter#176113

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 26, 2025

gemini-code-assist bot reviewed Sep 26, 2025

View reviewed changes

bkonyi added 2 commits September 26, 2025 16:03

Merge branch 'main' of github.com:flutter/flutter into improved_ide_i…

a8e16cc

…ntegration

Address comments

0ebc0b6

bkonyi requested a review from DanTup September 26, 2025 20:05

Fix bad merge

18d7727

DanTup reviewed Sep 26, 2025

View reviewed changes

bkonyi added 2 commits September 26, 2025 16:30

Update deps

e4300a4

Address comments

58be884

DanTup approved these changes Sep 26, 2025

View reviewed changes

DanTup mentioned this pull request Sep 29, 2025

Remove requirement for experiment flag for Widget Preview gated on Flutter version with important fixes Dart-Code/Dart-Code#5717

Closed

Fix pubspecs

3467df4

bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 29, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 29, 2025

Fix test

c011662

bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 29, 2025

auto-submit bot added this pull request to the merge queue Sep 29, 2025

Merged via the queue into master with commit 3d6b599 Sep 29, 2025
155 checks passed

auto-submit bot deleted the improved_ide_integration branch September 29, 2025 15:41

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 29, 2025

engine-flutter-autoroll mentioned this pull request Sep 29, 2025

Roll Flutter from 6cc976ec26d3 to 3d6b5994b86b (30 revisions) flutter/packages#10122

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 29, 2025

3d6b599 [ Widget Preview ] Improve IDE integration support (flutter/f…

c89d02f

…lutter#176114)

engine-flutter-autoroll mentioned this pull request Sep 29, 2025

Roll Flutter from 6cc976ec26d3 to 1e2447c604e5 (31 revisions) flutter/packages#10123

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 29, 2025

3d6b599 [ Widget Preview ] Improve IDE integration support (flutter/f…

6f4f181

…lutter#176114)

engine-flutter-autoroll mentioned this pull request Sep 29, 2025

Roll Flutter from 6cc976ec26d3 to 96fe3b3df509 (32 revisions) flutter/packages#10125

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 29, 2025

3d6b599 [ Widget Preview ] Improve IDE integration support (flutter/f…

121e305

…lutter#176114)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

3d6b5994b [ Widget Preview ] Improve IDE integration support (flutter…

13ffc02

…/flutter#176114)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ Widget Preview ] Improve IDE integration support #176114

[ Widget Preview ] Improve IDE integration support #176114

Uh oh!

bkonyi commented Sep 26, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bkonyi commented Sep 26, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DanTup Sep 26, 2025

Uh oh!

bkonyi Sep 29, 2025

Uh oh!

auto-submit bot commented Sep 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[ Widget Preview ] Improve IDE integration support #176114

[ Widget Preview ] Improve IDE integration support #176114

Uh oh!

Conversation

bkonyi commented Sep 26, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bkonyi commented Sep 26, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DanTup Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

bkonyi Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Sep 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants