Add non uniform TableBorder #175773

korca0220 · 2025-09-22T15:22:43Z

Re-implementation of PR #172441

Add non-uniform border radius support to TableBorder

This PR extends TableBorder to support border radius even when the outer border sides have different widths but the same color, similar to the non-uniform border support added to Border in #121921.

Changes

Enhanced border rendering logic: TableBorder can now apply border radius when outer border sides have uniform colors but non-uniform widths/styles
New helper methods: Added outerBorderIsUniform property and distinctVisibleOuterColors() method to determine border uniformity
Optimized paint method: Refactored the paint logic to handle three scenarios:
1. Fully uniform borders (existing optimized path)
2. Outer borders with uniform colors but non-uniform widths (new non-uniform border radius support)
3. Completely non-uniform borders (fallback to standard border painting)

Before/After

Before: TableBorder with border radius required all sides (including inner borders) to be completely identical.
After: TableBorder with border radius only requires outer border colors to be the same, allowing different widths per side.

Example Usage

TableBorder(
  top: BorderSide(color: Colors.blue, width: 3.0),
  right: BorderSide(color: Colors.blue, width: 1.0),  // Different width
  bottom: BorderSide(color: Colors.blue, width: 2.0), // Different width  
  left: BorderSide.none,                              // No border
  horizontalInside: BorderSide(color: Colors.red, width: 1.0), // Different color OK
  verticalInside: BorderSide(color: Colors.red, width: 1.0),   // Different color OK
  borderRadius: BorderRadius.circular(8), // ✅ Now works!
)

Fixes: #173193

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

gemini-code-assist

Code Review

This pull request extends TableBorder to support borderRadius for outer borders with uniform colors but non-uniform widths. The changes include moving inflateRRect and deflateRRect logic to EdgeInsets, refactoring TableBorder to handle different painting scenarios for uniform, color-uniform, and non-uniform borders, and adding associated tests. My feedback primarily focuses on enhancing test coverage for the new painting logic.

gemini-code-assist · 2025-09-22T15:25:22Z

packages/flutter/test/rendering/table_border_test.dart

+  test('TableBorder with non-uniform widths but uniform colors applies border radius', () {
+    const TableBorder borderWithRadius = TableBorder(
+      top: BorderSide(width: 3.0, color: Color(0xFF0000FF)),
+      right: BorderSide(color: Color(0xFF0000FF)),
+      bottom: BorderSide(width: 2.0, color: Color(0xFF0000FF)),
+      left: BorderSide(width: 1.5, color: Color(0xFF0000FF)),
+      borderRadius: BorderRadius.all(Radius.circular(8.0)),
+    );
+
+    expect(borderWithRadius.top.width, isNot(equals(borderWithRadius.bottom.width)));
+    expect(borderWithRadius.left.width, isNot(equals(borderWithRadius.right.width)));
+
+    final Color topColor = borderWithRadius.top.color;
+    expect(borderWithRadius.right.color, equals(topColor));
+    expect(borderWithRadius.bottom.color, equals(topColor));
+    expect(borderWithRadius.left.color, equals(topColor));
+
+    expect(borderWithRadius.borderRadius, const BorderRadius.all(Radius.circular(8.0)));
+  });


This test verifies the properties of the TableBorder object, which is a good start. However, it doesn't test the new painting logic in _paintTableBorder, which is the core of this change. To ensure the feature works as expected, please consider adding a test that calls the paint method and verifies that the correct drawing commands are issued on the canvas. This would provide stronger guarantees that the non-uniform border radius rendering is correct. You could use a mock canvas to check that drawDRRect is called with the expected RRects and Paint.

Piinks

Thanks for putting up another PR! Sorry the rebase went poorly. This LGTM - again! :)

justinmc

Reland LGTM 👍

Recreates the implementation from PR flutter#172441 on a clean branch after resolving rebase issues. Enables border radius when outer border sides have uniform colors but different widths/styles. Also adds inflateRRect and deflateRRect methods to EdgeInsets for consistent handling of rounded rectangles.

auto-submit · 2025-09-23T00:23:25Z

autosubmit label was removed for flutter/flutter/175773, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

Re-implementation of PR flutter#172441  ## Add non-uniform border radius support to TableBorder This PR extends TableBorder to support border radius even when the outer border sides have different widths but the same color, similar to the non-uniform border support added to Border in flutter#121921. ### Changes - Enhanced border rendering logic: TableBorder can now apply border radius when outer border sides have uniform colors but non-uniform widths/styles - New helper methods: Added `outerBorderIsUniform` property and `distinctVisibleOuterColors()` method to determine border uniformity - Optimized paint method: Refactored the paint logic to handle three scenarios: 1. Fully uniform borders (existing optimized path) 2. Outer borders with uniform colors but non-uniform widths (new non-uniform border radius support) 3. Completely non-uniform borders (fallback to standard border painting) ### Before/After - Before: TableBorder with border radius required all sides (including inner borders) to be completely identical. - After: TableBorder with border radius only requires outer border colors to be the same, allowing different widths per side. ### Example Usage ```dart TableBorder( top: BorderSide(color: Colors.blue, width: 3.0), right: BorderSide(color: Colors.blue, width: 1.0), // Different width bottom: BorderSide(color: Colors.blue, width: 2.0), // Different width left: BorderSide.none, // No border horizontalInside: BorderSide(color: Colors.red, width: 1.0), // Different color OK verticalInside: BorderSide(color: Colors.red, width: 1.0), // Different color OK borderRadius: BorderRadius.circular(8), // ✅ Now works! ) ``` Fixes: flutter#173193 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Roll Flutter from 4a04204 to b1a28bc (44 revisions) flutter/flutter@4a04204...b1a28bc 2025-09-25 48625061+muradhossin@users.noreply.github.com web_ui: avoid crash for showPerformanceOverlay; log 'not supported' once (flutter/flutter#173518) 2025-09-25 paulberry@google.com Ignore upcoming `experimental_member_use` warnings. (flutter/flutter#175969) 2025-09-25 engine-flutter-autoroll@skia.org Roll Skia from 753ce2221ce7 to 55436d87e414 (16 revisions) (flutter/flutter#176004) 2025-09-25 tirth@nevercode.io Add google_fonts to team-framework triage guidelines (flutter/flutter#175675) 2025-09-25 bruno.leroux@gmail.com Add tests for InputDecoration borders (M3 and theme normalization) (flutter/flutter#175838) 2025-09-24 737941+loic-sharma@users.noreply.github.com Update Flutter's templates to use dot shorthands (flutter/flutter#175891) 2025-09-24 matt.boetger@gmail.com In Gradle Flutter task, correctly replace '\ ' with ' '. (flutter/flutter#175815) 2025-09-24 47866232+chunhtai@users.noreply.github.com Cleans up navigator pop and remove logic (flutter/flutter#175612) 2025-09-24 rmolivares@renzo-olivares.dev Fix docs in `EditableText` (flutter/flutter#175787) 2025-09-24 47866232+chunhtai@users.noreply.github.com Fixes SemanticsFlags.isLink mis-translated in dart ui ffi (flutter/flutter#175812) 2025-09-24 1063596+reidbaker@users.noreply.github.com Update AGP/Java/Gradle comparison when using analyze --suggestions (flutter/flutter#175808) 2025-09-24 108678139+manu-sncf@users.noreply.github.com Fix SliverMainAxisGroup SliverEnsureSemantics support (flutter/flutter#175671) 2025-09-24 32538273+ValentinVignal@users.noreply.github.com Migrate to `WidgetStateColor` (flutter/flutter#175573) 2025-09-24 ahmedsameha1@gmail.com Make sure that a FlexibleSpaceBar doesn't crash in 0x0 environment (flutter/flutter#175228) 2025-09-24 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from BWj3yYC74ud58QhN0... to APSBP-sS-3FX69Ihf... (flutter/flutter#175944) 2025-09-24 ahmedsameha1@gmail.com Make sure that a MaterialApp doesn't crash in 0x0 environment (flutter/flutter#173090) 2025-09-24 36043466+koukibadr@users.noreply.github.com feat(cupertino): Add selectableDayPredicate parameter to CupertinoDatePicker for selectable day control #171332 (flutter/flutter#171334) 2025-09-24 mohellebiabdessalem@gmail.com Refactor `FlutterInjectorTest` to use lambdas/method reference (flutter/flutter#175777) 2025-09-24 mohellebiabdessalem@gmail.com Replace curly braces with lambdas in `KeyEventChannelTest` (flutter/flutter#175729) 2025-09-24 bkonyi@google.com [ Widget Preview ] Fix filter by file on Windows (flutter/flutter#175783) 2025-09-24 mohellebiabdessalem@gmail.com use lambda expressions /method reference to fix linter issue in `DartMessengerTest.java` (flutter/flutter#175733) 2025-09-24 engine-flutter-autoroll@skia.org Roll Packages from 3413b65 to 117bf63 (9 revisions) (flutter/flutter#175935) 2025-09-24 mohellebiabdessalem@gmail.com refactor code to use method reference and lambdas in `DartMessengerTest.java` (flutter/flutter#175731) 2025-09-24 mohellebiabdessalem@gmail.com Simplify/fix ordering of asserts in `TextInputPluginTest` (flutter/flutter#175784) 2025-09-24 mohellebiabdessalem@gmail.com Introduce a getter for `Project` to get `gradle-wrapper.properties` directly (flutter/flutter#175485) 2025-09-24 mohellebiabdessalem@gmail.com Change the arguments order in `assertEquals` to fix linter issues (flutter/flutter#175719) 2025-09-24 42980667+srivats22@users.noreply.github.com Broken link in NavigationRail documentation (flutter/flutter#175852) 2025-09-24 mdebbar@google.com Updates to flutter web triage links (flutter/flutter#175791) 2025-09-24 jason-simmons@users.noreply.github.com Do not present textures in FlutterMetalLayer if the drawable size changed and the texture's size does not match the new drawable size (flutter/flutter#175450) 2025-09-24 bkonyi@google.com Remove comment about trailing commas from templates (flutter/flutter#175864) 2025-09-24 engine-flutter-autoroll@skia.org Roll Skia from 1c1b19f2ffc3 to 753ce2221ce7 (4 revisions) (flutter/flutter#175909) 2025-09-24 engine-flutter-autoroll@skia.org Roll Skia from 3191a822cf10 to 1c1b19f2ffc3 (2 revisions) (flutter/flutter#175896) 2025-09-24 engine-flutter-autoroll@skia.org Roll Skia from cabeab8cb22c to 3191a822cf10 (14 revisions) (flutter/flutter#175894) 2025-09-24 engine-flutter-autoroll@skia.org Roll Dart SDK from 14b4ced3022a to 899c7340cc4c (4 revisions) (flutter/flutter#175893) 2025-09-24 paulberry@google.com Roll `package:analyzer` forward to `8.2.0`. (flutter/flutter#175849) 2025-09-24 ahmedsameha1@gmail.com Make sure that a VerticalDivider doesn't crash at 0x0 environment (flutter/flutter#174761) 2025-09-24 ahmedsameha1@gmail.com Make sure that Drawer & DrawerHeader don't crash in 0x0 environment (flutter/flutter#174772) 2025-09-24 rmolivares@renzo-olivares.dev Add an assertion for the relationship between `Visibility.maintainState` and `Visibility.maintainFocusability` (flutter/flutter#175552) 2025-09-24 34465683+rkishan516@users.noreply.github.com fix: remove final class modifier on MenuController (flutter/flutter#174490) 2025-09-24 34465683+rkishan516@users.noreply.github.com fix: cupertino sheet broken example with programatic pop (flutter/flutter#175709) 2025-09-24 mdebbar@google.com [web] Fix assertion thrown when hot restarting during animation (flutter/flutter#175856) 2025-09-24 krca0220@gmail.com Add non uniform TableBorder (flutter/flutter#175773) 2025-09-23 mohellebiabdessalem@gmail.com fix small typo in test docs (flutter/flutter#175776) 2025-09-23 mohellebiabdessalem@gmail.com Use `assertNull` to simplify code (flutter/flutter#175720) If this roll has caused a breakage, revert this CL and stop the roller ...

Re-implementation of PR flutter#172441  ## Add non-uniform border radius support to TableBorder This PR extends TableBorder to support border radius even when the outer border sides have different widths but the same color, similar to the non-uniform border support added to Border in flutter#121921. ### Changes - Enhanced border rendering logic: TableBorder can now apply border radius when outer border sides have uniform colors but non-uniform widths/styles - New helper methods: Added `outerBorderIsUniform` property and `distinctVisibleOuterColors()` method to determine border uniformity - Optimized paint method: Refactored the paint logic to handle three scenarios: 1. Fully uniform borders (existing optimized path) 2. Outer borders with uniform colors but non-uniform widths (new non-uniform border radius support) 3. Completely non-uniform borders (fallback to standard border painting) ### Before/After - Before: TableBorder with border radius required all sides (including inner borders) to be completely identical. - After: TableBorder with border radius only requires outer border colors to be the same, allowing different widths per side. ### Example Usage ```dart TableBorder( top: BorderSide(color: Colors.blue, width: 3.0), right: BorderSide(color: Colors.blue, width: 1.0), // Different width bottom: BorderSide(color: Colors.blue, width: 2.0), // Different width left: BorderSide.none, // No border horizontalInside: BorderSide(color: Colors.red, width: 1.0), // Different color OK verticalInside: BorderSide(color: Colors.red, width: 1.0), // Different color OK borderRadius: BorderRadius.circular(8), // ✅ Now works! ) ``` Fixes: flutter#173193 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Sep 22, 2025

gemini-code-assist bot reviewed Sep 22, 2025

View reviewed changes

korca0220 mentioned this pull request Sep 22, 2025

Add non uniform TableBorder #172441

Closed

9 tasks

Piinks approved these changes Sep 22, 2025

View reviewed changes

justinmc approved these changes Sep 22, 2025

View reviewed changes

korca0220 added 2 commits September 22, 2025 13:58

Feat re-implement BoxBorder from PR flutter#172441

fa04ffa

Piinks force-pushed the add-non-uniform-table-border-fix-rebase branch from 3aa8efc to fa04ffa Compare September 22, 2025 20:58

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2025

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2025

auto-submit bot added this pull request to the merge queue Sep 23, 2025

github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 23, 2025

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2025

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2025

auto-submit bot added this pull request to the merge queue Sep 24, 2025

Merged via the queue into flutter:master with commit 35b5342 Sep 24, 2025
82 of 83 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 24, 2025

35b5342 Add non uniform TableBorder (flutter/flutter#175773)

690b8d3

engine-flutter-autoroll mentioned this pull request Sep 24, 2025

Roll Flutter from 4a042046a0f1 to c804b2e0ea6f (15 revisions) flutter/packages#10068

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 24, 2025

35b5342 Add non uniform TableBorder (flutter/flutter#175773)

9f7d682

engine-flutter-autoroll mentioned this pull request Sep 24, 2025

Roll Flutter from 4a042046a0f1 to 9d203982172f (16 revisions) flutter/packages#10069

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 24, 2025

35b5342 Add non uniform TableBorder (flutter/flutter#175773)

c121c11

engine-flutter-autoroll mentioned this pull request Sep 24, 2025

Roll Flutter from 4a042046a0f1 to a6d424f7e366 (18 revisions) flutter/packages#10070

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 24, 2025

35b5342 Add non uniform TableBorder (flutter/flutter#175773)

c63e4ea

engine-flutter-autoroll mentioned this pull request Sep 24, 2025

Roll Flutter from 4a042046a0f1 to 439a80965a44 (21 revisions) flutter/packages#10071

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 24, 2025

35b5342 Add non uniform TableBorder (flutter/flutter#175773)

844997d

engine-flutter-autoroll mentioned this pull request Sep 24, 2025

Roll Flutter from 4a042046a0f1 to 321ae32b3eee (23 revisions) flutter/packages#10072

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 24, 2025

35b5342 Add non uniform TableBorder (flutter/flutter#175773)

7fbde4f

engine-flutter-autoroll mentioned this pull request Sep 24, 2025

Roll Flutter from 4a042046a0f1 to 440e7c2978dd (24 revisions) flutter/packages#10073

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2025

35b5342 Add non uniform TableBorder (flutter/flutter#175773)

b6e3a86

engine-flutter-autoroll mentioned this pull request Sep 25, 2025

Roll Flutter from 4a042046a0f1 to 57b7c46d0120 (43 revisions) flutter/packages#10076

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2025

35b5342 Add non uniform TableBorder (flutter/flutter#175773)

a043e36

engine-flutter-autoroll mentioned this pull request Sep 25, 2025

Roll Flutter from 4a042046a0f1 to b1a28bc065b0 (44 revisions) flutter/packages#10077

Merged

Piinks mentioned this pull request Oct 3, 2025

Flutter Notable Commits - 2025 #161460

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

35b5342 Add non uniform TableBorder (flutter/flutter#175773)

6de9988

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add non uniform TableBorder #175773

Add non uniform TableBorder #175773

Uh oh!

korca0220 commented Sep 22, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Sep 22, 2025

Uh oh!

Piinks left a comment

Uh oh!

justinmc left a comment

Uh oh!

auto-submit bot commented Sep 23, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add non uniform TableBorder #175773

Add non uniform TableBorder #175773

Uh oh!

Conversation

korca0220 commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add non-uniform border radius support to TableBorder

Changes

Before/After

Example Usage

Pre-launch Checklist

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Sep 23, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

korca0220 commented Sep 22, 2025 •

edited

Loading