Marks Windows plugin_test_android_variants to be unflaky #175167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Code Review
The pull request removes the bringup: true property from the Windows plugin_test_android_variants target in the .ci.yaml file. This change marks the test as unflaky, as it has been passing consistently for 50 consecutive runs. I have identified one high severity issue related to the removal of the bringup property without ensuring proper monitoring or alerting mechanisms are in place.
Comment on lines
6192
to
6193
| - name: Windows plugin_test_android_variants | ||
| bringup: true | ||
| recipe: devicelab/devicelab_drone |
Contributor
There was a problem hiding this comment.
Removing bringup: true marks the test as unflaky. However, it's crucial to ensure that proper monitoring and alerting are in place to detect any regressions promptly. Without bringup: true, failures will directly impact the tree. Consider adding alerts to notify the team if this test starts failing consistently again. 1
Style Guide References
Footnotes
-
This comment refers to the general principle of ensuring error messages are useful and that the system is monitored for failures, as described in the Flutter Style Guide. ↩
stuartmorgan-g
approved these changes
Sep 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 11, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 11, 2025
flutter/flutter@a082096...5a6a1bf 2025-09-11 engine-flutter-autoroll@skia.org Roll Dart SDK from 42045594dbc6 to f7d6a4732ab0 (2 revisions) (flutter/flutter#175222) 2025-09-11 engine-flutter-autoroll@skia.org Roll Skia from 00c8b3f69de9 to ead9277819fc (2 revisions) (flutter/flutter#175221) 2025-09-11 engine-flutter-autoroll@skia.org Roll Skia from 4a8817a48b25 to 00c8b3f69de9 (3 revisions) (flutter/flutter#175213) 2025-09-11 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 10x-JGF5zuuW8ik4K... to 1pTB3J5rn4YYugylf... (flutter/flutter#175210) 2025-09-11 engine-flutter-autoroll@skia.org Roll Dart SDK from 1de2289e49fe to 42045594dbc6 (1 revision) (flutter/flutter#175203) 2025-09-10 engine-flutter-autoroll@skia.org Roll Skia from cbb0388767d2 to 4a8817a48b25 (4 revisions) (flutter/flutter#175202) 2025-09-10 engine-flutter-autoroll@skia.org Roll Skia from 55c9d697da52 to cbb0388767d2 (7 revisions) (flutter/flutter#175197) 2025-09-10 engine-flutter-autoroll@skia.org Roll Dart SDK from f446144fb7c9 to 1de2289e49fe (3 revisions) (flutter/flutter#175192) 2025-09-10 engine-flutter-autoroll@skia.org Roll Skia from c3a3d1e47699 to 55c9d697da52 (4 revisions) (flutter/flutter#175190) 2025-09-10 engine-flutter-autoroll@skia.org Roll Packages from 2d651b2 to 03598e7 (5 revisions) (flutter/flutter#175185) 2025-09-10 engine-flutter-autoroll@skia.org Roll Skia from 36f3c3fbec19 to c3a3d1e47699 (2 revisions) (flutter/flutter#175181) 2025-09-10 fluttergithubbot@gmail.com Marks Linux plugin_test_android_standard to be unflaky (flutter/flutter#175163) 2025-09-10 engine-flutter-autoroll@skia.org Roll Skia from 97497ee065e4 to 36f3c3fbec19 (5 revisions) (flutter/flutter#175178) 2025-09-10 fluttergithubbot@gmail.com Marks Windows plugin_test_android_variants to be unflaky (flutter/flutter#175167) 2025-09-10 fluttergithubbot@gmail.com Marks Linux plugin_test_android_variants to be unflaky (flutter/flutter#175162) 2025-09-10 fluttergithubbot@gmail.com Marks Windows plugin_test_android_standard to be unflaky (flutter/flutter#175168) 2025-09-10 fluttergithubbot@gmail.com Marks Mac plugin_test_android_standard to be unflaky (flutter/flutter#175166) 2025-09-10 fluttergithubbot@gmail.com Marks Mac plugin_test_android_variants to be unflaky (flutter/flutter#175165) 2025-09-10 matej.knopp@gmail.com [shell] Fix engineId not being set after hot restart (flutter/flutter#174451) 2025-09-10 engine-flutter-autoroll@skia.org Roll Skia from 6acb8b29b60e to 97497ee065e4 (1 revision) (flutter/flutter#175152) 2025-09-10 engine-flutter-autoroll@skia.org Roll Skia from 127786500ad0 to 6acb8b29b60e (1 revision) (flutter/flutter#175148) 2025-09-10 engine-flutter-autoroll@skia.org Roll Skia from 04513dfdf517 to 127786500ad0 (2 revisions) (flutter/flutter#175145) 2025-09-09 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from m7Qmvj5wtfPlMA8i8... to 10x-JGF5zuuW8ik4K... (flutter/flutter#175140) 2025-09-09 engine-flutter-autoroll@skia.org Roll Skia from 416b3b42ece2 to 04513dfdf517 (5 revisions) (flutter/flutter#175137) 2025-09-09 engine-flutter-autoroll@skia.org Roll Skia from 19ba56dde579 to 416b3b42ece2 (1 revision) (flutter/flutter#175134) 2025-09-09 victorsanniay@gmail.com Adjust default CupertinoCheckbox size on desktop (flutter/flutter#172502) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
) <!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Windows plugin_test_android_variants" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20plugin_test_android_variants%22). This test can be marked as unflaky. Co-authored-by: stuartmorgan-g <stuartmorgan@google.com>
Jaineel-Mamtora
pushed a commit
to Jaineel-Mamtora/flutter_forked
that referenced
this pull request
Sep 24, 2025
) <!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Windows plugin_test_android_variants" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20plugin_test_android_variants%22). This test can be marked as unflaky. Co-authored-by: stuartmorgan-g <stuartmorgan@google.com>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
) <!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Windows plugin_test_android_variants" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20plugin_test_android_variants%22). This test can be marked as unflaky. Co-authored-by: stuartmorgan-g <stuartmorgan@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test has been passing for 50 consecutive runs.
This test can be marked as unflaky.