Update Chromium sysroot to pick up RISC-V support. #173671
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request updates the Chromium sysroot to add support for RISC-V and newer Debian versions for other architectures. The changes to the GN configuration and the sysroot JSON data appear correct and consistent. The Python script for installing sysroots has been significantly refactored. My review focuses on improving the Python script's adherence to best practices for maintainability and robustness, in line with the project's style guide. I've suggested changes to improve exception handling, resource management, string formatting, and code clarity.
flutter/flutter@29a238d...8d0b31d 2025-09-16 engine-flutter-autoroll@skia.org Roll Packages from fcd5f68 to 0255ac9 (2 revisions) (flutter/flutter#175427) 2025-09-16 47866232+chunhtai@users.noreply.github.com Adds a11y section locale support for iOS (flutter/flutter#175005) 2025-09-16 engine-flutter-autoroll@skia.org Roll Skia from 4e9c86d4a6d9 to 7d160bbf9403 (3 revisions) (flutter/flutter#175404) 2025-09-16 gregorysconrad@gmail.com [native_assets] Find more `CCompilerConfig` on Linux (flutter/flutter#175323) 2025-09-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 50e61e5bff51 to 700de52f29a9 (3 revisions) (flutter/flutter#175395) 2025-09-16 32538273+ValentinVignal@users.noreply.github.com Fix default overlay color in `TabBar` (flutter/flutter#175270) 2025-09-16 32538273+ValentinVignal@users.noreply.github.com Migrate to widget state (flutter/flutter#175242) 2025-09-16 engine-flutter-autoroll@skia.org Roll Skia from 01b0ede33ae9 to 4e9c86d4a6d9 (1 revision) (flutter/flutter#175387) 2025-09-15 chinmaygarde@google.com Merge the engine README into the README of the old buildroot. (flutter/flutter#175384) 2025-09-15 fluttergithubbot@gmail.com Marks Mac_ios microbenchmarks_ios to be unflaky (flutter/flutter#171146) 2025-09-15 okorohelijah@google.com Deprecate Objective-C plugin template (flutter/flutter#174003) 2025-09-15 robert.ancell@canonical.com Add a gn --ccache argument (flutter/flutter#174621) 2025-09-15 mohellebiabdessalem@gmail.com Update `build.gradle` to remove deprecation warning in `flutter\engine\src\flutter\shell\platform\android` (flutter/flutter#175305) 2025-09-15 54338732+Memet18@users.noreply.github.com Show cursor after swipe only if TextField has focus (flutter/flutter#175044) 2025-09-15 engine-flutter-autoroll@skia.org Roll Skia from f950263bb3d4 to 01b0ede33ae9 (7 revisions) (flutter/flutter#175373) 2025-09-15 rmacnak@google.com Update Chromium sysroot to pick up RISC-V support. (flutter/flutter#173671) 2025-09-15 magder@google.com Set Gemini Code Assist `include_drafts` to false (flutter/flutter#175098) 2025-09-15 engine-flutter-autoroll@skia.org Roll Packages from 15e7e89 to fcd5f68 (3 revisions) (flutter/flutter#175366) 2025-09-15 115182119+danwirele@users.noreply.github.com Remove 'v' Open DevTools from help on web in profile/release mode (flutter/flutter#172829) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: #99963