-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Remove 'v' Open DevTools from help on web in profile/release mode #172829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@nt4f04uNd hi, can i have a review, please |
nt4f04uNd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @danwirele, welcome here with your first contribution!
It mostly looks good, just small comments about docs here and there.
I am not terribly familiar with the flutter_tools, so I will also seek for one more reviewer to confirm all is good.
It's great that you added multiple tests for this!
Co-authored-by: Daniil Lipatkin <nt4f04uNd@gmail.com>
Co-authored-by: Daniil Lipatkin <nt4f04uNd@gmail.com>
This comment has been minimized.
This comment has been minimized.
|
LGTM! |
This comment has been minimized.
This comment has been minimized.
|
Swapping for @bkonyi |
|
autosubmit label was removed for flutter/flutter/172829, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
|
autosubmit label was removed for flutter/flutter/172829, because - The status or check suite Mac build_ios_framework_module_test has failed. Please fix the issues identified (or deflake) before re-applying this label. |
…72829) This change: - Hides `v` from the help menu on web in profile/release mode - Keeps `v` available in debug and on native platforms - Change command order: `v` now appears before `s` in help - Updates `_commonTerminalInputHandler` to block `v` on web in release mode Testing: - Added new test: `printHelpDetails hides v on web in profile mode` - Added new test: 'v - does not launchDevToolsInBrowser on web in profile mode' - Fixed existing test to match correct command order (`v` before `s`) fixes #143451 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Daniil Lipatkin <nt4f04uNd@gmail.com> Co-authored-by: Ben Konyi <bkonyi@google.com>
flutter/flutter@29a238d...8d0b31d 2025-09-16 engine-flutter-autoroll@skia.org Roll Packages from fcd5f68 to 0255ac9 (2 revisions) (flutter/flutter#175427) 2025-09-16 47866232+chunhtai@users.noreply.github.com Adds a11y section locale support for iOS (flutter/flutter#175005) 2025-09-16 engine-flutter-autoroll@skia.org Roll Skia from 4e9c86d4a6d9 to 7d160bbf9403 (3 revisions) (flutter/flutter#175404) 2025-09-16 gregorysconrad@gmail.com [native_assets] Find more `CCompilerConfig` on Linux (flutter/flutter#175323) 2025-09-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 50e61e5bff51 to 700de52f29a9 (3 revisions) (flutter/flutter#175395) 2025-09-16 32538273+ValentinVignal@users.noreply.github.com Fix default overlay color in `TabBar` (flutter/flutter#175270) 2025-09-16 32538273+ValentinVignal@users.noreply.github.com Migrate to widget state (flutter/flutter#175242) 2025-09-16 engine-flutter-autoroll@skia.org Roll Skia from 01b0ede33ae9 to 4e9c86d4a6d9 (1 revision) (flutter/flutter#175387) 2025-09-15 chinmaygarde@google.com Merge the engine README into the README of the old buildroot. (flutter/flutter#175384) 2025-09-15 fluttergithubbot@gmail.com Marks Mac_ios microbenchmarks_ios to be unflaky (flutter/flutter#171146) 2025-09-15 okorohelijah@google.com Deprecate Objective-C plugin template (flutter/flutter#174003) 2025-09-15 robert.ancell@canonical.com Add a gn --ccache argument (flutter/flutter#174621) 2025-09-15 mohellebiabdessalem@gmail.com Update `build.gradle` to remove deprecation warning in `flutter\engine\src\flutter\shell\platform\android` (flutter/flutter#175305) 2025-09-15 54338732+Memet18@users.noreply.github.com Show cursor after swipe only if TextField has focus (flutter/flutter#175044) 2025-09-15 engine-flutter-autoroll@skia.org Roll Skia from f950263bb3d4 to 01b0ede33ae9 (7 revisions) (flutter/flutter#175373) 2025-09-15 rmacnak@google.com Update Chromium sysroot to pick up RISC-V support. (flutter/flutter#173671) 2025-09-15 magder@google.com Set Gemini Code Assist `include_drafts` to false (flutter/flutter#175098) 2025-09-15 engine-flutter-autoroll@skia.org Roll Packages from 15e7e89 to fcd5f68 (3 revisions) (flutter/flutter#175366) 2025-09-15 115182119+danwirele@users.noreply.github.com Remove 'v' Open DevTools from help on web in profile/release mode (flutter/flutter#172829) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…utter#172829) This change: - Hides `v` from the help menu on web in profile/release mode - Keeps `v` available in debug and on native platforms - Change command order: `v` now appears before `s` in help - Updates `_commonTerminalInputHandler` to block `v` on web in release mode Testing: - Added new test: `printHelpDetails hides v on web in profile mode` - Added new test: 'v - does not launchDevToolsInBrowser on web in profile mode' - Fixed existing test to match correct command order (`v` before `s`) fixes flutter#143451 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Daniil Lipatkin <nt4f04uNd@gmail.com> Co-authored-by: Ben Konyi <bkonyi@google.com>
…utter#172829) This change: - Hides `v` from the help menu on web in profile/release mode - Keeps `v` available in debug and on native platforms - Change command order: `v` now appears before `s` in help - Updates `_commonTerminalInputHandler` to block `v` on web in release mode Testing: - Added new test: `printHelpDetails hides v on web in profile mode` - Added new test: 'v - does not launchDevToolsInBrowser on web in profile mode' - Fixed existing test to match correct command order (`v` before `s`) fixes flutter#143451 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Daniil Lipatkin <nt4f04uNd@gmail.com> Co-authored-by: Ben Konyi <bkonyi@google.com>
…utter#172829) This change: - Hides `v` from the help menu on web in profile/release mode - Keeps `v` available in debug and on native platforms - Change command order: `v` now appears before `s` in help - Updates `_commonTerminalInputHandler` to block `v` on web in release mode Testing: - Added new test: `printHelpDetails hides v on web in profile mode` - Added new test: 'v - does not launchDevToolsInBrowser on web in profile mode' - Fixed existing test to match correct command order (`v` before `s`) fixes flutter#143451 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Daniil Lipatkin <nt4f04uNd@gmail.com> Co-authored-by: Ben Konyi <bkonyi@google.com>
…utter#172829) This change: - Hides `v` from the help menu on web in profile/release mode - Keeps `v` available in debug and on native platforms - Change command order: `v` now appears before `s` in help - Updates `_commonTerminalInputHandler` to block `v` on web in release mode Testing: - Added new test: `printHelpDetails hides v on web in profile mode` - Added new test: 'v - does not launchDevToolsInBrowser on web in profile mode' - Fixed existing test to match correct command order (`v` before `s`) fixes flutter#143451 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Daniil Lipatkin <nt4f04uNd@gmail.com> Co-authored-by: Ben Konyi <bkonyi@google.com>
This change:
vfrom the help menu on web in profile/release modevavailable in debug and on native platformsvnow appears beforesin help_commonTerminalInputHandlerto blockvon web in release modeTesting:
printHelpDetails hides v on web in profile modevbefores)fixes #143451
Pre-launch Checklist
///).