Reapply "Make device debuggable if useDwdsWebSocketConnection is true … (#173551)" #173568

bkonyi · 2025-08-11T19:01:38Z

This reverts commit e2a347b.

Previously reverted due to *_chrome_dev_mode tests failing on all platforms.

… … (#173551) This reverts commit e2a347b.

gemini-code-assist

Code Review

This pull request reapplies a change to make WebServerDevice debuggable when using a DWDS WebSocket connection. The changes include refactoring the debuggability logic in ResidentWebRunner, introducing a WebServerDevice in the devicelab framework, and updating tests accordingly. A new integration test for the WebSocket hot reload flow is also added. The changes look good and the refactoring improves clarity. I've found one potential null pointer exception to address.

dev/devicelab/lib/tasks/web_dev_mode_tests.dart

jyameo · 2025-08-11T19:26:14Z

packages/flutter_tools/lib/src/isolated/resident_web_runner.dart


-  /// WebServer device is debuggable when running with --start-paused.
-  bool get deviceIsDebuggable => device!.device is! WebServerDevice || debuggingOptions.startPaused;
+  late final useDwdsWebSocketConnection = device!.device is! ChromiumDevice;


My only concern about this change is that I hope this doesn't break the DDCLibraryBundle/Web-server/Chromium path described here: https://docs.google.com/spreadsheets/d/1M5OfuSfLOaoanp1d_D_2m419Zp3CukX8bgJ9307dT8I/edit?resourcekey=0-hywN0w4hRS0iRpByOKXLnQ&gid=0#gid=0

I'll run some local test to make sure of this

I tested it locally and it seems to work as expected with the DdcLibraryBundle.

@nshahan @srujzs question for you, now that we are using the DDCLibraryBundle by default, do we still support the AMD format? If so, how can we run the app with this format?

We do still need to support running without the DdcLibraryBundle format for now. You can do it by disabling the hot reload support:

flutter run --no-web-experimental-hot-reload -d chrome
flutter drive --no-web-experimental-hot-reload -d chrome

And using the -d web-server device as well.

jyameo

Thank you so much @bkonyi !! 🚀

nshahan · 2025-08-11T20:44:14Z

packages/flutter_tools/test/integration.shard/hot_reload_websocket_test.dart

+          // Step 3: Launch headless Chrome to connect to DWDS
+          debugPrint('Step 3: Launching headless Chrome to connect to DWDS...');
+          chromeProcess = await _launchHeadlessChrome(debugUrl);
+          debugPrint('✓ Headless Chrome launched and connecting to DWDS');


Should we remove this part of the test now? It seems like we don't need another chrome session involved since we removed the race condition?

No, this is still required to actually initialize DWDS for the application. Breaking the deadlock just fixed the flutter drive case where the test driver couldn't start until the service was available, but the service couldn't become available until an initial connection had been made to the server.

OK thanks. IIUC this test simulates flutter run -d web-server which doesn't launch a browser itself so instead the test launches a headless chrome instance to connect to it and trigger the machinery to start the application.

That's correct!

auto-submit · 2025-08-11T22:10:29Z

A reason for requesting a revert of flutter/flutter/173568 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

bkonyi · 2025-08-11T22:11:22Z

Reason for revert: Chrome isn't configured for the test configuration and is causing failures.

… is true … (#173551)" (#173568)" This reverts commit a9fc145.

auto-submit · 2025-08-11T22:17:36Z

Unable to create the revert pull request due to ProcessException: Standard error
Pushing to https://github.com/flutter/flutter.git
To https://github.com/flutter/flutter.git
! [rejected] revert_a9fc145a3d09c3f224beb20f03c93b1da7d68361 -> revert_a9fc145a3d09c3f224beb20f03c93b1da7d68361 (non-fast-forward)
error: failed to push some refs to 'https://github.com/flutter/flutter.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
Command: git push --verbose origin revert_a9fc145a3d09c3f224beb20f03c93b1da7d68361

… is true … (#173551)" (flutter/flutter#173568)

srujzs · 2025-08-12T21:23:58Z

@bkonyi Are you still trying to revert the reland?

I'm looking into publishing a new version of dwds and use that in Flutter but I'm waiting until Flutter is updated with the current newest version of DWDS (this PR). If this is okay and you don't expect to revert it, I'll go ahead and work on that.

bkonyi · 2025-08-12T21:35:41Z

@bkonyi Are you still trying to revert the reland?

I'm looking into publishing a new version of dwds and use that in Flutter but I'm waiting until Flutter is updated with the current newest version of DWDS (this PR). If this is okay and you don't expect to revert it, I'll go ahead and work on that.

This has relanded in #173628 😁

srujzs · 2025-08-12T22:22:10Z

Hah, okay. Hopefully that should be the last of that, thank you both for dealing with all the back and forth!

… is true … (#173551)" (flutter/flutter#173568)

Roll Flutter from e2a347b to 34c2a3b (41 revisions) flutter/flutter@e2a347b...34c2a3b 2025-08-13 bkonyi@google.com [ Tool ] Mark Linux_pixel_7pro linux_chrome_dev_mode as bringup (flutter/flutter#173646) 2025-08-13 bkonyi@google.com [ Widget Preview ] Move `--dtd-url` from a global flag to a `widget-preview start` option (flutter/flutter#173712) 2025-08-13 jssaadeh@outlook.com Null aware elements clean-ups (flutter/flutter#173074) 2025-08-13 engine-flutter-autoroll@skia.org Roll Skia from 29e3e1ab7f62 to f7fdda3cd0e6 (3 revisions) (flutter/flutter#173709) 2025-08-13 matt.kosarek@canonical.com Regular windows win32 engine (flutter/flutter#173424) 2025-08-13 engine-flutter-autoroll@skia.org Roll Dart SDK from a098cb676fd6 to 73153bdc1459 (1 revision) (flutter/flutter#173708) 2025-08-13 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vgv-rTf7i9PfcDq2Y... to I1TfNmsqTp7t3rO8e... (flutter/flutter#173690) 2025-08-13 engine-flutter-autoroll@skia.org Roll Skia from 1170405c30cf to 29e3e1ab7f62 (2 revisions) (flutter/flutter#173689) 2025-08-13 engine-flutter-autoroll@skia.org Roll Dart SDK from e2b7aec7333e to a098cb676fd6 (4 revisions) (flutter/flutter#173683) 2025-08-13 engine-flutter-autoroll@skia.org Roll Skia from d06fdf03c6a1 to 1170405c30cf (4 revisions) (flutter/flutter#173681) 2025-08-13 engine-flutter-autoroll@skia.org Roll Skia from 9ed4b4e53db2 to d06fdf03c6a1 (11 revisions) (flutter/flutter#173661) 2025-08-12 robert.ancell@canonical.com Fix GTK redraw call being called from non-GTK thread. (flutter/flutter#173602) 2025-08-12 jason-simmons@users.noreply.github.com [Impeller] Apply Y coordinate scaling when sampling from the destination texture in framebuffer advanced blends (flutter/flutter#173639) 2025-08-12 11901536+romaingyh@users.noreply.github.com Fix directional focus in nested scrollables with different axis (flutter/flutter#172875) 2025-08-12 41930132+hellohuanlin@users.noreply.github.com [ios][tools]do not log "bonjour not found" at all (unless verbose) (flutter/flutter#173569) 2025-08-12 1063596+reidbaker@users.noreply.github.com Remove jetifier usages (flutter/flutter#173548) 2025-08-12 bkonyi@google.com [ Tool ] Fix run_linux_chrome_dev_mode (flutter/flutter#173647) 2025-08-12 41930132+hellohuanlin@users.noreply.github.com [ios] Update iOS code signing CIPD instruction command (flutter/flutter#171173) 2025-08-12 bkonyi@google.com Reapply "Make device debuggable if useDwdsWebSocketConnection is true … (#173551)" (flutter/flutter#173628) 2025-08-12 jason-simmons@users.noreply.github.com Roll Clang to 8c7a2ce01a77c96028fe2c8566f65c45ad9408d3 (flutter/flutter#173429) 2025-08-12 mdebbar@google.com [web] Fallback to CanvasKit when WebGL is not available (flutter/flutter#173629) 2025-08-12 engine-flutter-autoroll@skia.org Roll Packages from a114ac2 to 08a9b2c (3 revisions) (flutter/flutter#173625) 2025-08-12 bkonyi@google.com [ Tool ] Fix crash from possible DDS startup race (flutter/flutter#173362) 2025-08-12 engine-flutter-autoroll@skia.org Roll Skia from a2936eff2179 to 9ed4b4e53db2 (3 revisions) (flutter/flutter#173611) 2025-08-12 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4 to 5 in the all-github-actions group (flutter/flutter#173606) 2025-08-12 engine-flutter-autoroll@skia.org Roll Dart SDK from c5fe48aee60d to e2b7aec7333e (1 revision) (flutter/flutter#173604) 2025-08-12 engine-flutter-autoroll@skia.org Roll Skia from 44bb9d908ee4 to a2936eff2179 (21 revisions) (flutter/flutter#173603) 2025-08-12 ybz975218925@gmail.com Fix the issue of over-scrolling in SliverMainAxisGroup with a PinnedHeaderSliver. (flutter/flutter#173349) 2025-08-12 engine-flutter-autoroll@skia.org Roll Dart SDK from b2a23936f968 to c5fe48aee60d (2 revisions) (flutter/flutter#173596) 2025-08-11 fmalita@gmail.com Update CanRenderTiledTexture unit tests (flutter/flutter#173553) 2025-08-11 15619084+vashworth@users.noreply.github.com Update integration test for iOS deployment workflows (flutter/flutter#173566) 2025-08-11 30870216+gaaclarke@users.noreply.github.com Enables vulkan for PowerVR B-Series (flutter/flutter#173561) 2025-08-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reapply "Make device debuggable if useDwdsWebSocketConnection is true … (#173551)" (#173568)" (flutter/flutter#173587) 2025-08-11 engine-flutter-autoroll@skia.org Roll Dart SDK from 8e882349fcab to b2a23936f968 (2 revisions) (flutter/flutter#173571) 2025-08-11 bkonyi@google.com Reapply "Make device debuggable if useDwdsWebSocketConnection is true … (#173551)" (flutter/flutter#173568) 2025-08-11 15619084+vashworth@users.noreply.github.com Update CI iOS tests (flutter/flutter#173563) 2025-08-11 engine-flutter-autoroll@skia.org Roll Packages from 34948d1 to a114ac2 (4 revisions) (flutter/flutter#173556) 2025-08-11 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from HclTm0V8hgSpfqmtG... to vgv-rTf7i9PfcDq2Y... (flutter/flutter#173505) 2025-08-11 engine-flutter-autoroll@skia.org Roll Dart SDK from 6a7ae1ffd1c9 to 8e882349fcab (2 revisions) (flutter/flutter#173499) 2025-08-11 32538273+ValentinVignal@users.noreply.github.com Update `ExpansibleController` in `ExpansionTile` `didUpdateWidget` (flutter/flutter#173175) 2025-08-11 41930132+hellohuanlin@users.noreply.github.com add format cmd to tools instruction (flutter/flutter#173428) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human ...

… … (flutter#173551)" (flutter#173568) This reverts commit e2a347b. Previously reverted due to `*_chrome_dev_mode` tests failing on all platforms.

…n is true … (flutter#173551)" (flutter#173568)" (flutter#173587)  Reverts: flutter#173568   Initiated by: bkonyi   Reason for reverting: Chrome isn't configured for the test configuration and is causing failures.   Original PR Author: bkonyi   Reviewed By: {jyameo, matanlurey}   This change reverts the following previous change: This reverts commit e2a347b. Previously reverted due to `*_chrome_dev_mode` tests failing on all platforms.  Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>

… … (flutter#173551)" (flutter#173568) This reverts commit e2a347b. Previously reverted due to `*_chrome_dev_mode` tests failing on all platforms.

…n is true … (flutter#173551)" (flutter#173568)" (flutter#173587)  Reverts: flutter#173568   Initiated by: bkonyi   Reason for reverting: Chrome isn't configured for the test configuration and is causing failures.   Original PR Author: bkonyi   Reviewed By: {jyameo, matanlurey}   This change reverts the following previous change: This reverts commit e2a347b. Previously reverted due to `*_chrome_dev_mode` tests failing on all platforms.  Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>

… … (flutter#173551)" (flutter#173568) This reverts commit e2a347b. Previously reverted due to `*_chrome_dev_mode` tests failing on all platforms.

…n is true … (flutter#173551)" (flutter#173568)" (flutter#173587)  Reverts: flutter#173568   Initiated by: bkonyi   Reason for reverting: Chrome isn't configured for the test configuration and is causing failures.   Original PR Author: bkonyi   Reviewed By: {jyameo, matanlurey}   This change reverts the following previous change: This reverts commit e2a347b. Previously reverted due to `*_chrome_dev_mode` tests failing on all platforms.  Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>

… is true … (#173551)" (flutter/flutter#173568)

… … (flutter#173551)" (flutter#173568) This reverts commit e2a347b. Previously reverted due to `*_chrome_dev_mode` tests failing on all platforms.

…n is true … (flutter#173551)" (flutter#173568)" (flutter#173587)  Reverts: flutter#173568   Initiated by: bkonyi   Reason for reverting: Chrome isn't configured for the test configuration and is causing failures.   Original PR Author: bkonyi   Reviewed By: {jyameo, matanlurey}   This change reverts the following previous change: This reverts commit e2a347b. Previously reverted due to `*_chrome_dev_mode` tests failing on all platforms.  Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>

bkonyi added 2 commits August 11, 2025 14:58

Reapply "Make device debuggable if useDwdsWebSocketConnection is true…

5bb2429

… … (#173551) This reverts commit e2a347b.

Fix chrome_dev_mode tests

686bf09

bkonyi requested a review from jyameo August 11, 2025 19:01

bkonyi requested a review from matanlurey as a code owner August 11, 2025 19:01

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 11, 2025

Update browser.dart

37993fb

gemini-code-assist bot reviewed Aug 11, 2025

View reviewed changes

dev/devicelab/lib/tasks/web_dev_mode_tests.dart Outdated Show resolved Hide resolved

Update web_dev_mode_tests.dart

6cd606c

jyameo reviewed Aug 11, 2025

View reviewed changes

matanlurey approved these changes Aug 11, 2025

View reviewed changes

Fix tests

15693d1

jyameo approved these changes Aug 11, 2025

View reviewed changes

bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 11, 2025

auto-submit bot added this pull request to the merge queue Aug 11, 2025

nshahan reviewed Aug 11, 2025

View reviewed changes

Merged via the queue into master with commit a9fc145 Aug 11, 2025
156 checks passed

auto-submit bot deleted the reland_webserver_websocket branch August 11, 2025 21:15

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 11, 2025

bkonyi added the revert Autorevert PR (with "Reason for revert:" comment) label Aug 11, 2025

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Aug 11, 2025

bkonyi added the revert Autorevert PR (with "Reason for revert:" comment) label Aug 11, 2025

auto-submit bot pushed a commit that referenced this pull request Aug 11, 2025

Revert "Reapply "Make device debuggable if useDwdsWebSocketConnection…

be8cbcc

… is true … (#173551)" (#173568)" This reverts commit a9fc145.

auto-submit bot mentioned this pull request Aug 11, 2025

Reverts "Reapply "Make device debuggable if useDwdsWebSocketConnection is true … (#173551)" (#173568)" #173587

Merged

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Aug 11, 2025

bkonyi added the revert Autorevert PR (with "Reason for revert:" comment) label Aug 11, 2025

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Aug 11, 2025

engine-flutter-autoroll mentioned this pull request Aug 12, 2025

Roll Flutter from e2a347b14a18 to f63cb75520d2 (21 revisions) flutter/packages#9791

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2025

a9fc145 Reapply "Make device debuggable if useDwdsWebSocketConnection…

fb05131

… is true … (#173551)" (flutter/flutter#173568)

engine-flutter-autoroll mentioned this pull request Aug 12, 2025

Roll Flutter from e2a347b14a18 to f45a8f8b719e (22 revisions) flutter/packages#9792

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2025

a9fc145 Reapply "Make device debuggable if useDwdsWebSocketConnection…

b4d4d4c

… is true … (#173551)" (flutter/flutter#173568)

engine-flutter-autoroll mentioned this pull request Aug 12, 2025

Roll Flutter from e2a347b14a18 to c4ce6a8ef7f8 (23 revisions) flutter/packages#9793

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 13, 2025

a9fc145 Reapply "Make device debuggable if useDwdsWebSocketConnection…

c2c7dd5

… is true … (#173551)" (flutter/flutter#173568)

engine-flutter-autoroll mentioned this pull request Aug 13, 2025

Roll Flutter from e2a347b14a18 to 6a89f1e75367 (35 revisions) flutter/packages#9797

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 13, 2025

a9fc145 Reapply "Make device debuggable if useDwdsWebSocketConnection…

61690d7

… is true … (#173551)" (flutter/flutter#173568)

engine-flutter-autoroll mentioned this pull request Aug 13, 2025

Roll Flutter from e2a347b14a18 to 9cbd55ceb8ab (36 revisions) flutter/packages#9798

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 13, 2025

a9fc145 Reapply "Make device debuggable if useDwdsWebSocketConnection…

5a979ef

… is true … (#173551)" (flutter/flutter#173568)

engine-flutter-autoroll mentioned this pull request Aug 13, 2025

Roll Flutter from e2a347b14a18 to 738ec1a4b940 (37 revisions) flutter/packages#9799

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 13, 2025

a9fc145 Reapply "Make device debuggable if useDwdsWebSocketConnection…

1e5dfc5

… is true … (#173551)" (flutter/flutter#173568)

engine-flutter-autoroll mentioned this pull request Aug 13, 2025

Roll Flutter from e2a347b14a18 to f26eddba0053 (39 revisions) flutter/packages#9801

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 13, 2025

a9fc145 Reapply "Make device debuggable if useDwdsWebSocketConnection…

008de38

… is true … (#173551)" (flutter/flutter#173568)

engine-flutter-autoroll mentioned this pull request Aug 13, 2025

Roll Flutter from e2a347b14a18 to 1eb2f68da5a7 (40 revisions) flutter/packages#9802

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 13, 2025

a9fc145 Reapply "Make device debuggable if useDwdsWebSocketConnection…

92fa470

… is true … (#173551)" (flutter/flutter#173568)

engine-flutter-autoroll mentioned this pull request Aug 13, 2025

Roll Flutter from e2a347b14a18 to 34c2a3b158b2 (41 revisions) flutter/packages#9803

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

a9fc145 Reapply "Make device debuggable if useDwdsWebSocketConnection…

2790c3d

… is true … (#173551)" (flutter/flutter#173568)

Reapply "Make device debuggable if useDwdsWebSocketConnection is true … (#173551)" #173568

Reapply "Make device debuggable if useDwdsWebSocketConnection is true … (#173551)" #173568

Uh oh!

Conversation

bkonyi commented Aug 11, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

jyameo Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

jyameo Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

nshahan Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jyameo left a comment

Choose a reason for hiding this comment

Uh oh!

nshahan Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

bkonyi Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

nshahan Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

bkonyi Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

auto-submit bot commented Aug 11, 2025

Uh oh!

bkonyi commented Aug 11, 2025

Uh oh!

auto-submit bot commented Aug 11, 2025

Uh oh!

srujzs commented Aug 12, 2025

Uh oh!

bkonyi commented Aug 12, 2025

Uh oh!

srujzs commented Aug 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nshahan Aug 11, 2025 •

edited

Loading