Skip to content

Work around newer compilers requiring the satisfaction of three-way comparison of EncodableValue. #170822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Jun 18, 2025
Merged

Work around newer compilers requiring the satisfaction of three-way comparison of EncodableValue. #170822

auto-submit merged 2 commits into from
Jun 18, 2025

Conversation

@chinmaygarde
Copy link
Contributor

@chinmaygarde chinmaygarde commented Jun 18, 2025

Evolution of a previous blocker flutter/engine#43091.
Fixes b/423885648

@chinmaygarde
Work around newer compilers requiring the satisfaction of three-way c…
7e75cc3 
…omparison of EncodableValue.

Evolution of a previous blocker flutter/engine#43091.
Fixes b/423885648
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jun 18, 2025

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Jun 18, 2025
@jtmcdole
Copy link
Member

jtmcdole commented Jun 18, 2025

Thank you!

flar
flar approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, especially, especially the comment!

(typo nit?)

@flar
Copy link
Contributor

flar commented Jun 18, 2025

Test? Or request exemption?

@chinmaygarde
Copy link
Contributor Author

chinmaygarde commented Jun 18, 2025

@stuartmorgan-g Do you have any guidance on testing? We don't have any C++20 tests and our toolchain is not bleeding edge enough to exercise this either. Once it lands, the Google3 environment will also likely not exercise this till the internal roll succeeds. Not sure how you did it last time.

stuartmorgan-g
stuartmorgan-g approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We didn't have any meaningful upstream test last time; it was essentially upstreamed from google3. We also didn't have any conditional compilation that we weren't using though, so from the upstream perspective it was a refactoring with no changes, because we were still testing the code, even though we didn't need the change.

This is definitely worse than that since we aren't even compiling this, but I don't have a suggestion other than waiting until we have C++20 support to get coverage.

@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Jun 18, 2025 •
edited
Loading

test-exempt: unblocks future changes, and will become tested once we have upstream C++20 support. (Succeeding compilation will be the test.)

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 18, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 18, 2025
Merged via the queue into flutter:master with commit 9c3a133 Jun 18, 2025
176 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 18, 2025
@chinmaygarde chinmaygarde deleted the upstreamb423885648 branch June 18, 2025 20:44
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
9c3a133 Work around newer compilers requiring the satisfaction of thr…
857facb 
…ee-way comparison of EncodableValue. (flutter/flutter#170822)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
9c3a133 Work around newer compilers requiring the satisfaction of thr…
3cdd3ed 
…ee-way comparison of EncodableValue. (flutter/flutter#170822)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 19, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
9c3a133 Work around newer compilers requiring the satisfaction of thr…
a3daeaf 
…ee-way comparison of EncodableValue. (flutter/flutter#170822)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
Roll Flutter from 8303a96 to 85a9b4f (93 revisions) (#9457)
0ec4053 
Roll Flutter from 8303a96 to 85a9b4f (93 revisions)

flutter/flutter@8303a96...85a9b4f

2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from af242598f14d to 794936b23812 (2 revisions) (flutter/flutter#170875)
2025-06-19 gourabkumarsi@google.com Drop support for 21/22 Lollipop (flutter/flutter#170748)
2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from 6020126c10e8 to bce9abe03175 (1 revision) (flutter/flutter#170872)
2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from df97f7f407db to af242598f14d (4 revisions) (flutter/flutter#170867)
2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from 1d8f7ebd23cc to df97f7f407db (5 revisions) (flutter/flutter#170864)
2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from 4ab716b09e9d to 6020126c10e8 (1 revision) (flutter/flutter#170862)
2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from 291d41414fa7 to 1d8f7ebd23cc (2 revisions) (flutter/flutter#170857)
2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from b32559bca3cc to 4ab716b09e9d (9 revisions) (flutter/flutter#170855)
2025-06-19 jessy.yameogo@gmail.com remove --start-paused flag by default and set useDwdsWebSocketConnect… (flutter/flutter#170612)
2025-06-18 matanlurey@users.noreply.github.com Engine builders no longer require `is_fusion` (flutter/flutter#170849)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 5f110d5f48a3 to 291d41414fa7 (2 revisions) (flutter/flutter#170836)
2025-06-18 robert.ancell@canonical.com Use a shared vertex buffer for rendering layers. (flutter/flutter#170717)
2025-06-18 30870216+gaaclarke@users.noreply.github.com fixes deeplinking in uiscenedelegate migrated projects (flutter/flutter#170452)
2025-06-18 jonahwilliams@google.com [Impeller] fix array uniforms on GLES backend. (flutter/flutter#170710)
2025-06-18 chinmaygarde@google.com [Impeller] Update README to add section about custom embedders. (flutter/flutter#170077)
2025-06-18 jason-simmons@users.noreply.github.com Escape the forbidden strings in the regex used to check test command output (flutter/flutter#170702)
2025-06-18 30870216+gaaclarke@users.noreply.github.com License cpp jun16 (flutter/flutter#170716)
2025-06-18 chinmaygarde@google.com Work around newer compilers requiring the satisfaction of three-way comparison of EncodableValue. (flutter/flutter#170822)
2025-06-18 45459898+RamonFarizel@users.noreply.github.com Update didUnmountRenderObject text description (flutter/flutter#169628)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 297dbc32a6c7 to 5f110d5f48a3 (2 revisions) (flutter/flutter#170821)
2025-06-18 matanlurey@users.noreply.github.com Add an initial "Using feature flags" doc for the team. (flutter/flutter#170767)
2025-06-18 34465683+rkishan516@users.noreply.github.com Feat: Add mouse cursor for CupertinoDialogAction (flutter/flutter#169051)
2025-06-18 matanlurey@users.noreply.github.com Update `Engine-artifacts.md` to reflect flutter/cocoon/4785 (flutter/flutter#170751)
2025-06-18 alex.medinsh@gmail.com `CupertinoPicker` new onChanged behaviour (flutter/flutter#170202)
2025-06-18 pateltirth454@gmail.com Rename `entryPointBaseUrl` to `entrypointBaseUrl` (flutter/flutter#170166)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 1cb13a21b547 to 297dbc32a6c7 (4 revisions) (flutter/flutter#170809)
2025-06-18 engine-flutter-autoroll@skia.org Roll Packages from 25d4fa4 to 715a0a5 (2 revisions) (flutter/flutter#170808)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 0a106c038cd0 to 1cb13a21b547 (1 revision) (flutter/flutter#170801)
2025-06-18 derekx@google.com Add `--profile-microtasks` switch (flutter/flutter#170690)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from ff7fffa5dac5 to 0a106c038cd0 (3 revisions) (flutter/flutter#170795)
2025-06-18 87239766+thakaredipali@users.noreply.github.com Add example for CupertinoExpansionTile transition modes (flutter/flutter#170335)
2025-06-18 stanleycocoa@gmail.com feat: Add radius to DividerThemeData. (flutter/flutter#169739)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 75af9450b121 to ff7fffa5dac5 (3 revisions) (flutter/flutter#170772)
2025-06-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "add run_gradle_lock_files_check.dart for new PR's that modify gradle files (#169245)" (flutter/flutter#170770)
2025-06-17 30870216+gaaclarke@users.noreply.github.com Started bridging the scene delegate to the lifecycle delegate for shortcuts (flutter/flutter#170180)
2025-06-17 jonahwilliams@google.com [ui] npot display_list allocation. (flutter/flutter#170447)
2025-06-17 kevmoo@users.noreply.github.com Prefer .of over .from (flutter/flutter#170750)
2025-06-17 47866232+chunhtai@users.noreply.github.com Fix RawGestureDetector semantics (flutter/flutter#170549)
2025-06-17 runar@socialscreen.no Use correct type for filterIdentifier (flutter/flutter#170343)
2025-06-17 matanlurey@users.noreply.github.com Remove and inline `license_header.txt` (flutter/flutter#170475)
2025-06-17 muhatashim@google.com add run_gradle_lock_files_check.dart for new PR's that modify gradle files (flutter/flutter#169245)
2025-06-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 4fad61257b29 to b32559bca3cc (3 revisions) (flutter/flutter#170746)
2025-06-17 kevinjchisholm@google.com [release] Sync stable changelog to master (flutter/flutter#170691)
2025-06-17 engine-flutter-autoroll@skia.org Roll Packages from 03a6abb to 25d4fa4 (5 revisions) (flutter/flutter#170743)
2025-06-17 bkonyi@google.com [ Widget Preview ] Remove support for synthetic package:flutter_gen (flutter/flutter#170602)
2025-06-17 engine-flutter-autoroll@skia.org Roll Skia from 8879db3b3319 to 75af9450b121 (4 revisions) (flutter/flutter#170739)
...
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Roll Flutter from 8303a96 to 85a9b4f (93 revisions) (flutter#9457)
6f669b7 
Roll Flutter from 8303a96 to 85a9b4f (93 revisions)

flutter/flutter@8303a96...85a9b4f

2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from af242598f14d to 794936b23812 (2 revisions) (flutter/flutter#170875)
2025-06-19 gourabkumarsi@google.com Drop support for 21/22 Lollipop (flutter/flutter#170748)
2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from 6020126c10e8 to bce9abe03175 (1 revision) (flutter/flutter#170872)
2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from df97f7f407db to af242598f14d (4 revisions) (flutter/flutter#170867)
2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from 1d8f7ebd23cc to df97f7f407db (5 revisions) (flutter/flutter#170864)
2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from 4ab716b09e9d to 6020126c10e8 (1 revision) (flutter/flutter#170862)
2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from 291d41414fa7 to 1d8f7ebd23cc (2 revisions) (flutter/flutter#170857)
2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from b32559bca3cc to 4ab716b09e9d (9 revisions) (flutter/flutter#170855)
2025-06-19 jessy.yameogo@gmail.com remove --start-paused flag by default and set useDwdsWebSocketConnect… (flutter/flutter#170612)
2025-06-18 matanlurey@users.noreply.github.com Engine builders no longer require `is_fusion` (flutter/flutter#170849)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 5f110d5f48a3 to 291d41414fa7 (2 revisions) (flutter/flutter#170836)
2025-06-18 robert.ancell@canonical.com Use a shared vertex buffer for rendering layers. (flutter/flutter#170717)
2025-06-18 30870216+gaaclarke@users.noreply.github.com fixes deeplinking in uiscenedelegate migrated projects (flutter/flutter#170452)
2025-06-18 jonahwilliams@google.com [Impeller] fix array uniforms on GLES backend. (flutter/flutter#170710)
2025-06-18 chinmaygarde@google.com [Impeller] Update README to add section about custom embedders. (flutter/flutter#170077)
2025-06-18 jason-simmons@users.noreply.github.com Escape the forbidden strings in the regex used to check test command output (flutter/flutter#170702)
2025-06-18 30870216+gaaclarke@users.noreply.github.com License cpp jun16 (flutter/flutter#170716)
2025-06-18 chinmaygarde@google.com Work around newer compilers requiring the satisfaction of three-way comparison of EncodableValue. (flutter/flutter#170822)
2025-06-18 45459898+RamonFarizel@users.noreply.github.com Update didUnmountRenderObject text description (flutter/flutter#169628)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 297dbc32a6c7 to 5f110d5f48a3 (2 revisions) (flutter/flutter#170821)
2025-06-18 matanlurey@users.noreply.github.com Add an initial "Using feature flags" doc for the team. (flutter/flutter#170767)
2025-06-18 34465683+rkishan516@users.noreply.github.com Feat: Add mouse cursor for CupertinoDialogAction (flutter/flutter#169051)
2025-06-18 matanlurey@users.noreply.github.com Update `Engine-artifacts.md` to reflect flutter/cocoon/4785 (flutter/flutter#170751)
2025-06-18 alex.medinsh@gmail.com `CupertinoPicker` new onChanged behaviour (flutter/flutter#170202)
2025-06-18 pateltirth454@gmail.com Rename `entryPointBaseUrl` to `entrypointBaseUrl` (flutter/flutter#170166)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 1cb13a21b547 to 297dbc32a6c7 (4 revisions) (flutter/flutter#170809)
2025-06-18 engine-flutter-autoroll@skia.org Roll Packages from 25d4fa4 to 715a0a5 (2 revisions) (flutter/flutter#170808)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 0a106c038cd0 to 1cb13a21b547 (1 revision) (flutter/flutter#170801)
2025-06-18 derekx@google.com Add `--profile-microtasks` switch (flutter/flutter#170690)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from ff7fffa5dac5 to 0a106c038cd0 (3 revisions) (flutter/flutter#170795)
2025-06-18 87239766+thakaredipali@users.noreply.github.com Add example for CupertinoExpansionTile transition modes (flutter/flutter#170335)
2025-06-18 stanleycocoa@gmail.com feat: Add radius to DividerThemeData. (flutter/flutter#169739)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 75af9450b121 to ff7fffa5dac5 (3 revisions) (flutter/flutter#170772)
2025-06-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "add run_gradle_lock_files_check.dart for new PR's that modify gradle files (#169245)" (flutter/flutter#170770)
2025-06-17 30870216+gaaclarke@users.noreply.github.com Started bridging the scene delegate to the lifecycle delegate for shortcuts (flutter/flutter#170180)
2025-06-17 jonahwilliams@google.com [ui] npot display_list allocation. (flutter/flutter#170447)
2025-06-17 kevmoo@users.noreply.github.com Prefer .of over .from (flutter/flutter#170750)
2025-06-17 47866232+chunhtai@users.noreply.github.com Fix RawGestureDetector semantics (flutter/flutter#170549)
2025-06-17 runar@socialscreen.no Use correct type for filterIdentifier (flutter/flutter#170343)
2025-06-17 matanlurey@users.noreply.github.com Remove and inline `license_header.txt` (flutter/flutter#170475)
2025-06-17 muhatashim@google.com add run_gradle_lock_files_check.dart for new PR's that modify gradle files (flutter/flutter#169245)
2025-06-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 4fad61257b29 to b32559bca3cc (3 revisions) (flutter/flutter#170746)
2025-06-17 kevinjchisholm@google.com [release] Sync stable changelog to master (flutter/flutter#170691)
2025-06-17 engine-flutter-autoroll@skia.org Roll Packages from 03a6abb to 25d4fa4 (5 revisions) (flutter/flutter#170743)
2025-06-17 bkonyi@google.com [ Widget Preview ] Remove support for synthetic package:flutter_gen (flutter/flutter#170602)
2025-06-17 engine-flutter-autoroll@skia.org Roll Skia from 8879db3b3319 to 75af9450b121 (4 revisions) (flutter/flutter#170739)
...
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
@chinmaygarde @mboetger
Work around newer compilers requiring the satisfaction of three-way c…
3ae26ea 
…omparison of EncodableValue. (flutter#170822)

Evolution of a previous blocker
flutter/engine#43091.
Fixes b/423885648
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
@engine-flutter-autoroll @vashworth
Roll Flutter from 8303a96 to 85a9b4f (93 revisions) (flutter#9457)
96611fa 
Roll Flutter from 8303a96 to 85a9b4f (93 revisions)

flutter/flutter@8303a96...85a9b4f

2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from af242598f14d to 794936b23812 (2 revisions) (flutter/flutter#170875)
2025-06-19 gourabkumarsi@google.com Drop support for 21/22 Lollipop (flutter/flutter#170748)
2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from 6020126c10e8 to bce9abe03175 (1 revision) (flutter/flutter#170872)
2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from df97f7f407db to af242598f14d (4 revisions) (flutter/flutter#170867)
2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from 1d8f7ebd23cc to df97f7f407db (5 revisions) (flutter/flutter#170864)
2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from 4ab716b09e9d to 6020126c10e8 (1 revision) (flutter/flutter#170862)
2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from 291d41414fa7 to 1d8f7ebd23cc (2 revisions) (flutter/flutter#170857)
2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from b32559bca3cc to 4ab716b09e9d (9 revisions) (flutter/flutter#170855)
2025-06-19 jessy.yameogo@gmail.com remove --start-paused flag by default and set useDwdsWebSocketConnect… (flutter/flutter#170612)
2025-06-18 matanlurey@users.noreply.github.com Engine builders no longer require `is_fusion` (flutter/flutter#170849)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 5f110d5f48a3 to 291d41414fa7 (2 revisions) (flutter/flutter#170836)
2025-06-18 robert.ancell@canonical.com Use a shared vertex buffer for rendering layers. (flutter/flutter#170717)
2025-06-18 30870216+gaaclarke@users.noreply.github.com fixes deeplinking in uiscenedelegate migrated projects (flutter/flutter#170452)
2025-06-18 jonahwilliams@google.com [Impeller] fix array uniforms on GLES backend. (flutter/flutter#170710)
2025-06-18 chinmaygarde@google.com [Impeller] Update README to add section about custom embedders. (flutter/flutter#170077)
2025-06-18 jason-simmons@users.noreply.github.com Escape the forbidden strings in the regex used to check test command output (flutter/flutter#170702)
2025-06-18 30870216+gaaclarke@users.noreply.github.com License cpp jun16 (flutter/flutter#170716)
2025-06-18 chinmaygarde@google.com Work around newer compilers requiring the satisfaction of three-way comparison of EncodableValue. (flutter/flutter#170822)
2025-06-18 45459898+RamonFarizel@users.noreply.github.com Update didUnmountRenderObject text description (flutter/flutter#169628)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 297dbc32a6c7 to 5f110d5f48a3 (2 revisions) (flutter/flutter#170821)
2025-06-18 matanlurey@users.noreply.github.com Add an initial "Using feature flags" doc for the team. (flutter/flutter#170767)
2025-06-18 34465683+rkishan516@users.noreply.github.com Feat: Add mouse cursor for CupertinoDialogAction (flutter/flutter#169051)
2025-06-18 matanlurey@users.noreply.github.com Update `Engine-artifacts.md` to reflect flutter/cocoon/4785 (flutter/flutter#170751)
2025-06-18 alex.medinsh@gmail.com `CupertinoPicker` new onChanged behaviour (flutter/flutter#170202)
2025-06-18 pateltirth454@gmail.com Rename `entryPointBaseUrl` to `entrypointBaseUrl` (flutter/flutter#170166)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 1cb13a21b547 to 297dbc32a6c7 (4 revisions) (flutter/flutter#170809)
2025-06-18 engine-flutter-autoroll@skia.org Roll Packages from 25d4fa4 to 715a0a5 (2 revisions) (flutter/flutter#170808)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 0a106c038cd0 to 1cb13a21b547 (1 revision) (flutter/flutter#170801)
2025-06-18 derekx@google.com Add `--profile-microtasks` switch (flutter/flutter#170690)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from ff7fffa5dac5 to 0a106c038cd0 (3 revisions) (flutter/flutter#170795)
2025-06-18 87239766+thakaredipali@users.noreply.github.com Add example for CupertinoExpansionTile transition modes (flutter/flutter#170335)
2025-06-18 stanleycocoa@gmail.com feat: Add radius to DividerThemeData. (flutter/flutter#169739)
2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 75af9450b121 to ff7fffa5dac5 (3 revisions) (flutter/flutter#170772)
2025-06-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "add run_gradle_lock_files_check.dart for new PR's that modify gradle files (#169245)" (flutter/flutter#170770)
2025-06-17 30870216+gaaclarke@users.noreply.github.com Started bridging the scene delegate to the lifecycle delegate for shortcuts (flutter/flutter#170180)
2025-06-17 jonahwilliams@google.com [ui] npot display_list allocation. (flutter/flutter#170447)
2025-06-17 kevmoo@users.noreply.github.com Prefer .of over .from (flutter/flutter#170750)
2025-06-17 47866232+chunhtai@users.noreply.github.com Fix RawGestureDetector semantics (flutter/flutter#170549)
2025-06-17 runar@socialscreen.no Use correct type for filterIdentifier (flutter/flutter#170343)
2025-06-17 matanlurey@users.noreply.github.com Remove and inline `license_header.txt` (flutter/flutter#170475)
2025-06-17 muhatashim@google.com add run_gradle_lock_files_check.dart for new PR's that modify gradle files (flutter/flutter#169245)
2025-06-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 4fad61257b29 to b32559bca3cc (3 revisions) (flutter/flutter#170746)
2025-06-17 kevinjchisholm@google.com [release] Sync stable changelog to master (flutter/flutter#170691)
2025-06-17 engine-flutter-autoroll@skia.org Roll Packages from 03a6abb to 25d4fa4 (5 revisions) (flutter/flutter#170743)
2025-06-17 bkonyi@google.com [ Widget Preview ] Remove support for synthetic package:flutter_gen (flutter/flutter#170602)
2025-06-17 engine-flutter-autoroll@skia.org Roll Skia from 8879db3b3319 to 75af9450b121 (4 revisions) (flutter/flutter#170739)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
9c3a133 Work around newer compilers requiring the satisfaction of thr…
90e2e88 
…ee-way comparison of EncodableValue. (flutter/flutter#170822)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
9c3a133 Work around newer compilers requiring the satisfaction of thr…
3de99d0 
…ee-way comparison of EncodableValue. (flutter/flutter#170822)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
9c3a133 Work around newer compilers requiring the satisfaction of thr…
611a52b 
…ee-way comparison of EncodableValue. (flutter/flutter#170822)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
9c3a133 Work around newer compilers requiring the satisfaction of thr…
fdfdba2 
…ee-way comparison of EncodableValue. (flutter/flutter#170822)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
9c3a133 Work around newer compilers requiring the satisfaction of thr…
3372f4d 
…ee-way comparison of EncodableValue. (flutter/flutter#170822)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@flar flar flar approved these changes

@chingjun chingjun Awaiting requested review from chingjun

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chinmaygarde @jtmcdole @flar @stuartmorgan-g