[ui] npot display_list allocation. #170447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flar
requested changes
Jun 13, 2025
Contributor
flar
left a comment
There was a problem hiding this comment.
Glaring hole on 32-bit sizes (should be rare, though, but we used 64-bit sizes in DL just in case).
Also, testing nits.
| EXPECT_NE(storage.base(), nullptr); | ||
| EXPECT_EQ(storage.size(), 10u); | ||
| EXPECT_EQ(storage.capacity(), DisplayListStorage::kDLPageSize); | ||
| EXPECT_EQ(storage.capacity(), 8192u); |
Contributor
There was a problem hiding this comment.
Why the change from the expected constant?
Also, should be at least one test that tries to verify that it will go from N to N*2 instead of N+PageSize? Perhaps a loop that keeps doing a simple DrawRect until the size is larger than some PoT multiple of page size and then another loop that keeps doing DrawRect until it changes again and verifies that it changes to NPOT?
Contributor
There was a problem hiding this comment.
Also NPOT is not external, but it would be nice to have some tests for it.
Contributor
Author
There was a problem hiding this comment.
I changed the logic so that we always set DlStoragePageSize as the min size and added testss.
| return (value & (value - 1)) == 0; | ||
| } | ||
|
|
||
| static uint32_t NextPowerOfTwoSize(uint32_t x) { |
Contributor
There was a problem hiding this comment.
Needs to be size_t and deal with up to 64-bits.
Contributor
There was a problem hiding this comment.
Is size_t 64-bits on all platforms? If not then it needs to declare size_t and then have an optional extra set of shifts and ors depending on the sizeof size_t.
Contributor
Author
There was a problem hiding this comment.
size_t I believe can be 32 bits on 32 bit platforms (though it can also be 64.). Updated the logic to support both with a constexpr sizeof check
flar
reviewed
Jun 13, 2025
| // Next greater multiple of DL_BUILDER_PAGE. | ||
| size_t new_size = (used_ + needed + kDLPageSize) & ~(kDLPageSize - 1); | ||
| // NPOT, with minimum size of kDLPageSize. | ||
| size_t new_size = NextPowerOfTwoSize(used_ + needed + kDLPageSize); |
Contributor
There was a problem hiding this comment.
Should we have overflow protection? Hmmm, if we get to 63/64 bits something should be hurting so maybe the realloc results will tip us off... They are FML_CHECK'd below.
chunhtai
pushed a commit
to chunhtai/flutter
that referenced
this pull request
Jun 17, 2025
Split off of flutter#168019 Worst case allocation performance for dl is fairly bad as we end up copying the data many more times than something like an STL vector would. At the cost of more memory usage, we can improve the case where the display list grows quite large.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 18, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 19, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 19, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 19, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 19, 2025
Roll Flutter from 8303a96 to 85a9b4f (93 revisions) flutter/flutter@8303a96...85a9b4f 2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from af242598f14d to 794936b23812 (2 revisions) (flutter/flutter#170875) 2025-06-19 gourabkumarsi@google.com Drop support for 21/22 Lollipop (flutter/flutter#170748) 2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from 6020126c10e8 to bce9abe03175 (1 revision) (flutter/flutter#170872) 2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from df97f7f407db to af242598f14d (4 revisions) (flutter/flutter#170867) 2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from 1d8f7ebd23cc to df97f7f407db (5 revisions) (flutter/flutter#170864) 2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from 4ab716b09e9d to 6020126c10e8 (1 revision) (flutter/flutter#170862) 2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from 291d41414fa7 to 1d8f7ebd23cc (2 revisions) (flutter/flutter#170857) 2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from b32559bca3cc to 4ab716b09e9d (9 revisions) (flutter/flutter#170855) 2025-06-19 jessy.yameogo@gmail.com remove --start-paused flag by default and set useDwdsWebSocketConnect… (flutter/flutter#170612) 2025-06-18 matanlurey@users.noreply.github.com Engine builders no longer require `is_fusion` (flutter/flutter#170849) 2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 5f110d5f48a3 to 291d41414fa7 (2 revisions) (flutter/flutter#170836) 2025-06-18 robert.ancell@canonical.com Use a shared vertex buffer for rendering layers. (flutter/flutter#170717) 2025-06-18 30870216+gaaclarke@users.noreply.github.com fixes deeplinking in uiscenedelegate migrated projects (flutter/flutter#170452) 2025-06-18 jonahwilliams@google.com [Impeller] fix array uniforms on GLES backend. (flutter/flutter#170710) 2025-06-18 chinmaygarde@google.com [Impeller] Update README to add section about custom embedders. (flutter/flutter#170077) 2025-06-18 jason-simmons@users.noreply.github.com Escape the forbidden strings in the regex used to check test command output (flutter/flutter#170702) 2025-06-18 30870216+gaaclarke@users.noreply.github.com License cpp jun16 (flutter/flutter#170716) 2025-06-18 chinmaygarde@google.com Work around newer compilers requiring the satisfaction of three-way comparison of EncodableValue. (flutter/flutter#170822) 2025-06-18 45459898+RamonFarizel@users.noreply.github.com Update didUnmountRenderObject text description (flutter/flutter#169628) 2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 297dbc32a6c7 to 5f110d5f48a3 (2 revisions) (flutter/flutter#170821) 2025-06-18 matanlurey@users.noreply.github.com Add an initial "Using feature flags" doc for the team. (flutter/flutter#170767) 2025-06-18 34465683+rkishan516@users.noreply.github.com Feat: Add mouse cursor for CupertinoDialogAction (flutter/flutter#169051) 2025-06-18 matanlurey@users.noreply.github.com Update `Engine-artifacts.md` to reflect flutter/cocoon/4785 (flutter/flutter#170751) 2025-06-18 alex.medinsh@gmail.com `CupertinoPicker` new onChanged behaviour (flutter/flutter#170202) 2025-06-18 pateltirth454@gmail.com Rename `entryPointBaseUrl` to `entrypointBaseUrl` (flutter/flutter#170166) 2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 1cb13a21b547 to 297dbc32a6c7 (4 revisions) (flutter/flutter#170809) 2025-06-18 engine-flutter-autoroll@skia.org Roll Packages from 25d4fa4 to 715a0a5 (2 revisions) (flutter/flutter#170808) 2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 0a106c038cd0 to 1cb13a21b547 (1 revision) (flutter/flutter#170801) 2025-06-18 derekx@google.com Add `--profile-microtasks` switch (flutter/flutter#170690) 2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from ff7fffa5dac5 to 0a106c038cd0 (3 revisions) (flutter/flutter#170795) 2025-06-18 87239766+thakaredipali@users.noreply.github.com Add example for CupertinoExpansionTile transition modes (flutter/flutter#170335) 2025-06-18 stanleycocoa@gmail.com feat: Add radius to DividerThemeData. (flutter/flutter#169739) 2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 75af9450b121 to ff7fffa5dac5 (3 revisions) (flutter/flutter#170772) 2025-06-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "add run_gradle_lock_files_check.dart for new PR's that modify gradle files (#169245)" (flutter/flutter#170770) 2025-06-17 30870216+gaaclarke@users.noreply.github.com Started bridging the scene delegate to the lifecycle delegate for shortcuts (flutter/flutter#170180) 2025-06-17 jonahwilliams@google.com [ui] npot display_list allocation. (flutter/flutter#170447) 2025-06-17 kevmoo@users.noreply.github.com Prefer .of over .from (flutter/flutter#170750) 2025-06-17 47866232+chunhtai@users.noreply.github.com Fix RawGestureDetector semantics (flutter/flutter#170549) 2025-06-17 runar@socialscreen.no Use correct type for filterIdentifier (flutter/flutter#170343) 2025-06-17 matanlurey@users.noreply.github.com Remove and inline `license_header.txt` (flutter/flutter#170475) 2025-06-17 muhatashim@google.com add run_gradle_lock_files_check.dart for new PR's that modify gradle files (flutter/flutter#169245) 2025-06-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 4fad61257b29 to b32559bca3cc (3 revisions) (flutter/flutter#170746) 2025-06-17 kevinjchisholm@google.com [release] Sync stable changelog to master (flutter/flutter#170691) 2025-06-17 engine-flutter-autoroll@skia.org Roll Packages from 03a6abb to 25d4fa4 (5 revisions) (flutter/flutter#170743) 2025-06-17 bkonyi@google.com [ Widget Preview ] Remove support for synthetic package:flutter_gen (flutter/flutter#170602) 2025-06-17 engine-flutter-autoroll@skia.org Roll Skia from 8879db3b3319 to 75af9450b121 (4 revisions) (flutter/flutter#170739) ...
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
Roll Flutter from 8303a96 to 85a9b4f (93 revisions) flutter/flutter@8303a96...85a9b4f 2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from af242598f14d to 794936b23812 (2 revisions) (flutter/flutter#170875) 2025-06-19 gourabkumarsi@google.com Drop support for 21/22 Lollipop (flutter/flutter#170748) 2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from 6020126c10e8 to bce9abe03175 (1 revision) (flutter/flutter#170872) 2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from df97f7f407db to af242598f14d (4 revisions) (flutter/flutter#170867) 2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from 1d8f7ebd23cc to df97f7f407db (5 revisions) (flutter/flutter#170864) 2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from 4ab716b09e9d to 6020126c10e8 (1 revision) (flutter/flutter#170862) 2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from 291d41414fa7 to 1d8f7ebd23cc (2 revisions) (flutter/flutter#170857) 2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from b32559bca3cc to 4ab716b09e9d (9 revisions) (flutter/flutter#170855) 2025-06-19 jessy.yameogo@gmail.com remove --start-paused flag by default and set useDwdsWebSocketConnect… (flutter/flutter#170612) 2025-06-18 matanlurey@users.noreply.github.com Engine builders no longer require `is_fusion` (flutter/flutter#170849) 2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 5f110d5f48a3 to 291d41414fa7 (2 revisions) (flutter/flutter#170836) 2025-06-18 robert.ancell@canonical.com Use a shared vertex buffer for rendering layers. (flutter/flutter#170717) 2025-06-18 30870216+gaaclarke@users.noreply.github.com fixes deeplinking in uiscenedelegate migrated projects (flutter/flutter#170452) 2025-06-18 jonahwilliams@google.com [Impeller] fix array uniforms on GLES backend. (flutter/flutter#170710) 2025-06-18 chinmaygarde@google.com [Impeller] Update README to add section about custom embedders. (flutter/flutter#170077) 2025-06-18 jason-simmons@users.noreply.github.com Escape the forbidden strings in the regex used to check test command output (flutter/flutter#170702) 2025-06-18 30870216+gaaclarke@users.noreply.github.com License cpp jun16 (flutter/flutter#170716) 2025-06-18 chinmaygarde@google.com Work around newer compilers requiring the satisfaction of three-way comparison of EncodableValue. (flutter/flutter#170822) 2025-06-18 45459898+RamonFarizel@users.noreply.github.com Update didUnmountRenderObject text description (flutter/flutter#169628) 2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 297dbc32a6c7 to 5f110d5f48a3 (2 revisions) (flutter/flutter#170821) 2025-06-18 matanlurey@users.noreply.github.com Add an initial "Using feature flags" doc for the team. (flutter/flutter#170767) 2025-06-18 34465683+rkishan516@users.noreply.github.com Feat: Add mouse cursor for CupertinoDialogAction (flutter/flutter#169051) 2025-06-18 matanlurey@users.noreply.github.com Update `Engine-artifacts.md` to reflect flutter/cocoon/4785 (flutter/flutter#170751) 2025-06-18 alex.medinsh@gmail.com `CupertinoPicker` new onChanged behaviour (flutter/flutter#170202) 2025-06-18 pateltirth454@gmail.com Rename `entryPointBaseUrl` to `entrypointBaseUrl` (flutter/flutter#170166) 2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 1cb13a21b547 to 297dbc32a6c7 (4 revisions) (flutter/flutter#170809) 2025-06-18 engine-flutter-autoroll@skia.org Roll Packages from 25d4fa4 to 715a0a5 (2 revisions) (flutter/flutter#170808) 2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 0a106c038cd0 to 1cb13a21b547 (1 revision) (flutter/flutter#170801) 2025-06-18 derekx@google.com Add `--profile-microtasks` switch (flutter/flutter#170690) 2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from ff7fffa5dac5 to 0a106c038cd0 (3 revisions) (flutter/flutter#170795) 2025-06-18 87239766+thakaredipali@users.noreply.github.com Add example for CupertinoExpansionTile transition modes (flutter/flutter#170335) 2025-06-18 stanleycocoa@gmail.com feat: Add radius to DividerThemeData. (flutter/flutter#169739) 2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 75af9450b121 to ff7fffa5dac5 (3 revisions) (flutter/flutter#170772) 2025-06-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "add run_gradle_lock_files_check.dart for new PR's that modify gradle files (#169245)" (flutter/flutter#170770) 2025-06-17 30870216+gaaclarke@users.noreply.github.com Started bridging the scene delegate to the lifecycle delegate for shortcuts (flutter/flutter#170180) 2025-06-17 jonahwilliams@google.com [ui] npot display_list allocation. (flutter/flutter#170447) 2025-06-17 kevmoo@users.noreply.github.com Prefer .of over .from (flutter/flutter#170750) 2025-06-17 47866232+chunhtai@users.noreply.github.com Fix RawGestureDetector semantics (flutter/flutter#170549) 2025-06-17 runar@socialscreen.no Use correct type for filterIdentifier (flutter/flutter#170343) 2025-06-17 matanlurey@users.noreply.github.com Remove and inline `license_header.txt` (flutter/flutter#170475) 2025-06-17 muhatashim@google.com add run_gradle_lock_files_check.dart for new PR's that modify gradle files (flutter/flutter#169245) 2025-06-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 4fad61257b29 to b32559bca3cc (3 revisions) (flutter/flutter#170746) 2025-06-17 kevinjchisholm@google.com [release] Sync stable changelog to master (flutter/flutter#170691) 2025-06-17 engine-flutter-autoroll@skia.org Roll Packages from 03a6abb to 25d4fa4 (5 revisions) (flutter/flutter#170743) 2025-06-17 bkonyi@google.com [ Widget Preview ] Remove support for synthetic package:flutter_gen (flutter/flutter#170602) 2025-06-17 engine-flutter-autoroll@skia.org Roll Skia from 8879db3b3319 to 75af9450b121 (4 revisions) (flutter/flutter#170739) ...
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
Split off of flutter#168019 Worst case allocation performance for dl is fairly bad as we end up copying the data many more times than something like an STL vector would. At the cost of more memory usage, we can improve the case where the display list grows quite large.
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
Roll Flutter from 8303a96 to 85a9b4f (93 revisions) flutter/flutter@8303a96...85a9b4f 2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from af242598f14d to 794936b23812 (2 revisions) (flutter/flutter#170875) 2025-06-19 gourabkumarsi@google.com Drop support for 21/22 Lollipop (flutter/flutter#170748) 2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from 6020126c10e8 to bce9abe03175 (1 revision) (flutter/flutter#170872) 2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from df97f7f407db to af242598f14d (4 revisions) (flutter/flutter#170867) 2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from 1d8f7ebd23cc to df97f7f407db (5 revisions) (flutter/flutter#170864) 2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from 4ab716b09e9d to 6020126c10e8 (1 revision) (flutter/flutter#170862) 2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from 291d41414fa7 to 1d8f7ebd23cc (2 revisions) (flutter/flutter#170857) 2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from b32559bca3cc to 4ab716b09e9d (9 revisions) (flutter/flutter#170855) 2025-06-19 jessy.yameogo@gmail.com remove --start-paused flag by default and set useDwdsWebSocketConnect… (flutter/flutter#170612) 2025-06-18 matanlurey@users.noreply.github.com Engine builders no longer require `is_fusion` (flutter/flutter#170849) 2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 5f110d5f48a3 to 291d41414fa7 (2 revisions) (flutter/flutter#170836) 2025-06-18 robert.ancell@canonical.com Use a shared vertex buffer for rendering layers. (flutter/flutter#170717) 2025-06-18 30870216+gaaclarke@users.noreply.github.com fixes deeplinking in uiscenedelegate migrated projects (flutter/flutter#170452) 2025-06-18 jonahwilliams@google.com [Impeller] fix array uniforms on GLES backend. (flutter/flutter#170710) 2025-06-18 chinmaygarde@google.com [Impeller] Update README to add section about custom embedders. (flutter/flutter#170077) 2025-06-18 jason-simmons@users.noreply.github.com Escape the forbidden strings in the regex used to check test command output (flutter/flutter#170702) 2025-06-18 30870216+gaaclarke@users.noreply.github.com License cpp jun16 (flutter/flutter#170716) 2025-06-18 chinmaygarde@google.com Work around newer compilers requiring the satisfaction of three-way comparison of EncodableValue. (flutter/flutter#170822) 2025-06-18 45459898+RamonFarizel@users.noreply.github.com Update didUnmountRenderObject text description (flutter/flutter#169628) 2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 297dbc32a6c7 to 5f110d5f48a3 (2 revisions) (flutter/flutter#170821) 2025-06-18 matanlurey@users.noreply.github.com Add an initial "Using feature flags" doc for the team. (flutter/flutter#170767) 2025-06-18 34465683+rkishan516@users.noreply.github.com Feat: Add mouse cursor for CupertinoDialogAction (flutter/flutter#169051) 2025-06-18 matanlurey@users.noreply.github.com Update `Engine-artifacts.md` to reflect flutter/cocoon/4785 (flutter/flutter#170751) 2025-06-18 alex.medinsh@gmail.com `CupertinoPicker` new onChanged behaviour (flutter/flutter#170202) 2025-06-18 pateltirth454@gmail.com Rename `entryPointBaseUrl` to `entrypointBaseUrl` (flutter/flutter#170166) 2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 1cb13a21b547 to 297dbc32a6c7 (4 revisions) (flutter/flutter#170809) 2025-06-18 engine-flutter-autoroll@skia.org Roll Packages from 25d4fa4 to 715a0a5 (2 revisions) (flutter/flutter#170808) 2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 0a106c038cd0 to 1cb13a21b547 (1 revision) (flutter/flutter#170801) 2025-06-18 derekx@google.com Add `--profile-microtasks` switch (flutter/flutter#170690) 2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from ff7fffa5dac5 to 0a106c038cd0 (3 revisions) (flutter/flutter#170795) 2025-06-18 87239766+thakaredipali@users.noreply.github.com Add example for CupertinoExpansionTile transition modes (flutter/flutter#170335) 2025-06-18 stanleycocoa@gmail.com feat: Add radius to DividerThemeData. (flutter/flutter#169739) 2025-06-18 engine-flutter-autoroll@skia.org Roll Skia from 75af9450b121 to ff7fffa5dac5 (3 revisions) (flutter/flutter#170772) 2025-06-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "add run_gradle_lock_files_check.dart for new PR's that modify gradle files (#169245)" (flutter/flutter#170770) 2025-06-17 30870216+gaaclarke@users.noreply.github.com Started bridging the scene delegate to the lifecycle delegate for shortcuts (flutter/flutter#170180) 2025-06-17 jonahwilliams@google.com [ui] npot display_list allocation. (flutter/flutter#170447) 2025-06-17 kevmoo@users.noreply.github.com Prefer .of over .from (flutter/flutter#170750) 2025-06-17 47866232+chunhtai@users.noreply.github.com Fix RawGestureDetector semantics (flutter/flutter#170549) 2025-06-17 runar@socialscreen.no Use correct type for filterIdentifier (flutter/flutter#170343) 2025-06-17 matanlurey@users.noreply.github.com Remove and inline `license_header.txt` (flutter/flutter#170475) 2025-06-17 muhatashim@google.com add run_gradle_lock_files_check.dart for new PR's that modify gradle files (flutter/flutter#169245) 2025-06-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 4fad61257b29 to b32559bca3cc (3 revisions) (flutter/flutter#170746) 2025-06-17 kevinjchisholm@google.com [release] Sync stable changelog to master (flutter/flutter#170691) 2025-06-17 engine-flutter-autoroll@skia.org Roll Packages from 03a6abb to 25d4fa4 (5 revisions) (flutter/flutter#170743) 2025-06-17 bkonyi@google.com [ Widget Preview ] Remove support for synthetic package:flutter_gen (flutter/flutter#170602) 2025-06-17 engine-flutter-autoroll@skia.org Roll Skia from 8879db3b3319 to 75af9450b121 (4 revisions) (flutter/flutter#170739) ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off of #168019
Worst case allocation performance for dl is fairly bad as we end up copying the data many more times than something like an STL vector would. At the cost of more memory usage, we can improve the case where the display list grows quite large.