Skip to content

[web] Pass the same JS flags to both stages of the compiler #169730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 5 commits into from
May 31, 2025
Merged

[web] Pass the same JS flags to both stages of the compiler #169730

auto-submit merged 5 commits into from
May 31, 2025
+191 −275

Conversation

@kevmoo
Copy link
Contributor

@kevmoo kevmoo commented May 30, 2025 •
edited
Loading

Fixes #169714

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 30, 2025
@kevmoo kevmoo requested a review from mdebbar May 30, 2025 04:03
@kevmoo kevmoo mentioned this pull request May 30, 2025
Closed
fishythefish
fishythefish reviewed May 30, 2025
View reviewed changes
Copy link
Contributor

@fishythefish fishythefish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevmoo kevmoo changed the title same flags js compiler [web] Pass the same JS flags to both stages of the compiler May 30, 2025
@kevmoo
Copy link
Contributor Author

kevmoo commented May 30, 2025

FYI: confirmed there were no changes in JS output. Which means there were no BAD changes. At least for the app I checked.

eyebrowsoffire
eyebrowsoffire approved these changes May 30, 2025
View reviewed changes
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 31, 2025
Merged via the queue into master with commit bcfb871 May 31, 2025
147 checks passed
@auto-submit auto-submit bot deleted the same_flags_js_compiler branch May 31, 2025 00:51
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 31, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
fd7bc3e 
…lutter/flutter#169730)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
e933c18 
…lutter/flutter#169730)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
87c1853 
…lutter/flutter#169730)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
2296b65 
…lutter/flutter#169730)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
17c3ebb 
…lutter/flutter#169730)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
2dea9be 
…lutter/flutter#169730)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
eab93d1 
…lutter/flutter#169730)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
5ac3e1d 
…lutter/flutter#169730)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
12d24f8 
…lutter/flutter#169730)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
bddfee1 
…lutter/flutter#169730)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
38e5fe3 
…lutter/flutter#169730)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
28b8893 
…lutter/flutter#169730)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
bfc7f43 
…lutter/flutter#169730)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
315d0a8 
…lutter/flutter#169730)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
0cc2dee 
…lutter/flutter#169730)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
3c47a2c 
…lutter/flutter#169730)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
34ebd33 
…lutter/flutter#169730)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
581c263 
…lutter/flutter#169730)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
23e328f 
…lutter/flutter#169730)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
fd292c6 
…lutter/flutter#169730)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
6086384 
…lutter/flutter#169730)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
8329e3f 
…lutter/flutter#169730)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
2bad3e7 
…lutter/flutter#169730)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
b95009a 
…lutter/flutter#169730)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
6ffb757 
…lutter/flutter#169730)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
d152c03 
…lutter/flutter#169730)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
3ba6bd4 
…lutter/flutter#169730)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
f385ed9 
…lutter/flutter#169730)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
02ac158 
…lutter/flutter#169730)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
c5c5045 
…lutter/flutter#169730)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
f688271 
…lutter/flutter#169730)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
bcfb871 [web] Pass the same JS flags to both stages of the compiler (f…
aa0d0c7 
…lutter/flutter#169730)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fishythefish fishythefish fishythefish left review comments

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

@mdebbar mdebbar Awaiting requested review from mdebbar

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dart2js flags are unnecessarily split up

3 participants

@kevmoo @fishythefish @eyebrowsoffire