dart2js flags are unnecessarily split up

See prior discussion at https://github.com/flutter/flutter/issues/134423.

Some arguments to dart2js are specified here:

https://github.com/flutter/flutter/blob/42ecb869981c1ac3a6e1f6e963bacd564e4f7660/packages/flutter_tools/lib/src/web/compiler_config.dart#L95-L101

And some are specified here:

https://github.com/flutter/flutter/blob/42ecb869981c1ac3a6e1f6e963bacd564e4f7660/packages/flutter_tools/lib/src/web/compiler_config.dart#L114-L124

This is error-prone as dart2js generally assumes its flags to be consistent across a sequential compilation (with the exception of flags like `--stage` which actually govern how the compilation is split up).

	/// Arguments to use in both phases: full JS compile and CFE-only.
	List<String> toSharedCommandOptions(BuildMode buildMode) => <String>[
	if (nativeNullAssertions) '--native-null-assertions',
	if (!sourceMaps) '--no-source-maps',
	if (buildMode == BuildMode.debug) '--enable-asserts',
	'-O${optimizationLevelForBuildMode(buildMode)}',
	];

	/// Arguments to use in the full JS compile, but not CFE-only.
	///
	/// Includes the contents of [toSharedCommandOptions].
	@override
	List<String> toCommandOptions(BuildMode buildMode) => <String>[
	if (minify ?? buildMode == BuildMode.release) '--minify' else '--no-minify',
	...toSharedCommandOptions(buildMode),
	if (dumpInfo) '--stage=dump-info-all',
	if (noFrequencyBasedMinification) '--no-frequency-based-minification',
	if (csp) '--csp',
	];

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

dart2js flags are unnecessarily split up #169714

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

dart2js flags are unnecessarily split up #169714

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions