Set pause_isolates_on_start flag if --start-paused #169392

srujzs · 2025-05-23T20:58:35Z

This enables breakpoint management for hot restart and hot reload. --start-paused is passed by VS code.

Also fixes a small issue where we're not passing the isolate ID when hot reloading. It doesn't matter what we pass as there's only one isolate, but we should keep consistent and use the isolate ID that already exists.

dart-lang/sdk#60186

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

This enables breakpoint management for hot restart and hot reload. --start-paused is passed by VS code. Also fixes a small issue where we're not passing the isolate ID when hot reloading. It doesn't matter what we pass as there's only one isolate, but we should keep consistent and use the isolate ID that already exists.

flutter-dashboard · 2025-05-23T20:58:38Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

nshahan

Changes looks reasonable to me but your description mentions that vscode will pass --start-paused. I'm hoping that intellij does as well?

srujzs · 2025-05-24T00:20:05Z

I'm not really sure where the IntelliJ code lives unfortunately, but it would need to in order to make breakpoints and such work.

packages/flutter_tools/lib/src/vmservice.dart

packages/flutter_tools/lib/src/isolated/resident_web_runner.dart

packages/flutter_tools/test/general.shard/resident_web_runner_test.dart

…lutter#169392)

flutter/flutter@4372bfb...0e536eb 2025-05-28 30870216+gaaclarke@users.noreply.github.com Introduces FlutterPluginRegistrant protocol. (flutter/flutter#169399) 2025-05-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Initialize `default-flavor` in `FlutterCommand`, adds integration test. (#169298)" (flutter/flutter#169581) 2025-05-28 matanlurey@users.noreply.github.com Initialize `default-flavor` in `FlutterCommand`, adds integration test. (flutter/flutter#169298) 2025-05-28 jakemac@google.com Update DEPS to add dart-lang/ai repo (flutter/flutter#169540) 2025-05-28 engine-flutter-autoroll@skia.org Roll Skia from 92311f2ba0b7 to 82d326fc2148 (1 revision) (flutter/flutter#169552) 2025-05-28 kevmoo@users.noreply.github.com dev/bots: improve service worker test code (flutter/flutter#169231) 2025-05-28 magder@google.com Make Android team platform view TESTOWNERS (flutter/flutter#169297) 2025-05-28 engine-flutter-autoroll@skia.org Roll Skia from 044f58f78a73 to 92311f2ba0b7 (9 revisions) (flutter/flutter#169542) 2025-05-27 engine-flutter-autoroll@skia.org Roll Skia from 443f5257f382 to 044f58f78a73 (16 revisions) (flutter/flutter#169530) 2025-05-27 sokolovskyi.konstantin@gmail.com [web] Fix unresponsive input above SelectionArea in Safari and Firefox. (flutter/flutter#167275) 2025-05-27 58529443+srujzs@users.noreply.github.com Set pause_isolates_on_start flag if --start-paused (flutter/flutter#169392) 2025-05-27 engine-flutter-autoroll@skia.org Roll Packages from af0b9a9 to 6eebe72 (24 revisions) (flutter/flutter#169514) 2025-05-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 5mpmPsuD8rpeiJizT... to nC9hLWjYVlChDTEPh... (flutter/flutter#169498) 2025-05-27 zhongliu88889@gmail.com Split hint from label and expose it via aria-description or aria-describedby (flutter/flutter#169157) 2025-05-26 github@alexv525.com 🐛 Normalize generated file paths for the l10n generator (flutter/flutter#169467) 2025-05-26 engine-flutter-autoroll@skia.org Roll Dart SDK from d811152316e4 to 6aeb798bdbe2 (2 revisions) (flutter/flutter#169478) 2025-05-26 dkwingsmt@users.noreply.github.com [Cupertino] Apply RSuperellipse to most Cupertino widgets (flutter/flutter#167784) 2025-05-26 bkonyi@google.com Roll `package:dds` to 5.0.2 (flutter/flutter#169471) 2025-05-26 matanlurey@users.noreply.github.com Use `.flutter-plugins-dependencies` for crash reporting. (flutter/flutter#169319) 2025-05-26 matanlurey@users.noreply.github.com Remove now disabled code that would generate `.flutter-plugins`. (flutter/flutter#169320) 2025-05-26 engine-flutter-autoroll@skia.org Roll Dart SDK from 7dab9bffe1f7 to d811152316e4 (1 revision) (flutter/flutter#169473) 2025-05-26 munsocket@protonmail.com Precise browser resizing with integration_test and driver (flutter/flutter#160678) 2025-05-26 matanlurey@users.noreply.github.com Add `/coverage/` to `.gitignore.tmp` (flutter/flutter#169387) 2025-05-26 matanlurey@users.noreply.github.com Make test output with encoded `dart-defines=...` human readable. (flutter/flutter#169353) 2025-05-26 matanlurey@users.noreply.github.com Use at most `PROC~/2` tasks to transform assets. (flutter/flutter#169386) 2025-05-26 32538273+ValentinVignal@users.noreply.github.com Forward exit code from dart test to flutter test (flutter/flutter#168604) 2025-05-26 51940183+Sameri11@users.noreply.github.com Fix warning when building for macOS desktop (flutter/flutter#165996) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#169392)

srujzs requested review from bkonyi and nshahan May 23, 2025 20:58

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 23, 2025

nshahan approved these changes May 23, 2025

View reviewed changes

Fix expectations for tests and treat isolate id as nullable

5badf25

bkonyi reviewed May 26, 2025

View reviewed changes

Address review comments

e04d31b

srujzs added the autosubmit Merge PR when tree becomes green via auto submit App label May 27, 2025

auto-submit bot added this pull request to the merge queue May 27, 2025

Merged via the queue into flutter:master with commit 9737016 May 27, 2025
142 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 27, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2025

9737016 Set pause_isolates_on_start flag if --start-paused (flutter/f…

4c8ed05

…lutter#169392)

This was referenced May 27, 2025

Roll Flutter from 4372bfbc6c23 to 973701688c46 (17 revisions) flutter/packages#9327

Closed

Roll Flutter from 4372bfbc6c23 to 5d013c73baa7 (26 revisions) flutter/packages#9333

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2025

9737016 Set pause_isolates_on_start flag if --start-paused (flutter/f…

d8b153d

…lutter#169392)

engine-flutter-autoroll mentioned this pull request May 28, 2025

Roll Flutter from 4372bfbc6c23 to 0e536eb9fe4b (27 revisions) flutter/packages#9334

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2025

9737016 Set pause_isolates_on_start flag if --start-paused (flutter/f…

0a48a46

…lutter#169392)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

9737016 Set pause_isolates_on_start flag if --start-paused (flutter/f…

bae7ba1

…lutter#169392)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

9737016 Set pause_isolates_on_start flag if --start-paused (flutter/f…

30b2f0e

…lutter#169392)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

9737016 Set pause_isolates_on_start flag if --start-paused (flutter/f…

c4cd2de

…lutter#169392)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

9737016 Set pause_isolates_on_start flag if --start-paused (flutter/f…

d54ef9f

…lutter#169392)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

9737016 Set pause_isolates_on_start flag if --start-paused (flutter/f…

e2b40be

…lutter#169392)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Set pause_isolates_on_start flag if --start-paused #169392

Set pause_isolates_on_start flag if --start-paused #169392

Uh oh!

srujzs commented May 23, 2025 •

edited

Loading

Uh oh!

flutter-dashboard bot commented May 23, 2025

Uh oh!

nshahan left a comment

Uh oh!

srujzs commented May 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Set pause_isolates_on_start flag if --start-paused #169392

Set pause_isolates_on_start flag if --start-paused #169392

Uh oh!

Conversation

srujzs commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented May 23, 2025

Uh oh!

nshahan left a comment

Choose a reason for hiding this comment

Uh oh!

srujzs commented May 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

srujzs commented May 23, 2025 •

edited

Loading