Precise browser resizing with integration_test and driver #160678

munrocket · 2024-12-20T19:19:07Z

Fixes #136109 P2
Related #148028 P1

Roadmap:

find why not working (described in Flutter drive --browser-dimension not working #136109)
create new API with backward compatibility (--browser-dimension=393×852@3)
fix edge cases
internal testing
add documentation (flutter drive -h)

This PR:

Fixes Chrome bug from dart side
Adds pixelRatio mobile emulation in web
Adds new notation: 393,852 -> 393×852[@1]
Leaves previous behavior as it was, so 393,852 will give wrong size until Chrome will fix it. But you can use 393×852@1.

flutter-dashboard · 2024-12-23T11:53:08Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

munrocket · 2024-12-23T12:44:50Z

This PR is ready for review. Analyze broken because tree is red.

jmagman · 2024-12-26T19:20:06Z

The analysis error is

 Found 1 Dart file which was formatted incorrectly.
 To fix, run `dart format packages/flutter_tools/lib/src/drive/web_driver_service.dart` or:
 git apply <<DONE
 diff --git a/packages/flutter_tools/lib/src/drive/web_driver_service.dart b/packages/flutter_tools/lib/src/drive/web_driver_service.dart
 index 02cbe7a84e..0000000000 100644
 --- a/packages/flutter_tools/lib/src/drive/web_driver_service.dart
 +++ b/packages/flutter_tools/lib/src/drive/web_driver_service.dart
 @@ -178,7 +178,8 @@ class WebDriverService extends DriverService {
                'height': height,
                'pixelRatio': double.parse(browserDimension[2]),
              },
 -            'userAgent': 'Mozilla/5.0 (Linux; Android 15) AppleWebKit/537.36 '
 +            'userAgent':
 +                'Mozilla/5.0 (Linux; Android 15) AppleWebKit/537.36 '
                  '(KHTML, like Gecko) Chrome/131.0.6778.200 Mobile Safari/537.36',
            };
          }
 @@ -382,3 +383,4 @@ Map<String, dynamic> getDesiredCapabilities(
      },
    },
  };
 DONE

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8727677075114199649/+/u/run_test.dart_for_analyze_shard_and_subshard_None/stdout

flutter-dashboard · 2024-12-27T09:36:13Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #160678 at sha bdbf90d

munrocket · 2024-12-27T10:14:24Z

@jmagman thanks for answer, I have little progress.

fixed format
linux android stderr: Screenshot not supported for Linux. miraculously fixed after rebase
mac native_ui The Swift Package Manager feature is off. maybe will be fixed in same way.

It’s not obvious how to find proper build, because there are no link from github and searching by PR/hash is off, only by test name.

flutter-dashboard · 2024-12-27T12:14:14Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #160678 at sha 47f3e0c

munrocket · 2024-12-27T13:00:32Z

It was not easy, but CI passed. Ready for review.

jmagman · 2024-12-27T20:07:35Z

It was not easy, but CI passed. Ready for review.

Thank you for figuring it all out! We're a bit slower to review around the end of the year due to holidays, the web or tool team will take a look during their regularly scheduled triage.
cc @yjbanov

packages/flutter_tools/lib/src/drive/web_driver_service.dart

packages/flutter_tools/lib/src/commands/drive.dart

bkonyi · 2025-01-16T21:08:22Z

Hi @munrocket, just checking in. Do you have plans to pick this PR back up?

mdebbar · 2025-04-29T16:24:45Z

Looks good to me, thanks for the contribution!

I hit "Update branch" to bring the PR up to date. Let's see if CI is happy or not.

mdebbar · 2025-04-29T18:03:03Z

I think we need a 2nd review to land this PR. @bkonyi do you wanna take a look?

bkonyi

Sorry for the delay on this. LGTM.

@1

…0678) Fixes flutter#136109 P2 Related flutter#148028 P1 Roadmap: - [x] find why not working (described in flutter#136109) - [x] create new API with backward compatibility (`--browser-dimension=393×852@3`) - [x] fix edge cases - [x] internal testing - [x] add documentation (flutter drive -h) This PR: - Fixes Chrome bug from dart side - Adds pixelRatio mobile emulation in web - Adds new notation: 393,852 -> 393×852[@1] - Leaves previous behavior as it was, so 393,852 will give wrong size until Chrome will fix it. But you can use 393×852@1. --------- Co-authored-by: Mouad Debbar <mdebbar@google.com>

…utter/flutter#160678)

flutter/flutter@4372bfb...0e536eb 2025-05-28 30870216+gaaclarke@users.noreply.github.com Introduces FlutterPluginRegistrant protocol. (flutter/flutter#169399) 2025-05-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Initialize `default-flavor` in `FlutterCommand`, adds integration test. (#169298)" (flutter/flutter#169581) 2025-05-28 matanlurey@users.noreply.github.com Initialize `default-flavor` in `FlutterCommand`, adds integration test. (flutter/flutter#169298) 2025-05-28 jakemac@google.com Update DEPS to add dart-lang/ai repo (flutter/flutter#169540) 2025-05-28 engine-flutter-autoroll@skia.org Roll Skia from 92311f2ba0b7 to 82d326fc2148 (1 revision) (flutter/flutter#169552) 2025-05-28 kevmoo@users.noreply.github.com dev/bots: improve service worker test code (flutter/flutter#169231) 2025-05-28 magder@google.com Make Android team platform view TESTOWNERS (flutter/flutter#169297) 2025-05-28 engine-flutter-autoroll@skia.org Roll Skia from 044f58f78a73 to 92311f2ba0b7 (9 revisions) (flutter/flutter#169542) 2025-05-27 engine-flutter-autoroll@skia.org Roll Skia from 443f5257f382 to 044f58f78a73 (16 revisions) (flutter/flutter#169530) 2025-05-27 sokolovskyi.konstantin@gmail.com [web] Fix unresponsive input above SelectionArea in Safari and Firefox. (flutter/flutter#167275) 2025-05-27 58529443+srujzs@users.noreply.github.com Set pause_isolates_on_start flag if --start-paused (flutter/flutter#169392) 2025-05-27 engine-flutter-autoroll@skia.org Roll Packages from af0b9a9 to 6eebe72 (24 revisions) (flutter/flutter#169514) 2025-05-27 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 5mpmPsuD8rpeiJizT... to nC9hLWjYVlChDTEPh... (flutter/flutter#169498) 2025-05-27 zhongliu88889@gmail.com Split hint from label and expose it via aria-description or aria-describedby (flutter/flutter#169157) 2025-05-26 github@alexv525.com 🐛 Normalize generated file paths for the l10n generator (flutter/flutter#169467) 2025-05-26 engine-flutter-autoroll@skia.org Roll Dart SDK from d811152316e4 to 6aeb798bdbe2 (2 revisions) (flutter/flutter#169478) 2025-05-26 dkwingsmt@users.noreply.github.com [Cupertino] Apply RSuperellipse to most Cupertino widgets (flutter/flutter#167784) 2025-05-26 bkonyi@google.com Roll `package:dds` to 5.0.2 (flutter/flutter#169471) 2025-05-26 matanlurey@users.noreply.github.com Use `.flutter-plugins-dependencies` for crash reporting. (flutter/flutter#169319) 2025-05-26 matanlurey@users.noreply.github.com Remove now disabled code that would generate `.flutter-plugins`. (flutter/flutter#169320) 2025-05-26 engine-flutter-autoroll@skia.org Roll Dart SDK from 7dab9bffe1f7 to d811152316e4 (1 revision) (flutter/flutter#169473) 2025-05-26 munsocket@protonmail.com Precise browser resizing with integration_test and driver (flutter/flutter#160678) 2025-05-26 matanlurey@users.noreply.github.com Add `/coverage/` to `.gitignore.tmp` (flutter/flutter#169387) 2025-05-26 matanlurey@users.noreply.github.com Make test output with encoded `dart-defines=...` human readable. (flutter/flutter#169353) 2025-05-26 matanlurey@users.noreply.github.com Use at most `PROC~/2` tasks to transform assets. (flutter/flutter#169386) 2025-05-26 32538273+ValentinVignal@users.noreply.github.com Forward exit code from dart test to flutter test (flutter/flutter#168604) 2025-05-26 51940183+Sameri11@users.noreply.github.com Fix warning when building for macOS desktop (flutter/flutter#165996) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…utter/flutter#160678)

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 20, 2024

munrocket mentioned this pull request Dec 20, 2024

[Feature] How to use setMobileEmulation for correct window resize google/webdriver.dart#310

Closed

Precise browser resizing with integration_test and driver

9c5d0dd

munrocket force-pushed the master branch from 4501e57 to 9c5d0dd Compare December 22, 2024 10:08

munrocket mentioned this pull request Dec 22, 2024

Flutter drive --browser-dimension not working #136109

Closed

2 tasks

munrocket marked this pull request as ready for review December 22, 2024 10:51

munrocket added 2 commits December 22, 2024 19:42

Trigger luci

0af4065

Trigger LUCI

c1747c7

munrocket mentioned this pull request Dec 23, 2024

[infra] LUCI gives Mac flakiness, unreadable logs and wrong analyze result #160784

Closed

munrocket added 2 commits December 24, 2024 10:47

Trigger luci

6aaff16

Merge branch 'flutter:master' into master

26261d7

munrocket added 3 commits December 27, 2024 01:04

format

c91344f

Trigger luci

170363b

Merge branch 'master' into master

bdbf90d

flutter-dashboard bot added the will affect goldens Changes to golden files label Dec 27, 2024

Another attempt, who knows.

26904ba

almassolarenrgi mentioned this pull request Dec 27, 2024

Fixes #136109 P2 almassolarenrgi/almassolarenrgi#15

Open

5 tasks

.

47f3e0c

bkonyi requested review from bkonyi and yjbanov January 9, 2025 21:10

yjbanov reviewed Jan 9, 2025

View reviewed changes

packages/flutter_tools/lib/src/drive/web_driver_service.dart Show resolved Hide resolved

packages/flutter_tools/lib/src/commands/drive.dart Outdated Show resolved Hide resolved

mdebbar approved these changes Apr 29, 2025

View reviewed changes

bkonyi approved these changes May 26, 2025

View reviewed changes

bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label May 26, 2025

auto-submit bot added this pull request to the merge queue May 26, 2025

Merged via the queue into flutter:master with commit a9e9ff9 May 26, 2025
143 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 26, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2025

a9e9ff9 Precise browser resizing with integration_test and driver (fl…

7edcc14

…utter/flutter#160678)

engine-flutter-autoroll mentioned this pull request May 27, 2025

Roll Flutter from 4372bfbc6c23 to 4e75d56bdab0 (13 revisions) flutter/packages#9323

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2025

a9e9ff9 Precise browser resizing with integration_test and driver (fl…

9b684a6

…utter/flutter#160678)

engine-flutter-autoroll mentioned this pull request May 27, 2025

Roll Flutter from 4372bfbc6c23 to 768932e97299 (14 revisions) flutter/packages#9325

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2025

a9e9ff9 Precise browser resizing with integration_test and driver (fl…

1f77960

…utter/flutter#160678)

engine-flutter-autoroll mentioned this pull request May 27, 2025

Roll Flutter from 4372bfbc6c23 to 184835f7d8f5 (15 revisions) flutter/packages#9326

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2025

a9e9ff9 Precise browser resizing with integration_test and driver (fl…

6d5570b

…utter/flutter#160678)

engine-flutter-autoroll mentioned this pull request May 27, 2025

Roll Flutter from 4372bfbc6c23 to 973701688c46 (17 revisions) flutter/packages#9327

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2025

a9e9ff9 Precise browser resizing with integration_test and driver (fl…

0d376c3

…utter/flutter#160678)

engine-flutter-autoroll mentioned this pull request May 28, 2025

Roll Flutter from 4372bfbc6c23 to 5d013c73baa7 (26 revisions) flutter/packages#9333

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2025

a9e9ff9 Precise browser resizing with integration_test and driver (fl…

36ced87

…utter/flutter#160678)

engine-flutter-autoroll mentioned this pull request May 28, 2025

Roll Flutter from 4372bfbc6c23 to 0e536eb9fe4b (27 revisions) flutter/packages#9334

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

a9e9ff9 Precise browser resizing with integration_test and driver (fl…

a031bef

…utter/flutter#160678)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

a9e9ff9 Precise browser resizing with integration_test and driver (fl…

f26b11b

…utter/flutter#160678)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

a9e9ff9 Precise browser resizing with integration_test and driver (fl…

e2f5e1e

…utter/flutter#160678)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

a9e9ff9 Precise browser resizing with integration_test and driver (fl…

90516ed

…utter/flutter#160678)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

a9e9ff9 Precise browser resizing with integration_test and driver (fl…

5d74246

…utter/flutter#160678)

Precise browser resizing with integration_test and driver #160678

Precise browser resizing with integration_test and driver #160678

Uh oh!

Conversation

munrocket commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-dashboard bot commented Dec 23, 2024

Uh oh!

munrocket commented Dec 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmagman commented Dec 26, 2024

Uh oh!

flutter-dashboard bot commented Dec 27, 2024

Uh oh!

munrocket commented Dec 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-dashboard bot commented Dec 27, 2024

Uh oh!

munrocket commented Dec 27, 2024

Uh oh!

jmagman commented Dec 27, 2024

Uh oh!

Uh oh!

Uh oh!

bkonyi commented Jan 16, 2025

Uh oh!

mdebbar commented Apr 29, 2025

Uh oh!

mdebbar commented Apr 29, 2025

Uh oh!

bkonyi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

munrocket commented Dec 20, 2024 •

edited

Loading

munrocket commented Dec 23, 2024 •

edited

Loading

munrocket commented Dec 27, 2024 •

edited

Loading