Skip to content

delete stale references/includes to classes no longer used #168616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
May 10, 2025
Merged

delete stale references/includes to classes no longer used #168616

auto-submit merged 1 commit into from
May 10, 2025

Conversation

@flar
Copy link
Contributor

@flar flar commented May 9, 2025

Simple code pruning. While scanning the sources for unused code I found a few stale references to classes that were already no longer being used.

@flar flar requested a review from gaaclarke May 9, 2025 21:28
@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels May 9, 2025
gaaclarke
gaaclarke approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label May 10, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 10, 2025
Merged via the queue into flutter:master with commit 8ee8eaa May 10, 2025
182 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 10, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2025
@engine-flutter-autoroll
8ee8eaa delete stale references/includes to classes no longer used (f…
fae179b 
…lutter/flutter#168616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2025
@engine-flutter-autoroll
8ee8eaa delete stale references/includes to classes no longer used (f…
72af174 
…lutter/flutter#168616)
This was referenced May 10, 2025
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 11, 2025
@engine-flutter-autoroll
8ee8eaa delete stale references/includes to classes no longer used (f…
1f0bfa1 
…lutter/flutter#168616)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 11, 2025
@engine-flutter-autoroll
Roll Flutter from 83082c1 to 992ad74 (17 revisions) (#9239)
6a28ad9 
flutter/flutter@83082c1...992ad74

2025-05-10 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from F2xwL6WosfD7ETcPm... to VIG5-P9wwXgQkCkeX... (flutter/flutter#168633)
2025-05-10 flar@google.com delete stale references/includes to classes no longer used (flutter/flutter#168616)
2025-05-10 engine-flutter-autoroll@skia.org Roll Skia from 645404ec2d60 to 0feee17aeaca (1 revision) (flutter/flutter#168624)
2025-05-10 engine-flutter-autoroll@skia.org Roll Skia from 12dbc34d742e to 645404ec2d60 (1 revision) (flutter/flutter#168621)
2025-05-09 145144088+camfrandsen@users.noreply.github.com Add Option to disable full selection on focus on TextField, TextFormField, and EditableText (flutter/flutter#163491)
2025-05-09 alex.medinsh@gmail.com Add `CupertinoSlider` haptic feedback (flutter/flutter#167362)
2025-05-09 engine-flutter-autoroll@skia.org Roll Skia from 7f7555536e3c to 12dbc34d742e (1 revision) (flutter/flutter#168614)
2025-05-09 dkwingsmt@users.noreply.github.com Fix: Impeller playground's points should be draggable (flutter/flutter#168351)
2025-05-09 34871572+gmackall@users.noreply.github.com Remove old link for java gradle incompatibility (flutter/flutter#168561)
2025-05-09 engine-flutter-autoroll@skia.org Roll Skia from 0d16b74f74a5 to 7f7555536e3c (5 revisions) (flutter/flutter#168609)
2025-05-09 muhatashim@google.com add missing lockfiles not checked in from running generate_gradle_lockfiles.dart (flutter/flutter#168600)
2025-05-09 chinmaygarde@google.com [Impeller] libImpeller: Usability improvements for WASM and python bindings. (flutter/flutter#168397)
2025-05-09 69965798+ayyoub-coder@users.noreply.github.com Fix ListTile overwriting parent IconButtonTheme for its children (#167727) (flutter/flutter#168480)
2025-05-09 engine-flutter-autoroll@skia.org Roll Skia from efccaeb08b8d to 0d16b74f74a5 (6 revisions) (flutter/flutter#168569)
2025-05-09 kevmoo@users.noreply.github.com [web] more cleanup of unused APIs (flutter/flutter#168524)
2025-05-09 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from mqhX1OP8ezmialgqA... to F2xwL6WosfD7ETcPm... (flutter/flutter#168587)
2025-05-09 engine-flutter-autoroll@skia.org Roll Packages from ab44c26 to 7814fab (4 revisions) (flutter/flutter#168597)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from 83082c1 to 992ad74 (17 revisions) (flutter#9239)
da7ed84 
flutter/flutter@83082c1...992ad74

2025-05-10 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from F2xwL6WosfD7ETcPm... to VIG5-P9wwXgQkCkeX... (flutter/flutter#168633)
2025-05-10 flar@google.com delete stale references/includes to classes no longer used (flutter/flutter#168616)
2025-05-10 engine-flutter-autoroll@skia.org Roll Skia from 645404ec2d60 to 0feee17aeaca (1 revision) (flutter/flutter#168624)
2025-05-10 engine-flutter-autoroll@skia.org Roll Skia from 12dbc34d742e to 645404ec2d60 (1 revision) (flutter/flutter#168621)
2025-05-09 145144088+camfrandsen@users.noreply.github.com Add Option to disable full selection on focus on TextField, TextFormField, and EditableText (flutter/flutter#163491)
2025-05-09 alex.medinsh@gmail.com Add `CupertinoSlider` haptic feedback (flutter/flutter#167362)
2025-05-09 engine-flutter-autoroll@skia.org Roll Skia from 7f7555536e3c to 12dbc34d742e (1 revision) (flutter/flutter#168614)
2025-05-09 dkwingsmt@users.noreply.github.com Fix: Impeller playground's points should be draggable (flutter/flutter#168351)
2025-05-09 34871572+gmackall@users.noreply.github.com Remove old link for java gradle incompatibility (flutter/flutter#168561)
2025-05-09 engine-flutter-autoroll@skia.org Roll Skia from 0d16b74f74a5 to 7f7555536e3c (5 revisions) (flutter/flutter#168609)
2025-05-09 muhatashim@google.com add missing lockfiles not checked in from running generate_gradle_lockfiles.dart (flutter/flutter#168600)
2025-05-09 chinmaygarde@google.com [Impeller] libImpeller: Usability improvements for WASM and python bindings. (flutter/flutter#168397)
2025-05-09 69965798+ayyoub-coder@users.noreply.github.com Fix ListTile overwriting parent IconButtonTheme for its children (#167727) (flutter/flutter#168480)
2025-05-09 engine-flutter-autoroll@skia.org Roll Skia from efccaeb08b8d to 0d16b74f74a5 (6 revisions) (flutter/flutter#168569)
2025-05-09 kevmoo@users.noreply.github.com [web] more cleanup of unused APIs (flutter/flutter#168524)
2025-05-09 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from mqhX1OP8ezmialgqA... to F2xwL6WosfD7ETcPm... (flutter/flutter#168587)
2025-05-09 engine-flutter-autoroll@skia.org Roll Packages from ab44c26 to 7814fab (4 revisions) (flutter/flutter#168597)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Roll Flutter from 83082c1 to 992ad74 (17 revisions) (flutter#9239)
2afe648 
flutter/flutter@83082c1...992ad74

2025-05-10 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from F2xwL6WosfD7ETcPm... to VIG5-P9wwXgQkCkeX... (flutter/flutter#168633)
2025-05-10 flar@google.com delete stale references/includes to classes no longer used (flutter/flutter#168616)
2025-05-10 engine-flutter-autoroll@skia.org Roll Skia from 645404ec2d60 to 0feee17aeaca (1 revision) (flutter/flutter#168624)
2025-05-10 engine-flutter-autoroll@skia.org Roll Skia from 12dbc34d742e to 645404ec2d60 (1 revision) (flutter/flutter#168621)
2025-05-09 145144088+camfrandsen@users.noreply.github.com Add Option to disable full selection on focus on TextField, TextFormField, and EditableText (flutter/flutter#163491)
2025-05-09 alex.medinsh@gmail.com Add `CupertinoSlider` haptic feedback (flutter/flutter#167362)
2025-05-09 engine-flutter-autoroll@skia.org Roll Skia from 7f7555536e3c to 12dbc34d742e (1 revision) (flutter/flutter#168614)
2025-05-09 dkwingsmt@users.noreply.github.com Fix: Impeller playground's points should be draggable (flutter/flutter#168351)
2025-05-09 34871572+gmackall@users.noreply.github.com Remove old link for java gradle incompatibility (flutter/flutter#168561)
2025-05-09 engine-flutter-autoroll@skia.org Roll Skia from 0d16b74f74a5 to 7f7555536e3c (5 revisions) (flutter/flutter#168609)
2025-05-09 muhatashim@google.com add missing lockfiles not checked in from running generate_gradle_lockfiles.dart (flutter/flutter#168600)
2025-05-09 chinmaygarde@google.com [Impeller] libImpeller: Usability improvements for WASM and python bindings. (flutter/flutter#168397)
2025-05-09 69965798+ayyoub-coder@users.noreply.github.com Fix ListTile overwriting parent IconButtonTheme for its children (#167727) (flutter/flutter#168480)
2025-05-09 engine-flutter-autoroll@skia.org Roll Skia from efccaeb08b8d to 0d16b74f74a5 (6 revisions) (flutter/flutter#168569)
2025-05-09 kevmoo@users.noreply.github.com [web] more cleanup of unused APIs (flutter/flutter#168524)
2025-05-09 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from mqhX1OP8ezmialgqA... to F2xwL6WosfD7ETcPm... (flutter/flutter#168587)
2025-05-09 engine-flutter-autoroll@skia.org Roll Packages from ab44c26 to 7814fab (4 revisions) (flutter/flutter#168597)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
8ee8eaa delete stale references/includes to classes no longer used (f…
8edb76e 
…lutter/flutter#168616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
8ee8eaa delete stale references/includes to classes no longer used (f…
c77acc6 
…lutter/flutter#168616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
8ee8eaa delete stale references/includes to classes no longer used (f…
833e0af 
…lutter/flutter#168616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
8ee8eaa delete stale references/includes to classes no longer used (f…
a2a92e0 
…lutter/flutter#168616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
8ee8eaa delete stale references/includes to classes no longer used (f…
06c3219 
…lutter/flutter#168616)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@flar @gaaclarke