Fix ListTile overwriting parent IconButtonTheme for its children (#167727) #168480

ayyoub-coder · 2025-05-07T14:08:21Z

Description

ListTile was recreating its own IconButtonThemeData—discarding any styles inherited from an existing IconButtonTheme above it. This change makes ListTile merge its theme data with the inherited one instead of replacing it, so child IconButtons now correctly pick up parent styling

issue: #167727

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…eviously

dkwingsmt

LGTM

packages/flutter/lib/src/material/icon_button_theme.dart

packages/flutter/lib/src/material/list_tile.dart

…tTile

…ack to any of the original fields

packages/flutter/lib/src/material/button_style.dart

packages/flutter/lib/src/material/list_tile.dart

QuncCccccc

LGTM. Thank you for your contribution:)

…ren (#167727) (flutter/flutter#168480)

…ldren (#167727) (flutter/flutter#168480)

flutter/flutter@83082c1...992ad74 2025-05-10 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from F2xwL6WosfD7ETcPm... to VIG5-P9wwXgQkCkeX... (flutter/flutter#168633) 2025-05-10 flar@google.com delete stale references/includes to classes no longer used (flutter/flutter#168616) 2025-05-10 engine-flutter-autoroll@skia.org Roll Skia from 645404ec2d60 to 0feee17aeaca (1 revision) (flutter/flutter#168624) 2025-05-10 engine-flutter-autoroll@skia.org Roll Skia from 12dbc34d742e to 645404ec2d60 (1 revision) (flutter/flutter#168621) 2025-05-09 145144088+camfrandsen@users.noreply.github.com Add Option to disable full selection on focus on TextField, TextFormField, and EditableText (flutter/flutter#163491) 2025-05-09 alex.medinsh@gmail.com Add `CupertinoSlider` haptic feedback (flutter/flutter#167362) 2025-05-09 engine-flutter-autoroll@skia.org Roll Skia from 7f7555536e3c to 12dbc34d742e (1 revision) (flutter/flutter#168614) 2025-05-09 dkwingsmt@users.noreply.github.com Fix: Impeller playground's points should be draggable (flutter/flutter#168351) 2025-05-09 34871572+gmackall@users.noreply.github.com Remove old link for java gradle incompatibility (flutter/flutter#168561) 2025-05-09 engine-flutter-autoroll@skia.org Roll Skia from 0d16b74f74a5 to 7f7555536e3c (5 revisions) (flutter/flutter#168609) 2025-05-09 muhatashim@google.com add missing lockfiles not checked in from running generate_gradle_lockfiles.dart (flutter/flutter#168600) 2025-05-09 chinmaygarde@google.com [Impeller] libImpeller: Usability improvements for WASM and python bindings. (flutter/flutter#168397) 2025-05-09 69965798+ayyoub-coder@users.noreply.github.com Fix ListTile overwriting parent IconButtonTheme for its children (#167727) (flutter/flutter#168480) 2025-05-09 engine-flutter-autoroll@skia.org Roll Skia from efccaeb08b8d to 0d16b74f74a5 (6 revisions) (flutter/flutter#168569) 2025-05-09 kevmoo@users.noreply.github.com [web] more cleanup of unused APIs (flutter/flutter#168524) 2025-05-09 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from mqhX1OP8ezmialgqA... to F2xwL6WosfD7ETcPm... (flutter/flutter#168587) 2025-05-09 engine-flutter-autoroll@skia.org Roll Packages from ab44c26 to 7814fab (4 revisions) (flutter/flutter#168597) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…ren (#167727) (flutter/flutter#168480)

ayyoub-coder added 3 commits May 7, 2025 15:03

fix(ListTile): merge parent IconButtonTheme instead of overwriting pr…

5006510

…eviously

reorganize imports

94d30c5

add test

6ef2494

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels May 7, 2025

dkwingsmt approved these changes May 7, 2025

View reviewed changes

QuncCccccc self-requested a review May 7, 2025 19:13

QuncCccccc reviewed May 7, 2025

View reviewed changes

packages/flutter/lib/src/material/icon_button_theme.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/material/list_tile.dart Outdated Show resolved Hide resolved

ayyoub-coder and others added 3 commits May 8, 2025 10:27

Merge branch 'master' into fix-list-tile-overwriting-icon-button-style

d9b7e1f

refactor(IconButtonTheme): merge styles instead of overwriting in Lis…

b96539b

…tTile

fix(button_style): use style properties directly instead of falling b…

28b74f8

…ack to any of the original fields

QuncCccccc reviewed May 8, 2025

View reviewed changes

packages/flutter/lib/src/material/button_style.dart Outdated Show resolved Hide resolved

ayyoub-coder and others added 2 commits May 8, 2025 21:35

Restores the previous merge logic for ButtonStyle.merge, as before

716db00

Merge branch 'master' into fix-list-tile-overwriting-icon-button-style

2a46d55

QuncCccccc reviewed May 9, 2025

View reviewed changes

packages/flutter/lib/src/material/list_tile.dart Outdated Show resolved Hide resolved

ayyoub-coder and others added 2 commits May 9, 2025 09:22

fix(list_tile): update IconButtonTheme to merge styles correctly

5ca3df7

Merge branch 'master' into fix-list-tile-overwriting-icon-button-style

0908d42

QuncCccccc approved these changes May 9, 2025

View reviewed changes

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2025

auto-submit bot added this pull request to the merge queue May 9, 2025

Merged via the queue into flutter:master with commit c82cf49 May 9, 2025
75 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2025

c82cf49 Fix ListTile overwriting parent IconButtonTheme for its child…

cf98b1f

…ren (#167727) (flutter/flutter#168480)

engine-flutter-autoroll mentioned this pull request May 10, 2025

Roll Flutter from 83082c19b727 to 8ee8eaa66e8d (16 revisions) flutter/packages#9235

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2025

c82cf49 Fix ListTile overwriting parent IconButtonTheme for its child…

1297ef3

…ren (#167727) (flutter/flutter#168480)

engine-flutter-autoroll mentioned this pull request May 10, 2025

Roll Flutter from 83082c19b727 to 8ee8eaa66e8d (16 revisions) flutter/packages#9238

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 11, 2025

c82cf49b6 Fix ListTile overwriting parent IconButtonTheme for its chi…

bd03d88

…ldren (#167727) (flutter/flutter#168480)

engine-flutter-autoroll mentioned this pull request May 11, 2025

Roll Flutter from 83082c19b727 to 992ad7489c38 (17 revisions) flutter/packages#9239

Merged

RamonFarizel mentioned this pull request May 13, 2025

Fix ListTiles theme override #167857

Closed

8 tasks

QuncCccccc mentioned this pull request May 21, 2025

Fix remaining iconbuttontheme overrides in listtile #169029

Merged

9 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

c82cf49 Fix ListTile overwriting parent IconButtonTheme for its child…

d185493

…ren (#167727) (flutter/flutter#168480)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

c82cf49 Fix ListTile overwriting parent IconButtonTheme for its child…

52e1aca

…ren (#167727) (flutter/flutter#168480)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

c82cf49 Fix ListTile overwriting parent IconButtonTheme for its child…

d9a0282

…ren (#167727) (flutter/flutter#168480)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

c82cf49 Fix ListTile overwriting parent IconButtonTheme for its child…

d3c1c34

…ren (#167727) (flutter/flutter#168480)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

c82cf49 Fix ListTile overwriting parent IconButtonTheme for its child…

955c33f

…ren (#167727) (flutter/flutter#168480)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix ListTile overwriting parent IconButtonTheme for its children (#167727) #168480

Fix ListTile overwriting parent IconButtonTheme for its children (#167727) #168480

Uh oh!

ayyoub-coder commented May 7, 2025 •

edited

Loading

Uh oh!

dkwingsmt left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

QuncCccccc left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix ListTile overwriting parent IconButtonTheme for its children (#167727) #168480

Fix ListTile overwriting parent IconButtonTheme for its children (#167727) #168480

Uh oh!

Conversation

ayyoub-coder commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pre-launch Checklist

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ayyoub-coder commented May 7, 2025 •

edited

Loading