Skip to content

Conversation

@LouiseHsu
Copy link
Contributor

@LouiseHsu LouiseHsu commented Apr 17, 2025

Update led docs to include led edit -pa is_fusion='true'

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@LouiseHsu LouiseHsu changed the title bonk Update led docs Apr 17, 2025
@LouiseHsu LouiseHsu marked this pull request as ready for review April 17, 2025 23:36
@LouiseHsu LouiseHsu requested a review from matanlurey as a code owner April 17, 2025 23:36
@LouiseHsu LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 18, 2025
Merged via the queue into flutter:master with commit 3ed38e2 Apr 18, 2025
149 of 150 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 18, 2025
flutter/flutter@ecabb1a...3ed38e2

2025-04-18 louisehsu@google.com Update `led` docs (flutter/flutter#167380)
2025-04-18 jason-simmons@users.noreply.github.com Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948)
2025-04-18 1063596+reidbaker@users.noreply.github.com Add kotlin compatability to build file validation (flutter/flutter#167143)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400)
2025-04-18 bruno.leroux@gmail.com Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396)
2025-04-18 bruno.leroux@gmail.com Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387)
2025-04-18 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385)
2025-04-17 engine-flutter-autoroll@skia.org Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347)
2025-04-17 jason-simmons@users.noreply.github.com Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918)
2025-04-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361)
2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226)
2025-04-17 30870216+gaaclarke@users.noreply.github.com adds Entity docstrings (flutter/flutter#167228)
2025-04-17 30870216+gaaclarke@users.noreply.github.com fixed impeller golden content scale (flutter/flutter#167308)
2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterContents::RenderFilter (flutter/flutter#167227)
2025-04-17 34465683+rkishan516@users.noreply.github.com Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655)
2025-04-17 linxunfeng@yeah.net Fix link to engine docs (flutter/flutter#167346)
2025-04-17 matej.knopp@gmail.com [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536)
2025-04-17 matej.knopp@gmail.com [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726)
2025-04-17 matanlurey@users.noreply.github.com Update `CHANGELOG.md` (flutter/flutter#167225)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
flutter/flutter@ecabb1a...3ed38e2

2025-04-18 louisehsu@google.com Update `led` docs (flutter/flutter#167380)
2025-04-18 jason-simmons@users.noreply.github.com Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948)
2025-04-18 1063596+reidbaker@users.noreply.github.com Add kotlin compatability to build file validation (flutter/flutter#167143)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400)
2025-04-18 bruno.leroux@gmail.com Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396)
2025-04-18 bruno.leroux@gmail.com Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387)
2025-04-18 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385)
2025-04-17 engine-flutter-autoroll@skia.org Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347)
2025-04-17 jason-simmons@users.noreply.github.com Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918)
2025-04-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361)
2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226)
2025-04-17 30870216+gaaclarke@users.noreply.github.com adds Entity docstrings (flutter/flutter#167228)
2025-04-17 30870216+gaaclarke@users.noreply.github.com fixed impeller golden content scale (flutter/flutter#167308)
2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterContents::RenderFilter (flutter/flutter#167227)
2025-04-17 34465683+rkishan516@users.noreply.github.com Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655)
2025-04-17 linxunfeng@yeah.net Fix link to engine docs (flutter/flutter#167346)
2025-04-17 matej.knopp@gmail.com [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536)
2025-04-17 matej.knopp@gmail.com [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726)
2025-04-17 matanlurey@users.noreply.github.com Update `CHANGELOG.md` (flutter/flutter#167225)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
flutter/flutter@ecabb1a...3ed38e2

2025-04-18 louisehsu@google.com Update `led` docs (flutter/flutter#167380)
2025-04-18 jason-simmons@users.noreply.github.com Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948)
2025-04-18 1063596+reidbaker@users.noreply.github.com Add kotlin compatability to build file validation (flutter/flutter#167143)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400)
2025-04-18 bruno.leroux@gmail.com Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396)
2025-04-18 bruno.leroux@gmail.com Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387)
2025-04-18 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385)
2025-04-17 engine-flutter-autoroll@skia.org Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347)
2025-04-17 jason-simmons@users.noreply.github.com Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918)
2025-04-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361)
2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226)
2025-04-17 30870216+gaaclarke@users.noreply.github.com adds Entity docstrings (flutter/flutter#167228)
2025-04-17 30870216+gaaclarke@users.noreply.github.com fixed impeller golden content scale (flutter/flutter#167308)
2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterContents::RenderFilter (flutter/flutter#167227)
2025-04-17 34465683+rkishan516@users.noreply.github.com Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655)
2025-04-17 linxunfeng@yeah.net Fix link to engine docs (flutter/flutter#167346)
2025-04-17 matej.knopp@gmail.com [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536)
2025-04-17 matej.knopp@gmail.com [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726)
2025-04-17 matanlurey@users.noreply.github.com Update `CHANGELOG.md` (flutter/flutter#167225)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
flutter/flutter@ecabb1a...3ed38e2

2025-04-18 louisehsu@google.com Update `led` docs (flutter/flutter#167380)
2025-04-18 jason-simmons@users.noreply.github.com Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948)
2025-04-18 1063596+reidbaker@users.noreply.github.com Add kotlin compatability to build file validation (flutter/flutter#167143)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400)
2025-04-18 bruno.leroux@gmail.com Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396)
2025-04-18 bruno.leroux@gmail.com Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387)
2025-04-18 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385)
2025-04-17 engine-flutter-autoroll@skia.org Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347)
2025-04-17 jason-simmons@users.noreply.github.com Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918)
2025-04-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361)
2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226)
2025-04-17 30870216+gaaclarke@users.noreply.github.com adds Entity docstrings (flutter/flutter#167228)
2025-04-17 30870216+gaaclarke@users.noreply.github.com fixed impeller golden content scale (flutter/flutter#167308)
2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterContents::RenderFilter (flutter/flutter#167227)
2025-04-17 34465683+rkishan516@users.noreply.github.com Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655)
2025-04-17 linxunfeng@yeah.net Fix link to engine docs (flutter/flutter#167346)
2025-04-17 matej.knopp@gmail.com [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536)
2025-04-17 matej.knopp@gmail.com [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726)
2025-04-17 matanlurey@users.noreply.github.com Update `CHANGELOG.md` (flutter/flutter#167225)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
flutter/flutter@ecabb1a...3ed38e2

2025-04-18 louisehsu@google.com Update `led` docs (flutter/flutter#167380)
2025-04-18 jason-simmons@users.noreply.github.com Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948)
2025-04-18 1063596+reidbaker@users.noreply.github.com Add kotlin compatability to build file validation (flutter/flutter#167143)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400)
2025-04-18 bruno.leroux@gmail.com Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396)
2025-04-18 bruno.leroux@gmail.com Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387)
2025-04-18 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385)
2025-04-17 engine-flutter-autoroll@skia.org Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347)
2025-04-17 jason-simmons@users.noreply.github.com Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918)
2025-04-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361)
2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226)
2025-04-17 30870216+gaaclarke@users.noreply.github.com adds Entity docstrings (flutter/flutter#167228)
2025-04-17 30870216+gaaclarke@users.noreply.github.com fixed impeller golden content scale (flutter/flutter#167308)
2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterContents::RenderFilter (flutter/flutter#167227)
2025-04-17 34465683+rkishan516@users.noreply.github.com Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655)
2025-04-17 linxunfeng@yeah.net Fix link to engine docs (flutter/flutter#167346)
2025-04-17 matej.knopp@gmail.com [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536)
2025-04-17 matej.knopp@gmail.com [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726)
2025-04-17 matanlurey@users.noreply.github.com Update `CHANGELOG.md` (flutter/flutter#167225)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
Update led docs to include `led edit -pa is_fusion='true'`

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants