Skip to content

Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity #166834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Apr 18, 2025
Merged

Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity #166834

auto-submit merged 1 commit into from
Apr 18, 2025

Conversation

@bleroux
Copy link
Contributor

@bleroux bleroux commented Apr 9, 2025

Description

This PR introduces InputDecoration.visualDensity and InputDecorationTheme.visualDensity.
See #166201 (comment) for motivation.

Related Issue

Fixes #166201

Tests

Adds 8 tests (4 for filled decoration, 4 for outlined decoration).

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Apr 9, 2025
@bleroux bleroux requested a review from dkwingsmt April 9, 2025 13:00
@bleroux bleroux changed the title Add inputDecoration.visualDensity and InputDecorationTheme.visualDensity Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity Apr 9, 2025
dkwingsmt
dkwingsmt approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/lib/src/material/input_decorator.dart
final BoxConstraints? constraints;

/// Defines how compact the decoration's layout will be.
///
Copy link
Contributor

@dkwingsmt dkwingsmt Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional that flutter.material.themedata.visualDensity macro is not used here?

Copy link
Contributor Author

@bleroux bleroux Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was on purpose because I wanted to have a specific documentation and also because in the 'See also' section I added a link to ThemeData.visualDensity. One of the problem when documenting VisualDensity is that its effect are specific to each widget and the flutter.material.themedata.visualDensity documentation macro is very generic.

@bleroux bleroux force-pushed the add_InputDecoration_visualDensity branch from e2eed2c to 0d20a47 Compare April 18, 2025 08:31
@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 18, 2025
Merged via the queue into flutter:master with commit 8e3e7f4 Apr 18, 2025
75 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2025
@bleroux bleroux deleted the add_InputDecoration_visualDensity branch April 18, 2025 10:54
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2025
@engine-flutter-autoroll
8e3e7f4 Add InputDecoration.visualDensity and InputDecorationTheme.vi…
e70bc15 
…sualDensity (flutter/flutter#166834)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2025
@engine-flutter-autoroll
8e3e7f4 Add InputDecoration.visualDensity and InputDecorationTheme.vi…
c2f97c8 
…sualDensity (flutter/flutter#166834)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2025
@engine-flutter-autoroll
8e3e7f4 Add InputDecoration.visualDensity and InputDecorationTheme.vi…
db0f160 
…sualDensity (flutter/flutter#166834)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 18, 2025
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 18, 2025
@engine-flutter-autoroll
Roll Flutter from ecabb1a to 3ed38e2 (23 revisions) (#9114)
bfb42a6 
flutter/flutter@ecabb1a...3ed38e2

2025-04-18 louisehsu@google.com Update `led` docs (flutter/flutter#167380)
2025-04-18 jason-simmons@users.noreply.github.com Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948)
2025-04-18 1063596+reidbaker@users.noreply.github.com Add kotlin compatability to build file validation (flutter/flutter#167143)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400)
2025-04-18 bruno.leroux@gmail.com Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396)
2025-04-18 bruno.leroux@gmail.com Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387)
2025-04-18 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385)
2025-04-17 engine-flutter-autoroll@skia.org Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347)
2025-04-17 jason-simmons@users.noreply.github.com Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918)
2025-04-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361)
2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226)
2025-04-17 30870216+gaaclarke@users.noreply.github.com adds Entity docstrings (flutter/flutter#167228)
2025-04-17 30870216+gaaclarke@users.noreply.github.com fixed impeller golden content scale (flutter/flutter#167308)
2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterContents::RenderFilter (flutter/flutter#167227)
2025-04-17 34465683+rkishan516@users.noreply.github.com Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655)
2025-04-17 linxunfeng@yeah.net Fix link to engine docs (flutter/flutter#167346)
2025-04-17 matej.knopp@gmail.com [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536)
2025-04-17 matej.knopp@gmail.com [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726)
2025-04-17 matanlurey@users.noreply.github.com Update `CHANGELOG.md` (flutter/flutter#167225)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Roll Flutter from ecabb1a05212 to 3ed38e24528a (23 revisions) (#9114)
83531f2 
flutter/flutter@ecabb1a...3ed38e2

2025-04-18 louisehsu@google.com Update `led` docs (flutter/flutter#167380)
2025-04-18 jason-simmons@users.noreply.github.com Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948)
2025-04-18 1063596+reidbaker@users.noreply.github.com Add kotlin compatability to build file validation (flutter/flutter#167143)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400)
2025-04-18 bruno.leroux@gmail.com Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396)
2025-04-18 bruno.leroux@gmail.com Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387)
2025-04-18 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385)
2025-04-17 engine-flutter-autoroll@skia.org Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347)
2025-04-17 jason-simmons@users.noreply.github.com Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918)
2025-04-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361)
2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226)
2025-04-17 30870216+gaaclarke@users.noreply.github.com adds Entity docstrings (flutter/flutter#167228)
2025-04-17 30870216+gaaclarke@users.noreply.github.com fixed impeller golden content scale (flutter/flutter#167308)
2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterContents::RenderFilter (flutter/flutter#167227)
2025-04-17 34465683+rkishan516@users.noreply.github.com Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655)
2025-04-17 linxunfeng@yeah.net Fix link to engine docs (flutter/flutter#167346)
2025-04-17 matej.knopp@gmail.com [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536)
2025-04-17 matej.knopp@gmail.com [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726)
2025-04-17 matanlurey@users.noreply.github.com Update `CHANGELOG.md` (flutter/flutter#167225)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from ecabb1a to 3ed38e2 (23 revisions) (flutter#9114)
04ead92 
flutter/flutter@ecabb1a...3ed38e2

2025-04-18 louisehsu@google.com Update `led` docs (flutter/flutter#167380)
2025-04-18 jason-simmons@users.noreply.github.com Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948)
2025-04-18 1063596+reidbaker@users.noreply.github.com Add kotlin compatability to build file validation (flutter/flutter#167143)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400)
2025-04-18 bruno.leroux@gmail.com Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396)
2025-04-18 bruno.leroux@gmail.com Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387)
2025-04-18 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385)
2025-04-17 engine-flutter-autoroll@skia.org Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347)
2025-04-17 jason-simmons@users.noreply.github.com Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918)
2025-04-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361)
2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226)
2025-04-17 30870216+gaaclarke@users.noreply.github.com adds Entity docstrings (flutter/flutter#167228)
2025-04-17 30870216+gaaclarke@users.noreply.github.com fixed impeller golden content scale (flutter/flutter#167308)
2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterContents::RenderFilter (flutter/flutter#167227)
2025-04-17 34465683+rkishan516@users.noreply.github.com Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655)
2025-04-17 linxunfeng@yeah.net Fix link to engine docs (flutter/flutter#167346)
2025-04-17 matej.knopp@gmail.com [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536)
2025-04-17 matej.knopp@gmail.com [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726)
2025-04-17 matanlurey@users.noreply.github.com Update `CHANGELOG.md` (flutter/flutter#167225)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from ecabb1a to 3ed38e2 (23 revisions) (flutter#9114)
993466f 
flutter/flutter@ecabb1a...3ed38e2

2025-04-18 louisehsu@google.com Update `led` docs (flutter/flutter#167380)
2025-04-18 jason-simmons@users.noreply.github.com Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948)
2025-04-18 1063596+reidbaker@users.noreply.github.com Add kotlin compatability to build file validation (flutter/flutter#167143)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400)
2025-04-18 bruno.leroux@gmail.com Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396)
2025-04-18 bruno.leroux@gmail.com Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387)
2025-04-18 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385)
2025-04-17 engine-flutter-autoroll@skia.org Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347)
2025-04-17 jason-simmons@users.noreply.github.com Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918)
2025-04-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361)
2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226)
2025-04-17 30870216+gaaclarke@users.noreply.github.com adds Entity docstrings (flutter/flutter#167228)
2025-04-17 30870216+gaaclarke@users.noreply.github.com fixed impeller golden content scale (flutter/flutter#167308)
2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterContents::RenderFilter (flutter/flutter#167227)
2025-04-17 34465683+rkishan516@users.noreply.github.com Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655)
2025-04-17 linxunfeng@yeah.net Fix link to engine docs (flutter/flutter#167346)
2025-04-17 matej.knopp@gmail.com [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536)
2025-04-17 matej.knopp@gmail.com [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726)
2025-04-17 matanlurey@users.noreply.github.com Update `CHANGELOG.md` (flutter/flutter#167225)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Roll Flutter from ecabb1a to 3ed38e2 (23 revisions) (flutter#9114)
b319071 
flutter/flutter@ecabb1a...3ed38e2

2025-04-18 louisehsu@google.com Update `led` docs (flutter/flutter#167380)
2025-04-18 jason-simmons@users.noreply.github.com Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948)
2025-04-18 1063596+reidbaker@users.noreply.github.com Add kotlin compatability to build file validation (flutter/flutter#167143)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400)
2025-04-18 bruno.leroux@gmail.com Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396)
2025-04-18 bruno.leroux@gmail.com Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387)
2025-04-18 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385)
2025-04-17 engine-flutter-autoroll@skia.org Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347)
2025-04-17 jason-simmons@users.noreply.github.com Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918)
2025-04-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361)
2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226)
2025-04-17 30870216+gaaclarke@users.noreply.github.com adds Entity docstrings (flutter/flutter#167228)
2025-04-17 30870216+gaaclarke@users.noreply.github.com fixed impeller golden content scale (flutter/flutter#167308)
2025-04-17 30870216+gaaclarke@users.noreply.github.com Added docstring for FilterContents::RenderFilter (flutter/flutter#167227)
2025-04-17 34465683+rkishan516@users.noreply.github.com Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655)
2025-04-17 linxunfeng@yeah.net Fix link to engine docs (flutter/flutter#167346)
2025-04-17 matej.knopp@gmail.com [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536)
2025-04-17 matej.knopp@gmail.com [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726)
2025-04-17 matanlurey@users.noreply.github.com Update `CHANGELOG.md` (flutter/flutter#167225)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@bleroux bleroux mentioned this pull request Jul 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
8e3e7f4 Add InputDecoration.visualDensity and InputDecorationTheme.vi…
f010e03 
…sualDensity (flutter/flutter#166834)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
8e3e7f4 Add InputDecoration.visualDensity and InputDecorationTheme.vi…
1e4f985 
…sualDensity (flutter/flutter#166834)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@bleroux @romanejaquez
Add InputDecoration.visualDensity and InputDecorationTheme.visualDens…
f4bc9c0 
…ity (flutter#166834)

## Description

This PR introduces `InputDecoration.visualDensity` and
`InputDecorationTheme.visualDensity`.
See
flutter#166201 (comment)
for motivation.

## Related Issue

Fixes flutter#166201

## Tests

Adds 8 tests (4 for filled decoration, 4 for outlined decoration).
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
8e3e7f4 Add InputDecoration.visualDensity and InputDecorationTheme.vi…
a32e8ed 
…sualDensity (flutter/flutter#166834)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
8e3e7f4 Add InputDecoration.visualDensity and InputDecorationTheme.vi…
1f55400 
…sualDensity (flutter/flutter#166834)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
8e3e7f4 Add InputDecoration.visualDensity and InputDecorationTheme.vi…
3529e46 
…sualDensity (flutter/flutter#166834)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

InputDecorator's contentPadding.vertical is incorrect on desktop / web.

2 participants

@bleroux @dkwingsmt