Skip to content

[native assets] Use workspace pubspec for user-defines #166977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Apr 11, 2025
Merged

[native assets] Use workspace pubspec for user-defines #166977

auto-submit merged 1 commit into from
Apr 11, 2025

Conversation

@dcharkes
Copy link
Contributor

@dcharkes dcharkes commented Apr 11, 2025

If pub workspaces are used, then native assets are shared across the whole pub workspace. Using a different user-define, invalidates the cache. Therefore, we want to avoid having different user-defines in different pubspecs belonging to the same workspace. So, only use the workspace pubspec for user-defines.

Analogous Dart SDK CL: https://dart-review.googlesource.com/c/sdk/+/422101

Testing

Covered by the integration tests added in #166940 for user-defines.

Design discussion

We could allow adding user-defines in root package pubspecs later, but this will likely deteriorate caching behavior (either invalidating the cache often, or requiring a cache directory per root package, which increases latency for new root packages).

Also, we'd likely add command-line user-defines later, these are expected to deteriorate caching behavior.

For design discussion, refer to:

@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 11, 2025

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 11, 2025
@dcharkes dcharkes requested review from bkonyi and mosuem April 11, 2025 13:32
bkonyi
bkonyi approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Test Exemption: testing done in Dart SDK

@dcharkes
Copy link
Contributor Author

dcharkes commented Apr 11, 2025

Thanks for the quick reviews @bkonyi! 🙏

@dcharkes dcharkes added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 11, 2025
Merged via the queue into master with commit 02008f0 Apr 11, 2025
146 checks passed
@auto-submit auto-submit bot deleted the native-assets-user-defines-pub-workspace branch April 11, 2025 15:01
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
02008f0 [native assets] Use workspace pubspec for user-defines (flutt…
d2efb7c 
…er/flutter#166977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
02008f0 [native assets] Use workspace pubspec for user-defines (flutt…
c6cccd3 
…er/flutter#166977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
02008f0 [native assets] Use workspace pubspec for user-defines (flutt…
2721926 
…er/flutter#166977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
02008f0 [native assets] Use workspace pubspec for user-defines (flutt…
2cc6db4 
…er/flutter#166977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
02008f0 [native assets] Use workspace pubspec for user-defines (flutt…
382f21b 
…er/flutter#166977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2025
@engine-flutter-autoroll
02008f0 [native assets] Use workspace pubspec for user-defines (flutt…
4b263a2 
…er/flutter#166977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2025
@engine-flutter-autoroll
02008f0 [native assets] Use workspace pubspec for user-defines (flutt…
1248882 
…er/flutter#166977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 13, 2025
@engine-flutter-autoroll
02008f0 [native assets] Use workspace pubspec for user-defines (flutt…
fbb0f63 
…er/flutter#166977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
02008f0 [native assets] Use workspace pubspec for user-defines (flutt…
0baef52 
…er/flutter#166977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
02008f0 [native assets] Use workspace pubspec for user-defines (flutt…
04262c8 
…er/flutter#166977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
02008f007 [native assets] Use workspace pubspec for user-defines (flu…
cbe7c48 
…tter/flutter#166977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
02008f0 [native assets] Use workspace pubspec for user-defines (flutt…
f3199d3 
…er/flutter#166977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
02008f0 [native assets] Use workspace pubspec for user-defines (flutt…
0081cac 
…er/flutter#166977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
02008f0 [native assets] Use workspace pubspec for user-defines (flutt…
f096c78 
…er/flutter#166977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
02008f0 [native assets] Use workspace pubspec for user-defines (flutt…
9053cdb 
…er/flutter#166977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
02008f0 [native assets] Use workspace pubspec for user-defines (flutt…
dd00940 
…er/flutter#166977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
02008f0 [native assets] Use workspace pubspec for user-defines (flutt…
a7eec19 
…er/flutter#166977)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
02008f0 [native assets] Use workspace pubspec for user-defines (flutt…
2d61ccd 
…er/flutter#166977)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 16, 2025
@engine-flutter-autoroll
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) (#9092)
1f0a894 
Manual roll Flutter from 30e53b0 to db68c95 (98 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@30e53b0...db68c95

2025-04-15 aam@google.com [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 engine-flutter-autoroll@skia.org Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218)
2025-04-15 34465683+rkishan516@users.noreply.github.com Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 36861262+QuncCccccc@users.noreply.github.com Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 bent@bent.party Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 34465683+rkishan516@users.noreply.github.com fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 matanlurey@users.noreply.github.com Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 bkonyi@google.com [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 matanlurey@users.noreply.github.com Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 victorsanniay@gmail.com Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 rmacnak@google.com Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 victorsanniay@gmail.com Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 victorsanniay@gmail.com Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 engine-flutter-autoroll@skia.org Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 68449066+zijiehe-google-com@users.noreply.github.com [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 lukin.bogdan.a@gmail.com Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 engine-flutter-autoroll@skia.org Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122)
2025-04-14 jacksongardner@google.com [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 jason-simmons@users.noreply.github.com Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 34871572+gmackall@users.noreply.github.com [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 1063596+reidbaker@users.noreply.github.com Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 1063596+reidbaker@users.noreply.github.com Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 jonahwilliams@google.com [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 jonahwilliams@google.com [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 34871572+gmackall@users.noreply.github.com Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 koji.wakamiya@gmail.com [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 jonahwilliams@google.com [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 56130129+MaironLucas@users.noreply.github.com modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 737941+loic-sharma@users.noreply.github.com [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 engine-flutter-autoroll@skia.org Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982)
2025-04-11 jonahwilliams@google.com [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 bkonyi@google.com Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 dacoharkes@google.com [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 engine-flutter-autoroll@skia.org Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 dacoharkes@google.com [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 jonahwilliams@google.com [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 jonahwilliams@google.com [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 rmolivares@renzo-olivares.dev Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 engine-flutter-autoroll@skia.org Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Manual roll Flutter from 30e53b0d9caa to db68c950c599 (98 revisions) …
fc4e794 
…(#9092)

Manual roll Flutter from 30e53b0d9caa to db68c950c599 (98 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@30e53b0...db68c95

2025-04-15 aam@google.com [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 engine-flutter-autoroll@skia.org Roll Packages from 853e96a to a5ed6cb (4 revisions) (flutter/flutter#167218)
2025-04-15 34465683+rkishan516@users.noreply.github.com Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 36861262+QuncCccccc@users.noreply.github.com Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 bent@bent.party Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 34465683+rkishan516@users.noreply.github.com fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 matanlurey@users.noreply.github.com Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 bkonyi@google.com [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 matanlurey@users.noreply.github.com Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 victorsanniay@gmail.com Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 rmacnak@google.com Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 victorsanniay@gmail.com Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 victorsanniay@gmail.com Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 engine-flutter-autoroll@skia.org Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 68449066+zijiehe-google-com@users.noreply.github.com [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 lukin.bogdan.a@gmail.com Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 engine-flutter-autoroll@skia.org Roll Packages from 4808eff to 853e96a (1 revision) (flutter/flutter#167122)
2025-04-14 jacksongardner@google.com [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 jason-simmons@users.noreply.github.com Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 34871572+gmackall@users.noreply.github.com [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 1063596+reidbaker@users.noreply.github.com Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 1063596+reidbaker@users.noreply.github.com Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 jonahwilliams@google.com [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 jonahwilliams@google.com [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 34871572+gmackall@users.noreply.github.com Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 koji.wakamiya@gmail.com [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 jonahwilliams@google.com [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 56130129+MaironLucas@users.noreply.github.com modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 737941+loic-sharma@users.noreply.github.com [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 engine-flutter-autoroll@skia.org Roll Packages from b2c45f9 to 4808eff (2 revisions) (flutter/flutter#166982)
2025-04-11 jonahwilliams@google.com [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 bkonyi@google.com Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 dacoharkes@google.com [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 engine-flutter-autoroll@skia.org Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 dacoharkes@google.com [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 jonahwilliams@google.com [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 jonahwilliams@google.com [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 rmolivares@renzo-olivares.dev Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 engine-flutter-autoroll@skia.org Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from 30e53b0 to db68c95 (98 revisions) (flutter#9092
b21d593 
)

Manual roll Flutter from 30e53b0 to db68c95 (98 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@30e53b0...db68c95

2025-04-15 aam@google.com [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 engine-flutter-autoroll@skia.org Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218)
2025-04-15 34465683+rkishan516@users.noreply.github.com Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 36861262+QuncCccccc@users.noreply.github.com Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 bent@bent.party Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 34465683+rkishan516@users.noreply.github.com fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 matanlurey@users.noreply.github.com Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 bkonyi@google.com [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 matanlurey@users.noreply.github.com Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 victorsanniay@gmail.com Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 rmacnak@google.com Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 victorsanniay@gmail.com Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 victorsanniay@gmail.com Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 engine-flutter-autoroll@skia.org Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 68449066+zijiehe-google-com@users.noreply.github.com [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 lukin.bogdan.a@gmail.com Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 engine-flutter-autoroll@skia.org Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122)
2025-04-14 jacksongardner@google.com [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 jason-simmons@users.noreply.github.com Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 34871572+gmackall@users.noreply.github.com [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 1063596+reidbaker@users.noreply.github.com Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 1063596+reidbaker@users.noreply.github.com Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 jonahwilliams@google.com [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 jonahwilliams@google.com [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 34871572+gmackall@users.noreply.github.com Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 koji.wakamiya@gmail.com [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 jonahwilliams@google.com [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 56130129+MaironLucas@users.noreply.github.com modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 737941+loic-sharma@users.noreply.github.com [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 engine-flutter-autoroll@skia.org Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982)
2025-04-11 jonahwilliams@google.com [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 bkonyi@google.com Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 dacoharkes@google.com [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 engine-flutter-autoroll@skia.org Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 dacoharkes@google.com [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 jonahwilliams@google.com [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 jonahwilliams@google.com [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 rmolivares@renzo-olivares.dev Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 engine-flutter-autoroll@skia.org Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from 30e53b0 to db68c95 (98 revisions) (flutter#9092
9ee6018 
)

Manual roll Flutter from 30e53b0 to db68c95 (98 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@30e53b0...db68c95

2025-04-15 aam@google.com [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 engine-flutter-autoroll@skia.org Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218)
2025-04-15 34465683+rkishan516@users.noreply.github.com Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 36861262+QuncCccccc@users.noreply.github.com Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 bent@bent.party Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 34465683+rkishan516@users.noreply.github.com fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 matanlurey@users.noreply.github.com Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 bkonyi@google.com [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 matanlurey@users.noreply.github.com Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 victorsanniay@gmail.com Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 rmacnak@google.com Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 victorsanniay@gmail.com Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 victorsanniay@gmail.com Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 engine-flutter-autoroll@skia.org Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 68449066+zijiehe-google-com@users.noreply.github.com [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 lukin.bogdan.a@gmail.com Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 engine-flutter-autoroll@skia.org Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122)
2025-04-14 jacksongardner@google.com [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 jason-simmons@users.noreply.github.com Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 34871572+gmackall@users.noreply.github.com [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 1063596+reidbaker@users.noreply.github.com Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 1063596+reidbaker@users.noreply.github.com Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 jonahwilliams@google.com [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 jonahwilliams@google.com [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 34871572+gmackall@users.noreply.github.com Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 koji.wakamiya@gmail.com [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 jonahwilliams@google.com [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 56130129+MaironLucas@users.noreply.github.com modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 737941+loic-sharma@users.noreply.github.com [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 engine-flutter-autoroll@skia.org Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982)
2025-04-11 jonahwilliams@google.com [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 bkonyi@google.com Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 dacoharkes@google.com [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 engine-flutter-autoroll@skia.org Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 dacoharkes@google.com [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 jonahwilliams@google.com [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 jonahwilliams@google.com [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 rmolivares@renzo-olivares.dev Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 engine-flutter-autoroll@skia.org Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Manual roll Flutter from 30e53b0 to db68c95 (98 revisions) (flutter#9092
35ba046 
)

Manual roll Flutter from 30e53b0 to db68c95 (98 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@30e53b0...db68c95

2025-04-15 aam@google.com [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 engine-flutter-autoroll@skia.org Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218)
2025-04-15 34465683+rkishan516@users.noreply.github.com Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 36861262+QuncCccccc@users.noreply.github.com Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 bent@bent.party Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 34465683+rkishan516@users.noreply.github.com fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 matanlurey@users.noreply.github.com Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 bkonyi@google.com [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 matanlurey@users.noreply.github.com Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 victorsanniay@gmail.com Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 rmacnak@google.com Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 victorsanniay@gmail.com Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 victorsanniay@gmail.com Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 engine-flutter-autoroll@skia.org Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 68449066+zijiehe-google-com@users.noreply.github.com [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 lukin.bogdan.a@gmail.com Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 engine-flutter-autoroll@skia.org Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122)
2025-04-14 jacksongardner@google.com [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 jason-simmons@users.noreply.github.com Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 34871572+gmackall@users.noreply.github.com [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 1063596+reidbaker@users.noreply.github.com Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 1063596+reidbaker@users.noreply.github.com Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 jonahwilliams@google.com [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 jonahwilliams@google.com [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 34871572+gmackall@users.noreply.github.com Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 koji.wakamiya@gmail.com [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 jonahwilliams@google.com [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 56130129+MaironLucas@users.noreply.github.com modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 737941+loic-sharma@users.noreply.github.com [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 engine-flutter-autoroll@skia.org Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982)
2025-04-11 jonahwilliams@google.com [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 bkonyi@google.com Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 dacoharkes@google.com [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 engine-flutter-autoroll@skia.org Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 dacoharkes@google.com [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 jonahwilliams@google.com [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 jonahwilliams@google.com [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 rmolivares@renzo-olivares.dev Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 engine-flutter-autoroll@skia.org Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
02008f0 [native assets] Use workspace pubspec for user-defines (flutt…
98d04af 
…er/flutter#166977)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
02008f0 [native assets] Use workspace pubspec for user-defines (flutt…
2c09279 
…er/flutter#166977)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@dcharkes @romanejaquez
[native assets] Use workspace pubspec for user-defines (flutter#166977)
998e7cf 
If pub workspaces are used, then native assets are shared across the
whole pub workspace. Using a different user-define, invalidates the
cache. Therefore, we want to avoid having different user-defines in
different pubspecs belonging to the same workspace. So, only use the
workspace pubspec for user-defines.

Analogous Dart SDK CL:
https://dart-review.googlesource.com/c/sdk/+/422101

### Testing

Covered by the integration tests added in
flutter#166940 for user-defines.

### Design discussion

We could allow adding user-defines in root package pubspecs later, but
this will likely deteriorate caching behavior (either invalidating the
cache often, or requiring a cache directory per root package, which
increases latency for new root packages).

Also, we'd likely add command-line user-defines later, these are
expected to deteriorate caching behavior.

For design discussion, refer to:

* dart-lang/native#39
* dart-lang/native#2187
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
02008f0 [native assets] Use workspace pubspec for user-defines (flutt…
16d03a5 
…er/flutter#166977)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
02008f0 [native assets] Use workspace pubspec for user-defines (flutt…
d14713e 
…er/flutter#166977)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
02008f0 [native assets] Use workspace pubspec for user-defines (flutt…
5aed51a 
…er/flutter#166977)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkonyi bkonyi bkonyi approved these changes

@mosuem mosuem Awaiting requested review from mosuem

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dcharkes @bkonyi