Persistent CupertinoListTile leading and trailing #166799

victorsanni · 2025-04-08T23:33:50Z

The bug occurs because the background color passed into the underlying Container changes from null to backgroundColorActivated. Under the hood, the Container wraps its child in a ColoredBox only if the color is non-null. So the extra wrapping with a ColoredBox happening mid-animation breaks reparenting, causing the widgets to be replaced/inflated instead of updated.

Before

list_tile_before.mov

After

list_tile_after.mov

Fixes CupertinoListTile animations are not running when pressing longer

Sample code

import 'package:flutter/cupertino.dart';

void main() => runApp(const ListTileApp());

class ListTileApp extends StatelessWidget {
  const ListTileApp({super.key});

  @override
  Widget build(BuildContext context) {
    return CupertinoApp(home: const ListTileExample());
  }
}

class ListTileExample extends StatefulWidget {
  const ListTileExample({super.key});

  @override
  State<ListTileExample> createState() => _ListTileExampleState();
}

class _ListTileExampleState extends State<ListTileExample> {
  bool _pushedToggle = false;

  void _toggle() {
    setState(() {
      _pushedToggle = !_pushedToggle;
    });
  }

  @override
  Widget build(BuildContext context) {
    return CupertinoPageScaffold(
      child: Center(
        child: SizedBox(
          height: 40,
          child: CupertinoListTile(
              onTap: _toggle,
              title: Center(
                child: Text(
                  'Toggle',
                ),
              ),
              leading: CupertinoSwitch(
                value: _pushedToggle,
                onChanged: (_) {},
              ),
              trailing: CupertinoSwitch(
                value: _pushedToggle,
                onChanged: (_) {},
              )),
        ),
      ),
    );
  }
}

flutter-dashboard · 2025-04-08T23:33:53Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

flutter-dashboard · 2025-04-08T23:52:01Z

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

LongCatIsLooong · 2025-04-14T15:41:43Z

Could you add an explanation as to why the states were lost without the global keys? Is it because of the Container?

LongCatIsLooong

LGTM

packages/flutter/lib/src/cupertino/list_tile.dart

…utter#166799)

Manual roll Flutter from 30e53b0 to db68c95 (98 revisions) Manual roll requested by tarrinneal@google.com flutter/flutter@30e53b0...db68c95 2025-04-15 aam@google.com [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212) 2025-04-15 engine-flutter-autoroll@skia.org Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218) 2025-04-15 34465683+rkishan516@users.noreply.github.com Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473) 2025-04-15 36861262+QuncCccccc@users.noreply.github.com Add Irish(ga) to Flutter (flutter/flutter#167129) 2025-04-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213) 2025-04-15 bent@bent.party Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639) 2025-04-15 34465683+rkishan516@users.noreply.github.com fix: Update time picker dialog input size (flutter/flutter#163184) 2025-04-15 matanlurey@users.noreply.github.com Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204) 2025-04-15 bkonyi@google.com [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001) 2025-04-15 matanlurey@users.noreply.github.com Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206) 2025-04-15 victorsanniay@gmail.com Persistent CupertinoListTile leading and trailing (flutter/flutter#166799) 2025-04-15 rmacnak@google.com Add buildroot compatibility for HWASAN. (flutter/flutter#167133) 2025-04-15 victorsanniay@gmail.com Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569) 2025-04-15 victorsanniay@gmail.com Clip bottom widgets in nav bar transition (flutter/flutter#166705) 2025-04-14 engine-flutter-autoroll@skia.org Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132) 2025-04-14 68449066+zijiehe-google-com@users.noreply.github.com [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929) 2025-04-14 lukin.bogdan.a@gmail.com Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916) 2025-04-14 engine-flutter-autoroll@skia.org Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122) 2025-04-14 jacksongardner@google.com [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997) 2025-04-14 jason-simmons@users.noreply.github.com Remove some unused third party library build scripts (flutter/flutter#166960) 2025-04-14 34871572+gmackall@users.noreply.github.com [reland] Fix regression in NDK version checking (flutter/flutter#167011) 2025-04-14 1063596+reidbaker@users.noreply.github.com Add network permissions information to the dart doc of network image. (flutter/flutter#167110) 2025-04-14 1063596+reidbaker@users.noreply.github.com Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994) 2025-04-12 jonahwilliams@google.com [Impeller] various iOS cleanups. (flutter/flutter#166859) 2025-04-11 jonahwilliams@google.com [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007) 2025-04-11 34871572+gmackall@users.noreply.github.com Fix regression in NDK version checking (flutter/flutter#166998) 2025-04-11 koji.wakamiya@gmail.com [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637) 2025-04-11 jonahwilliams@google.com [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957) 2025-04-11 56130129+MaironLucas@users.noreply.github.com modify toggle mode style with DatePickerTheme (flutter/flutter#164102) 2025-04-11 737941+loic-sharma@users.noreply.github.com [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990) 2025-04-11 engine-flutter-autoroll@skia.org Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982) 2025-04-11 jonahwilliams@google.com [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941) 2025-04-11 bkonyi@google.com Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877) 2025-04-11 dacoharkes@google.com [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977) 2025-04-11 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#166969) 2025-04-11 engine-flutter-autoroll@skia.org Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966) 2025-04-11 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963) 2025-04-11 dacoharkes@google.com [native assets] Support user-defines in pubspec (flutter/flutter#166940) 2025-04-11 jonahwilliams@google.com [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892) 2025-04-11 jonahwilliams@google.com [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943) 2025-04-11 rmolivares@renzo-olivares.dev Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889) 2025-04-11 engine-flutter-autoroll@skia.org Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955) ...

@OverRide

The bug occurs because the background color passed into the underlying `Container` changes from null to `backgroundColorActivated`. Under the hood, the `Container` wraps its child in a `ColoredBox` only if the color is non-null. So the extra wrapping with a `ColoredBox` happening mid-animation breaks reparenting, causing the widgets to be replaced/inflated instead of updated. ### Before https://github.com/user-attachments/assets/ca0b657a-1340-405f-8c1d-34b34366b994 ### After https://github.com/user-attachments/assets/8445c55c-0d5d-4b5f-96d2-4f12d908bdec Fixes [CupertinoListTile animations are not running when pressing longer](flutter#153225) <details> <summary>Sample code</summary> ```dart import 'package:flutter/cupertino.dart'; void main() => runApp(const ListTileApp()); class ListTileApp extends StatelessWidget { const ListTileApp({super.key}); @OverRide Widget build(BuildContext context) { return CupertinoApp(home: const ListTileExample()); } } class ListTileExample extends StatefulWidget { const ListTileExample({super.key}); @OverRide State<ListTileExample> createState() => _ListTileExampleState(); } class _ListTileExampleState extends State<ListTileExample> { bool _pushedToggle = false; void _toggle() { setState(() { _pushedToggle = !_pushedToggle; }); } @OverRide Widget build(BuildContext context) { return CupertinoPageScaffold( child: Center( child: SizedBox( height: 40, child: CupertinoListTile( onTap: _toggle, title: Center( child: Text( 'Toggle', ), ), leading: CupertinoSwitch( value: _pushedToggle, onChanged: (_) {}, ), trailing: CupertinoSwitch( value: _pushedToggle, onChanged: (_) {}, )), ), ), ); } } ``` </details>

…(#9092) Manual roll Flutter from 30e53b0d9caa to db68c950c599 (98 revisions) Manual roll requested by tarrinneal@google.com flutter/flutter@30e53b0...db68c95 2025-04-15 aam@google.com [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212) 2025-04-15 engine-flutter-autoroll@skia.org Roll Packages from 853e96a to a5ed6cb (4 revisions) (flutter/flutter#167218) 2025-04-15 34465683+rkishan516@users.noreply.github.com Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473) 2025-04-15 36861262+QuncCccccc@users.noreply.github.com Add Irish(ga) to Flutter (flutter/flutter#167129) 2025-04-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213) 2025-04-15 bent@bent.party Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639) 2025-04-15 34465683+rkishan516@users.noreply.github.com fix: Update time picker dialog input size (flutter/flutter#163184) 2025-04-15 matanlurey@users.noreply.github.com Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204) 2025-04-15 bkonyi@google.com [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001) 2025-04-15 matanlurey@users.noreply.github.com Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206) 2025-04-15 victorsanniay@gmail.com Persistent CupertinoListTile leading and trailing (flutter/flutter#166799) 2025-04-15 rmacnak@google.com Add buildroot compatibility for HWASAN. (flutter/flutter#167133) 2025-04-15 victorsanniay@gmail.com Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569) 2025-04-15 victorsanniay@gmail.com Clip bottom widgets in nav bar transition (flutter/flutter#166705) 2025-04-14 engine-flutter-autoroll@skia.org Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132) 2025-04-14 68449066+zijiehe-google-com@users.noreply.github.com [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929) 2025-04-14 lukin.bogdan.a@gmail.com Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916) 2025-04-14 engine-flutter-autoroll@skia.org Roll Packages from 4808eff to 853e96a (1 revision) (flutter/flutter#167122) 2025-04-14 jacksongardner@google.com [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997) 2025-04-14 jason-simmons@users.noreply.github.com Remove some unused third party library build scripts (flutter/flutter#166960) 2025-04-14 34871572+gmackall@users.noreply.github.com [reland] Fix regression in NDK version checking (flutter/flutter#167011) 2025-04-14 1063596+reidbaker@users.noreply.github.com Add network permissions information to the dart doc of network image. (flutter/flutter#167110) 2025-04-14 1063596+reidbaker@users.noreply.github.com Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994) 2025-04-12 jonahwilliams@google.com [Impeller] various iOS cleanups. (flutter/flutter#166859) 2025-04-11 jonahwilliams@google.com [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007) 2025-04-11 34871572+gmackall@users.noreply.github.com Fix regression in NDK version checking (flutter/flutter#166998) 2025-04-11 koji.wakamiya@gmail.com [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637) 2025-04-11 jonahwilliams@google.com [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957) 2025-04-11 56130129+MaironLucas@users.noreply.github.com modify toggle mode style with DatePickerTheme (flutter/flutter#164102) 2025-04-11 737941+loic-sharma@users.noreply.github.com [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990) 2025-04-11 engine-flutter-autoroll@skia.org Roll Packages from b2c45f9 to 4808eff (2 revisions) (flutter/flutter#166982) 2025-04-11 jonahwilliams@google.com [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941) 2025-04-11 bkonyi@google.com Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877) 2025-04-11 dacoharkes@google.com [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977) 2025-04-11 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#166969) 2025-04-11 engine-flutter-autoroll@skia.org Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966) 2025-04-11 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963) 2025-04-11 dacoharkes@google.com [native assets] Support user-defines in pubspec (flutter/flutter#166940) 2025-04-11 jonahwilliams@google.com [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892) 2025-04-11 jonahwilliams@google.com [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943) 2025-04-11 rmolivares@renzo-olivares.dev Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889) 2025-04-11 engine-flutter-autoroll@skia.org Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955) ...

) Manual roll Flutter from 30e53b0 to db68c95 (98 revisions) Manual roll requested by tarrinneal@google.com flutter/flutter@30e53b0...db68c95 2025-04-15 aam@google.com [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212) 2025-04-15 engine-flutter-autoroll@skia.org Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218) 2025-04-15 34465683+rkishan516@users.noreply.github.com Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473) 2025-04-15 36861262+QuncCccccc@users.noreply.github.com Add Irish(ga) to Flutter (flutter/flutter#167129) 2025-04-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213) 2025-04-15 bent@bent.party Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639) 2025-04-15 34465683+rkishan516@users.noreply.github.com fix: Update time picker dialog input size (flutter/flutter#163184) 2025-04-15 matanlurey@users.noreply.github.com Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204) 2025-04-15 bkonyi@google.com [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001) 2025-04-15 matanlurey@users.noreply.github.com Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206) 2025-04-15 victorsanniay@gmail.com Persistent CupertinoListTile leading and trailing (flutter/flutter#166799) 2025-04-15 rmacnak@google.com Add buildroot compatibility for HWASAN. (flutter/flutter#167133) 2025-04-15 victorsanniay@gmail.com Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569) 2025-04-15 victorsanniay@gmail.com Clip bottom widgets in nav bar transition (flutter/flutter#166705) 2025-04-14 engine-flutter-autoroll@skia.org Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132) 2025-04-14 68449066+zijiehe-google-com@users.noreply.github.com [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929) 2025-04-14 lukin.bogdan.a@gmail.com Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916) 2025-04-14 engine-flutter-autoroll@skia.org Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122) 2025-04-14 jacksongardner@google.com [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997) 2025-04-14 jason-simmons@users.noreply.github.com Remove some unused third party library build scripts (flutter/flutter#166960) 2025-04-14 34871572+gmackall@users.noreply.github.com [reland] Fix regression in NDK version checking (flutter/flutter#167011) 2025-04-14 1063596+reidbaker@users.noreply.github.com Add network permissions information to the dart doc of network image. (flutter/flutter#167110) 2025-04-14 1063596+reidbaker@users.noreply.github.com Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994) 2025-04-12 jonahwilliams@google.com [Impeller] various iOS cleanups. (flutter/flutter#166859) 2025-04-11 jonahwilliams@google.com [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007) 2025-04-11 34871572+gmackall@users.noreply.github.com Fix regression in NDK version checking (flutter/flutter#166998) 2025-04-11 koji.wakamiya@gmail.com [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637) 2025-04-11 jonahwilliams@google.com [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957) 2025-04-11 56130129+MaironLucas@users.noreply.github.com modify toggle mode style with DatePickerTheme (flutter/flutter#164102) 2025-04-11 737941+loic-sharma@users.noreply.github.com [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990) 2025-04-11 engine-flutter-autoroll@skia.org Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982) 2025-04-11 jonahwilliams@google.com [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941) 2025-04-11 bkonyi@google.com Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877) 2025-04-11 dacoharkes@google.com [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977) 2025-04-11 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#166969) 2025-04-11 engine-flutter-autoroll@skia.org Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966) 2025-04-11 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963) 2025-04-11 dacoharkes@google.com [native assets] Support user-defines in pubspec (flutter/flutter#166940) 2025-04-11 jonahwilliams@google.com [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892) 2025-04-11 jonahwilliams@google.com [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943) 2025-04-11 rmolivares@renzo-olivares.dev Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889) 2025-04-11 engine-flutter-autoroll@skia.org Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955) ...

…utter#166799)

@OverRide

The bug occurs because the background color passed into the underlying `Container` changes from null to `backgroundColorActivated`. Under the hood, the `Container` wraps its child in a `ColoredBox` only if the color is non-null. So the extra wrapping with a `ColoredBox` happening mid-animation breaks reparenting, causing the widgets to be replaced/inflated instead of updated. ### Before https://github.com/user-attachments/assets/ca0b657a-1340-405f-8c1d-34b34366b994 ### After https://github.com/user-attachments/assets/8445c55c-0d5d-4b5f-96d2-4f12d908bdec Fixes [CupertinoListTile animations are not running when pressing longer](flutter#153225) <details> <summary>Sample code</summary> ```dart import 'package:flutter/cupertino.dart'; void main() => runApp(const ListTileApp()); class ListTileApp extends StatelessWidget { const ListTileApp({super.key}); @OverRide Widget build(BuildContext context) { return CupertinoApp(home: const ListTileExample()); } } class ListTileExample extends StatefulWidget { const ListTileExample({super.key}); @OverRide State<ListTileExample> createState() => _ListTileExampleState(); } class _ListTileExampleState extends State<ListTileExample> { bool _pushedToggle = false; void _toggle() { setState(() { _pushedToggle = !_pushedToggle; }); } @OverRide Widget build(BuildContext context) { return CupertinoPageScaffold( child: Center( child: SizedBox( height: 40, child: CupertinoListTile( onTap: _toggle, title: Center( child: Text( 'Toggle', ), ), leading: CupertinoSwitch( value: _pushedToggle, onChanged: (_) {}, ), trailing: CupertinoSwitch( value: _pushedToggle, onChanged: (_) {}, )), ), ), ); } } ``` </details>

…utter#166799)

Persistent CupertinoListTile leading and trailing

7bd9e80

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Apr 8, 2025

victorsanni requested review from LongCatIsLooong and MitchellGoodwin April 8, 2025 23:34

Merge branch 'master' into animate-list-tile

d79f866

victorsanni marked this pull request as draft April 8, 2025 23:49

Add test

ddb6c8c

victorsanni marked this pull request as ready for review April 9, 2025 22:49

victorsanni added 2 commits April 9, 2025 18:49

Merge branch 'master' into animate-list-tile

4e94eed

Merge branch 'master' into animate-list-tile

b861c66

victorsanni added 2 commits April 14, 2025 13:34

Replace Container with ConstrainedBox + ColoredBox

0978ac4

Merge branch 'master' into animate-list-tile

e6e2018

LongCatIsLooong approved these changes Apr 14, 2025

View reviewed changes

packages/flutter/lib/src/cupertino/list_tile.dart Show resolved Hide resolved

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2025

auto-submit bot added this pull request to the merge queue Apr 15, 2025

Merged via the queue into flutter:master with commit 77c42fb Apr 15, 2025
75 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2025

engine-flutter-autoroll mentioned this pull request Apr 15, 2025

Roll Flutter from 30e53b0d9caa to 77c42fbd22fe (88 revisions) flutter/packages#9084

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025

77c42fb Persistent CupertinoListTile leading and trailing (flutter/fl…

e9cf2b0

…utter#166799)

engine-flutter-autoroll mentioned this pull request Apr 15, 2025

Roll Flutter from 30e53b0d9caa to 427f8c8e1569 (89 revisions) flutter/packages#9085

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025

77c42fb Persistent CupertinoListTile leading and trailing (flutter/fl…

aa61345

…utter#166799)

engine-flutter-autoroll mentioned this pull request Apr 15, 2025

Roll Flutter from 30e53b0d9caa to 3595e7dad098 (90 revisions) flutter/packages#9087

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025

77c42fb Persistent CupertinoListTile leading and trailing (flutter/fl…

985e43e

…utter#166799)

engine-flutter-autoroll mentioned this pull request Apr 15, 2025

Roll Flutter from 30e53b0d9caa to 38eaface2ffe (91 revisions) flutter/packages#9088

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025

77c42fb Persistent CupertinoListTile leading and trailing (flutter/fl…

73007a2

…utter#166799)

engine-flutter-autoroll mentioned this pull request Apr 15, 2025

Manual roll Flutter from 30e53b0d9caa to db68c950c599 (98 revisions) flutter/packages#9092

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025

77c42fb Persistent CupertinoListTile leading and trailing (flutter/fl…

2340d88

…utter#166799)

Piinks mentioned this pull request Apr 18, 2025

Flutter Notable Commits - 2025 #161460

Open

victorsanni deleted the animate-list-tile branch July 1, 2025 20:02

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

77c42fb Persistent CupertinoListTile leading and trailing (flutter/fl…

03a8129

…utter#166799)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

77c42fb Persistent CupertinoListTile leading and trailing (flutter/fl…

dcf4ab2

…utter#166799)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

77c42fb Persistent CupertinoListTile leading and trailing (flutter/fl…

521947e

…utter#166799)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

77c42fb Persistent CupertinoListTile leading and trailing (flutter/fl…

82dc89f

…utter#166799)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

77c42fb Persistent CupertinoListTile leading and trailing (flutter/fl…

8593c23

…utter#166799)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Persistent CupertinoListTile leading and trailing #166799

Persistent CupertinoListTile leading and trailing #166799

victorsanni commented Apr 8, 2025 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Apr 8, 2025

Uh oh!

flutter-dashboard bot commented Apr 8, 2025

Uh oh!

LongCatIsLooong commented Apr 14, 2025

Uh oh!

LongCatIsLooong left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Persistent CupertinoListTile leading and trailing #166799

Persistent CupertinoListTile leading and trailing #166799

Conversation

victorsanni commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before

After

Uh oh!

flutter-dashboard bot commented Apr 8, 2025

Uh oh!

flutter-dashboard bot commented Apr 8, 2025

Uh oh!

LongCatIsLooong commented Apr 14, 2025

Uh oh!

LongCatIsLooong left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

victorsanni commented Apr 8, 2025 •

edited

Loading