Skip to content

[Impeller] fix min filter for GL external textures. #166224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 31, 2025
Merged

[Impeller] fix min filter for GL external textures. #166224

auto-submit merged 1 commit into from
Mar 31, 2025

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Mar 30, 2025

Fixes #165976

Pass through sampler options for oes external textures.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Mar 30, 2025
@jonahwilliams jonahwilliams marked this pull request as ready for review March 30, 2025 18:40
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 30, 2025

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #166224 at sha 20840f4

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Mar 30, 2025
@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Mar 30, 2025

Tests are updated goldens.

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 31, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 31, 2025
Merged via the queue into flutter:master with commit 8d7e860 Mar 31, 2025
174 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 31, 2025
@holzgeist holzgeist mentioned this pull request Mar 31, 2025
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8d7e860 [Impeller] fix min filter for GL external textures. (flutter/…
ed57373 
…flutter#166224)
@holzgeist
Copy link
Contributor

holzgeist commented Mar 31, 2025

Thanks @jonahwilliams for the fix!
I can confirm that it works

Is there any chance that this will be included in 3.29.3 (if there will be such a release)

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8d7e860 [Impeller] fix min filter for GL external textures. (flutter/…
1ecb044 
…flutter#166224)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8d7e860 [Impeller] fix min filter for GL external textures. (flutter/…
ab25d44 
…flutter#166224)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8d7e860 [Impeller] fix min filter for GL external textures. (flutter/…
23cb14e 
…flutter#166224)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8d7e860 [Impeller] fix min filter for GL external textures. (flutter/…
f64848b 
…flutter#166224)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8d7e860 [Impeller] fix min filter for GL external textures. (flutter/…
8e9a25b 
…flutter#166224)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
8d7e860 [Impeller] fix min filter for GL external textures. (flutter/…
b15c874 
…flutter#166224)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
8d7e860 [Impeller] fix min filter for GL external textures. (flutter/…
8547739 
…flutter#166224)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
8d7e860 [Impeller] fix min filter for GL external textures. (flutter/…
cf7538e 
…flutter#166224)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
8d7e860 [Impeller] fix min filter for GL external textures. (flutter/…
f688c4d 
…flutter#166224)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 2, 2025
@engine-flutter-autoroll
8d7e860 [Impeller] fix min filter for GL external textures. (flutter/…
5d9cc38 
…flutter#166224)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 2, 2025
@engine-flutter-autoroll
8d7e860 [Impeller] fix min filter for GL external textures. (flutter/…
7a83519 
…flutter#166224)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 2, 2025
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 2, 2025
@engine-flutter-autoroll
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions) (#8985)
8f5844a 
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions)

flutter/flutter@05b5e79...a0b1b32

2025-04-01 engine-flutter-autoroll@skia.org Roll Dart SDK from b4d374ec59ec to 4e1f02bc704f (2 revisions) (flutter/flutter#166342)
2025-04-01 15619084+vashworth@users.noreply.github.com Trim any text before osascript JSON response (flutter/flutter#166296)
2025-04-01 benthillerkus@gmail.com [Gen-l10n] Add `Message.resourceId` and `locale` to all `L10nException` error messages (flutter/flutter#163654)
2025-04-01 me@nils.re Add `--ignore-timeouts` flag for `flutter test` command (flutter/flutter#164437)
2025-04-01 stuartmorgan@google.com Update TESTOWNERS username (flutter/flutter#166191)
2025-04-01 engine-flutter-autoroll@skia.org Roll Skia from 4b07443e6071 to 52cbb917fffd (4 revisions) (flutter/flutter#166329)
2025-04-01 engine-flutter-autoroll@skia.org Roll Dart SDK from 6b07a09cbd2d to b4d374ec59ec (2 revisions) (flutter/flutter#166321)
2025-04-01 737941+loic-sharma@users.noreply.github.com [tool] Improve using project files in build targets (flutter/flutter#166211)
2025-04-01 robert.ancell@canonical.com Rename FlRenderer to FlCompositorOpenGL (flutter/flutter#166037)
2025-04-01 kevmoo@users.noreply.github.com [engine, web_ui] Fix instances of library_private_types_in_public_api (flutter/flutter#166156)
2025-04-01 engine-flutter-autoroll@skia.org Roll Dart SDK from 509faa921c95 to 6b07a09cbd2d (1 revision) (flutter/flutter#166301)
2025-04-01 jonahwilliams@google.com [Impeller] small cpu perf for text contents. (flutter/flutter#166199)
2025-04-01 jonahwilliams@google.com [android_engine_test] disable old HC mode tests. (flutter/flutter#166293)
2025-04-01 30870216+gaaclarke@users.noreply.github.com [impeller] fixes diagonal antialiased lines (flutter/flutter#166298)
2025-04-01 engine-flutter-autoroll@skia.org Roll Skia from 5f262bd2cbb4 to 4b07443e6071 (10 revisions) (flutter/flutter#166299)
2025-03-31 flar@google.com [Impeller] Directly tessellate conics to linear path segments (flutter/flutter#166165)
2025-03-31 737941+loic-sharma@users.noreply.github.com [tool] Don't write the .flutter-plugins-dependencies file if it is unchanged (flutter/flutter#166164)
2025-03-31 34871572+gmackall@users.noreply.github.com Move `.cxx` directory out of `android/app` (flutter/flutter#166277)
2025-03-31 4nahom@gmail.com Fix typo in carousel.dart (flutter/flutter#164727)
2025-03-31 engine-flutter-autoroll@skia.org Roll Dart SDK from c5fa06710bb6 to 509faa921c95 (1 revision) (flutter/flutter#166283)
2025-03-31 conner@emerssso.com Public nodes needing paint or layout (flutter/flutter#166148)
2025-03-31 benthillerkus@gmail.com [Gen-l10n] Infer placeholder types on both templates and localizations (flutter/flutter#163690)
2025-03-31 koji.wakamiya@gmail.com [Engine][iOS] Cancel animation when recieved `UIKeyboardWillHideNotification` with duration 0.0 (flutter/flutter#164884)
2025-03-31 51209748+gbbosak@users.noreply.github.com [fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead (flutter/flutter#162780)
2025-03-31 jessiewong401@gmail.com Updated to latest AVD to Support Android 16 (API 36) (flutter/flutter#165926)
2025-03-31 34465683+rkishan516@users.noreply.github.com Feat: Add brightnessOf method for theme (flutter/flutter#163733)
2025-03-31 fluttergithubbot@gmail.com Marks Linux_mokey new_gallery__crane_perf to be flaky (flutter/flutter#165964)
2025-03-31 bkonyi@google.com [ Tool ] Correctly select entrypoint target for web build from positional argument list (flutter/flutter#166260)
2025-03-31 jonahwilliams@google.com [Impeller] remove validation warning ignores. (flutter/flutter#166205)
2025-03-31 jonahwilliams@google.com [Impeller] handle shader ordering bug on macOS. (flutter/flutter#165937)
2025-03-31 737941+loic-sharma@users.noreply.github.com Fix CODEOWNERS for the iOS review team (flutter/flutter#166178)
2025-03-31 bkonyi@google.com Remove `<meta content="IE=Edge" http-equiv="X-UA-Compatible">` (flutter/flutter#166252)
2025-03-31 engine-flutter-autoroll@skia.org Roll Dart SDK from b9c35e05feb5 to c5fa06710bb6 (1 revision) (flutter/flutter#166251)
2025-03-31 engine-flutter-autoroll@skia.org Roll Skia from 418c68ea5ccb to 5f262bd2cbb4 (2 revisions) (flutter/flutter#166244)
2025-03-31 engine-flutter-autoroll@skia.org Roll Skia from b6a3bbd1d153 to 418c68ea5ccb (1 revision) (flutter/flutter#166236)
2025-03-31 jonahwilliams@google.com [Impeller] fix min filter for GL external textures. (flutter/flutter#166224)
2025-03-31 engine-flutter-autoroll@skia.org Roll Skia from 10f4cf9a817d to b6a3bbd1d153 (13 revisions) (flutter/flutter#166231)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
masterromuald pushed a commit to masterromuald/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll @masterromuald
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions) (flutter#8985)
894e301 
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions)

flutter/flutter@05b5e79...a0b1b32

2025-04-01 engine-flutter-autoroll@skia.org Roll Dart SDK from b4d374ec59ec to 4e1f02bc704f (2 revisions) (flutter/flutter#166342)
2025-04-01 15619084+vashworth@users.noreply.github.com Trim any text before osascript JSON response (flutter/flutter#166296)
2025-04-01 benthillerkus@gmail.com [Gen-l10n] Add `Message.resourceId` and `locale` to all `L10nException` error messages (flutter/flutter#163654)
2025-04-01 me@nils.re Add `--ignore-timeouts` flag for `flutter test` command (flutter/flutter#164437)
2025-04-01 stuartmorgan@google.com Update TESTOWNERS username (flutter/flutter#166191)
2025-04-01 engine-flutter-autoroll@skia.org Roll Skia from 4b07443e6071 to 52cbb917fffd (4 revisions) (flutter/flutter#166329)
2025-04-01 engine-flutter-autoroll@skia.org Roll Dart SDK from 6b07a09cbd2d to b4d374ec59ec (2 revisions) (flutter/flutter#166321)
2025-04-01 737941+loic-sharma@users.noreply.github.com [tool] Improve using project files in build targets (flutter/flutter#166211)
2025-04-01 robert.ancell@canonical.com Rename FlRenderer to FlCompositorOpenGL (flutter/flutter#166037)
2025-04-01 kevmoo@users.noreply.github.com [engine, web_ui] Fix instances of library_private_types_in_public_api (flutter/flutter#166156)
2025-04-01 engine-flutter-autoroll@skia.org Roll Dart SDK from 509faa921c95 to 6b07a09cbd2d (1 revision) (flutter/flutter#166301)
2025-04-01 jonahwilliams@google.com [Impeller] small cpu perf for text contents. (flutter/flutter#166199)
2025-04-01 jonahwilliams@google.com [android_engine_test] disable old HC mode tests. (flutter/flutter#166293)
2025-04-01 30870216+gaaclarke@users.noreply.github.com [impeller] fixes diagonal antialiased lines (flutter/flutter#166298)
2025-04-01 engine-flutter-autoroll@skia.org Roll Skia from 5f262bd2cbb4 to 4b07443e6071 (10 revisions) (flutter/flutter#166299)
2025-03-31 flar@google.com [Impeller] Directly tessellate conics to linear path segments (flutter/flutter#166165)
2025-03-31 737941+loic-sharma@users.noreply.github.com [tool] Don't write the .flutter-plugins-dependencies file if it is unchanged (flutter/flutter#166164)
2025-03-31 34871572+gmackall@users.noreply.github.com Move `.cxx` directory out of `android/app` (flutter/flutter#166277)
2025-03-31 4nahom@gmail.com Fix typo in carousel.dart (flutter/flutter#164727)
2025-03-31 engine-flutter-autoroll@skia.org Roll Dart SDK from c5fa06710bb6 to 509faa921c95 (1 revision) (flutter/flutter#166283)
2025-03-31 conner@emerssso.com Public nodes needing paint or layout (flutter/flutter#166148)
2025-03-31 benthillerkus@gmail.com [Gen-l10n] Infer placeholder types on both templates and localizations (flutter/flutter#163690)
2025-03-31 koji.wakamiya@gmail.com [Engine][iOS] Cancel animation when recieved `UIKeyboardWillHideNotification` with duration 0.0 (flutter/flutter#164884)
2025-03-31 51209748+gbbosak@users.noreply.github.com [fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead (flutter/flutter#162780)
2025-03-31 jessiewong401@gmail.com Updated to latest AVD to Support Android 16 (API 36) (flutter/flutter#165926)
2025-03-31 34465683+rkishan516@users.noreply.github.com Feat: Add brightnessOf method for theme (flutter/flutter#163733)
2025-03-31 fluttergithubbot@gmail.com Marks Linux_mokey new_gallery__crane_perf to be flaky (flutter/flutter#165964)
2025-03-31 bkonyi@google.com [ Tool ] Correctly select entrypoint target for web build from positional argument list (flutter/flutter#166260)
2025-03-31 jonahwilliams@google.com [Impeller] remove validation warning ignores. (flutter/flutter#166205)
2025-03-31 jonahwilliams@google.com [Impeller] handle shader ordering bug on macOS. (flutter/flutter#165937)
2025-03-31 737941+loic-sharma@users.noreply.github.com Fix CODEOWNERS for the iOS review team (flutter/flutter#166178)
2025-03-31 bkonyi@google.com Remove `<meta content="IE=Edge" http-equiv="X-UA-Compatible">` (flutter/flutter#166252)
2025-03-31 engine-flutter-autoroll@skia.org Roll Dart SDK from b9c35e05feb5 to c5fa06710bb6 (1 revision) (flutter/flutter#166251)
2025-03-31 engine-flutter-autoroll@skia.org Roll Skia from 418c68ea5ccb to 5f262bd2cbb4 (2 revisions) (flutter/flutter#166244)
2025-03-31 engine-flutter-autoroll@skia.org Roll Skia from b6a3bbd1d153 to 418c68ea5ccb (1 revision) (flutter/flutter#166236)
2025-03-31 jonahwilliams@google.com [Impeller] fix min filter for GL external textures. (flutter/flutter#166224)
2025-03-31 engine-flutter-autoroll@skia.org Roll Skia from 10f4cf9a817d to b6a3bbd1d153 (13 revisions) (flutter/flutter#166231)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Roll Flutter from 05b5e7910544 to a0b1b3253416 (37 revisions) (#8985)
1721bf2 
Roll Flutter from 05b5e7910544 to a0b1b3253416 (37 revisions)

flutter/flutter@05b5e79...a0b1b32

2025-04-01 engine-flutter-autoroll@skia.org Roll Dart SDK from b4d374ec59ec to 4e1f02bc704f (2 revisions) (flutter/flutter#166342)
2025-04-01 15619084+vashworth@users.noreply.github.com Trim any text before osascript JSON response (flutter/flutter#166296)
2025-04-01 benthillerkus@gmail.com [Gen-l10n] Add `Message.resourceId` and `locale` to all `L10nException` error messages (flutter/flutter#163654)
2025-04-01 me@nils.re Add `--ignore-timeouts` flag for `flutter test` command (flutter/flutter#164437)
2025-04-01 stuartmorgan@google.com Update TESTOWNERS username (flutter/flutter#166191)
2025-04-01 engine-flutter-autoroll@skia.org Roll Skia from 4b07443e6071 to 52cbb917fffd (4 revisions) (flutter/flutter#166329)
2025-04-01 engine-flutter-autoroll@skia.org Roll Dart SDK from 6b07a09cbd2d to b4d374ec59ec (2 revisions) (flutter/flutter#166321)
2025-04-01 737941+loic-sharma@users.noreply.github.com [tool] Improve using project files in build targets (flutter/flutter#166211)
2025-04-01 robert.ancell@canonical.com Rename FlRenderer to FlCompositorOpenGL (flutter/flutter#166037)
2025-04-01 kevmoo@users.noreply.github.com [engine, web_ui] Fix instances of library_private_types_in_public_api (flutter/flutter#166156)
2025-04-01 engine-flutter-autoroll@skia.org Roll Dart SDK from 509faa921c95 to 6b07a09cbd2d (1 revision) (flutter/flutter#166301)
2025-04-01 jonahwilliams@google.com [Impeller] small cpu perf for text contents. (flutter/flutter#166199)
2025-04-01 jonahwilliams@google.com [android_engine_test] disable old HC mode tests. (flutter/flutter#166293)
2025-04-01 30870216+gaaclarke@users.noreply.github.com [impeller] fixes diagonal antialiased lines (flutter/flutter#166298)
2025-04-01 engine-flutter-autoroll@skia.org Roll Skia from 5f262bd2cbb4 to 4b07443e6071 (10 revisions) (flutter/flutter#166299)
2025-03-31 flar@google.com [Impeller] Directly tessellate conics to linear path segments (flutter/flutter#166165)
2025-03-31 737941+loic-sharma@users.noreply.github.com [tool] Don't write the .flutter-plugins-dependencies file if it is unchanged (flutter/flutter#166164)
2025-03-31 34871572+gmackall@users.noreply.github.com Move `.cxx` directory out of `android/app` (flutter/flutter#166277)
2025-03-31 4nahom@gmail.com Fix typo in carousel.dart (flutter/flutter#164727)
2025-03-31 engine-flutter-autoroll@skia.org Roll Dart SDK from c5fa06710bb6 to 509faa921c95 (1 revision) (flutter/flutter#166283)
2025-03-31 conner@emerssso.com Public nodes needing paint or layout (flutter/flutter#166148)
2025-03-31 benthillerkus@gmail.com [Gen-l10n] Infer placeholder types on both templates and localizations (flutter/flutter#163690)
2025-03-31 koji.wakamiya@gmail.com [Engine][iOS] Cancel animation when recieved `UIKeyboardWillHideNotification` with duration 0.0 (flutter/flutter#164884)
2025-03-31 51209748+gbbosak@users.noreply.github.com [fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead (flutter/flutter#162780)
2025-03-31 jessiewong401@gmail.com Updated to latest AVD to Support Android 16 (API 36) (flutter/flutter#165926)
2025-03-31 34465683+rkishan516@users.noreply.github.com Feat: Add brightnessOf method for theme (flutter/flutter#163733)
2025-03-31 fluttergithubbot@gmail.com Marks Linux_mokey new_gallery__crane_perf to be flaky (flutter/flutter#165964)
2025-03-31 bkonyi@google.com [ Tool ] Correctly select entrypoint target for web build from positional argument list (flutter/flutter#166260)
2025-03-31 jonahwilliams@google.com [Impeller] remove validation warning ignores. (flutter/flutter#166205)
2025-03-31 jonahwilliams@google.com [Impeller] handle shader ordering bug on macOS. (flutter/flutter#165937)
2025-03-31 737941+loic-sharma@users.noreply.github.com Fix CODEOWNERS for the iOS review team (flutter/flutter#166178)
2025-03-31 bkonyi@google.com Remove `<meta content="IE=Edge" http-equiv="X-UA-Compatible">` (flutter/flutter#166252)
2025-03-31 engine-flutter-autoroll@skia.org Roll Dart SDK from b9c35e05feb5 to c5fa06710bb6 (1 revision) (flutter/flutter#166251)
2025-03-31 engine-flutter-autoroll@skia.org Roll Skia from 418c68ea5ccb to 5f262bd2cbb4 (2 revisions) (flutter/flutter#166244)
2025-03-31 engine-flutter-autoroll@skia.org Roll Skia from b6a3bbd1d153 to 418c68ea5ccb (1 revision) (flutter/flutter#166236)
2025-03-31 jonahwilliams@google.com [Impeller] fix min filter for GL external textures. (flutter/flutter#166224)
2025-03-31 engine-flutter-autoroll@skia.org Roll Skia from 10f4cf9a817d to b6a3bbd1d153 (13 revisions) (flutter/flutter#166231)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
8d7e860 [Impeller] fix min filter for GL external textures. (flutter/…
8165209 
…flutter#166224)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
8d7e860 [Impeller] fix min filter for GL external textures. (flutter/…
c6356db 
…flutter#166224)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
8d7e860 [Impeller] fix min filter for GL external textures. (flutter/…
3bc3b0b 
…flutter#166224)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions) (flutter#8985)
315d890 
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions)

flutter/flutter@05b5e79...a0b1b32

2025-04-01 engine-flutter-autoroll@skia.org Roll Dart SDK from b4d374ec59ec to 4e1f02bc704f (2 revisions) (flutter/flutter#166342)
2025-04-01 15619084+vashworth@users.noreply.github.com Trim any text before osascript JSON response (flutter/flutter#166296)
2025-04-01 benthillerkus@gmail.com [Gen-l10n] Add `Message.resourceId` and `locale` to all `L10nException` error messages (flutter/flutter#163654)
2025-04-01 me@nils.re Add `--ignore-timeouts` flag for `flutter test` command (flutter/flutter#164437)
2025-04-01 stuartmorgan@google.com Update TESTOWNERS username (flutter/flutter#166191)
2025-04-01 engine-flutter-autoroll@skia.org Roll Skia from 4b07443e6071 to 52cbb917fffd (4 revisions) (flutter/flutter#166329)
2025-04-01 engine-flutter-autoroll@skia.org Roll Dart SDK from 6b07a09cbd2d to b4d374ec59ec (2 revisions) (flutter/flutter#166321)
2025-04-01 737941+loic-sharma@users.noreply.github.com [tool] Improve using project files in build targets (flutter/flutter#166211)
2025-04-01 robert.ancell@canonical.com Rename FlRenderer to FlCompositorOpenGL (flutter/flutter#166037)
2025-04-01 kevmoo@users.noreply.github.com [engine, web_ui] Fix instances of library_private_types_in_public_api (flutter/flutter#166156)
2025-04-01 engine-flutter-autoroll@skia.org Roll Dart SDK from 509faa921c95 to 6b07a09cbd2d (1 revision) (flutter/flutter#166301)
2025-04-01 jonahwilliams@google.com [Impeller] small cpu perf for text contents. (flutter/flutter#166199)
2025-04-01 jonahwilliams@google.com [android_engine_test] disable old HC mode tests. (flutter/flutter#166293)
2025-04-01 30870216+gaaclarke@users.noreply.github.com [impeller] fixes diagonal antialiased lines (flutter/flutter#166298)
2025-04-01 engine-flutter-autoroll@skia.org Roll Skia from 5f262bd2cbb4 to 4b07443e6071 (10 revisions) (flutter/flutter#166299)
2025-03-31 flar@google.com [Impeller] Directly tessellate conics to linear path segments (flutter/flutter#166165)
2025-03-31 737941+loic-sharma@users.noreply.github.com [tool] Don't write the .flutter-plugins-dependencies file if it is unchanged (flutter/flutter#166164)
2025-03-31 34871572+gmackall@users.noreply.github.com Move `.cxx` directory out of `android/app` (flutter/flutter#166277)
2025-03-31 4nahom@gmail.com Fix typo in carousel.dart (flutter/flutter#164727)
2025-03-31 engine-flutter-autoroll@skia.org Roll Dart SDK from c5fa06710bb6 to 509faa921c95 (1 revision) (flutter/flutter#166283)
2025-03-31 conner@emerssso.com Public nodes needing paint or layout (flutter/flutter#166148)
2025-03-31 benthillerkus@gmail.com [Gen-l10n] Infer placeholder types on both templates and localizations (flutter/flutter#163690)
2025-03-31 koji.wakamiya@gmail.com [Engine][iOS] Cancel animation when recieved `UIKeyboardWillHideNotification` with duration 0.0 (flutter/flutter#164884)
2025-03-31 51209748+gbbosak@users.noreply.github.com [fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead (flutter/flutter#162780)
2025-03-31 jessiewong401@gmail.com Updated to latest AVD to Support Android 16 (API 36) (flutter/flutter#165926)
2025-03-31 34465683+rkishan516@users.noreply.github.com Feat: Add brightnessOf method for theme (flutter/flutter#163733)
2025-03-31 fluttergithubbot@gmail.com Marks Linux_mokey new_gallery__crane_perf to be flaky (flutter/flutter#165964)
2025-03-31 bkonyi@google.com [ Tool ] Correctly select entrypoint target for web build from positional argument list (flutter/flutter#166260)
2025-03-31 jonahwilliams@google.com [Impeller] remove validation warning ignores. (flutter/flutter#166205)
2025-03-31 jonahwilliams@google.com [Impeller] handle shader ordering bug on macOS. (flutter/flutter#165937)
2025-03-31 737941+loic-sharma@users.noreply.github.com Fix CODEOWNERS for the iOS review team (flutter/flutter#166178)
2025-03-31 bkonyi@google.com Remove `<meta content="IE=Edge" http-equiv="X-UA-Compatible">` (flutter/flutter#166252)
2025-03-31 engine-flutter-autoroll@skia.org Roll Dart SDK from b9c35e05feb5 to c5fa06710bb6 (1 revision) (flutter/flutter#166251)
2025-03-31 engine-flutter-autoroll@skia.org Roll Skia from 418c68ea5ccb to 5f262bd2cbb4 (2 revisions) (flutter/flutter#166244)
2025-03-31 engine-flutter-autoroll@skia.org Roll Skia from b6a3bbd1d153 to 418c68ea5ccb (1 revision) (flutter/flutter#166236)
2025-03-31 jonahwilliams@google.com [Impeller] fix min filter for GL external textures. (flutter/flutter#166224)
2025-03-31 engine-flutter-autoroll@skia.org Roll Skia from 10f4cf9a817d to b6a3bbd1d153 (13 revisions) (flutter/flutter#166231)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
[Impeller] fix min filter for GL external textures. (flutter#166224)
ec132fe 
Fixes flutter#165976

Pass through sampler options for oes external textures.
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions) (flutter#8985)
2e03ef8 
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions)

flutter/flutter@05b5e79...a0b1b32

2025-04-01 engine-flutter-autoroll@skia.org Roll Dart SDK from b4d374ec59ec to 4e1f02bc704f (2 revisions) (flutter/flutter#166342)
2025-04-01 15619084+vashworth@users.noreply.github.com Trim any text before osascript JSON response (flutter/flutter#166296)
2025-04-01 benthillerkus@gmail.com [Gen-l10n] Add `Message.resourceId` and `locale` to all `L10nException` error messages (flutter/flutter#163654)
2025-04-01 me@nils.re Add `--ignore-timeouts` flag for `flutter test` command (flutter/flutter#164437)
2025-04-01 stuartmorgan@google.com Update TESTOWNERS username (flutter/flutter#166191)
2025-04-01 engine-flutter-autoroll@skia.org Roll Skia from 4b07443e6071 to 52cbb917fffd (4 revisions) (flutter/flutter#166329)
2025-04-01 engine-flutter-autoroll@skia.org Roll Dart SDK from 6b07a09cbd2d to b4d374ec59ec (2 revisions) (flutter/flutter#166321)
2025-04-01 737941+loic-sharma@users.noreply.github.com [tool] Improve using project files in build targets (flutter/flutter#166211)
2025-04-01 robert.ancell@canonical.com Rename FlRenderer to FlCompositorOpenGL (flutter/flutter#166037)
2025-04-01 kevmoo@users.noreply.github.com [engine, web_ui] Fix instances of library_private_types_in_public_api (flutter/flutter#166156)
2025-04-01 engine-flutter-autoroll@skia.org Roll Dart SDK from 509faa921c95 to 6b07a09cbd2d (1 revision) (flutter/flutter#166301)
2025-04-01 jonahwilliams@google.com [Impeller] small cpu perf for text contents. (flutter/flutter#166199)
2025-04-01 jonahwilliams@google.com [android_engine_test] disable old HC mode tests. (flutter/flutter#166293)
2025-04-01 30870216+gaaclarke@users.noreply.github.com [impeller] fixes diagonal antialiased lines (flutter/flutter#166298)
2025-04-01 engine-flutter-autoroll@skia.org Roll Skia from 5f262bd2cbb4 to 4b07443e6071 (10 revisions) (flutter/flutter#166299)
2025-03-31 flar@google.com [Impeller] Directly tessellate conics to linear path segments (flutter/flutter#166165)
2025-03-31 737941+loic-sharma@users.noreply.github.com [tool] Don't write the .flutter-plugins-dependencies file if it is unchanged (flutter/flutter#166164)
2025-03-31 34871572+gmackall@users.noreply.github.com Move `.cxx` directory out of `android/app` (flutter/flutter#166277)
2025-03-31 4nahom@gmail.com Fix typo in carousel.dart (flutter/flutter#164727)
2025-03-31 engine-flutter-autoroll@skia.org Roll Dart SDK from c5fa06710bb6 to 509faa921c95 (1 revision) (flutter/flutter#166283)
2025-03-31 conner@emerssso.com Public nodes needing paint or layout (flutter/flutter#166148)
2025-03-31 benthillerkus@gmail.com [Gen-l10n] Infer placeholder types on both templates and localizations (flutter/flutter#163690)
2025-03-31 koji.wakamiya@gmail.com [Engine][iOS] Cancel animation when recieved `UIKeyboardWillHideNotification` with duration 0.0 (flutter/flutter#164884)
2025-03-31 51209748+gbbosak@users.noreply.github.com [fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead (flutter/flutter#162780)
2025-03-31 jessiewong401@gmail.com Updated to latest AVD to Support Android 16 (API 36) (flutter/flutter#165926)
2025-03-31 34465683+rkishan516@users.noreply.github.com Feat: Add brightnessOf method for theme (flutter/flutter#163733)
2025-03-31 fluttergithubbot@gmail.com Marks Linux_mokey new_gallery__crane_perf to be flaky (flutter/flutter#165964)
2025-03-31 bkonyi@google.com [ Tool ] Correctly select entrypoint target for web build from positional argument list (flutter/flutter#166260)
2025-03-31 jonahwilliams@google.com [Impeller] remove validation warning ignores. (flutter/flutter#166205)
2025-03-31 jonahwilliams@google.com [Impeller] handle shader ordering bug on macOS. (flutter/flutter#165937)
2025-03-31 737941+loic-sharma@users.noreply.github.com Fix CODEOWNERS for the iOS review team (flutter/flutter#166178)
2025-03-31 bkonyi@google.com Remove `<meta content="IE=Edge" http-equiv="X-UA-Compatible">` (flutter/flutter#166252)
2025-03-31 engine-flutter-autoroll@skia.org Roll Dart SDK from b9c35e05feb5 to c5fa06710bb6 (1 revision) (flutter/flutter#166251)
2025-03-31 engine-flutter-autoroll@skia.org Roll Skia from 418c68ea5ccb to 5f262bd2cbb4 (2 revisions) (flutter/flutter#166244)
2025-03-31 engine-flutter-autoroll@skia.org Roll Skia from b6a3bbd1d153 to 418c68ea5ccb (1 revision) (flutter/flutter#166236)
2025-03-31 jonahwilliams@google.com [Impeller] fix min filter for GL external textures. (flutter/flutter#166224)
2025-03-31 engine-flutter-autoroll@skia.org Roll Skia from 10f4cf9a817d to b6a3bbd1d153 (13 revisions) (flutter/flutter#166231)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions) (flutter#8985)
53ee18d 
Roll Flutter from 05b5e79 to a0b1b32 (37 revisions)

flutter/flutter@05b5e79...a0b1b32

2025-04-01 engine-flutter-autoroll@skia.org Roll Dart SDK from b4d374ec59ec to 4e1f02bc704f (2 revisions) (flutter/flutter#166342)
2025-04-01 15619084+vashworth@users.noreply.github.com Trim any text before osascript JSON response (flutter/flutter#166296)
2025-04-01 benthillerkus@gmail.com [Gen-l10n] Add `Message.resourceId` and `locale` to all `L10nException` error messages (flutter/flutter#163654)
2025-04-01 me@nils.re Add `--ignore-timeouts` flag for `flutter test` command (flutter/flutter#164437)
2025-04-01 stuartmorgan@google.com Update TESTOWNERS username (flutter/flutter#166191)
2025-04-01 engine-flutter-autoroll@skia.org Roll Skia from 4b07443e6071 to 52cbb917fffd (4 revisions) (flutter/flutter#166329)
2025-04-01 engine-flutter-autoroll@skia.org Roll Dart SDK from 6b07a09cbd2d to b4d374ec59ec (2 revisions) (flutter/flutter#166321)
2025-04-01 737941+loic-sharma@users.noreply.github.com [tool] Improve using project files in build targets (flutter/flutter#166211)
2025-04-01 robert.ancell@canonical.com Rename FlRenderer to FlCompositorOpenGL (flutter/flutter#166037)
2025-04-01 kevmoo@users.noreply.github.com [engine, web_ui] Fix instances of library_private_types_in_public_api (flutter/flutter#166156)
2025-04-01 engine-flutter-autoroll@skia.org Roll Dart SDK from 509faa921c95 to 6b07a09cbd2d (1 revision) (flutter/flutter#166301)
2025-04-01 jonahwilliams@google.com [Impeller] small cpu perf for text contents. (flutter/flutter#166199)
2025-04-01 jonahwilliams@google.com [android_engine_test] disable old HC mode tests. (flutter/flutter#166293)
2025-04-01 30870216+gaaclarke@users.noreply.github.com [impeller] fixes diagonal antialiased lines (flutter/flutter#166298)
2025-04-01 engine-flutter-autoroll@skia.org Roll Skia from 5f262bd2cbb4 to 4b07443e6071 (10 revisions) (flutter/flutter#166299)
2025-03-31 flar@google.com [Impeller] Directly tessellate conics to linear path segments (flutter/flutter#166165)
2025-03-31 737941+loic-sharma@users.noreply.github.com [tool] Don't write the .flutter-plugins-dependencies file if it is unchanged (flutter/flutter#166164)
2025-03-31 34871572+gmackall@users.noreply.github.com Move `.cxx` directory out of `android/app` (flutter/flutter#166277)
2025-03-31 4nahom@gmail.com Fix typo in carousel.dart (flutter/flutter#164727)
2025-03-31 engine-flutter-autoroll@skia.org Roll Dart SDK from c5fa06710bb6 to 509faa921c95 (1 revision) (flutter/flutter#166283)
2025-03-31 conner@emerssso.com Public nodes needing paint or layout (flutter/flutter#166148)
2025-03-31 benthillerkus@gmail.com [Gen-l10n] Infer placeholder types on both templates and localizations (flutter/flutter#163690)
2025-03-31 koji.wakamiya@gmail.com [Engine][iOS] Cancel animation when recieved `UIKeyboardWillHideNotification` with duration 0.0 (flutter/flutter#164884)
2025-03-31 51209748+gbbosak@users.noreply.github.com [fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead (flutter/flutter#162780)
2025-03-31 jessiewong401@gmail.com Updated to latest AVD to Support Android 16 (API 36) (flutter/flutter#165926)
2025-03-31 34465683+rkishan516@users.noreply.github.com Feat: Add brightnessOf method for theme (flutter/flutter#163733)
2025-03-31 fluttergithubbot@gmail.com Marks Linux_mokey new_gallery__crane_perf to be flaky (flutter/flutter#165964)
2025-03-31 bkonyi@google.com [ Tool ] Correctly select entrypoint target for web build from positional argument list (flutter/flutter#166260)
2025-03-31 jonahwilliams@google.com [Impeller] remove validation warning ignores. (flutter/flutter#166205)
2025-03-31 jonahwilliams@google.com [Impeller] handle shader ordering bug on macOS. (flutter/flutter#165937)
2025-03-31 737941+loic-sharma@users.noreply.github.com Fix CODEOWNERS for the iOS review team (flutter/flutter#166178)
2025-03-31 bkonyi@google.com Remove `<meta content="IE=Edge" http-equiv="X-UA-Compatible">` (flutter/flutter#166252)
2025-03-31 engine-flutter-autoroll@skia.org Roll Dart SDK from b9c35e05feb5 to c5fa06710bb6 (1 revision) (flutter/flutter#166251)
2025-03-31 engine-flutter-autoroll@skia.org Roll Skia from 418c68ea5ccb to 5f262bd2cbb4 (2 revisions) (flutter/flutter#166244)
2025-03-31 engine-flutter-autoroll@skia.org Roll Skia from b6a3bbd1d153 to 418c68ea5ccb (1 revision) (flutter/flutter#166236)
2025-03-31 jonahwilliams@google.com [Impeller] fix min filter for GL external textures. (flutter/flutter#166224)
2025-03-31 engine-flutter-autoroll@skia.org Roll Skia from 10f4cf9a817d to b6a3bbd1d153 (13 revisions) (flutter/flutter#166231)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@romanejaquez
[Impeller] fix min filter for GL external textures. (flutter#166224)
9a81db0 
Fixes flutter#165976

Pass through sampler options for oes external textures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels. will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Video rendering broken for OpenGLES Impeller Backend

3 participants

@jonahwilliams @holzgeist @matanlurey