[FGP conversion] Port FlutterExtension from Groovy to Kotlin
#165143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 13, 2025 11:54
gmackall
commented
Mar 13, 2025
|
|
||
| // The default getter name that Kotlin creates conflicts with the above methods. | ||
| @get:JvmName("getVersionCodeProperty") | ||
| val versionCode: Int |
Member
Author
There was a problem hiding this comment.
In groovy the presence of a getVersionCode/getVersionName allows the syntactic sugar flutter.versionCode/versionName. You can read about this here
https://www.groovy-lang.org/objectorientation.html#properties
By convention, Groovy will recognize properties even if there is no backing field provided there are getters or setters that follow the Java Beans specification. For example:
class PseudoProperties {
// a pseudo property "name"
void setName(String name) {}
String getName() {}
// a pseudo read-only property "age"
int getAge() { 42 }
// a pseudo write-only property "groovy"
void setGroovy(boolean groovy) { }
}
def p = new PseudoProperties()
p.name = 'Foo' (1)
assert p.age == 42 (2)
p.groovy = true (3)(1) writing p.name is allowed because there is a pseudo-property name
(2) reading p.age is allowed because there is a pseudo-readonly property age
(3) writing p.groovy is allowed because there is a pseudo-write-only property groovy
But then having a versionCode property, a getter for that property, and also a getVersionCode property causes an error because Kotlin implicitly names the getter getVersionCode. So I'm renaming the generated getter name here, because it doesn't actually matter what it is (all that matters is that we have an equivalent for the syntactic sugar that Groovy was generating, i.e. referencing it as flutter.versionCode).
ash2moon
approved these changes
Mar 13, 2025
packages/flutter_tools/gradle/src/test/kotlin/FlutterExtensionTest.kt
Outdated
Show resolved
Hide resolved
packages/flutter_tools/gradle/src/test/kotlin/FlutterExtensionTest.kt
Outdated
Show resolved
Hide resolved
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 25, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 25, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2025
stuartmorgan-g
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 28, 2025
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) Manual roll requested by stuartmorgan@google.com flutter/flutter@b16430b...1d954f4 2025-03-17 jacksongardner@google.com Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutter#165350) 2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa669e2e6d12 to 52130e5c3b34 (4 revisions) (flutter/flutter#165348) 2025-03-17 31859944+LongCatIsLooong@users.noreply.github.com `OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal` rebuilds. (flutter/flutter#165331) 2025-03-17 jhy03261997@gmail.com [web][a11y]Delete _childContainerElement (flutter/flutter#163662) 2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from e45207898e60 to fa669e2e6d12 (8 revisions) (flutter/flutter#165342) 2025-03-17 katelovett@google.com Add documentation for Java test filtering to plugins test document (flutter/flutter#165314) 2025-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313) 2025-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310) 2025-03-17 kamil@szczek.dev feat(Tooltip): replace the height parameter with constraints (flutter/flutter#163314) 2025-03-17 huy@nevercode.io Fix arrowHeadColor breaks differentiation between states (flutter/flutter#165178) 2025-03-17 30870216+gaaclarke@users.noreply.github.com Removes assumption that basis scalar and rounded_scalar match (flutter/flutter#165166) 2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69cf4c2c5db8 to e45207898e60 (1 revision) (flutter/flutter#165300) 2025-03-17 34465683+rkishan516@users.noreply.github.com Refactor: Move sliders value indicator shape to seperate file (flutter/flutter#162858) 2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 3931c31032c7 to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288) 2025-03-17 matanlurey@users.noreply.github.com Delete `docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258) 2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from 3413a02d6fc8 to 3931c31032c7 (1 revision) (flutter/flutter#165277) 2025-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275) 2025-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269) 2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from f124daeb564d to 3413a02d6fc8 (1 revision) (flutter/flutter#165263) 2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from 40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262) 2025-03-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252) 2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250) 2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from 8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246) 2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from 4568e766ed0a to f124daeb564d (1 revision) (flutter/flutter#165245) 2025-03-15 47866232+chunhtai@users.noreply.github.com Revert "Prevent explicit roles from merging (#164732)" (flutter/flutter#165222) 2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from bac6e76abfc7 to 4568e766ed0a (5 revisions) (flutter/flutter#165241) 2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227) 2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from 98b6922deecf to bac6e76abfc7 (5 revisions) (flutter/flutter#165225) 2025-03-14 34871572+gmackall@users.noreply.github.com Point ktlint AS docs to the `.editorconfig` that is actually used by ci, instead of making a copy in the README (flutter/flutter#165213) 2025-03-14 katelovett@google.com Add remaining dart fixes for Color deprecations when importing painting.dart (flutter/flutter#162609) 2025-03-14 737941+loic-sharma@users.noreply.github.com [Accessibility] Add required semantics flags (flutter/flutter#164585) 2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from f4467ff38f1f to 98b6922deecf (5 revisions) (flutter/flutter#165215) 2025-03-14 jessiewong401@gmail.com Convert `BaseFlutterTask` From Groovy to Kotlin (flutter/flutter#163148) 2025-03-14 31859944+LongCatIsLooong@users.noreply.github.com `OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034) 2025-03-14 2shrestha22@gmail.com Remove redundant `useMaterial3: true` (flutter/flutter#163376) 2025-03-14 engine-flutter-autoroll@skia.org Roll Packages from 9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197) 2025-03-14 1063596+reidbaker@users.noreply.github.com Changelog updates from 3.29.2 (flutter/flutter#165194) 2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from 576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191) 2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180) 2025-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175) 2025-03-14 jonahwilliams@google.com [Impeller] Enable mediatek on API 34+. (flutter/flutter#165156) 2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159) 2025-03-13 34871572+gmackall@users.noreply.github.com [FGP conversion] Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143) 2025-03-13 47866232+chunhtai@users.noreply.github.com Prevent explicit roles from merging (flutter/flutter#164732) ...
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Mar 31, 2025
…8922) Manual roll Flutter from b16430b to 1d954f4 (114 revisions) Manual roll requested by stuartmorgan@google.com flutter/flutter@b16430b...1d954f4 2025-03-17 jacksongardner@google.com Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutter#165350) 2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa669e2e6d12 to 52130e5c3b34 (4 revisions) (flutter/flutter#165348) 2025-03-17 31859944+LongCatIsLooong@users.noreply.github.com `OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal` rebuilds. (flutter/flutter#165331) 2025-03-17 jhy03261997@gmail.com [web][a11y]Delete _childContainerElement (flutter/flutter#163662) 2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from e45207898e60 to fa669e2e6d12 (8 revisions) (flutter/flutter#165342) 2025-03-17 katelovett@google.com Add documentation for Java test filtering to plugins test document (flutter/flutter#165314) 2025-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313) 2025-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310) 2025-03-17 kamil@szczek.dev feat(Tooltip): replace the height parameter with constraints (flutter/flutter#163314) 2025-03-17 huy@nevercode.io Fix arrowHeadColor breaks differentiation between states (flutter/flutter#165178) 2025-03-17 30870216+gaaclarke@users.noreply.github.com Removes assumption that basis scalar and rounded_scalar match (flutter/flutter#165166) 2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69cf4c2c5db8 to e45207898e60 (1 revision) (flutter/flutter#165300) 2025-03-17 34465683+rkishan516@users.noreply.github.com Refactor: Move sliders value indicator shape to seperate file (flutter/flutter#162858) 2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 3931c31032c7 to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288) 2025-03-17 matanlurey@users.noreply.github.com Delete `docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258) 2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from 3413a02d6fc8 to 3931c31032c7 (1 revision) (flutter/flutter#165277) 2025-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275) 2025-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269) 2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from f124daeb564d to 3413a02d6fc8 (1 revision) (flutter/flutter#165263) 2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from 40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262) 2025-03-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252) 2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250) 2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from 8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246) 2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from 4568e766ed0a to f124daeb564d (1 revision) (flutter/flutter#165245) 2025-03-15 47866232+chunhtai@users.noreply.github.com Revert "Prevent explicit roles from merging (#164732)" (flutter/flutter#165222) 2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from bac6e76abfc7 to 4568e766ed0a (5 revisions) (flutter/flutter#165241) 2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227) 2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from 98b6922deecf to bac6e76abfc7 (5 revisions) (flutter/flutter#165225) 2025-03-14 34871572+gmackall@users.noreply.github.com Point ktlint AS docs to the `.editorconfig` that is actually used by ci, instead of making a copy in the README (flutter/flutter#165213) 2025-03-14 katelovett@google.com Add remaining dart fixes for Color deprecations when importing painting.dart (flutter/flutter#162609) 2025-03-14 737941+loic-sharma@users.noreply.github.com [Accessibility] Add required semantics flags (flutter/flutter#164585) 2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from f4467ff38f1f to 98b6922deecf (5 revisions) (flutter/flutter#165215) 2025-03-14 jessiewong401@gmail.com Convert `BaseFlutterTask` From Groovy to Kotlin (flutter/flutter#163148) 2025-03-14 31859944+LongCatIsLooong@users.noreply.github.com `OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034) 2025-03-14 2shrestha22@gmail.com Remove redundant `useMaterial3: true` (flutter/flutter#163376) 2025-03-14 engine-flutter-autoroll@skia.org Roll Packages from 9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197) 2025-03-14 1063596+reidbaker@users.noreply.github.com Changelog updates from 3.29.2 (flutter/flutter#165194) 2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from 576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191) 2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180) 2025-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175) 2025-03-14 jonahwilliams@google.com [Impeller] Enable mediatek on API 34+. (flutter/flutter#165156) 2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159) 2025-03-13 34871572+gmackall@users.noreply.github.com [FGP conversion] Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143) 2025-03-13 47866232+chunhtai@users.noreply.github.com Prevent explicit roles from merging (flutter/flutter#164732) ...
CodixNinja
pushed a commit
to CodixNinja/packages
that referenced
this pull request
May 15, 2025
… (#8922) Manual roll Flutter from b16430b2fd57 to 1d954f4e96bd (114 revisions) Manual roll requested by stuartmorgan@google.com flutter/flutter@b16430b...1d954f4 2025-03-17 jacksongardner@google.com Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutter#165350) 2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa669e2e6d12 to 52130e5c3b34 (4 revisions) (flutter/flutter#165348) 2025-03-17 31859944+LongCatIsLooong@users.noreply.github.com `OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal` rebuilds. (flutter/flutter#165331) 2025-03-17 jhy03261997@gmail.com [web][a11y]Delete _childContainerElement (flutter/flutter#163662) 2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from e45207898e60 to fa669e2e6d12 (8 revisions) (flutter/flutter#165342) 2025-03-17 katelovett@google.com Add documentation for Java test filtering to plugins test document (flutter/flutter#165314) 2025-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313) 2025-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310) 2025-03-17 kamil@szczek.dev feat(Tooltip): replace the height parameter with constraints (flutter/flutter#163314) 2025-03-17 huy@nevercode.io Fix arrowHeadColor breaks differentiation between states (flutter/flutter#165178) 2025-03-17 30870216+gaaclarke@users.noreply.github.com Removes assumption that basis scalar and rounded_scalar match (flutter/flutter#165166) 2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69cf4c2c5db8 to e45207898e60 (1 revision) (flutter/flutter#165300) 2025-03-17 34465683+rkishan516@users.noreply.github.com Refactor: Move sliders value indicator shape to seperate file (flutter/flutter#162858) 2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 3931c31032c7 to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288) 2025-03-17 matanlurey@users.noreply.github.com Delete `docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258) 2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from 3413a02d6fc8 to 3931c31032c7 (1 revision) (flutter/flutter#165277) 2025-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275) 2025-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269) 2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from f124daeb564d to 3413a02d6fc8 (1 revision) (flutter/flutter#165263) 2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from 40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262) 2025-03-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252) 2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250) 2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from 8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246) 2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from 4568e766ed0a to f124daeb564d (1 revision) (flutter/flutter#165245) 2025-03-15 47866232+chunhtai@users.noreply.github.com Revert "Prevent explicit roles from merging (#164732)" (flutter/flutter#165222) 2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from bac6e76abfc7 to 4568e766ed0a (5 revisions) (flutter/flutter#165241) 2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227) 2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from 98b6922deecf to bac6e76abfc7 (5 revisions) (flutter/flutter#165225) 2025-03-14 34871572+gmackall@users.noreply.github.com Point ktlint AS docs to the `.editorconfig` that is actually used by ci, instead of making a copy in the README (flutter/flutter#165213) 2025-03-14 katelovett@google.com Add remaining dart fixes for Color deprecations when importing painting.dart (flutter/flutter#162609) 2025-03-14 737941+loic-sharma@users.noreply.github.com [Accessibility] Add required semantics flags (flutter/flutter#164585) 2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from f4467ff38f1f to 98b6922deecf (5 revisions) (flutter/flutter#165215) 2025-03-14 jessiewong401@gmail.com Convert `BaseFlutterTask` From Groovy to Kotlin (flutter/flutter#163148) 2025-03-14 31859944+LongCatIsLooong@users.noreply.github.com `OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034) 2025-03-14 2shrestha22@gmail.com Remove redundant `useMaterial3: true` (flutter/flutter#163376) 2025-03-14 engine-flutter-autoroll@skia.org Roll Packages from bdb9c96 to d632936 (1 revision) (flutter/flutter#165197) 2025-03-14 1063596+reidbaker@users.noreply.github.com Changelog updates from 3.29.2 (flutter/flutter#165194) 2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from 576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191) 2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180) 2025-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175) 2025-03-14 jonahwilliams@google.com [Impeller] Enable mediatek on API 34+. (flutter/flutter#165156) 2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159) 2025-03-13 34871572+gmackall@users.noreply.github.com [FGP conversion] Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143) 2025-03-13 47866232+chunhtai@users.noreply.github.com Prevent explicit roles from merging (flutter/flutter#164732) ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 21, 2025
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
…8922) Manual roll Flutter from b16430b to 1d954f4 (114 revisions) Manual roll requested by stuartmorgan@google.com flutter/flutter@b16430b...1d954f4 2025-03-17 jacksongardner@google.com Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutter#165350) 2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa669e2e6d12 to 52130e5c3b34 (4 revisions) (flutter/flutter#165348) 2025-03-17 31859944+LongCatIsLooong@users.noreply.github.com `OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal` rebuilds. (flutter/flutter#165331) 2025-03-17 jhy03261997@gmail.com [web][a11y]Delete _childContainerElement (flutter/flutter#163662) 2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from e45207898e60 to fa669e2e6d12 (8 revisions) (flutter/flutter#165342) 2025-03-17 katelovett@google.com Add documentation for Java test filtering to plugins test document (flutter/flutter#165314) 2025-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313) 2025-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310) 2025-03-17 kamil@szczek.dev feat(Tooltip): replace the height parameter with constraints (flutter/flutter#163314) 2025-03-17 huy@nevercode.io Fix arrowHeadColor breaks differentiation between states (flutter/flutter#165178) 2025-03-17 30870216+gaaclarke@users.noreply.github.com Removes assumption that basis scalar and rounded_scalar match (flutter/flutter#165166) 2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69cf4c2c5db8 to e45207898e60 (1 revision) (flutter/flutter#165300) 2025-03-17 34465683+rkishan516@users.noreply.github.com Refactor: Move sliders value indicator shape to seperate file (flutter/flutter#162858) 2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 3931c31032c7 to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288) 2025-03-17 matanlurey@users.noreply.github.com Delete `docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258) 2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from 3413a02d6fc8 to 3931c31032c7 (1 revision) (flutter/flutter#165277) 2025-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275) 2025-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269) 2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from f124daeb564d to 3413a02d6fc8 (1 revision) (flutter/flutter#165263) 2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from 40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262) 2025-03-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252) 2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250) 2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from 8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246) 2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from 4568e766ed0a to f124daeb564d (1 revision) (flutter/flutter#165245) 2025-03-15 47866232+chunhtai@users.noreply.github.com Revert "Prevent explicit roles from merging (#164732)" (flutter/flutter#165222) 2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from bac6e76abfc7 to 4568e766ed0a (5 revisions) (flutter/flutter#165241) 2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227) 2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from 98b6922deecf to bac6e76abfc7 (5 revisions) (flutter/flutter#165225) 2025-03-14 34871572+gmackall@users.noreply.github.com Point ktlint AS docs to the `.editorconfig` that is actually used by ci, instead of making a copy in the README (flutter/flutter#165213) 2025-03-14 katelovett@google.com Add remaining dart fixes for Color deprecations when importing painting.dart (flutter/flutter#162609) 2025-03-14 737941+loic-sharma@users.noreply.github.com [Accessibility] Add required semantics flags (flutter/flutter#164585) 2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from f4467ff38f1f to 98b6922deecf (5 revisions) (flutter/flutter#165215) 2025-03-14 jessiewong401@gmail.com Convert `BaseFlutterTask` From Groovy to Kotlin (flutter/flutter#163148) 2025-03-14 31859944+LongCatIsLooong@users.noreply.github.com `OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034) 2025-03-14 2shrestha22@gmail.com Remove redundant `useMaterial3: true` (flutter/flutter#163376) 2025-03-14 engine-flutter-autoroll@skia.org Roll Packages from 9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197) 2025-03-14 1063596+reidbaker@users.noreply.github.com Changelog updates from 3.29.2 (flutter/flutter#165194) 2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from 576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191) 2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180) 2025-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175) 2025-03-14 jonahwilliams@google.com [Impeller] Enable mediatek on API 34+. (flutter/flutter#165156) 2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159) 2025-03-13 34871572+gmackall@users.noreply.github.com [FGP conversion] Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143) 2025-03-13 47866232+chunhtai@users.noreply.github.com Prevent explicit roles from merging (flutter/flutter#164732) ...
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…8922) Manual roll Flutter from b16430b to 1d954f4 (114 revisions) Manual roll requested by stuartmorgan@google.com flutter/flutter@b16430b...1d954f4 2025-03-17 jacksongardner@google.com Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutter#165350) 2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa669e2e6d12 to 52130e5c3b34 (4 revisions) (flutter/flutter#165348) 2025-03-17 31859944+LongCatIsLooong@users.noreply.github.com `OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal` rebuilds. (flutter/flutter#165331) 2025-03-17 jhy03261997@gmail.com [web][a11y]Delete _childContainerElement (flutter/flutter#163662) 2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from e45207898e60 to fa669e2e6d12 (8 revisions) (flutter/flutter#165342) 2025-03-17 katelovett@google.com Add documentation for Java test filtering to plugins test document (flutter/flutter#165314) 2025-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313) 2025-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310) 2025-03-17 kamil@szczek.dev feat(Tooltip): replace the height parameter with constraints (flutter/flutter#163314) 2025-03-17 huy@nevercode.io Fix arrowHeadColor breaks differentiation between states (flutter/flutter#165178) 2025-03-17 30870216+gaaclarke@users.noreply.github.com Removes assumption that basis scalar and rounded_scalar match (flutter/flutter#165166) 2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69cf4c2c5db8 to e45207898e60 (1 revision) (flutter/flutter#165300) 2025-03-17 34465683+rkishan516@users.noreply.github.com Refactor: Move sliders value indicator shape to seperate file (flutter/flutter#162858) 2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 3931c31032c7 to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288) 2025-03-17 matanlurey@users.noreply.github.com Delete `docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258) 2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from 3413a02d6fc8 to 3931c31032c7 (1 revision) (flutter/flutter#165277) 2025-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275) 2025-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269) 2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from f124daeb564d to 3413a02d6fc8 (1 revision) (flutter/flutter#165263) 2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from 40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262) 2025-03-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252) 2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250) 2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from 8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246) 2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from 4568e766ed0a to f124daeb564d (1 revision) (flutter/flutter#165245) 2025-03-15 47866232+chunhtai@users.noreply.github.com Revert "Prevent explicit roles from merging (#164732)" (flutter/flutter#165222) 2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from bac6e76abfc7 to 4568e766ed0a (5 revisions) (flutter/flutter#165241) 2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227) 2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from 98b6922deecf to bac6e76abfc7 (5 revisions) (flutter/flutter#165225) 2025-03-14 34871572+gmackall@users.noreply.github.com Point ktlint AS docs to the `.editorconfig` that is actually used by ci, instead of making a copy in the README (flutter/flutter#165213) 2025-03-14 katelovett@google.com Add remaining dart fixes for Color deprecations when importing painting.dart (flutter/flutter#162609) 2025-03-14 737941+loic-sharma@users.noreply.github.com [Accessibility] Add required semantics flags (flutter/flutter#164585) 2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from f4467ff38f1f to 98b6922deecf (5 revisions) (flutter/flutter#165215) 2025-03-14 jessiewong401@gmail.com Convert `BaseFlutterTask` From Groovy to Kotlin (flutter/flutter#163148) 2025-03-14 31859944+LongCatIsLooong@users.noreply.github.com `OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034) 2025-03-14 2shrestha22@gmail.com Remove redundant `useMaterial3: true` (flutter/flutter#163376) 2025-03-14 engine-flutter-autoroll@skia.org Roll Packages from 9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197) 2025-03-14 1063596+reidbaker@users.noreply.github.com Changelog updates from 3.29.2 (flutter/flutter#165194) 2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from 576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191) 2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180) 2025-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175) 2025-03-14 jonahwilliams@google.com [Impeller] Enable mediatek on API 34+. (flutter/flutter#165156) 2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159) 2025-03-13 34871572+gmackall@users.noreply.github.com [FGP conversion] Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143) 2025-03-13 47866232+chunhtai@users.noreply.github.com Prevent explicit roles from merging (flutter/flutter#164732) ...
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
…er#165143) Ports `FlutterExtension` from groovy to kotlin. Fixes flutter#162105 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall <mackall@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports
FlutterExtensionfrom groovy to kotlin.Fixes #162105
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.