Skip to content

Refactor: Move sliders value indicator shape to seperate file #162858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 5 commits into from
Mar 17, 2025
Merged

Refactor: Move sliders value indicator shape to seperate file #162858

auto-submit merged 5 commits into from
Mar 17, 2025

Conversation

@rkishan516
Copy link
Contributor

@rkishan516 rkishan516 commented Feb 7, 2025 •
edited
Loading

Refactor: Move sliders value indicator shape to seperate file
Part of: #162510

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 7, 2025

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Feb 7, 2025
@rkishan516
Copy link
Contributor Author

rkishan516 commented Feb 9, 2025

@TahaTesser or @Piinks Would you guys mind reviewing this PR ?

TahaTesser
TahaTesser reviewed Feb 10, 2025
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an idea. What if we separate Slider and RangeSlider components into separate files since the base files slider.dart and range_slider.dart are also separate. WYDT?

@rkishan516
Copy link
Contributor Author

rkishan516 commented Feb 10, 2025 •
edited
Loading

Just an idea. What if we separate Slider and RangeSlider components into separate files since the base files slider.dart and range_slider.dart are also separate. WYDT?

Yaa, sure. Because may be in future each of them can have multiple component and we won't have to face decoupling them again if we already do it here. Should i go ahead and do the change ?

@TahaTesser
Copy link
Member

TahaTesser commented Feb 10, 2025

@rkishan516
please go ahead.

@rkishan516 rkishan516 force-pushed the sliders-refactor branch 2 times, most recently from bf85cf9 to 2e740bd Compare February 10, 2025 11:55
@rkishan516
Copy link
Contributor Author

rkishan516 commented Feb 10, 2025

@rkishan516 please go ahead.

I have pushed the changes.

TahaTesser
TahaTesser reviewed Feb 10, 2025
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we please add "s" for components?

@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 10, 2025

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #162858 at sha 2e740bd

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Feb 10, 2025
@rkishan516
Copy link
Contributor Author

rkishan516 commented Feb 10, 2025

can we please add "s" for components?

Sorry, My bad. I have fixed and pushed.

TahaTesser
TahaTesser requested changes Feb 10, 2025
View reviewed changes
packages/flutter/lib/src/material/slider_theme.dart Outdated
Comment on lines 22 to 23
part 'slider_components.dart';
part 'range_slider_components.dart';
Copy link
Member

@TahaTesser TahaTesser Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be using import relatively similar to other relative files in this class.

packages/flutter/lib/src/material/slider_components.dart Outdated
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

part of 'slider_theme.dart';
Copy link
Member

@TahaTesser TahaTesser Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import

packages/flutter/lib/src/material/range_slider_components.dart Outdated
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

part of 'slider_theme.dart';
Copy link
Member

@TahaTesser TahaTesser Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import

@TahaTesser TahaTesser requested a review from bleroux February 10, 2025 14:21
@rkishan516 rkishan516 force-pushed the sliders-refactor branch 2 times, most recently from e1cf260 to c68255b Compare February 10, 2025 15:17
@rkishan516
Copy link
Contributor Author

rkishan516 commented Feb 10, 2025

I thought making part will make it like slider as a small library. But i have pushed with import changes.

@TahaTesser
Copy link
Member

TahaTesser commented Feb 10, 2025

I thought making part will make it like slider as a small library. But i have pushed with import changes.

These files are exposed under material library. As final step, we will need to export new files in https://github.com/flutter/flutter/blob/master/packages/flutter/lib/material.dart

@TahaTesser TahaTesser requested a review from Piinks February 10, 2025 15:30
@rkishan516 rkishan516 force-pushed the sliders-refactor branch 2 times, most recently from 2167682 to ad58f10 Compare February 10, 2025 15:34
TahaTesser
TahaTesser requested changes Feb 10, 2025
View reviewed changes
packages/flutter/test/material/slider_test.dart Outdated
import 'package:flutter/rendering.dart';
import 'package:flutter/scheduler.dart';
import 'package:flutter/services.dart';
import 'package:flutter/src/material/slider_components.dart';
Copy link
Member

@TahaTesser TahaTesser Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary. The test class is already importing material library.

Copy link
Member

@TahaTesser TahaTesser Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar changes in other classes. please notice the import pattern.

@rkishan516 rkishan516 force-pushed the sliders-refactor branch 5 times, most recently from 31fafe2 to 14cd59b Compare February 11, 2025 02:41
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
413fc75 Refactor: Move sliders value indicator shape to seperate file (…
f1789b1 
…flutter/flutter#162858)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
413fc75 Refactor: Move sliders value indicator shape to seperate file (…
e6bb9d8 
…flutter/flutter#162858)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
413fc75 Refactor: Move sliders value indicator shape to seperate file (…
1d4d20a 
…flutter/flutter#162858)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
413fc75 Refactor: Move sliders value indicator shape to seperate file (…
7e33031 
…flutter/flutter#162858)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
413fc75 Refactor: Move sliders value indicator shape to seperate file (…
910b8b8 
…flutter/flutter#162858)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
413fc75 Refactor: Move sliders value indicator shape to seperate file (…
0acf367 
…flutter/flutter#162858)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
413fc75 Refactor: Move sliders value indicator shape to seperate file (…
fad5423 
…flutter/flutter#162858)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
413fc75 Refactor: Move sliders value indicator shape to seperate file (…
e16ae59 
…flutter/flutter#162858)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
413fc75 Refactor: Move sliders value indicator shape to seperate file (…
53fbdda 
…flutter/flutter#162858)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
413fc75 Refactor: Move sliders value indicator shape to seperate file (…
8b37354 
…flutter/flutter#162858)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
413fc75 Refactor: Move sliders value indicator shape to seperate file (…
77926fe 
…flutter/flutter#162858)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
413fc75 Refactor: Move sliders value indicator shape to seperate file (…
c582a57 
…flutter/flutter#162858)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
413fc75 Refactor: Move sliders value indicator shape to seperate file (…
87862c3 
…flutter/flutter#162858)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
413fc75 Refactor: Move sliders value indicator shape to seperate file (…
d3f3356 
…flutter/flutter#162858)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
413fc75 Refactor: Move sliders value indicator shape to seperate file (…
2e9ea40 
…flutter/flutter#162858)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
413fc75 Refactor: Move sliders value indicator shape to seperate file (…
52f4426 
…flutter/flutter#162858)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
413fc75 Refactor: Move sliders value indicator shape to seperate file (…
e3a3658 
…flutter/flutter#162858)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
413fc75 Refactor: Move sliders value indicator shape to seperate file (…
b4a4191 
…flutter/flutter#162858)
stuartmorgan-g pushed a commit to flutter/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (#8922)
a1b1cf1 
Manual roll Flutter from b16430b to 1d954f4 (114 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@b16430b...1d954f4

2025-03-17 jacksongardner@google.com Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 31859944+LongCatIsLooong@users.noreply.github.com
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 jhy03261997@gmail.com [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 katelovett@google.com Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 kamil@szczek.dev feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 huy@nevercode.io Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 30870216+gaaclarke@users.noreply.github.com Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 34465683+rkishan516@users.noreply.github.com Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 matanlurey@users.noreply.github.com Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 47866232+chunhtai@users.noreply.github.com Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 34871572+gmackall@users.noreply.github.com Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 katelovett@google.com Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 737941+loic-sharma@users.noreply.github.com [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 jessiewong401@gmail.com Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 31859944+LongCatIsLooong@users.noreply.github.com
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 2shrestha22@gmail.com Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 engine-flutter-autoroll@skia.org Roll Packages from
9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197)
2025-03-14 1063596+reidbaker@users.noreply.github.com Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 jonahwilliams@google.com [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 34871572+gmackall@users.noreply.github.com [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 47866232+chunhtai@users.noreply.github.com Prevent explicit
roles from merging (flutter/flutter#164732)
...
vashworth pushed a commit to vashworth/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll @vashworth
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (flutter#…
88d5013 
…8922)

Manual roll Flutter from b16430b to 1d954f4 (114 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@b16430b...1d954f4

2025-03-17 jacksongardner@google.com Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 31859944+LongCatIsLooong@users.noreply.github.com
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 jhy03261997@gmail.com [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 katelovett@google.com Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 kamil@szczek.dev feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 huy@nevercode.io Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 30870216+gaaclarke@users.noreply.github.com Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 34465683+rkishan516@users.noreply.github.com Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 matanlurey@users.noreply.github.com Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 47866232+chunhtai@users.noreply.github.com Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 34871572+gmackall@users.noreply.github.com Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 katelovett@google.com Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 737941+loic-sharma@users.noreply.github.com [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 jessiewong401@gmail.com Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 31859944+LongCatIsLooong@users.noreply.github.com
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 2shrestha22@gmail.com Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 engine-flutter-autoroll@skia.org Roll Packages from
9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197)
2025-03-14 1063596+reidbaker@users.noreply.github.com Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 jonahwilliams@google.com [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 34871572+gmackall@users.noreply.github.com [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 47866232+chunhtai@users.noreply.github.com Prevent explicit
roles from merging (flutter/flutter#164732)
...
@Piinks Piinks mentioned this pull request Apr 10, 2025
Merged
9 tasks
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Manual roll Flutter from b16430b2fd57 to 1d954f4e96bd (114 revisions)…
b6536bc 
… (#8922)

Manual roll Flutter from b16430b2fd57 to 1d954f4e96bd (114 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@b16430b...1d954f4

2025-03-17 jacksongardner@google.com Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 31859944+LongCatIsLooong@users.noreply.github.com
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 jhy03261997@gmail.com [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 katelovett@google.com Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 kamil@szczek.dev feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 huy@nevercode.io Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 30870216+gaaclarke@users.noreply.github.com Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 34465683+rkishan516@users.noreply.github.com Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 matanlurey@users.noreply.github.com Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 47866232+chunhtai@users.noreply.github.com Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 34871572+gmackall@users.noreply.github.com Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 katelovett@google.com Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 737941+loic-sharma@users.noreply.github.com [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 jessiewong401@gmail.com Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 31859944+LongCatIsLooong@users.noreply.github.com
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 2shrestha22@gmail.com Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 engine-flutter-autoroll@skia.org Roll Packages from
bdb9c96 to d632936 (1 revision) (flutter/flutter#165197)
2025-03-14 1063596+reidbaker@users.noreply.github.com Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 jonahwilliams@google.com [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 34871572+gmackall@users.noreply.github.com [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 47866232+chunhtai@users.noreply.github.com Prevent explicit
roles from merging (flutter/flutter#164732)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
413fc75 Refactor: Move sliders value indicator shape to seperate file (…
0e46589 
…flutter/flutter#162858)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
413fc75 Refactor: Move sliders value indicator shape to seperate file (…
efa3250 
…flutter/flutter#162858)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
413fc75 Refactor: Move sliders value indicator shape to seperate file (…
ca2c32f 
…flutter/flutter#162858)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (flutter#…
a06362c 
…8922)

Manual roll Flutter from b16430b to 1d954f4 (114 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@b16430b...1d954f4

2025-03-17 jacksongardner@google.com Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 31859944+LongCatIsLooong@users.noreply.github.com
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 jhy03261997@gmail.com [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 katelovett@google.com Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 kamil@szczek.dev feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 huy@nevercode.io Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 30870216+gaaclarke@users.noreply.github.com Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 34465683+rkishan516@users.noreply.github.com Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 matanlurey@users.noreply.github.com Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 47866232+chunhtai@users.noreply.github.com Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 34871572+gmackall@users.noreply.github.com Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 katelovett@google.com Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 737941+loic-sharma@users.noreply.github.com [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 jessiewong401@gmail.com Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 31859944+LongCatIsLooong@users.noreply.github.com
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 2shrestha22@gmail.com Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 engine-flutter-autoroll@skia.org Roll Packages from
9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197)
2025-03-14 1063596+reidbaker@users.noreply.github.com Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 jonahwilliams@google.com [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 34871572+gmackall@users.noreply.github.com [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 47866232+chunhtai@users.noreply.github.com Prevent explicit
roles from merging (flutter/flutter#164732)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (flutter#…
19d634b 
…8922)

Manual roll Flutter from b16430b to 1d954f4 (114 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@b16430b...1d954f4

2025-03-17 jacksongardner@google.com Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 31859944+LongCatIsLooong@users.noreply.github.com
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 jhy03261997@gmail.com [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 katelovett@google.com Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 engine-flutter-autoroll@skia.org Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 kamil@szczek.dev feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 huy@nevercode.io Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 30870216+gaaclarke@users.noreply.github.com Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 34465683+rkishan516@users.noreply.github.com Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 engine-flutter-autoroll@skia.org Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 matanlurey@users.noreply.github.com Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 engine-flutter-autoroll@skia.org Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 engine-flutter-autoroll@skia.org Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 engine-flutter-autoroll@skia.org Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 47866232+chunhtai@users.noreply.github.com Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 engine-flutter-autoroll@skia.org Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 34871572+gmackall@users.noreply.github.com Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 katelovett@google.com Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 737941+loic-sharma@users.noreply.github.com [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 engine-flutter-autoroll@skia.org Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 jessiewong401@gmail.com Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 31859944+LongCatIsLooong@users.noreply.github.com
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 2shrestha22@gmail.com Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 engine-flutter-autoroll@skia.org Roll Packages from
9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197)
2025-03-14 1063596+reidbaker@users.noreply.github.com Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 jonahwilliams@google.com [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 engine-flutter-autoroll@skia.org Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 34871572+gmackall@users.noreply.github.com [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 47866232+chunhtai@users.noreply.github.com Prevent explicit
roles from merging (flutter/flutter#164732)
...
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@rkishan516 @romanejaquez
Refactor: Move sliders value indicator shape to seperate file (flutte…
e6fe2f5 
…r#162858)

Refactor: Move sliders value indicator shape to seperate file
Part of: flutter#162510 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@Piinks Piinks Piinks approved these changes

@bleroux bleroux Awaiting requested review from bleroux

@TahaTesser TahaTesser Awaiting requested review from TahaTesser

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rkishan516 @TahaTesser @Piinks @bleroux @gspencergoog