[Impeller] Skip clip entity replay that cannot impact current clip. #162113

jonahwilliams · 2025-01-23T21:06:23Z

Sometimes we end up with clip replay entities that have clip depth values substantially below the current depth. I suspect this is due to either mismatched save/restore or a bug in our code. Update: this isn't a bug/bug but its definitely a bug. We can have multiple clips per save, but the restore will remove at most one from the record/replay.

If a clip has a depth value that is less than the current clip depth, it cannot by definition impact anything that draws after it.

gaaclarke

LGTM, just needs an issue filed for the part of the work we aren't completing here.

gaaclarke · 2025-01-24T17:15:06Z

engine/src/flutter/impeller/entity/entity_pass_clip_stack.cc

+    // This code is slightly wrong and should be popping more than one clip
+    // entry.


File an issue and add a TODO with the link.

gaaclarke · 2025-01-24T17:17:18Z

engine/src/flutter/impeller/display_list/aiks_dl_basic_unittests.cc

+TEST_P(AiksTest, BackdropFilterOverUnclosedClip) {
+  DisplayListBuilder builder;
+
+  builder.DrawPaint(DlPaint().setColor(DlColor::kWhite()));


nit: I think this would be easier to follow if you added some curly braces around the save/restores.

gaaclarke

lgtm!

flutter-dashboard · 2025-01-24T19:31:17Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #162113 at sha e7d2e3c

…lutter#162113) Fixes flutter#161262 Sometimes we end up with clip replay entities that have clip depth values substantially below the current depth. I suspect this is due to either mismatched save/restore or a bug in our code. Update: this isn't a bug/bug but its definitely a bug. We can have multiple clips per save, but the restore will remove at most one from the record/replay. If a clip has a depth value that is less than the current clip depth, it cannot by definition impact anything that draws after it.

… clip. (flutter/flutter#162113)

Roll Flutter from c1ffaa9 to b007899 (43 revisions) flutter/flutter@c1ffaa9...b007899 2025-01-29 tessertaha@gmail.com Fix `Tab` linear and elastic animation blink (flutter/flutter#162315) 2025-01-29 pateltirth454@gmail.com Pass-through `textInputAction` in `DropdownMenu` (flutter/flutter#162309) 2025-01-29 38378650+hgraceb@users.noreply.github.com Fix scrollUntilVisible in WidgetTester (flutter/flutter#159582) 2025-01-29 pateltirth454@gmail.com Pass-through `maxLines` in `DropdownMenu` (flutter/flutter#161903) 2025-01-29 gaganyadav80@gmail.com fix: appbar leading width is not square for custom toolbar height (flutter/flutter#161880) 2025-01-29 chinmaygarde@google.com [DisplayList] Don't call Skia Ganesh methods when its not available. (flutter/flutter#162345) 2025-01-29 reidbaker@google.com Update README.md to include googler post verification steps (flutter/flutter#162272) 2025-01-29 kevmoo@users.noreply.github.com [engine, web] return switch expressions in many places (flutter/flutter#162336) 2025-01-29 reidbaker@google.com Update README.md to not have engine link for android (flutter/flutter#162330) 2025-01-29 bkonyi@google.com Reland "[ Widget Previews ] Add support for detecting previews and generating code (#161911)"" (flutter/flutter#162337) 2025-01-29 34871572+gmackall@users.noreply.github.com Add instructions to download the Gradle wrapper to FGP readme, and add to gitignore (flutter/flutter#162332) 2025-01-29 matanlurey@users.noreply.github.com Fix tests to prepare for `--explicit-package-dependencies` and a bug. (flutter/flutter#162289) 2025-01-29 matanlurey@users.noreply.github.com Add a currently unused `runs_in_merge_queue` property to `Linux analyze`. (flutter/flutter#162335) 2025-01-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ Widget Previews ] Add support for detecting previews and generating code (#161911)" (flutter/flutter#162327) 2025-01-28 58529443+srujzs@users.noreply.github.com Support hot restart for DDC library bundle format (flutter/flutter#162123) 2025-01-28 30870216+gaaclarke@users.noreply.github.com Started adjusting uvs to match pixel snapping. (flutter/flutter#162049) 2025-01-28 mohellebiabdessalem@gmail.com Refactor code inside flutter.groovy (flutter/flutter#160250) 2025-01-28 47866232+chunhtai@users.noreply.github.com Table implements redepth (flutter/flutter#162282) 2025-01-28 bkonyi@google.com [ Widget Previews ] Add support for detecting previews and generating code (flutter/flutter#161911) 2025-01-28 andrewrkolos@gmail.com remove dependency on `Usage` from `Pub` class (flutter/flutter#162279) 2025-01-28 engine-flutter-autoroll@skia.org Roll Packages from 258f6dc to 02c6fef (6 revisions) (flutter/flutter#162313) 2025-01-28 matanlurey@users.noreply.github.com Remove `scenario_app/android` and rename to `ios_scenario_app`. (flutter/flutter#160992) 2025-01-28 matanlurey@users.noreply.github.com Apparently it is illegal to use `stderr` in this project. (flutter/flutter#162294) 2025-01-28 aam@google.com Fix update_engine_version_test in presence of FLUTTER_PREBUILT_ENGINE_VERSION env vars. (flutter/flutter#162270) 2025-01-28 matanlurey@users.noreply.github.com Add missing `properties: ...` and move to presubmit. (flutter/flutter#162170) 2025-01-27 jonahwilliams@google.com [Impeller] make swapchain related external fence/semaphore extensions optional. (flutter/flutter#162205) 2025-01-27 49699333+dependabot[bot]@users.noreply.github.com Bump the all-github-actions group with 2 updates (flutter/flutter#162277) 2025-01-27 chinmaygarde@google.com Don't depend on Dart from FML. (flutter/flutter#162271) 2025-01-27 chinmaygarde@google.com [DisplayList] Move nested canvas enums into their own TU. (flutter/flutter#162037) 2025-01-27 importRyan@gmail.com Avoid iOS text selection crash by returning nil range (flutter/flutter#161996) 2025-01-27 mohellebiabdessalem@gmail.com fix `felt` link to point to flutter repo instead of the engine repo (flutter/flutter#161423) 2025-01-27 matanlurey@users.noreply.github.com Enable the Android Engine OpenGLES/Vulkan suites. (flutter/flutter#162258) 2025-01-27 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Fix debug build for CanvasKit (flutter/flutter#162198) 2025-01-27 engine-flutter-autoroll@skia.org Roll Packages from 3d3ab7b to 258f6dc (19 revisions) (flutter/flutter#162254) 2025-01-25 matanlurey@users.noreply.github.com Pin `customer_testing` to the SHA specified in `tests.version` (flutter/flutter#162048) 2025-01-25 matanlurey@users.noreply.github.com Formalize `update_engine_version.{sh|ps1}`. (flutter/flutter#162118) 2025-01-25 pateltirth454@gmail.com Rename 'SelectionChangedCause.scribble' to 'SelectionChangedCause.stylusHandwriting' (flutter/flutter#161518) 2025-01-25 jacksongardner@google.com Don't install xcode when doing `local_engine` web builds on mac. (flutter/flutter#162164) 2025-01-25 matanlurey@users.noreply.github.com Force Impeller backend for `android_engine_test`, and test both OpenGLES and Vulkan (flutter/flutter#162089) 2025-01-24 jonahwilliams@google.com [Impeller] when a command pool has many unused buffers, reset with release resources flag. (flutter/flutter#162171) 2025-01-24 mdebbar@google.com [web] Remove HTML renderer from framework tests (flutter/flutter#162038) 2025-01-24 jonahwilliams@google.com [Impeller] Skip clip entity replay that cannot impact current clip. (flutter/flutter#162113) 2025-01-24 de.frankenapps@gmail.com Update Android integration test package for newer AGP (flutter/flutter#161856) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: ...

…p. (#162113) (#162195) Fixes #161262 Sometimes we end up with clip replay entities that have clip depth values substantially below the current depth. I suspect this is due to either mismatched save/restore or a bug in our code. Update: this isn't a bug/bug but its definitely a bug. We can have multiple clips per save, but the restore will remove at most one from the record/replay. If a clip has a depth value that is less than the current clip depth, it cannot by definition impact anything that draws after it.

… clip. (flutter/flutter#162113)

Roll Flutter from c1ffaa9 to b007899 (43 revisions) flutter/flutter@c1ffaa9...b007899 2025-01-29 tessertaha@gmail.com Fix `Tab` linear and elastic animation blink (flutter/flutter#162315) 2025-01-29 pateltirth454@gmail.com Pass-through `textInputAction` in `DropdownMenu` (flutter/flutter#162309) 2025-01-29 38378650+hgraceb@users.noreply.github.com Fix scrollUntilVisible in WidgetTester (flutter/flutter#159582) 2025-01-29 pateltirth454@gmail.com Pass-through `maxLines` in `DropdownMenu` (flutter/flutter#161903) 2025-01-29 gaganyadav80@gmail.com fix: appbar leading width is not square for custom toolbar height (flutter/flutter#161880) 2025-01-29 chinmaygarde@google.com [DisplayList] Don't call Skia Ganesh methods when its not available. (flutter/flutter#162345) 2025-01-29 reidbaker@google.com Update README.md to include googler post verification steps (flutter/flutter#162272) 2025-01-29 kevmoo@users.noreply.github.com [engine, web] return switch expressions in many places (flutter/flutter#162336) 2025-01-29 reidbaker@google.com Update README.md to not have engine link for android (flutter/flutter#162330) 2025-01-29 bkonyi@google.com Reland "[ Widget Previews ] Add support for detecting previews and generating code (#161911)"" (flutter/flutter#162337) 2025-01-29 34871572+gmackall@users.noreply.github.com Add instructions to download the Gradle wrapper to FGP readme, and add to gitignore (flutter/flutter#162332) 2025-01-29 matanlurey@users.noreply.github.com Fix tests to prepare for `--explicit-package-dependencies` and a bug. (flutter/flutter#162289) 2025-01-29 matanlurey@users.noreply.github.com Add a currently unused `runs_in_merge_queue` property to `Linux analyze`. (flutter/flutter#162335) 2025-01-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ Widget Previews ] Add support for detecting previews and generating code (#161911)" (flutter/flutter#162327) 2025-01-28 58529443+srujzs@users.noreply.github.com Support hot restart for DDC library bundle format (flutter/flutter#162123) 2025-01-28 30870216+gaaclarke@users.noreply.github.com Started adjusting uvs to match pixel snapping. (flutter/flutter#162049) 2025-01-28 mohellebiabdessalem@gmail.com Refactor code inside flutter.groovy (flutter/flutter#160250) 2025-01-28 47866232+chunhtai@users.noreply.github.com Table implements redepth (flutter/flutter#162282) 2025-01-28 bkonyi@google.com [ Widget Previews ] Add support for detecting previews and generating code (flutter/flutter#161911) 2025-01-28 andrewrkolos@gmail.com remove dependency on `Usage` from `Pub` class (flutter/flutter#162279) 2025-01-28 engine-flutter-autoroll@skia.org Roll Packages from 258f6dc to 02c6fef (6 revisions) (flutter/flutter#162313) 2025-01-28 matanlurey@users.noreply.github.com Remove `scenario_app/android` and rename to `ios_scenario_app`. (flutter/flutter#160992) 2025-01-28 matanlurey@users.noreply.github.com Apparently it is illegal to use `stderr` in this project. (flutter/flutter#162294) 2025-01-28 aam@google.com Fix update_engine_version_test in presence of FLUTTER_PREBUILT_ENGINE_VERSION env vars. (flutter/flutter#162270) 2025-01-28 matanlurey@users.noreply.github.com Add missing `properties: ...` and move to presubmit. (flutter/flutter#162170) 2025-01-27 jonahwilliams@google.com [Impeller] make swapchain related external fence/semaphore extensions optional. (flutter/flutter#162205) 2025-01-27 49699333+dependabot[bot]@users.noreply.github.com Bump the all-github-actions group with 2 updates (flutter/flutter#162277) 2025-01-27 chinmaygarde@google.com Don't depend on Dart from FML. (flutter/flutter#162271) 2025-01-27 chinmaygarde@google.com [DisplayList] Move nested canvas enums into their own TU. (flutter/flutter#162037) 2025-01-27 importRyan@gmail.com Avoid iOS text selection crash by returning nil range (flutter/flutter#161996) 2025-01-27 mohellebiabdessalem@gmail.com fix `felt` link to point to flutter repo instead of the engine repo (flutter/flutter#161423) 2025-01-27 matanlurey@users.noreply.github.com Enable the Android Engine OpenGLES/Vulkan suites. (flutter/flutter#162258) 2025-01-27 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Fix debug build for CanvasKit (flutter/flutter#162198) 2025-01-27 engine-flutter-autoroll@skia.org Roll Packages from 3d3ab7b to 258f6dc (19 revisions) (flutter/flutter#162254) 2025-01-25 matanlurey@users.noreply.github.com Pin `customer_testing` to the SHA specified in `tests.version` (flutter/flutter#162048) 2025-01-25 matanlurey@users.noreply.github.com Formalize `update_engine_version.{sh|ps1}`. (flutter/flutter#162118) 2025-01-25 pateltirth454@gmail.com Rename 'SelectionChangedCause.scribble' to 'SelectionChangedCause.stylusHandwriting' (flutter/flutter#161518) 2025-01-25 jacksongardner@google.com Don't install xcode when doing `local_engine` web builds on mac. (flutter/flutter#162164) 2025-01-25 matanlurey@users.noreply.github.com Force Impeller backend for `android_engine_test`, and test both OpenGLES and Vulkan (flutter/flutter#162089) 2025-01-24 jonahwilliams@google.com [Impeller] when a command pool has many unused buffers, reset with release resources flag. (flutter/flutter#162171) 2025-01-24 mdebbar@google.com [web] Remove HTML renderer from framework tests (flutter/flutter#162038) 2025-01-24 jonahwilliams@google.com [Impeller] Skip clip entity replay that cannot impact current clip. (flutter/flutter#162113) 2025-01-24 de.frankenapps@gmail.com Update Android integration test package for newer AGP (flutter/flutter#161856) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: ...

[Impeller] test disabling scissor when performing clip replay.

d13f13b

github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Jan 23, 2025

jonahwilliams mentioned this pull request Jan 23, 2025

[Impeller] : Issue with Flutter 3.27 optimization for BackdropFilter #161262

Closed

Skip depth if less than current depth.

917f57a

jonahwilliams changed the title ~~[Impeller] test disabling scissor when performing clip replay.~~ [Impeller] Skip clip entity replay that cannot impact current clip. Jan 23, 2025

jonahwilliams marked this pull request as ready for review January 23, 2025 22:49

jonahwilliams added 2 commits January 23, 2025 19:31

add test.

ad6bdba

++

283384b

jonahwilliams requested a review from gaaclarke January 24, 2025 16:37

gaaclarke reviewed Jan 24, 2025

View reviewed changes

jonahwilliams mentioned this pull request Jan 24, 2025

[Impeller] entitypass clip stack should pop the appropriate number of clips on restore. #162172

Open

aaron review.

e7d2e3c

jonahwilliams requested a review from gaaclarke January 24, 2025 18:21

gaaclarke approved these changes Jan 24, 2025

View reviewed changes

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2025

flutter-dashboard bot added the will affect goldens Changes to golden files label Jan 24, 2025

auto-submit bot added this pull request to the merge queue Jan 24, 2025

Merged via the queue into flutter:master with commit b82e902 Jan 24, 2025
176 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2025

engine-flutter-autoroll mentioned this pull request Jan 25, 2025

Roll Flutter from c1ffaa9d9deb to 586a59211df4 (7 revisions) flutter/packages#8503

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 25, 2025

b82e902 [Impeller] Skip clip entity replay that cannot impact current…

d7f9611

… clip. (flutter/flutter#162113)

engine-flutter-autoroll mentioned this pull request Jan 25, 2025

Roll Flutter from c1ffaa9d9deb to 586a59211df4 (7 revisions) flutter/packages#8504

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 25, 2025

b82e902 [Impeller] Skip clip entity replay that cannot impact current…

b260c69

… clip. (flutter/flutter#162113)

engine-flutter-autoroll mentioned this pull request Jan 26, 2025

Roll Flutter from c1ffaa9d9deb to a16de734bd2d (9 revisions) flutter/packages#8506

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 26, 2025

b82e902 [Impeller] Skip clip entity replay that cannot impact current…

7ef34c9

… clip. (flutter/flutter#162113)

engine-flutter-autoroll mentioned this pull request Jan 26, 2025

Roll Flutter from c1ffaa9d9deb to a16de734bd2d (9 revisions) flutter/packages#8507

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 26, 2025

b82e902 [Impeller] Skip clip entity replay that cannot impact current…

68b0e44

… clip. (flutter/flutter#162113)

engine-flutter-autoroll mentioned this pull request Jan 27, 2025

Roll Flutter from c1ffaa9d9deb to a16de734bd2d (9 revisions) flutter/packages#8508

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 27, 2025

b82e902 [Impeller] Skip clip entity replay that cannot impact current…

d47cc04

… clip. (flutter/flutter#162113)

engine-flutter-autoroll mentioned this pull request Jan 27, 2025

Roll Flutter from c1ffaa9d9deb to a2c56f3d755a (10 revisions) flutter/packages#8511

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 27, 2025

b82e902 [Impeller] Skip clip entity replay that cannot impact current…

92c4e36

… clip. (flutter/flutter#162113)

engine-flutter-autoroll mentioned this pull request Jan 28, 2025

Roll Flutter from c1ffaa9d9deb to 9e273d5e6e2e (22 revisions) flutter/packages#8520

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2025

b82e902 [Impeller] Skip clip entity replay that cannot impact current…

d1af388

… clip. (flutter/flutter#162113)

engine-flutter-autoroll mentioned this pull request Jan 28, 2025

Roll Flutter from c1ffaa9d9deb to 21f7283f5dfb (23 revisions) flutter/packages#8522

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2025

b82e902 [Impeller] Skip clip entity replay that cannot impact current…

1c8c373

… clip. (flutter/flutter#162113)

engine-flutter-autoroll mentioned this pull request Jan 28, 2025

Roll Flutter from c1ffaa9d9deb to a9c50335c736 (24 revisions) flutter/packages#8523

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2025

b82e902 [Impeller] Skip clip entity replay that cannot impact current…

0d8ec50

… clip. (flutter/flutter#162113)

engine-flutter-autoroll mentioned this pull request Jan 29, 2025

Roll Flutter from c1ffaa9d9deb to b007899d3a7a (43 revisions) flutter/packages#8527

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 29, 2025

b82e902 [Impeller] Skip clip entity replay that cannot impact current…

0c6acd0

… clip. (flutter/flutter#162113)

reidbaker mentioned this pull request Jan 30, 2025

3.29 engine bump and dart rev #162471

Merged

9 tasks

WyvernPirate mentioned this pull request Apr 3, 2025

Updates Flutter to 3.29.2 stable release WyvernPirate/flutter#1

Merged

reidbaker mentioned this pull request Apr 4, 2025

Unbreak presubmit for stable #166594

Merged

9 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

b82e902 [Impeller] Skip clip entity replay that cannot impact current…

d6dc3fe

… clip. (flutter/flutter#162113)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

b82e902 [Impeller] Skip clip entity replay that cannot impact current…

bc31022

… clip. (flutter/flutter#162113)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

b82e902 [Impeller] Skip clip entity replay that cannot impact current…

30b9108

… clip. (flutter/flutter#162113)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Impeller] Skip clip entity replay that cannot impact current clip. #162113

[Impeller] Skip clip entity replay that cannot impact current clip. #162113

Uh oh!

jonahwilliams commented Jan 23, 2025 •

edited

Loading

Uh oh!

gaaclarke left a comment

Uh oh!

gaaclarke Jan 24, 2025

Uh oh!

jonahwilliams Jan 24, 2025

Uh oh!

gaaclarke Jan 24, 2025

Uh oh!

jonahwilliams Jan 24, 2025

Uh oh!

gaaclarke left a comment

Uh oh!

flutter-dashboard bot commented Jan 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		// This code is slightly wrong and should be popping more than one clip
		// entry.

[Impeller] Skip clip entity replay that cannot impact current clip. #162113

[Impeller] Skip clip entity replay that cannot impact current clip. #162113

Uh oh!

Conversation

jonahwilliams commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

gaaclarke Jan 24, 2025

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Jan 24, 2025

Choose a reason for hiding this comment

Uh oh!

gaaclarke Jan 24, 2025

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Jan 24, 2025

Choose a reason for hiding this comment

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented Jan 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jonahwilliams commented Jan 23, 2025 •

edited

Loading