Started adjusting uvs to match pixel snapping. #162049

gaaclarke · 2025-01-23T00:28:15Z

issue: #149652
doc: (currently google only) https://docs.google.com/document/d/1Rulw_noQi0G8Glb47vk17uBbb6sySDxlQe-l-0kHn14/edit?tab=t.0

This increases the RMSE value in the test in #161445 by a slight amount. I do believe this reduces the time where we get non uniform scalars and protects the integrity of relative spacing, thus being more what we expect. There is still a bug that has to do with pixel alignment that does give the illusion of stretching and shrinking though because of hard/soft lines.

Before

ondevice.mov

After

adjustuvs.mov

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gaaclarke · 2025-01-23T00:31:04Z

Note to self: one way you can verify this is by printing out the aspect ratio of the UVs before and after. The hypothesis is that the "before" has more noisy aspect ratios for the uvs.

jonahwilliams · 2025-01-23T16:16:58Z

I've thought about this more and I think this isn't quite the right approach, but its close.

I think =the scaling problem can be caused by scaling up/down and not the rounding. With the rounding, we're only rounding/pixel snapping the origin point. Then computing the remaining coordinates off of that origin point. As long as the size is correct, that should not change the uv width.

gaaclarke · 2025-01-23T17:48:46Z

Here's the test I thought up for this, it fails with or without this patch though with the exact same results:

TEST_P(TextContentsTest, MaintainsAspectRatio) {
#ifndef FML_OS_MACOSX
  GTEST_SKIP() << "Results aren't stable across linux and macos.";
#endif

  GlyphAtlasPipeline::VertexShader::PerVertexData data[6];

  std::shared_ptr<TextFrame> text_frame =
      MakeTextFrame("1", "ahem.ttf", /*font_size=*/50);

  std::shared_ptr<TypographerContext> context = TypographerContextSkia::Make();
  std::shared_ptr<GlyphAtlasContext> atlas_context =
      context->CreateGlyphAtlasContext(GlyphAtlas::Type::kAlphaBitmap);
  std::shared_ptr<HostBuffer> host_buffer = HostBuffer::Create(
      GetContext()->GetResourceAllocator(), GetContext()->GetIdleWaiter());
  ASSERT_TRUE(context && context->IsValid());
  for (int i = 0; i < 10; ++i) {
    Scalar font_scale = 0.440f + i * 0.001f;
    std::shared_ptr<GlyphAtlas> atlas = CreateGlyphAtlas(
        *GetContext(), context.get(), *host_buffer,
        GlyphAtlas::Type::kAlphaBitmap, font_scale, atlas_context, text_frame);

    ISize texture_size = atlas->GetTexture()->GetSize();
    TextContents::ComputeVertexData(
        data, text_frame, font_scale,
        /*entity_transform=*/Matrix::MakeScale({font_scale, font_scale, 1}),
        /*offset=*/Vector2(0, 0),
        /*glyph_properties=*/std::nullopt, atlas);

    Rect position_rect = PerVertexDataPositionToRect(data);
    Rect uv_rect = PerVertexDataUVToRect(data, texture_size);
    EXPECT_NEAR(GetAspectRatio(position_rect), GetAspectRatio(uv_rect), 0.001)
        << "scale: " << font_scale;
  }
}

gaaclarke · 2025-01-23T17:54:17Z

To be clear the results are 4/10 times it passes, but 6/10 times the difference is aspect ratios is 0.15%.

gaaclarke · 2025-01-24T21:06:23Z

Here is another example of before and after, I think you can more clearly see the benefit of this PR with this. This was generated by drawing 300pt font at scale 0.444x and 0.445x.

before

after

Look at the bottom of the h versus the bottom of the t in "the". They seem to move together more.
Look at the q, it seems to squash more in the before
Look at the width of the i, seems more consistent in the after

gaaclarke · 2025-01-24T22:39:38Z

Okay @jonahwilliams , I just merged in the RMSE test and switched it to just look for a jump in the maximum y value for a tiny scale. The diff should be 1 based on observation, but we are seeing 2 as noted in #162049 (comment)

I wish we had a more holistic test for this but this is what I could come up with.

jonahwilliams

LGTM

auto-submit · 2025-01-24T23:36:22Z

autosubmit label was removed for flutter/flutter/162049, because - The status or check suite Linux mac_android_aot_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

flutter-dashboard · 2025-01-25T00:29:30Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #162049 at sha 95fafce

gaaclarke · 2025-01-25T02:19:58Z

The golden's in that particular case don't look ideal since there is a 1px space between the baseline and some of the glyphs. I think the old test was a fluke though since we know the glyphs would bounce around with certain scalars. I'll audit that particular test on monday.

gaaclarke · 2025-01-28T17:32:30Z

I made the test animated and looked through different scales, looks good. I'll approve the goldens and then push my PR with the test tweak.

…er#162049)

This reverts commit dc580af.

gaaclarke · 2025-01-29T16:33:31Z

Reason for revert: Negatively affected Android rendering ( #162361)

This reverts commit dc580af.

…162392)  Reverts: #162049   Initiated by: gaaclarke   Reason for reverting: Negatively affected Android rendering ( #162361)   Original PR Author: gaaclarke   Reviewed By: {jonahwilliams}   This change reverts the following previous change: issue: #149652 doc: (currently google only) https://docs.google.com/document/d/1Rulw_noQi0G8Glb47vk17uBbb6sySDxlQe-l-0kHn14/edit?tab=t.0 This increases the RMSE value in the test in #161445 by a slight amount. I do believe this reduces the time where we get non uniform scalars and protects the integrity of relative spacing, thus being more what we expect. There is still a bug that has to do with pixel alignment that does give the illusion of stretching and shrinking though because of hard/soft lines. ## Before https://github.com/user-attachments/assets/e9b80b70-0961-4e02-9053-84d4457348e5 ## After https://github.com/user-attachments/assets/2494a2b1-497d-4a2b-afd7-23064acba293 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md  Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>

…ter#162049)" (flutter#162392)" This reverts some of commit d048c77, just the testing parts.

Roll Flutter from c1ffaa9 to b007899 (43 revisions) flutter/flutter@c1ffaa9...b007899 2025-01-29 tessertaha@gmail.com Fix `Tab` linear and elastic animation blink (flutter/flutter#162315) 2025-01-29 pateltirth454@gmail.com Pass-through `textInputAction` in `DropdownMenu` (flutter/flutter#162309) 2025-01-29 38378650+hgraceb@users.noreply.github.com Fix scrollUntilVisible in WidgetTester (flutter/flutter#159582) 2025-01-29 pateltirth454@gmail.com Pass-through `maxLines` in `DropdownMenu` (flutter/flutter#161903) 2025-01-29 gaganyadav80@gmail.com fix: appbar leading width is not square for custom toolbar height (flutter/flutter#161880) 2025-01-29 chinmaygarde@google.com [DisplayList] Don't call Skia Ganesh methods when its not available. (flutter/flutter#162345) 2025-01-29 reidbaker@google.com Update README.md to include googler post verification steps (flutter/flutter#162272) 2025-01-29 kevmoo@users.noreply.github.com [engine, web] return switch expressions in many places (flutter/flutter#162336) 2025-01-29 reidbaker@google.com Update README.md to not have engine link for android (flutter/flutter#162330) 2025-01-29 bkonyi@google.com Reland "[ Widget Previews ] Add support for detecting previews and generating code (#161911)"" (flutter/flutter#162337) 2025-01-29 34871572+gmackall@users.noreply.github.com Add instructions to download the Gradle wrapper to FGP readme, and add to gitignore (flutter/flutter#162332) 2025-01-29 matanlurey@users.noreply.github.com Fix tests to prepare for `--explicit-package-dependencies` and a bug. (flutter/flutter#162289) 2025-01-29 matanlurey@users.noreply.github.com Add a currently unused `runs_in_merge_queue` property to `Linux analyze`. (flutter/flutter#162335) 2025-01-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ Widget Previews ] Add support for detecting previews and generating code (#161911)" (flutter/flutter#162327) 2025-01-28 58529443+srujzs@users.noreply.github.com Support hot restart for DDC library bundle format (flutter/flutter#162123) 2025-01-28 30870216+gaaclarke@users.noreply.github.com Started adjusting uvs to match pixel snapping. (flutter/flutter#162049) 2025-01-28 mohellebiabdessalem@gmail.com Refactor code inside flutter.groovy (flutter/flutter#160250) 2025-01-28 47866232+chunhtai@users.noreply.github.com Table implements redepth (flutter/flutter#162282) 2025-01-28 bkonyi@google.com [ Widget Previews ] Add support for detecting previews and generating code (flutter/flutter#161911) 2025-01-28 andrewrkolos@gmail.com remove dependency on `Usage` from `Pub` class (flutter/flutter#162279) 2025-01-28 engine-flutter-autoroll@skia.org Roll Packages from 258f6dc to 02c6fef (6 revisions) (flutter/flutter#162313) 2025-01-28 matanlurey@users.noreply.github.com Remove `scenario_app/android` and rename to `ios_scenario_app`. (flutter/flutter#160992) 2025-01-28 matanlurey@users.noreply.github.com Apparently it is illegal to use `stderr` in this project. (flutter/flutter#162294) 2025-01-28 aam@google.com Fix update_engine_version_test in presence of FLUTTER_PREBUILT_ENGINE_VERSION env vars. (flutter/flutter#162270) 2025-01-28 matanlurey@users.noreply.github.com Add missing `properties: ...` and move to presubmit. (flutter/flutter#162170) 2025-01-27 jonahwilliams@google.com [Impeller] make swapchain related external fence/semaphore extensions optional. (flutter/flutter#162205) 2025-01-27 49699333+dependabot[bot]@users.noreply.github.com Bump the all-github-actions group with 2 updates (flutter/flutter#162277) 2025-01-27 chinmaygarde@google.com Don't depend on Dart from FML. (flutter/flutter#162271) 2025-01-27 chinmaygarde@google.com [DisplayList] Move nested canvas enums into their own TU. (flutter/flutter#162037) 2025-01-27 importRyan@gmail.com Avoid iOS text selection crash by returning nil range (flutter/flutter#161996) 2025-01-27 mohellebiabdessalem@gmail.com fix `felt` link to point to flutter repo instead of the engine repo (flutter/flutter#161423) 2025-01-27 matanlurey@users.noreply.github.com Enable the Android Engine OpenGLES/Vulkan suites. (flutter/flutter#162258) 2025-01-27 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Fix debug build for CanvasKit (flutter/flutter#162198) 2025-01-27 engine-flutter-autoroll@skia.org Roll Packages from 3d3ab7b to 258f6dc (19 revisions) (flutter/flutter#162254) 2025-01-25 matanlurey@users.noreply.github.com Pin `customer_testing` to the SHA specified in `tests.version` (flutter/flutter#162048) 2025-01-25 matanlurey@users.noreply.github.com Formalize `update_engine_version.{sh|ps1}`. (flutter/flutter#162118) 2025-01-25 pateltirth454@gmail.com Rename 'SelectionChangedCause.scribble' to 'SelectionChangedCause.stylusHandwriting' (flutter/flutter#161518) 2025-01-25 jacksongardner@google.com Don't install xcode when doing `local_engine` web builds on mac. (flutter/flutter#162164) 2025-01-25 matanlurey@users.noreply.github.com Force Impeller backend for `android_engine_test`, and test both OpenGLES and Vulkan (flutter/flutter#162089) 2025-01-24 jonahwilliams@google.com [Impeller] when a command pool has many unused buffers, reset with release resources flag. (flutter/flutter#162171) 2025-01-24 mdebbar@google.com [web] Remove HTML renderer from framework tests (flutter/flutter#162038) 2025-01-24 jonahwilliams@google.com [Impeller] Skip clip entity replay that cannot impact current clip. (flutter/flutter#162113) 2025-01-24 de.frankenapps@gmail.com Update Android integration test package for newer AGP (flutter/flutter#161856) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: ...

…er#162049)

Roll Flutter from c1ffaa9 to b007899 (43 revisions) flutter/flutter@c1ffaa9...b007899 2025-01-29 tessertaha@gmail.com Fix `Tab` linear and elastic animation blink (flutter/flutter#162315) 2025-01-29 pateltirth454@gmail.com Pass-through `textInputAction` in `DropdownMenu` (flutter/flutter#162309) 2025-01-29 38378650+hgraceb@users.noreply.github.com Fix scrollUntilVisible in WidgetTester (flutter/flutter#159582) 2025-01-29 pateltirth454@gmail.com Pass-through `maxLines` in `DropdownMenu` (flutter/flutter#161903) 2025-01-29 gaganyadav80@gmail.com fix: appbar leading width is not square for custom toolbar height (flutter/flutter#161880) 2025-01-29 chinmaygarde@google.com [DisplayList] Don't call Skia Ganesh methods when its not available. (flutter/flutter#162345) 2025-01-29 reidbaker@google.com Update README.md to include googler post verification steps (flutter/flutter#162272) 2025-01-29 kevmoo@users.noreply.github.com [engine, web] return switch expressions in many places (flutter/flutter#162336) 2025-01-29 reidbaker@google.com Update README.md to not have engine link for android (flutter/flutter#162330) 2025-01-29 bkonyi@google.com Reland "[ Widget Previews ] Add support for detecting previews and generating code (#161911)"" (flutter/flutter#162337) 2025-01-29 34871572+gmackall@users.noreply.github.com Add instructions to download the Gradle wrapper to FGP readme, and add to gitignore (flutter/flutter#162332) 2025-01-29 matanlurey@users.noreply.github.com Fix tests to prepare for `--explicit-package-dependencies` and a bug. (flutter/flutter#162289) 2025-01-29 matanlurey@users.noreply.github.com Add a currently unused `runs_in_merge_queue` property to `Linux analyze`. (flutter/flutter#162335) 2025-01-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ Widget Previews ] Add support for detecting previews and generating code (#161911)" (flutter/flutter#162327) 2025-01-28 58529443+srujzs@users.noreply.github.com Support hot restart for DDC library bundle format (flutter/flutter#162123) 2025-01-28 30870216+gaaclarke@users.noreply.github.com Started adjusting uvs to match pixel snapping. (flutter/flutter#162049) 2025-01-28 mohellebiabdessalem@gmail.com Refactor code inside flutter.groovy (flutter/flutter#160250) 2025-01-28 47866232+chunhtai@users.noreply.github.com Table implements redepth (flutter/flutter#162282) 2025-01-28 bkonyi@google.com [ Widget Previews ] Add support for detecting previews and generating code (flutter/flutter#161911) 2025-01-28 andrewrkolos@gmail.com remove dependency on `Usage` from `Pub` class (flutter/flutter#162279) 2025-01-28 engine-flutter-autoroll@skia.org Roll Packages from 258f6dc to 02c6fef (6 revisions) (flutter/flutter#162313) 2025-01-28 matanlurey@users.noreply.github.com Remove `scenario_app/android` and rename to `ios_scenario_app`. (flutter/flutter#160992) 2025-01-28 matanlurey@users.noreply.github.com Apparently it is illegal to use `stderr` in this project. (flutter/flutter#162294) 2025-01-28 aam@google.com Fix update_engine_version_test in presence of FLUTTER_PREBUILT_ENGINE_VERSION env vars. (flutter/flutter#162270) 2025-01-28 matanlurey@users.noreply.github.com Add missing `properties: ...` and move to presubmit. (flutter/flutter#162170) 2025-01-27 jonahwilliams@google.com [Impeller] make swapchain related external fence/semaphore extensions optional. (flutter/flutter#162205) 2025-01-27 49699333+dependabot[bot]@users.noreply.github.com Bump the all-github-actions group with 2 updates (flutter/flutter#162277) 2025-01-27 chinmaygarde@google.com Don't depend on Dart from FML. (flutter/flutter#162271) 2025-01-27 chinmaygarde@google.com [DisplayList] Move nested canvas enums into their own TU. (flutter/flutter#162037) 2025-01-27 importRyan@gmail.com Avoid iOS text selection crash by returning nil range (flutter/flutter#161996) 2025-01-27 mohellebiabdessalem@gmail.com fix `felt` link to point to flutter repo instead of the engine repo (flutter/flutter#161423) 2025-01-27 matanlurey@users.noreply.github.com Enable the Android Engine OpenGLES/Vulkan suites. (flutter/flutter#162258) 2025-01-27 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Fix debug build for CanvasKit (flutter/flutter#162198) 2025-01-27 engine-flutter-autoroll@skia.org Roll Packages from 3d3ab7b to 258f6dc (19 revisions) (flutter/flutter#162254) 2025-01-25 matanlurey@users.noreply.github.com Pin `customer_testing` to the SHA specified in `tests.version` (flutter/flutter#162048) 2025-01-25 matanlurey@users.noreply.github.com Formalize `update_engine_version.{sh|ps1}`. (flutter/flutter#162118) 2025-01-25 pateltirth454@gmail.com Rename 'SelectionChangedCause.scribble' to 'SelectionChangedCause.stylusHandwriting' (flutter/flutter#161518) 2025-01-25 jacksongardner@google.com Don't install xcode when doing `local_engine` web builds on mac. (flutter/flutter#162164) 2025-01-25 matanlurey@users.noreply.github.com Force Impeller backend for `android_engine_test`, and test both OpenGLES and Vulkan (flutter/flutter#162089) 2025-01-24 jonahwilliams@google.com [Impeller] when a command pool has many unused buffers, reset with release resources flag. (flutter/flutter#162171) 2025-01-24 mdebbar@google.com [web] Remove HTML renderer from framework tests (flutter/flutter#162038) 2025-01-24 jonahwilliams@google.com [Impeller] Skip clip entity replay that cannot impact current clip. (flutter/flutter#162113) 2025-01-24 de.frankenapps@gmail.com Update Android integration test package for newer AGP (flutter/flutter#161856) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: ...

github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Jan 23, 2025

gaaclarke added 2 commits January 24, 2025 10:56

added tests that quantify text jitter

1298679

cut out static pixes to boost the RMSE value

db3fe29

gaaclarke added 5 commits January 24, 2025 13:43

Started adjusting uvs to match pixel snapping.

dc4a438

removed stray variable

d003671

changed the test to check centroids of a glyph

e560271

switched to measuring max y

8998e55

format

90e6548

gaaclarke force-pushed the adjust-text-uvs branch from ba10e73 to 90e6548 Compare January 24, 2025 22:29

gaaclarke added 2 commits January 24, 2025 14:30

removed playground

e9f4f24

moved to 300pt just h

95fafce

gaaclarke marked this pull request as ready for review January 24, 2025 22:37

gaaclarke requested a review from jonahwilliams January 24, 2025 22:37

jonahwilliams approved these changes Jan 24, 2025

View reviewed changes

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2025

flutter-dashboard bot added the will affect goldens Changes to golden files label Jan 25, 2025

made the test animatable

ee5b843

Merge branch 'master' into adjust-text-uvs

e69e8da

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 28, 2025

gaaclarke mentioned this pull request Jan 28, 2025

[impeller] adds golden test for jumping glyphs when scaling tests #161445

Closed

9 tasks

auto-submit bot added this pull request to the merge queue Jan 28, 2025

Merged via the queue into flutter:master with commit dc580af Jan 28, 2025
176 of 177 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 28, 2025

gaaclarke mentioned this pull request Jan 28, 2025

[Impeller] Jittery glyphs when animating text transformation #149652

Closed

danagbemava-nc mentioned this pull request Jan 29, 2025

Text cut off on Android with Impeller #162361

Closed

engine-flutter-autoroll mentioned this pull request Jan 29, 2025

Roll Flutter from c1ffaa9d9deb to b007899d3a7a (43 revisions) flutter/packages#8527

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 29, 2025

dc580af Started adjusting uvs to match pixel snapping. (flutter/flutt…

4755eb7

…er#162049)

gaaclarke added a commit that referenced this pull request Jan 29, 2025

Revert "Started adjusting uvs to match pixel snapping. (#162049)"

b80da44

This reverts commit dc580af.

gaaclarke mentioned this pull request Jan 29, 2025

Revert "Started adjusting uvs to match pixel snapping." #162391

Closed

gaaclarke added the revert Autorevert PR (with "Reason for revert:" comment) label Jan 29, 2025

This comment was marked as outdated.

Sign in to view

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jan 29, 2025

gaaclarke added the revert Autorevert PR (with "Reason for revert:" comment) label Jan 29, 2025

auto-submit bot pushed a commit that referenced this pull request Jan 29, 2025

Revert "Started adjusting uvs to match pixel snapping. (#162049)"

e04e42b

This reverts commit dc580af.

auto-submit bot mentioned this pull request Jan 29, 2025

Reverts "Started adjusting uvs to match pixel snapping. (#162049)" #162392

Merged

9 tasks

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jan 29, 2025

gaaclarke added a commit to gaaclarke/flutter that referenced this pull request Jan 30, 2025

Revert "Reverts "Started adjusting uvs to match pixel snapping. (flut…

aee09d9

…ter#162049)" (flutter#162392)" This reverts some of commit d048c77, just the testing parts.

gaaclarke mentioned this pull request Jan 30, 2025

Fixed some floating point inaccuracies in TextContents #162351

Merged

9 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

dc580af Started adjusting uvs to match pixel snapping. (flutter/flutt…

d129bd7

…er#162049)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

dc580af Started adjusting uvs to match pixel snapping. (flutter/flutt…

6cdeec4

…er#162049)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

dc580af Started adjusting uvs to match pixel snapping. (flutter/flutt…

eaab657

…er#162049)

Started adjusting uvs to match pixel snapping. #162049

Started adjusting uvs to match pixel snapping. #162049

Uh oh!

Conversation

gaaclarke commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before

After

Pre-launch Checklist

Uh oh!

gaaclarke commented Jan 23, 2025

Uh oh!

jonahwilliams commented Jan 23, 2025

Uh oh!

gaaclarke commented Jan 23, 2025

Uh oh!

gaaclarke commented Jan 23, 2025

Uh oh!

gaaclarke commented Jan 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

before

after

Uh oh!

gaaclarke commented Jan 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jan 24, 2025

Uh oh!

flutter-dashboard bot commented Jan 25, 2025

Uh oh!

gaaclarke commented Jan 25, 2025

Uh oh!

gaaclarke commented Jan 28, 2025

Uh oh!

Uh oh!

This comment was marked as outdated.

gaaclarke commented Jan 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gaaclarke commented Jan 23, 2025 •

edited

Loading

gaaclarke commented Jan 24, 2025 •

edited

Loading

gaaclarke commented Jan 24, 2025 •

edited

Loading