Skip to content

Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine. #161925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robert-ancell merged 2 commits into from
Jan 22, 2025
Merged

Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine. #161925

robert-ancell merged 2 commits into from
Jan 22, 2025

Conversation

@robert-ancell
Copy link
Contributor

@robert-ancell robert-ancell commented Jan 21, 2025

There can only be one handler that is shared between the views.

Move event redispatch matcher back into FlKeyboardManager - if a redispatched event was moved between views due to a focus change it would not be matched against.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-linux Building on or for Linux specifically a: desktop Running on desktop labels Jan 21, 2025
@robert-ancell
Copy link
Contributor Author

robert-ancell commented Jan 21, 2025

Builds on top of #161705

@robert-ancell robert-ancell mentioned this pull request Jan 21, 2025
Merged
@robert-ancell robert-ancell force-pushed the linux-move-keyboard-handler branch from a115e0e to a2ff4ee Compare January 22, 2025 02:03
@robert-ancell
Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine.
b16c1bd 
There can only be one handler that is shared between the views.
@robert-ancell
Move event redispatch matcher back into FlKeyboardManager -
0cd6167 
if a redispatched event was moved between views due to a
focus change it would not be matched against.
@robert-ancell robert-ancell force-pushed the linux-move-keyboard-handler branch from a2ff4ee to 0cd6167 Compare January 22, 2025 02:10
@robert-ancell
Copy link
Contributor Author

robert-ancell commented Jan 22, 2025

Rebased to make easier to review.

mattkae
mattkae approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The saga has ended 📖

@robert-ancell robert-ancell added this pull request to the merge queue Jan 22, 2025
Merged via the queue into flutter:master with commit 2d3bead Jan 22, 2025
179 of 180 checks passed
@robert-ancell robert-ancell deleted the linux-move-keyboard-handler branch January 22, 2025 22:26
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2025
@engine-flutter-autoroll
2d3bead Move FlKeyboardManager and FlKeyboardHandler from FlView to F…
032e8de 
…lEngine. (flutter/flutter#161925)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 23, 2025
@engine-flutter-autoroll
Manual roll Flutter from b9e86a5 to b2f515f (42 revisions) (#8482)
b346343 
Manual roll Flutter from b9e86a5 to b2f515f (42 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@b9e86a5...b2f515f

2025-01-22 a-siva@users.noreply.github.com Roll Dart to Version 3.8.0-24.0.dev (flutter/flutter#162035)
2025-01-22 nate.w5687@gmail.com `const AnimationStyle` (flutter/flutter#160564)
2025-01-22 matanlurey@users.noreply.github.com Add piping and bringup nodes for `_vulkan` and `_opengles` suites. (flutter/flutter#162020)
2025-01-22 flar@google.com [Impeller] Migrate unit tests off of Skia geometry classes (flutter/flutter#161855)
2025-01-22 matanlurey@users.noreply.github.com Experiment with a `files-changed.json` per PR (flutter/flutter#161788)
2025-01-22 robert.ancell@canonical.com Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine. (flutter/flutter#161925)
2025-01-22 engine-flutter-autoroll@skia.org Roll Packages from e8f1f63 to 3d3ab7b (1 revision) (flutter/flutter#162019)
2025-01-22 47866232+chunhtai@users.noreply.github.com Adds cupertino picker semantics test (flutter/flutter#161768)
2025-01-22 mdebbar@google.com [web] Remove deprecated web-only APIs from dart:ui (flutter/flutter#161775)
2025-01-22 34465683+rkishan516@users.noreply.github.com fix: Add enabled property for search anchor named constructor (flutter/flutter#161468)
2025-01-22 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162015)
2025-01-22 mdebbar@google.com [web] Remove spam from test output (flutter/flutter#161774)
2025-01-22 43089218+chika3742@users.noreply.github.com Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (2) (flutter/flutter#161577)
2025-01-22 matanlurey@users.noreply.github.com Make `font-subset` a standalone `run_tests.py` variant. (flutter/flutter#162016)
2025-01-22 kczarnota7@gmail.com Enabled provisioning updates and device registration during building xcarchive. (flutter/flutter#159622)
2025-01-22 mdebbar@google.com [web] Remove HTML from bots, test suites and e2e tests (flutter/flutter#161537)
2025-01-22 matanlurey@users.noreply.github.com Expand the `.ci.yaml` and `builder.json` linter (flutter/flutter#161991)
2025-01-22 37592940+sethmfuller@users.noreply.github.com Fix incorrect [enabled] documentation (flutter/flutter#161650)
2025-01-22 matanlurey@users.noreply.github.com Add `windows_host_engine_test`. (flutter/flutter#161992)
2025-01-22 a-siva@users.noreply.github.com Roll Dart to version Version 3.8.0-19.0.dev (flutter/flutter#161989)
2025-01-22 tessertaha@gmail.com Deprecate `ThemeData.indicatorColor` in favor of `TabBarThemeData.indicatorColor` (flutter/flutter#160024)
2025-01-22 jonahwilliams@google.com [Impeller] disable older xclipse gpu driver. (flutter/flutter#161981)
2025-01-22 jacksongardner@google.com Merge changelog for 3.27.3 release (flutter/flutter#161977)
2025-01-21 robert.ancell@canonical.com Remove FlKeyboardViewDelegate (flutter/flutter#161705)
2025-01-21 mernen@users.noreply.github.com Fix documentation of Flow.clipBehavior (flutter/flutter#161863)
2025-01-21 jonahwilliams@google.com [impeller] prevent PowerVR from using Vulkan backend. (flutter/flutter#161841)
2025-01-21 30870216+gaaclarke@users.noreply.github.com [Impeller] backfilling TextContents unit tests (flutter/flutter#161625)
2025-01-21 jason-simmons@users.noreply.github.com Do not handle Dart isolate messages if the isolate is being shut down (flutter/flutter#161824)
2025-01-21 mohellebiabdessalem@gmail.com fix failing lint : findByPath requires a specific ordering of project evaluation in `aar_init_script.gradle` (flutter/flutter#159301)
2025-01-21 jacksongardner@google.com Get `et` working for local web engine builds. (flutter/flutter#161825)
2025-01-21 magder@google.com Mark Linux_pixel_7pro flavors_test unflaky (flutter/flutter#160994)
2025-01-21 fluttergithubbot@gmail.com Marks Mac_mokey run_debug_test_android to be flaky (flutter/flutter#161656)
2025-01-21 saltedpotatos@users.noreply.github.com Don't crash flutter tool if Chrome is not available (flutter/flutter#154941)
2025-01-21 bruno.leroux@gmail.com Fix DropdownMenu icon and item icon misalignment (flutter/flutter#161717)
2025-01-21 dacoharkes@google.com [native assets] Cleanup dead code 2 (flutter/flutter#161916)
2025-01-21 tessertaha@gmail.com Update `ListTile` test to prevent log dump and test error message. (flutter/flutter#161811)
2025-01-21 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161924)
2025-01-21 31859944+LongCatIsLooong@users.noreply.github.com Make `PipelineOwner` a `base` class (flutter/flutter#161789)
2025-01-20 dacoharkes@google.com [native assets] Cleanup dead code (flutter/flutter#161913)
2025-01-20 engine-flutter-autoroll@skia.org Roll Packages from f73cb00 to e8f1f63 (9 revisions) (flutter/flutter#161914)
2025-01-20 bkonyi@google.com [ flutter_tool ] Fix flakiness in doctor_test.dart (flutter/flutter#161917)
2025-01-19 robert.ancell@canonical.com Update documentation on what display information is provided. (flutter/flutter#161785)

If this roll has caused a breakage, revert this CL and stop the roller
...
Wasmund1 pushed a commit to Wasmund1/flutter that referenced this pull request Jan 24, 2025
@robert-ancell
Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine. (…
ade6ad6 
…flutter#161925)

There can only be one handler that is shared between the views.

Move event redispatch matcher back into FlKeyboardManager - if a
redispatched event was moved between views due to a focus change it
would not be matched against.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
2d3bead Move FlKeyboardManager and FlKeyboardHandler from FlView to F…
90ad120 
…lEngine. (flutter/flutter#161925)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
2d3bead Move FlKeyboardManager and FlKeyboardHandler from FlView to F…
1974af7 
…lEngine. (flutter/flutter#161925)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
2d3bead Move FlKeyboardManager and FlKeyboardHandler from FlView to F…
4364b3b 
…lEngine. (flutter/flutter#161925)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from b9e86a5 to b2f515f (42 revisions) (flutter#8482
3b38e95 
)

Manual roll Flutter from b9e86a5 to b2f515f (42 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@b9e86a5...b2f515f

2025-01-22 a-siva@users.noreply.github.com Roll Dart to Version 3.8.0-24.0.dev (flutter/flutter#162035)
2025-01-22 nate.w5687@gmail.com `const AnimationStyle` (flutter/flutter#160564)
2025-01-22 matanlurey@users.noreply.github.com Add piping and bringup nodes for `_vulkan` and `_opengles` suites. (flutter/flutter#162020)
2025-01-22 flar@google.com [Impeller] Migrate unit tests off of Skia geometry classes (flutter/flutter#161855)
2025-01-22 matanlurey@users.noreply.github.com Experiment with a `files-changed.json` per PR (flutter/flutter#161788)
2025-01-22 robert.ancell@canonical.com Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine. (flutter/flutter#161925)
2025-01-22 engine-flutter-autoroll@skia.org Roll Packages from e8f1f63 to 3d3ab7b (1 revision) (flutter/flutter#162019)
2025-01-22 47866232+chunhtai@users.noreply.github.com Adds cupertino picker semantics test (flutter/flutter#161768)
2025-01-22 mdebbar@google.com [web] Remove deprecated web-only APIs from dart:ui (flutter/flutter#161775)
2025-01-22 34465683+rkishan516@users.noreply.github.com fix: Add enabled property for search anchor named constructor (flutter/flutter#161468)
2025-01-22 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162015)
2025-01-22 mdebbar@google.com [web] Remove spam from test output (flutter/flutter#161774)
2025-01-22 43089218+chika3742@users.noreply.github.com Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (2) (flutter/flutter#161577)
2025-01-22 matanlurey@users.noreply.github.com Make `font-subset` a standalone `run_tests.py` variant. (flutter/flutter#162016)
2025-01-22 kczarnota7@gmail.com Enabled provisioning updates and device registration during building xcarchive. (flutter/flutter#159622)
2025-01-22 mdebbar@google.com [web] Remove HTML from bots, test suites and e2e tests (flutter/flutter#161537)
2025-01-22 matanlurey@users.noreply.github.com Expand the `.ci.yaml` and `builder.json` linter (flutter/flutter#161991)
2025-01-22 37592940+sethmfuller@users.noreply.github.com Fix incorrect [enabled] documentation (flutter/flutter#161650)
2025-01-22 matanlurey@users.noreply.github.com Add `windows_host_engine_test`. (flutter/flutter#161992)
2025-01-22 a-siva@users.noreply.github.com Roll Dart to version Version 3.8.0-19.0.dev (flutter/flutter#161989)
2025-01-22 tessertaha@gmail.com Deprecate `ThemeData.indicatorColor` in favor of `TabBarThemeData.indicatorColor` (flutter/flutter#160024)
2025-01-22 jonahwilliams@google.com [Impeller] disable older xclipse gpu driver. (flutter/flutter#161981)
2025-01-22 jacksongardner@google.com Merge changelog for 3.27.3 release (flutter/flutter#161977)
2025-01-21 robert.ancell@canonical.com Remove FlKeyboardViewDelegate (flutter/flutter#161705)
2025-01-21 mernen@users.noreply.github.com Fix documentation of Flow.clipBehavior (flutter/flutter#161863)
2025-01-21 jonahwilliams@google.com [impeller] prevent PowerVR from using Vulkan backend. (flutter/flutter#161841)
2025-01-21 30870216+gaaclarke@users.noreply.github.com [Impeller] backfilling TextContents unit tests (flutter/flutter#161625)
2025-01-21 jason-simmons@users.noreply.github.com Do not handle Dart isolate messages if the isolate is being shut down (flutter/flutter#161824)
2025-01-21 mohellebiabdessalem@gmail.com fix failing lint : findByPath requires a specific ordering of project evaluation in `aar_init_script.gradle` (flutter/flutter#159301)
2025-01-21 jacksongardner@google.com Get `et` working for local web engine builds. (flutter/flutter#161825)
2025-01-21 magder@google.com Mark Linux_pixel_7pro flavors_test unflaky (flutter/flutter#160994)
2025-01-21 fluttergithubbot@gmail.com Marks Mac_mokey run_debug_test_android to be flaky (flutter/flutter#161656)
2025-01-21 saltedpotatos@users.noreply.github.com Don't crash flutter tool if Chrome is not available (flutter/flutter#154941)
2025-01-21 bruno.leroux@gmail.com Fix DropdownMenu icon and item icon misalignment (flutter/flutter#161717)
2025-01-21 dacoharkes@google.com [native assets] Cleanup dead code 2 (flutter/flutter#161916)
2025-01-21 tessertaha@gmail.com Update `ListTile` test to prevent log dump and test error message. (flutter/flutter#161811)
2025-01-21 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161924)
2025-01-21 31859944+LongCatIsLooong@users.noreply.github.com Make `PipelineOwner` a `base` class (flutter/flutter#161789)
2025-01-20 dacoharkes@google.com [native assets] Cleanup dead code (flutter/flutter#161913)
2025-01-20 engine-flutter-autoroll@skia.org Roll Packages from f73cb00 to e8f1f63 (9 revisions) (flutter/flutter#161914)
2025-01-20 bkonyi@google.com [ flutter_tool ] Fix flakiness in doctor_test.dart (flutter/flutter#161917)
2025-01-19 robert.ancell@canonical.com Update documentation on what display information is provided. (flutter/flutter#161785)

If this roll has caused a breakage, revert this CL and stop the roller
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from b9e86a5 to b2f515f (42 revisions) (flutter#8482
1e59947 
)

Manual roll Flutter from b9e86a5 to b2f515f (42 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@b9e86a5...b2f515f

2025-01-22 a-siva@users.noreply.github.com Roll Dart to Version 3.8.0-24.0.dev (flutter/flutter#162035)
2025-01-22 nate.w5687@gmail.com `const AnimationStyle` (flutter/flutter#160564)
2025-01-22 matanlurey@users.noreply.github.com Add piping and bringup nodes for `_vulkan` and `_opengles` suites. (flutter/flutter#162020)
2025-01-22 flar@google.com [Impeller] Migrate unit tests off of Skia geometry classes (flutter/flutter#161855)
2025-01-22 matanlurey@users.noreply.github.com Experiment with a `files-changed.json` per PR (flutter/flutter#161788)
2025-01-22 robert.ancell@canonical.com Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine. (flutter/flutter#161925)
2025-01-22 engine-flutter-autoroll@skia.org Roll Packages from e8f1f63 to 3d3ab7b (1 revision) (flutter/flutter#162019)
2025-01-22 47866232+chunhtai@users.noreply.github.com Adds cupertino picker semantics test (flutter/flutter#161768)
2025-01-22 mdebbar@google.com [web] Remove deprecated web-only APIs from dart:ui (flutter/flutter#161775)
2025-01-22 34465683+rkishan516@users.noreply.github.com fix: Add enabled property for search anchor named constructor (flutter/flutter#161468)
2025-01-22 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162015)
2025-01-22 mdebbar@google.com [web] Remove spam from test output (flutter/flutter#161774)
2025-01-22 43089218+chika3742@users.noreply.github.com Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (2) (flutter/flutter#161577)
2025-01-22 matanlurey@users.noreply.github.com Make `font-subset` a standalone `run_tests.py` variant. (flutter/flutter#162016)
2025-01-22 kczarnota7@gmail.com Enabled provisioning updates and device registration during building xcarchive. (flutter/flutter#159622)
2025-01-22 mdebbar@google.com [web] Remove HTML from bots, test suites and e2e tests (flutter/flutter#161537)
2025-01-22 matanlurey@users.noreply.github.com Expand the `.ci.yaml` and `builder.json` linter (flutter/flutter#161991)
2025-01-22 37592940+sethmfuller@users.noreply.github.com Fix incorrect [enabled] documentation (flutter/flutter#161650)
2025-01-22 matanlurey@users.noreply.github.com Add `windows_host_engine_test`. (flutter/flutter#161992)
2025-01-22 a-siva@users.noreply.github.com Roll Dart to version Version 3.8.0-19.0.dev (flutter/flutter#161989)
2025-01-22 tessertaha@gmail.com Deprecate `ThemeData.indicatorColor` in favor of `TabBarThemeData.indicatorColor` (flutter/flutter#160024)
2025-01-22 jonahwilliams@google.com [Impeller] disable older xclipse gpu driver. (flutter/flutter#161981)
2025-01-22 jacksongardner@google.com Merge changelog for 3.27.3 release (flutter/flutter#161977)
2025-01-21 robert.ancell@canonical.com Remove FlKeyboardViewDelegate (flutter/flutter#161705)
2025-01-21 mernen@users.noreply.github.com Fix documentation of Flow.clipBehavior (flutter/flutter#161863)
2025-01-21 jonahwilliams@google.com [impeller] prevent PowerVR from using Vulkan backend. (flutter/flutter#161841)
2025-01-21 30870216+gaaclarke@users.noreply.github.com [Impeller] backfilling TextContents unit tests (flutter/flutter#161625)
2025-01-21 jason-simmons@users.noreply.github.com Do not handle Dart isolate messages if the isolate is being shut down (flutter/flutter#161824)
2025-01-21 mohellebiabdessalem@gmail.com fix failing lint : findByPath requires a specific ordering of project evaluation in `aar_init_script.gradle` (flutter/flutter#159301)
2025-01-21 jacksongardner@google.com Get `et` working for local web engine builds. (flutter/flutter#161825)
2025-01-21 magder@google.com Mark Linux_pixel_7pro flavors_test unflaky (flutter/flutter#160994)
2025-01-21 fluttergithubbot@gmail.com Marks Mac_mokey run_debug_test_android to be flaky (flutter/flutter#161656)
2025-01-21 saltedpotatos@users.noreply.github.com Don't crash flutter tool if Chrome is not available (flutter/flutter#154941)
2025-01-21 bruno.leroux@gmail.com Fix DropdownMenu icon and item icon misalignment (flutter/flutter#161717)
2025-01-21 dacoharkes@google.com [native assets] Cleanup dead code 2 (flutter/flutter#161916)
2025-01-21 tessertaha@gmail.com Update `ListTile` test to prevent log dump and test error message. (flutter/flutter#161811)
2025-01-21 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161924)
2025-01-21 31859944+LongCatIsLooong@users.noreply.github.com Make `PipelineOwner` a `base` class (flutter/flutter#161789)
2025-01-20 dacoharkes@google.com [native assets] Cleanup dead code (flutter/flutter#161913)
2025-01-20 engine-flutter-autoroll@skia.org Roll Packages from f73cb00 to e8f1f63 (9 revisions) (flutter/flutter#161914)
2025-01-20 bkonyi@google.com [ flutter_tool ] Fix flakiness in doctor_test.dart (flutter/flutter#161917)
2025-01-19 robert.ancell@canonical.com Update documentation on what display information is provided. (flutter/flutter#161785)

If this roll has caused a breakage, revert this CL and stop the roller
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattkae mattkae mattkae approved these changes

@cbracken cbracken Awaiting requested review from cbracken

Assignees

No one assigned

Labels

a: desktop Running on desktop engine flutter/engine related. See also e: labels. platform-linux Building on or for Linux specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robert-ancell @mattkae