Skip to content

Deprecate ThemeData.indicatorColor in favor of TabBarThemeData.indicatorColor #160024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Jan 22, 2025
Merged

Deprecate ThemeData.indicatorColor in favor of TabBarThemeData.indicatorColor #160024

auto-submit merged 4 commits into from
Jan 22, 2025

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Dec 10, 2024

Related to ☂️ Material Theme System Updates

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. c: tech-debt Technical debt, code quality, testing, etc. labels Dec 10, 2024
@TahaTesser TahaTesser changed the title Deprecate ThemeData.indicatorColor in favor of TabBarThemeData.ind icatorColor Deprecate ThemeData.indicatorColor in favor of TabBarThemeData.indicatorColor Dec 10, 2024
@TahaTesser TahaTesser marked this pull request as ready for review December 10, 2024 13:03
@TahaTesser TahaTesser mentioned this pull request Dec 10, 2024
Merged
4 tasks
@TahaTesser
Copy link
Member Author

TahaTesser commented Dec 10, 2024

Migration guide is ready as well flutter/website#11481

sfshaza2 added a commit to flutter/website that referenced this pull request Dec 12, 2024
@TahaTesser @sfshaza2
Migration guide for ThemeData.indicatorColor deprecation (#11481)
9a82e91 
Related to flutter/flutter#155072
PR deprecating `ThemeData.indicatorColor`
flutter/flutter#160024

## Presubmit checklist

- [x] This PR is marked as draft with an explanation if not meant to
land until a future stable release.
- [x] This PR doesn’t contain automatically generated corrections
(Grammarly or similar).
- [x] This PR follows the [Google Developer Documentation Style
Guidelines](https://developers.google.com/style) — for example, it
doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person).
- [x] This PR uses [semantic line
breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks)
of 80 characters or fewer.

---------

Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
QuncCccccc
QuncCccccc reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for continuing to help with the Material theme system cleanup! Just left one comment for M2 default TabBarThemeData.

@QuncCccccc QuncCccccc self-requested a review January 15, 2025 19:17
@Piinks
Copy link
Contributor

Piinks commented Jan 15, 2025 •
edited
Loading

Flyby comment from triage: Looks like CI is unhappy. :(

QuncCccccc
QuncCccccc approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

packages/flutter/test/material/theme_data_test.dart
toggleButtonsTheme: const ToggleButtonsThemeData(textStyle: TextStyle(color: Colors.black)),
tooltipTheme: const TooltipThemeData(height: 100),
// DEPRECATED (newest deprecations at the bottom)
buttonBarTheme: const ButtonBarThemeData(alignment: MainAxisAlignment.start),
Copy link
Contributor

@QuncCccccc QuncCccccc Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks for reorganizing this and below!

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jan 22, 2025
Merged via the queue into flutter:master with commit 9adbc51 Jan 22, 2025
104 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2025
@engine-flutter-autoroll
9adbc51 Deprecate ThemeData.indicatorColor in favor of `TabBarTheme…
5c65a7b 
…Data.indicatorColor` (flutter/flutter#160024)
@TahaTesser TahaTesser deleted the deprecate_theme_data_indicator_color branch January 22, 2025 15:10
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2025
@engine-flutter-autoroll
9adbc51 Deprecate ThemeData.indicatorColor in favor of `TabBarTheme…
75b894f 
…Data.indicatorColor` (flutter/flutter#160024)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 22, 2025
@engine-flutter-autoroll
9adbc51 Deprecate ThemeData.indicatorColor in favor of `TabBarTheme…
f86e930 
…Data.indicatorColor` (flutter/flutter#160024)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 23, 2025
@engine-flutter-autoroll
Manual roll Flutter from b9e86a5 to b2f515f (42 revisions) (#8482)
b346343 
Manual roll Flutter from b9e86a5 to b2f515f (42 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@b9e86a5...b2f515f

2025-01-22 a-siva@users.noreply.github.com Roll Dart to Version 3.8.0-24.0.dev (flutter/flutter#162035)
2025-01-22 nate.w5687@gmail.com `const AnimationStyle` (flutter/flutter#160564)
2025-01-22 matanlurey@users.noreply.github.com Add piping and bringup nodes for `_vulkan` and `_opengles` suites. (flutter/flutter#162020)
2025-01-22 flar@google.com [Impeller] Migrate unit tests off of Skia geometry classes (flutter/flutter#161855)
2025-01-22 matanlurey@users.noreply.github.com Experiment with a `files-changed.json` per PR (flutter/flutter#161788)
2025-01-22 robert.ancell@canonical.com Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine. (flutter/flutter#161925)
2025-01-22 engine-flutter-autoroll@skia.org Roll Packages from e8f1f63 to 3d3ab7b (1 revision) (flutter/flutter#162019)
2025-01-22 47866232+chunhtai@users.noreply.github.com Adds cupertino picker semantics test (flutter/flutter#161768)
2025-01-22 mdebbar@google.com [web] Remove deprecated web-only APIs from dart:ui (flutter/flutter#161775)
2025-01-22 34465683+rkishan516@users.noreply.github.com fix: Add enabled property for search anchor named constructor (flutter/flutter#161468)
2025-01-22 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162015)
2025-01-22 mdebbar@google.com [web] Remove spam from test output (flutter/flutter#161774)
2025-01-22 43089218+chika3742@users.noreply.github.com Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (2) (flutter/flutter#161577)
2025-01-22 matanlurey@users.noreply.github.com Make `font-subset` a standalone `run_tests.py` variant. (flutter/flutter#162016)
2025-01-22 kczarnota7@gmail.com Enabled provisioning updates and device registration during building xcarchive. (flutter/flutter#159622)
2025-01-22 mdebbar@google.com [web] Remove HTML from bots, test suites and e2e tests (flutter/flutter#161537)
2025-01-22 matanlurey@users.noreply.github.com Expand the `.ci.yaml` and `builder.json` linter (flutter/flutter#161991)
2025-01-22 37592940+sethmfuller@users.noreply.github.com Fix incorrect [enabled] documentation (flutter/flutter#161650)
2025-01-22 matanlurey@users.noreply.github.com Add `windows_host_engine_test`. (flutter/flutter#161992)
2025-01-22 a-siva@users.noreply.github.com Roll Dart to version Version 3.8.0-19.0.dev (flutter/flutter#161989)
2025-01-22 tessertaha@gmail.com Deprecate `ThemeData.indicatorColor` in favor of `TabBarThemeData.indicatorColor` (flutter/flutter#160024)
2025-01-22 jonahwilliams@google.com [Impeller] disable older xclipse gpu driver. (flutter/flutter#161981)
2025-01-22 jacksongardner@google.com Merge changelog for 3.27.3 release (flutter/flutter#161977)
2025-01-21 robert.ancell@canonical.com Remove FlKeyboardViewDelegate (flutter/flutter#161705)
2025-01-21 mernen@users.noreply.github.com Fix documentation of Flow.clipBehavior (flutter/flutter#161863)
2025-01-21 jonahwilliams@google.com [impeller] prevent PowerVR from using Vulkan backend. (flutter/flutter#161841)
2025-01-21 30870216+gaaclarke@users.noreply.github.com [Impeller] backfilling TextContents unit tests (flutter/flutter#161625)
2025-01-21 jason-simmons@users.noreply.github.com Do not handle Dart isolate messages if the isolate is being shut down (flutter/flutter#161824)
2025-01-21 mohellebiabdessalem@gmail.com fix failing lint : findByPath requires a specific ordering of project evaluation in `aar_init_script.gradle` (flutter/flutter#159301)
2025-01-21 jacksongardner@google.com Get `et` working for local web engine builds. (flutter/flutter#161825)
2025-01-21 magder@google.com Mark Linux_pixel_7pro flavors_test unflaky (flutter/flutter#160994)
2025-01-21 fluttergithubbot@gmail.com Marks Mac_mokey run_debug_test_android to be flaky (flutter/flutter#161656)
2025-01-21 saltedpotatos@users.noreply.github.com Don't crash flutter tool if Chrome is not available (flutter/flutter#154941)
2025-01-21 bruno.leroux@gmail.com Fix DropdownMenu icon and item icon misalignment (flutter/flutter#161717)
2025-01-21 dacoharkes@google.com [native assets] Cleanup dead code 2 (flutter/flutter#161916)
2025-01-21 tessertaha@gmail.com Update `ListTile` test to prevent log dump and test error message. (flutter/flutter#161811)
2025-01-21 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161924)
2025-01-21 31859944+LongCatIsLooong@users.noreply.github.com Make `PipelineOwner` a `base` class (flutter/flutter#161789)
2025-01-20 dacoharkes@google.com [native assets] Cleanup dead code (flutter/flutter#161913)
2025-01-20 engine-flutter-autoroll@skia.org Roll Packages from f73cb00 to e8f1f63 (9 revisions) (flutter/flutter#161914)
2025-01-20 bkonyi@google.com [ flutter_tool ] Fix flakiness in doctor_test.dart (flutter/flutter#161917)
2025-01-19 robert.ancell@canonical.com Update documentation on what display information is provided. (flutter/flutter#161785)

If this roll has caused a breakage, revert this CL and stop the roller
...
Wasmund1 pushed a commit to Wasmund1/flutter that referenced this pull request Jan 24, 2025
@TahaTesser
Deprecate ThemeData.indicatorColor in favor of `TabBarThemeData.ind…
d9cf6a1 
…icatorColor` (flutter#160024)

Related to [☂️ Material Theme System
Updates](flutter#91772)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
@Piinks Piinks mentioned this pull request Jan 24, 2025
Open
@guidezpl guidezpl mentioned this pull request Jan 28, 2025
Open
43 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
9adbc51 Deprecate ThemeData.indicatorColor in favor of `TabBarTheme…
3c21aed 
…Data.indicatorColor` (flutter/flutter#160024)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
9adbc51 Deprecate ThemeData.indicatorColor in favor of `TabBarTheme…
b1e9661 
…Data.indicatorColor` (flutter/flutter#160024)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
9adbc51 Deprecate ThemeData.indicatorColor in favor of `TabBarTheme…
6963c0a 
…Data.indicatorColor` (flutter/flutter#160024)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from b9e86a5 to b2f515f (42 revisions) (flutter#8482
3b38e95 
)

Manual roll Flutter from b9e86a5 to b2f515f (42 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@b9e86a5...b2f515f

2025-01-22 a-siva@users.noreply.github.com Roll Dart to Version 3.8.0-24.0.dev (flutter/flutter#162035)
2025-01-22 nate.w5687@gmail.com `const AnimationStyle` (flutter/flutter#160564)
2025-01-22 matanlurey@users.noreply.github.com Add piping and bringup nodes for `_vulkan` and `_opengles` suites. (flutter/flutter#162020)
2025-01-22 flar@google.com [Impeller] Migrate unit tests off of Skia geometry classes (flutter/flutter#161855)
2025-01-22 matanlurey@users.noreply.github.com Experiment with a `files-changed.json` per PR (flutter/flutter#161788)
2025-01-22 robert.ancell@canonical.com Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine. (flutter/flutter#161925)
2025-01-22 engine-flutter-autoroll@skia.org Roll Packages from e8f1f63 to 3d3ab7b (1 revision) (flutter/flutter#162019)
2025-01-22 47866232+chunhtai@users.noreply.github.com Adds cupertino picker semantics test (flutter/flutter#161768)
2025-01-22 mdebbar@google.com [web] Remove deprecated web-only APIs from dart:ui (flutter/flutter#161775)
2025-01-22 34465683+rkishan516@users.noreply.github.com fix: Add enabled property for search anchor named constructor (flutter/flutter#161468)
2025-01-22 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162015)
2025-01-22 mdebbar@google.com [web] Remove spam from test output (flutter/flutter#161774)
2025-01-22 43089218+chika3742@users.noreply.github.com Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (2) (flutter/flutter#161577)
2025-01-22 matanlurey@users.noreply.github.com Make `font-subset` a standalone `run_tests.py` variant. (flutter/flutter#162016)
2025-01-22 kczarnota7@gmail.com Enabled provisioning updates and device registration during building xcarchive. (flutter/flutter#159622)
2025-01-22 mdebbar@google.com [web] Remove HTML from bots, test suites and e2e tests (flutter/flutter#161537)
2025-01-22 matanlurey@users.noreply.github.com Expand the `.ci.yaml` and `builder.json` linter (flutter/flutter#161991)
2025-01-22 37592940+sethmfuller@users.noreply.github.com Fix incorrect [enabled] documentation (flutter/flutter#161650)
2025-01-22 matanlurey@users.noreply.github.com Add `windows_host_engine_test`. (flutter/flutter#161992)
2025-01-22 a-siva@users.noreply.github.com Roll Dart to version Version 3.8.0-19.0.dev (flutter/flutter#161989)
2025-01-22 tessertaha@gmail.com Deprecate `ThemeData.indicatorColor` in favor of `TabBarThemeData.indicatorColor` (flutter/flutter#160024)
2025-01-22 jonahwilliams@google.com [Impeller] disable older xclipse gpu driver. (flutter/flutter#161981)
2025-01-22 jacksongardner@google.com Merge changelog for 3.27.3 release (flutter/flutter#161977)
2025-01-21 robert.ancell@canonical.com Remove FlKeyboardViewDelegate (flutter/flutter#161705)
2025-01-21 mernen@users.noreply.github.com Fix documentation of Flow.clipBehavior (flutter/flutter#161863)
2025-01-21 jonahwilliams@google.com [impeller] prevent PowerVR from using Vulkan backend. (flutter/flutter#161841)
2025-01-21 30870216+gaaclarke@users.noreply.github.com [Impeller] backfilling TextContents unit tests (flutter/flutter#161625)
2025-01-21 jason-simmons@users.noreply.github.com Do not handle Dart isolate messages if the isolate is being shut down (flutter/flutter#161824)
2025-01-21 mohellebiabdessalem@gmail.com fix failing lint : findByPath requires a specific ordering of project evaluation in `aar_init_script.gradle` (flutter/flutter#159301)
2025-01-21 jacksongardner@google.com Get `et` working for local web engine builds. (flutter/flutter#161825)
2025-01-21 magder@google.com Mark Linux_pixel_7pro flavors_test unflaky (flutter/flutter#160994)
2025-01-21 fluttergithubbot@gmail.com Marks Mac_mokey run_debug_test_android to be flaky (flutter/flutter#161656)
2025-01-21 saltedpotatos@users.noreply.github.com Don't crash flutter tool if Chrome is not available (flutter/flutter#154941)
2025-01-21 bruno.leroux@gmail.com Fix DropdownMenu icon and item icon misalignment (flutter/flutter#161717)
2025-01-21 dacoharkes@google.com [native assets] Cleanup dead code 2 (flutter/flutter#161916)
2025-01-21 tessertaha@gmail.com Update `ListTile` test to prevent log dump and test error message. (flutter/flutter#161811)
2025-01-21 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161924)
2025-01-21 31859944+LongCatIsLooong@users.noreply.github.com Make `PipelineOwner` a `base` class (flutter/flutter#161789)
2025-01-20 dacoharkes@google.com [native assets] Cleanup dead code (flutter/flutter#161913)
2025-01-20 engine-flutter-autoroll@skia.org Roll Packages from f73cb00 to e8f1f63 (9 revisions) (flutter/flutter#161914)
2025-01-20 bkonyi@google.com [ flutter_tool ] Fix flakiness in doctor_test.dart (flutter/flutter#161917)
2025-01-19 robert.ancell@canonical.com Update documentation on what display information is provided. (flutter/flutter#161785)

If this roll has caused a breakage, revert this CL and stop the roller
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from b9e86a5 to b2f515f (42 revisions) (flutter#8482
1e59947 
)

Manual roll Flutter from b9e86a5 to b2f515f (42 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@b9e86a5...b2f515f

2025-01-22 a-siva@users.noreply.github.com Roll Dart to Version 3.8.0-24.0.dev (flutter/flutter#162035)
2025-01-22 nate.w5687@gmail.com `const AnimationStyle` (flutter/flutter#160564)
2025-01-22 matanlurey@users.noreply.github.com Add piping and bringup nodes for `_vulkan` and `_opengles` suites. (flutter/flutter#162020)
2025-01-22 flar@google.com [Impeller] Migrate unit tests off of Skia geometry classes (flutter/flutter#161855)
2025-01-22 matanlurey@users.noreply.github.com Experiment with a `files-changed.json` per PR (flutter/flutter#161788)
2025-01-22 robert.ancell@canonical.com Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine. (flutter/flutter#161925)
2025-01-22 engine-flutter-autoroll@skia.org Roll Packages from e8f1f63 to 3d3ab7b (1 revision) (flutter/flutter#162019)
2025-01-22 47866232+chunhtai@users.noreply.github.com Adds cupertino picker semantics test (flutter/flutter#161768)
2025-01-22 mdebbar@google.com [web] Remove deprecated web-only APIs from dart:ui (flutter/flutter#161775)
2025-01-22 34465683+rkishan516@users.noreply.github.com fix: Add enabled property for search anchor named constructor (flutter/flutter#161468)
2025-01-22 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162015)
2025-01-22 mdebbar@google.com [web] Remove spam from test output (flutter/flutter#161774)
2025-01-22 43089218+chika3742@users.noreply.github.com Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (2) (flutter/flutter#161577)
2025-01-22 matanlurey@users.noreply.github.com Make `font-subset` a standalone `run_tests.py` variant. (flutter/flutter#162016)
2025-01-22 kczarnota7@gmail.com Enabled provisioning updates and device registration during building xcarchive. (flutter/flutter#159622)
2025-01-22 mdebbar@google.com [web] Remove HTML from bots, test suites and e2e tests (flutter/flutter#161537)
2025-01-22 matanlurey@users.noreply.github.com Expand the `.ci.yaml` and `builder.json` linter (flutter/flutter#161991)
2025-01-22 37592940+sethmfuller@users.noreply.github.com Fix incorrect [enabled] documentation (flutter/flutter#161650)
2025-01-22 matanlurey@users.noreply.github.com Add `windows_host_engine_test`. (flutter/flutter#161992)
2025-01-22 a-siva@users.noreply.github.com Roll Dart to version Version 3.8.0-19.0.dev (flutter/flutter#161989)
2025-01-22 tessertaha@gmail.com Deprecate `ThemeData.indicatorColor` in favor of `TabBarThemeData.indicatorColor` (flutter/flutter#160024)
2025-01-22 jonahwilliams@google.com [Impeller] disable older xclipse gpu driver. (flutter/flutter#161981)
2025-01-22 jacksongardner@google.com Merge changelog for 3.27.3 release (flutter/flutter#161977)
2025-01-21 robert.ancell@canonical.com Remove FlKeyboardViewDelegate (flutter/flutter#161705)
2025-01-21 mernen@users.noreply.github.com Fix documentation of Flow.clipBehavior (flutter/flutter#161863)
2025-01-21 jonahwilliams@google.com [impeller] prevent PowerVR from using Vulkan backend. (flutter/flutter#161841)
2025-01-21 30870216+gaaclarke@users.noreply.github.com [Impeller] backfilling TextContents unit tests (flutter/flutter#161625)
2025-01-21 jason-simmons@users.noreply.github.com Do not handle Dart isolate messages if the isolate is being shut down (flutter/flutter#161824)
2025-01-21 mohellebiabdessalem@gmail.com fix failing lint : findByPath requires a specific ordering of project evaluation in `aar_init_script.gradle` (flutter/flutter#159301)
2025-01-21 jacksongardner@google.com Get `et` working for local web engine builds. (flutter/flutter#161825)
2025-01-21 magder@google.com Mark Linux_pixel_7pro flavors_test unflaky (flutter/flutter#160994)
2025-01-21 fluttergithubbot@gmail.com Marks Mac_mokey run_debug_test_android to be flaky (flutter/flutter#161656)
2025-01-21 saltedpotatos@users.noreply.github.com Don't crash flutter tool if Chrome is not available (flutter/flutter#154941)
2025-01-21 bruno.leroux@gmail.com Fix DropdownMenu icon and item icon misalignment (flutter/flutter#161717)
2025-01-21 dacoharkes@google.com [native assets] Cleanup dead code 2 (flutter/flutter#161916)
2025-01-21 tessertaha@gmail.com Update `ListTile` test to prevent log dump and test error message. (flutter/flutter#161811)
2025-01-21 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161924)
2025-01-21 31859944+LongCatIsLooong@users.noreply.github.com Make `PipelineOwner` a `base` class (flutter/flutter#161789)
2025-01-20 dacoharkes@google.com [native assets] Cleanup dead code (flutter/flutter#161913)
2025-01-20 engine-flutter-autoroll@skia.org Roll Packages from f73cb00 to e8f1f63 (9 revisions) (flutter/flutter#161914)
2025-01-20 bkonyi@google.com [ flutter_tool ] Fix flakiness in doctor_test.dart (flutter/flutter#161917)
2025-01-19 robert.ancell@canonical.com Update documentation on what display information is provided. (flutter/flutter#161785)

If this roll has caused a breakage, revert this CL and stop the roller
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuncCccccc QuncCccccc QuncCccccc approved these changes

Assignees

No one assigned

Labels

c: tech-debt Technical debt, code quality, testing, etc. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TahaTesser @Piinks @QuncCccccc