Move validation logic for .ci.yaml to flutter/flutter.
#161249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Jan 7, 2025
| @@ -0,0 +1,161 @@ | |||
| // Copyright 2014 The Flutter Authors. All rights reserved. | |||
Contributor
There was a problem hiding this comment.
What causes this test to run? Do we glob everything under dev/bots/test?
Contributor
Author
There was a problem hiding this comment.
Hmm I'm not sure, I was going to spelunk through the logs but maybe @christopherfujino knows off hand.
Contributor
There was a problem hiding this comment.
| import './common.dart'; | ||
|
|
||
| void main() { | ||
| final String flutterRoot = () { |
Contributor
There was a problem hiding this comment.
Maybe just do $(which flutter)/../..?
Contributor
Author
|
Will wait for an LGTM from @christopherfujino before moving forward. |
Contributor
oops yeah, was taking a look at this and got distracted. una momento... |
auto-submit bot
pushed a commit
to flutter/cocoon
that referenced
this pull request
Jan 7, 2025
) Closes flutter/flutter#160915. This exact logic was moved to flutter/flutter in flutter/flutter#161249.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 8, 2025
srujzs
pushed a commit
to srujzs/flutter
that referenced
this pull request
Jan 12, 2025
…61249) Towards flutter#160915 (future cleanup: remove the validation from `flutter/cocoon`). This PR effectively duplicates the logic in flutter/cocoon#4137, in `flutter/flutter`. /cc @jtmcdole
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #160915 (future cleanup: remove the validation from
flutter/cocoon).This PR effectively duplicates the logic in flutter/cocoon#4137, in
flutter/flutter./cc @jtmcdole