Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 #157032

gmackall · 2024-10-16T19:17:39Z

I recently noticed the following log when building an app in verbose mode:

This Android Gradle plugin (8.1.0) was tested up to compileSdk = 33 (and compileSdkPreview = "UpsideDownCakePrivacySandbox").
You are strongly encouraged to update your project to use a newer
Android Gradle plugin that has been tested with compileSdk = 35.

It looks like AGP would like us to use a newer AGP version if we want to use compileSdk 35 (which we do). This pr upgrades the tests, in advance of updating the templates.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gmackall · 2024-10-16T19:19:09Z

dev/tools/bin/generate_gradle_lockfiles.dart

@@ -83,6 +83,7 @@ void main(List<String> arguments) {
        (loadYaml(exclusionFile.readAsStringSync()) as YamlList)
            .toList()
            .cast<String>()
+            .map((String s) => '${repoRoot.path}/$s')


Exclusion was broken because of the change to how the script was intended to be run (it used to take relative directories, and was changed to absolute directories implicitly when it was changed to no longer take the output of find ... via a pipe operator).

…nto upgrade_to_agp87

gmackall · 2024-10-23T19:33:02Z

Converting back to draft to address these comments,
#156502 (comment)
forgot to get to them initially

bartekpacia

LGTM (I assume it's only version bumps in gradle wrapper config file and lockfiles changes)

bartekpacia · 2024-10-23T19:57:03Z

BTW (offtop, not related to this issue)

Currently the Android app created by flutter create doesn't compile with the latest stable Java (23), which is the default that is installed with e.g. brew install openjdk. This is because the template uses Gradle 8.3 and AGP 8.1:

flutter/packages/flutter_tools/lib/src/android/gradle_utils.dart

Lines 29 to 32 in eccf4ee

    
           const String templateDefaultGradleVersion = '8.3'; 
        
           const String templateAndroidGradlePluginVersion = '8.1.0'; 
        
           const String templateAndroidGradlePluginVersionForModule = '8.1.0'; 
        
           const String templateKotlinGradlePluginVersion = '1.8.22';

It'd be cool to update the app template to use Gradle 8.10.x, which is the only version that supports Java 23.

gmackall · 2024-10-23T19:59:48Z

BTW (offtop, not related to this issue)

Currently the Android app created by flutter create doesn't compile with the latest stable Java (23), which is the default that is installed with e.g. brew install openjdk.

It'd be cool to update the app template to use Gradle 8.10.x, which is the only version that supports Java 23.

I don't mind updating this pr to use Gradle 8.10 and then having that be the default version in the templates. I generally find Gradle updates to be painless anyways (unlike AGP a lot of the time).

bartekpacia · 2024-10-23T20:20:32Z

That'd be cool, if it indeed turns out to be as simple as changing "8.7" to "8.10.2", let's go for it.

gmackall · 2024-10-24T21:04:54Z

I'm going to speculatively revert this: The tree seems blocked on some android tests - they all pass for me locally... but I doubt it was any of the later PRs, and they aren't passing on retry.

gmackall · 2024-10-24T21:05:05Z

Reason for revert: #157032 (comment)

This reverts commit 5ca6350.

…" (#157559) Reverts: #157032 Initiated by: gmackall Reason for reverting: #157032 (comment) Original PR Author: gmackall Reviewed By: {reidbaker, bartekpacia} This change reverts the following previous change: I recently noticed the following log when building an app in verbose mode: ``` This Android Gradle plugin (8.1.0) was tested up to compileSdk = 33 (and compileSdkPreview = "UpsideDownCakePrivacySandbox"). You are strongly encouraged to update your project to use a newer Android Gradle plugin that has been tested with compileSdk = 35. ``` It looks like AGP would like us to use a newer AGP version if we want to use compileSdk 35 (which we do). This pr upgrades the tests, in advance of updating the templates.

…/flutter#157032)

…flutter#157032)" (flutter#157559)" This reverts commit b98d9a3.

…/flutter#157032)

Roll Flutter from 4faa4a4 to 5a11904 (67 revisions) flutter/flutter@4faa4a4...5a11904 2024-10-26 30870216+gaaclarke@users.noreply.github.com Relands "Wide gamut framework gradient test (#153976)" (flutter/flutter#157643) 2024-10-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c5c5fe5c84d to c9b8ac96f6ce (3 revisions) (flutter/flutter#157662) 2024-10-26 32538273+ValentinVignal@users.noreply.github.com Add test for `navigator_state.restorable_push_and_remove_until.0.dart` (flutter/flutter#157595) 2024-10-26 matanlurey@users.noreply.github.com Tighten up `throwToolExit`, explain when to use it. (flutter/flutter#157561) 2024-10-26 matanlurey@users.noreply.github.com Remove extraneous `throw`. (flutter/flutter#157658) 2024-10-26 32538273+ValentinVignal@users.noreply.github.com Add tests for `navigator.restorable_push.0.dart` (flutter/flutter#157492) 2024-10-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 43e4d9a30666 to 7c5c5fe5c84d (1 revision) (flutter/flutter#157644) 2024-10-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5061358e255f to 43e4d9a30666 (1 revision) (flutter/flutter#157637) 2024-10-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from eb867e055790 to 5061358e255f (2 revisions) (flutter/flutter#157623) 2024-10-25 polinach@google.com Create flutter specific leak troubleshooting guidance. (flutter/flutter#157396) 2024-10-25 katelovett@google.com Update CupertinoNavigationBar to support large layout (flutter/flutter#157133) 2024-10-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 38e9be1f74fa to eb867e055790 (3 revisions) (flutter/flutter#157613) 2024-10-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Wide gamut framework gradient test (#153976)" (flutter/flutter#157615) 2024-10-25 30870216+gaaclarke@users.noreply.github.com Wide gamut framework gradient test (flutter/flutter#153976) 2024-10-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from b413d9996c86 to 38e9be1f74fa (2 revisions) (flutter/flutter#157604) 2024-10-25 engine-flutter-autoroll@skia.org Roll Packages from a556f0f to e0c4f55 (2 revisions) (flutter/flutter#157605) 2024-10-25 jonahwilliams@google.com Support backdrop key in flutter framework. (flutter/flutter#157278) 2024-10-25 reidbaker@google.com Add 3.24.4 changelog to master (flutter/flutter#157600) 2024-10-25 mohellebiabdessalem@gmail.com Update flutter.groovy to catch unknown task exception when finding api task (flutter/flutter#157282) 2024-10-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from c4b0184c8783 to b413d9996c86 (1 revision) (flutter/flutter#157580) 2024-10-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from b1c2ba8c4d52 to c4b0184c8783 (1 revision) (flutter/flutter#157578) 2024-10-25 32538273+ValentinVignal@users.noreply.github.com Add test for `build_owner.0.dart` (flutter/flutter#157499) 2024-10-25 32538273+ValentinVignal@users.noreply.github.com Add tests for `focusable_action_detector.0.dart` (flutter/flutter#157575) 2024-10-25 32538273+ValentinVignal@users.noreply.github.com Add test for `navigator.restorable_push_and_remove_until.0.dart` (flutter/flutter#157487) 2024-10-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 29440ed1e225 to b1c2ba8c4d52 (1 revision) (flutter/flutter#157572) 2024-10-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 88716d804aef to 29440ed1e225 (1 revision) (flutter/flutter#157569) 2024-10-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from b8b28c80a737 to 88716d804aef (2 revisions) (flutter/flutter#157567) 2024-10-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 48ff670d256b to b8b28c80a737 (2 revisions) (flutter/flutter#157564) 2024-10-24 matanlurey@users.noreply.github.com Use discenrable characters (replace `' ð�� ð�� '` in error logs) (flutter/flutter#157548) 2024-10-24 matanlurey@users.noreply.github.com Remove unused `PubDependenciesProjectValidator`. (flutter/flutter#157516) 2024-10-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (#157032)" (flutter/flutter#157559) 2024-10-24 jonahwilliams@google.com Mark mac impeller as bringup. (flutter/flutter#157551) 2024-10-24 tessertaha@gmail.com Deprecate `ThemeData.dialogBackgroundColor` in favor of `DialogThemeData.backgroundColor` (flutter/flutter#155072) 2024-10-24 34871572+gmackall@users.noreply.github.com Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (flutter/flutter#157032) 2024-10-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 246344f26edc to 48ff670d256b (2 revisions) (flutter/flutter#157544) 2024-10-24 matanlurey@users.noreply.github.com Allow opting out of `.flutter-plugins`, opt-out in `refreshPluginsList`. (flutter/flutter#157527) 2024-10-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Added a warning if `flutter.groovy` uses a `.flutter-plugins` file. (#157388)" (#157541)" (flutter/flutter#157549) 2024-10-24 50643541+Mairramer@users.noreply.github.com Changes the offset computation to first item for RenderSliverMainAxisGroup (flutter/flutter#154688) 2024-10-24 engine-flutter-autoroll@skia.org Roll Packages from 5e03bb1 to a556f0f (7 revisions) (flutter/flutter#157539) 2024-10-24 737941+loic-sharma@users.noreply.github.com Add partial test for flutter build ios-framework on non-module (flutter/flutter#157482) 2024-10-24 737941+loic-sharma@users.noreply.github.com Add example to SafeArea docs (flutter/flutter#157228) 2024-10-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Added a warning if `flutter.groovy` uses a `.flutter-plugins` file. (#157388)" (flutter/flutter#157541) 2024-10-24 matanlurey@users.noreply.github.com Added a warning if `flutter.groovy` uses a `.flutter-plugins` file. (flutter/flutter#157388) 2024-10-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from be56084344d1 to 246344f26edc (2 revisions) (flutter/flutter#157504) 2024-10-24 104349824+huycozy@users.noreply.github.com Add ability to disable CupertinoSegmentedControl (flutter/flutter#152813) 2024-10-24 tessertaha@gmail.com Update `Tab.height` parameter doc for tab height lower than default (flutter/flutter#157443) ...

Reland of #157032. Failed tests for initial land: https://flutter-dashboard.appspot.com/#/build?hashFilter=5ca6350a06fdae8d3e160f9adbece193f34d0302&repo=flutter&branch=master These two tests run the same `flavors_test` https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20flavors_test/4579/overview https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_mokey%20flavors_test_win/988/overview which is now passing https://ci.chromium.org/ui/p/flutter/builders/try/Linux_pixel_7pro%20flavors_test/37/overview (fixed by 23c62df) The other failures seem to be flakes https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20new_gallery_impeller_old_zoom__transition_perf/4902/overview https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20tool_integration_tests_2_5/1247/overview the first is a timeout, the second passed in presubmit on the original PR and also on this PR.

…/flutter#157032)

Gray Mackall added 3 commits October 16, 2024 11:56

update versions in the script, before running...

f7ea5c3

fix exclusion in generate_gradle_lockfiles.dart

b34dc76

upgrade the tests

0856f24

github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Oct 16, 2024

gmackall commented Oct 16, 2024

View reviewed changes

gmackall added the test: all label Oct 16, 2024

gmackall mentioned this pull request Oct 16, 2024

Support host android apps with kts gradle files for add to app #156502

Merged

9 tasks

gmackall and others added 2 commits October 22, 2024 14:05

Merge branch 'master' into upgrade_to_agp87

4ce932c

make us know about more recent gradle and AGP

1eace90

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 22, 2024

empty commit to retrigger tests

0bed651

gmackall removed the test: all label Oct 22, 2024

Gray Mackall and others added 4 commits October 22, 2024 14:37

empty commit to retrigger tests 2

290beb4

Merge branch 'master' into upgrade_to_agp87

bbc107a

update the tests, and the known java version

4a9c2c3

Merge remote-tracking branch 'refs/remotes/origin/upgrade_to_agp87' i…

021d347

…nto upgrade_to_agp87

gmackall marked this pull request as ready for review October 23, 2024 19:32

gmackall requested review from bartekpacia and removed request for bartekpacia October 23, 2024 19:32

gmackall marked this pull request as draft October 23, 2024 19:33

bartekpacia approved these changes Oct 23, 2024

View reviewed changes

Gray Mackall added 2 commits October 23, 2024 14:37

change the string content of gradle wrapper file in generation script

bffd001

upgrade gradle version

4bc3626

gmackall added the revert Autorevert PR (with "Reason for revert:" comment) label Oct 24, 2024

auto-submit bot pushed a commit that referenced this pull request Oct 24, 2024

Revert "Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (#157032)"

f710ec4

This reverts commit 5ca6350.

auto-submit bot mentioned this pull request Oct 24, 2024

Reverts "Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (#157032)" #157559

Merged

9 tasks

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Oct 24, 2024

engine-flutter-autoroll mentioned this pull request Oct 25, 2024

Roll Flutter from 4faa4a415ec9 to 7e2a06657c1c (49 revisions) flutter/packages#7929

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2024

5ca6350 Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (flutter…

f291cfe

…/flutter#157032)

engine-flutter-autoroll mentioned this pull request Oct 25, 2024

Roll Flutter from 4faa4a415ec9 to 23274284a7b5 (50 revisions) flutter/packages#7931

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2024

5ca6350 Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (flutter…

5bed582

…/flutter#157032)

engine-flutter-autoroll mentioned this pull request Oct 25, 2024

Roll Flutter from 4faa4a415ec9 to c4c545215ad9 (51 revisions) flutter/packages#7932

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2024

5ca6350 Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (flutter…

2a390d5

…/flutter#157032)

engine-flutter-autoroll mentioned this pull request Oct 25, 2024

Roll Flutter from 4faa4a415ec9 to add7e81f4f5c (55 revisions) flutter/packages#7933

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2024

5ca6350 Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (flutter…

9143fbb

…/flutter#157032)

gmackall pushed a commit to gmackall/flutter that referenced this pull request Oct 25, 2024

Revert "Reverts "Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (…

7da1709

…flutter#157032)" (flutter#157559)" This reverts commit b98d9a3.

gmackall mentioned this pull request Oct 25, 2024

Reland "Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10" #157617

Merged

9 tasks

engine-flutter-autoroll mentioned this pull request Oct 25, 2024

Roll Flutter from 4faa4a415ec9 to 6337eb1a3925 (56 revisions) flutter/packages#7934

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2024

5ca6350 Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (flutter…

76ab064

…/flutter#157032)

engine-flutter-autoroll mentioned this pull request Oct 26, 2024

Roll Flutter from 4faa4a415ec9 to 9327c24d8086 (66 revisions) flutter/packages#7936

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 26, 2024

5ca6350 Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (flutter…

7ea4e68

…/flutter#157032)

engine-flutter-autoroll mentioned this pull request Oct 26, 2024

Roll Flutter from 4faa4a415ec9 to 5a11904383d1 (67 revisions) flutter/packages#7937

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 26, 2024

5ca6350 Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (flutter…

a65dcee

…/flutter#157032)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

5ca6350 Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (flutter…

d270e5b

…/flutter#157032)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

5ca6350 Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (flutter…

6c5400d

…/flutter#157032)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

5ca6350 Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (flutter…

d780098

…/flutter#157032)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

5ca6350 Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (flutter…

8150c7d

…/flutter#157032)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

5ca6350 Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (flutter…

df9d5ea

…/flutter#157032)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 #157032

Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 #157032

Uh oh!

gmackall commented Oct 16, 2024 •

edited

Loading

Uh oh!

gmackall Oct 16, 2024

Uh oh!

gmackall commented Oct 23, 2024

Uh oh!

bartekpacia left a comment

Uh oh!

bartekpacia commented Oct 23, 2024 •

edited

Loading

Uh oh!

gmackall commented Oct 23, 2024

Uh oh!

bartekpacia commented Oct 23, 2024

Uh oh!

gmackall commented Oct 24, 2024

Uh oh!

gmackall commented Oct 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 #157032

Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 #157032

Uh oh!

Conversation

gmackall commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gmackall Oct 16, 2024

Choose a reason for hiding this comment

Uh oh!

gmackall commented Oct 23, 2024

Uh oh!

bartekpacia left a comment

Choose a reason for hiding this comment

Uh oh!

bartekpacia commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gmackall commented Oct 23, 2024

Uh oh!

bartekpacia commented Oct 23, 2024

Uh oh!

gmackall commented Oct 24, 2024

Uh oh!

gmackall commented Oct 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gmackall commented Oct 16, 2024 •

edited

Loading

bartekpacia commented Oct 23, 2024 •

edited

Loading