-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Increase timeout for customer_testing test step #154339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Piinks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - in addition to the bring up, should I revert the extended timeouts once the issue is resolved?
|
Something to investigate would be whether new tests were recently added or re-enabled. If so, then I think it would be expected that this shard takes longer to run. OTOH, if the increased runtime is due to a bug in some part of Flutter, then we should consider making the timeout tighter again after fixing that bug. |
Related: flutter#154251 Successful runs are bumping right up against the timeout See https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20customer_testing/84496/overview which succeeded in 29 minutes vs. https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20customer_testing/84497/overview which failed with a timeout at 30 minutes.
Reverts increased timeouts on customer testing from #154339, also removes bringup state from #154293. This was related to #154251, which will be fixed by flutter/tests#406 (so we should land that first).
Related: #154251
Successful runs are bumping right up against the timeout
See https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20customer_testing/84496/overview which succeeded in 29 minutes vs. https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20customer_testing/84497/overview which failed with a timeout at 30 minutes.