Fix leaky tests. #153786
Merged
Fix leaky tests. #153786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| void listener(ImageInfo image, bool synchronousCall) { | ||
| addTearDown(image.dispose); | ||
| } | ||
| imageStream.addListener(ImageStreamListener(listener)); |
Contributor
There was a problem hiding this comment.
should we also remove this listener at the end of this test?
Contributor
Author
There was a problem hiding this comment.
For some reasons this one does not cause leaks if not removed.
| void listener(ImageInfo image, bool synchronousCall) { | ||
| addTearDown(image.dispose); | ||
| } | ||
| imageStream.addListener(ImageStreamListener(listener)); |
Contributor
There was a problem hiding this comment.
should we also remove this listener at the end of the test?
Contributor
Author
There was a problem hiding this comment.
For some reasons this one does not cause leaks if not removed.
Renzo-Olivares
approved these changes
Aug 20, 2024
Contributor
Renzo-Olivares
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 21, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 21, 2024
flutter/flutter@e7da16d...b8f89f7 2024-08-21 34465683+rkishan516@users.noreply.github.com docs: Update doc for scale behaviour of floating label (flutter/flutter#151835) 2024-08-21 120297255+PurplePolyhedron@users.noreply.github.com Disable Dropdown menu search during keyboard navigation (flutter/flutter#152378) 2024-08-21 matanlurey@users.noreply.github.com Add a `bin/flutter-dev` script, for running the `flutter` command-line tool from source (flutter/flutter#153599) 2024-08-21 engine-flutter-autoroll@skia.org Roll Packages from 4d2d2e3 to 4e5d47e (6 revisions) (flutter/flutter#153848) 2024-08-21 jason-simmons@users.noreply.github.com Remove unnecessary breaks in default clauses of switch statements (flutter/flutter#153843) 2024-08-21 reidbaker@google.com Create Postmortem-Platform-View-android-14-regression (flutter/flutter#149201) 2024-08-21 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#153838) 2024-08-21 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#153833) 2024-08-21 32538273+ValentinVignal@users.noreply.github.com Add tests for `SingleChildScrollView` examples (flutter/flutter#153548) 2024-08-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from b1220aa0ebf2 to b94e0097035d (3 revisions) (flutter/flutter#153817) 2024-08-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from aa1422391cf6 to b1220aa0ebf2 (1 revision) (flutter/flutter#153810) 2024-08-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from a6508d6557dc to aa1422391cf6 (2 revisions) (flutter/flutter#153808) 2024-08-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5cbf96d0a80f to a6508d6557dc (1 revision) (flutter/flutter#153806) 2024-08-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3d18f65c378a to 5cbf96d0a80f (3 revisions) (flutter/flutter#153804) 2024-08-21 nate.w5687@gmail.com `_InteractiveViewerState` code cleanup (flutter/flutter#153645) 2024-08-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from b80c831e03f7 to 3d18f65c378a (1 revision) (flutter/flutter#153797) 2024-08-20 polinach@google.com Fix leaky test. (flutter/flutter#153798) 2024-08-20 polinach@google.com Fix leaky tests. (flutter/flutter#153786) 2024-08-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 663176175b4c to b80c831e03f7 (1 revision) (flutter/flutter#153789) 2024-08-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Update template/test `compileSdk`, `targetSdk`, `ndk` versions (#152487)" (flutter/flutter#153793) 2024-08-20 34871572+gmackall@users.noreply.github.com Update template/test `compileSdk`, `targetSdk`, `ndk` versions (flutter/flutter#152487) 2024-08-20 42016383+DBowen33@users.noreply.github.com add autofocus to fix a11y issue with dialog (flutter/flutter#152637) 2024-08-20 kevinjchisholm@google.com [Release] Update bots to expect new entitlements (flutter/flutter#153787) 2024-08-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from d6bc4dc6e59d to 663176175b4c (1 revision) (flutter/flutter#153785) 2024-08-20 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#153740) 2024-08-20 victorsanniay@gmail.com Implement tap to scroll to item in CupertinoPicker (flutter/flutter#153386) 2024-08-20 polinach@google.com Fix leaky test. (flutter/flutter#153780) 2024-08-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from e10b07598091 to d6bc4dc6e59d (2 revisions) (flutter/flutter#153781) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.