Skip to content

Conversation

@ValentinVignal
Copy link
Contributor

Contributes to #130459

It adds a test for

  • examples/api/lib/widgets/single_child_scroll_view/single_child_scroll_view.0.dart
  • examples/api/lib/widgets/single_child_scroll_view/single_child_scroll_view.1.dart

I also fixed a mistake in the documentation

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Aug 16, 2024
@ValentinVignal ValentinVignal requested a review from bleroux August 16, 2024 07:38
Copy link
Contributor

@bleroux bleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great tests 👍

@ValentinVignal ValentinVignal force-pushed the flutter/api/example/Add-test-for-single-child-scroll-view branch from 91c97f6 to d45d91d Compare August 21, 2024 08:34
@ValentinVignal ValentinVignal added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 21, 2024
@auto-submit auto-submit bot merged commit 36a391f into flutter:master Aug 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 21, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 21, 2024
flutter/flutter@e7da16d...b8f89f7

2024-08-21 34465683+rkishan516@users.noreply.github.com docs: Update doc for scale behaviour of floating label (flutter/flutter#151835)
2024-08-21 120297255+PurplePolyhedron@users.noreply.github.com Disable Dropdown menu search during keyboard navigation (flutter/flutter#152378)
2024-08-21 matanlurey@users.noreply.github.com Add a `bin/flutter-dev` script, for running the `flutter` command-line tool from source (flutter/flutter#153599)
2024-08-21 engine-flutter-autoroll@skia.org Roll Packages from 4d2d2e3 to 4e5d47e (6 revisions) (flutter/flutter#153848)
2024-08-21 jason-simmons@users.noreply.github.com Remove unnecessary breaks in default clauses of switch statements (flutter/flutter#153843)
2024-08-21 reidbaker@google.com Create Postmortem-Platform-View-android-14-regression (flutter/flutter#149201)
2024-08-21 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#153838)
2024-08-21 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#153833)
2024-08-21 32538273+ValentinVignal@users.noreply.github.com Add tests for `SingleChildScrollView` examples (flutter/flutter#153548)
2024-08-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from b1220aa0ebf2 to b94e0097035d (3 revisions) (flutter/flutter#153817)
2024-08-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from aa1422391cf6 to b1220aa0ebf2 (1 revision) (flutter/flutter#153810)
2024-08-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from a6508d6557dc to aa1422391cf6 (2 revisions) (flutter/flutter#153808)
2024-08-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5cbf96d0a80f to a6508d6557dc (1 revision) (flutter/flutter#153806)
2024-08-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3d18f65c378a to 5cbf96d0a80f (3 revisions) (flutter/flutter#153804)
2024-08-21 nate.w5687@gmail.com `_InteractiveViewerState` code cleanup (flutter/flutter#153645)
2024-08-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from b80c831e03f7 to 3d18f65c378a (1 revision) (flutter/flutter#153797)
2024-08-20 polinach@google.com Fix leaky test. (flutter/flutter#153798)
2024-08-20 polinach@google.com Fix leaky tests. (flutter/flutter#153786)
2024-08-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 663176175b4c to b80c831e03f7 (1 revision) (flutter/flutter#153789)
2024-08-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Update template/test `compileSdk`, `targetSdk`, `ndk` versions (#152487)" (flutter/flutter#153793)
2024-08-20 34871572+gmackall@users.noreply.github.com Update template/test `compileSdk`, `targetSdk`, `ndk` versions (flutter/flutter#152487)
2024-08-20 42016383+DBowen33@users.noreply.github.com add autofocus to fix a11y issue with dialog (flutter/flutter#152637)
2024-08-20 kevinjchisholm@google.com [Release] Update bots to expect new entitlements (flutter/flutter#153787)
2024-08-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from d6bc4dc6e59d to 663176175b4c (1 revision) (flutter/flutter#153785)
2024-08-20 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#153740)
2024-08-20 victorsanniay@gmail.com Implement tap to scroll to item in CupertinoPicker (flutter/flutter#153386)
2024-08-20 polinach@google.com Fix leaky test. (flutter/flutter#153780)
2024-08-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from e10b07598091 to d6bc4dc6e59d (2 revisions) (flutter/flutter#153781)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
Contributes to flutter#130459

It adds a test for
- `examples/api/lib/widgets/single_child_scroll_view/single_child_scroll_view.0.dart`
- `examples/api/lib/widgets/single_child_scroll_view/single_child_scroll_view.1.dart`

I also fixed a mistake in the documentation
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants