Skip to content

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Jun 13, 2024

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@chunhtai chunhtai requested a review from yjbanov June 13, 2024 18:15
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 13, 2024
@auto-submit auto-submit bot merged commit 1330675 into flutter:master Jun 13, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 14, 2024
flutter/flutter@01db23b...349ec71

2024-06-14 32538273+ValentinVignal@users.noreply.github.com Add tests for navigator.0.dart (flutter/flutter#150034)
2024-06-14 parlough@gmail.com Switch to `Iterable.cast` instance method (flutter/flutter#150185)
2024-06-14 65806473+Zabadam@users.noreply.github.com Include transform in static Gradient lerp methods (flutter/flutter#149624)
2024-06-14 parlough@gmail.com Validate the `contrastLevel` during `ColorScheme` creation (flutter/flutter#150176)
2024-06-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.9 to 3.25.10 (flutter/flutter#150228)
2024-06-13 polinach@google.com Fix leaky test. (flutter/flutter#150235)
2024-06-13 109111084+yaakovschectman@users.noreply.github.com Document CIPD role & login for upgrading Android engine (flutter/flutter#149433)
2024-06-13 36861262+QuncCccccc@users.noreply.github.com Update doc for `ColorScheme.surface` (flutter/flutter#150212)
2024-06-13 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#150206)
2024-06-13 47866232+chunhtai@users.noreply.github.com Bump new release for a11y_assessment (flutter/flutter#150213)
2024-06-13 kustermann@google.com Use --(no-)strip-wams instead of --(no-)-name-section in `dart compile wasm` (flutter/flutter#149641)
2024-06-13 34871572+gmackall@users.noreply.github.com Reland "Identify and re-throw our dependency checking errors in flutter.groovy" (flutter/flutter#150128)
2024-06-13 kustermann@google.com Use --(no-)strip-wams instead of --(no-)-name-section in `dart compile wasm` (flutter/flutter#150180)
2024-06-13 matanlurey@users.noreply.github.com Suppress Flutter update check if `--machine` is present at all. (flutter/flutter#150138)
2024-06-13 tessertaha@gmail.com [Reland] Introduce `ChipAnimationStyle` to override default chips animations durations (flutter/flutter#149876)
2024-06-13 parlough@gmail.com Update framework and flutter fix flutter.dev/docs links (flutter/flutter#150174)
2024-06-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4cb3025d3abf to 8167dffd1914 (2 revisions) (flutter/flutter#150208)
2024-06-13 leroux_bruno@yahoo.fr Replace InputDecorator M3 golden test (flutter/flutter#150111)
2024-06-13 engine-flutter-autoroll@skia.org Roll Packages from 260102b to 7805455 (2 revisions) (flutter/flutter#150198)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jun 14, 2024
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jun 14, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants