Suppress Flutter update check if --machine is present at all.
#150138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkolos
approved these changes
Jun 12, 2024
| return super.run(args); | ||
| } | ||
|
|
||
| /// Whether to perform a flutter version check, which prints a warning if old. |
Contributor
There was a problem hiding this comment.
Nit: Should a function's doc string explain (and thus be coupled to) what the caller(s) plan to do with it? (Not a big deal here since this comment is unlikely to become incorrect)
packages/flutter_tools/lib/src/runner/flutter_command_runner.dart
Outdated
Show resolved
Hide resolved
Update packages/flutter_tools/lib/src/runner/flutter_command_runner.dart Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com> ++
272570b to
0250bae
Compare
Contributor
|
auto label is removed for flutter/flutter/150138, due to - The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
auto label is removed for flutter/flutter/150138, due to - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
auto label is removed for flutter/flutter/150138, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 14, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 14, 2024
flutter/flutter@01db23b...349ec71 2024-06-14 32538273+ValentinVignal@users.noreply.github.com Add tests for navigator.0.dart (flutter/flutter#150034) 2024-06-14 parlough@gmail.com Switch to `Iterable.cast` instance method (flutter/flutter#150185) 2024-06-14 65806473+Zabadam@users.noreply.github.com Include transform in static Gradient lerp methods (flutter/flutter#149624) 2024-06-14 parlough@gmail.com Validate the `contrastLevel` during `ColorScheme` creation (flutter/flutter#150176) 2024-06-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.9 to 3.25.10 (flutter/flutter#150228) 2024-06-13 polinach@google.com Fix leaky test. (flutter/flutter#150235) 2024-06-13 109111084+yaakovschectman@users.noreply.github.com Document CIPD role & login for upgrading Android engine (flutter/flutter#149433) 2024-06-13 36861262+QuncCccccc@users.noreply.github.com Update doc for `ColorScheme.surface` (flutter/flutter#150212) 2024-06-13 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#150206) 2024-06-13 47866232+chunhtai@users.noreply.github.com Bump new release for a11y_assessment (flutter/flutter#150213) 2024-06-13 kustermann@google.com Use --(no-)strip-wams instead of --(no-)-name-section in `dart compile wasm` (flutter/flutter#149641) 2024-06-13 34871572+gmackall@users.noreply.github.com Reland "Identify and re-throw our dependency checking errors in flutter.groovy" (flutter/flutter#150128) 2024-06-13 kustermann@google.com Use --(no-)strip-wams instead of --(no-)-name-section in `dart compile wasm` (flutter/flutter#150180) 2024-06-13 matanlurey@users.noreply.github.com Suppress Flutter update check if `--machine` is present at all. (flutter/flutter#150138) 2024-06-13 tessertaha@gmail.com [Reland] Introduce `ChipAnimationStyle` to override default chips animations durations (flutter/flutter#149876) 2024-06-13 parlough@gmail.com Update framework and flutter fix flutter.dev/docs links (flutter/flutter#150174) 2024-06-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4cb3025d3abf to 8167dffd1914 (2 revisions) (flutter/flutter#150208) 2024-06-13 leroux_bruno@yahoo.fr Replace InputDecorator M3 golden test (flutter/flutter#150111) 2024-06-13 engine-flutter-autoroll@skia.org Roll Packages from 260102b to 7805455 (2 revisions) (flutter/flutter#150198) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
…ter#150138) Fixes flutter#145158. In an ideal world, the `--machine` flag would be strictly a global flag which sub-commands can choose to use (or perhaps just to report a `toolExit` that they don't have a `--machine` supported-mode if not. However currently, there is both a global flag, and command-specific flags. This leads to the confusing scenario where: ```sh flutter devices --machine ``` ... still checks for a Flutter update, printing a banner and breaking the JSON output. This PR "fixes" that by allowing `--machine` _anywhere_ in the command-line arguments to suppress the check. /cc @johnmccutchan.
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
…ter#150138) Fixes flutter#145158. In an ideal world, the `--machine` flag would be strictly a global flag which sub-commands can choose to use (or perhaps just to report a `toolExit` that they don't have a `--machine` supported-mode if not. However currently, there is both a global flag, and command-specific flags. This leads to the confusing scenario where: ```sh flutter devices --machine ``` ... still checks for a Flutter update, printing a banner and breaking the JSON output. This PR "fixes" that by allowing `--machine` _anywhere_ in the command-line arguments to suppress the check. /cc @johnmccutchan.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
This was referenced Jul 21, 2025
azatech
pushed a commit
to azatech/flutter
that referenced
this pull request
Jul 28, 2025
Was already fixed in flutter#150138, so removes duplicate flag. Already tested by existing test suite.
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
Was already fixed in flutter#150138, so removes duplicate flag. Already tested by existing test suite.
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
Was already fixed in flutter#150138, so removes duplicate flag. Already tested by existing test suite.
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
Was already fixed in flutter#150138, so removes duplicate flag. Already tested by existing test suite.
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
Was already fixed in flutter#150138, so removes duplicate flag. Already tested by existing test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145158.
In an ideal world, the
--machineflag would be strictly a global flag which sub-commands can choose to use (or perhaps just to report atoolExitthat they don't have a--machinesupported-mode if not. However currently, there is both a global flag, and command-specific flags.This leads to the confusing scenario where:
... still checks for a Flutter update, printing a banner and breaking the JSON output.
This PR "fixes" that by allowing
--machineanywhere in the command-line arguments to suppress the check./cc @johnmccutchan.