Fix semantic debugger #147953
Merged
Fix semantic debugger #147953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4627bbd to
8c7bc0e
Compare
1aa2b3b to
766a33c
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken in #122452. The culprit is that
PipelineOwner.ensureSemanticsdoesn't turn on semantics for the entire app, it pretends to only turn it on for the localPipelineOwner. Unfortunately, that localPipelineOwneris never informed that it should produce semantics when semantics are not turned on globally. So,PipelineOwner.ensureSemanticsis essentially without effect if semantics are not already turned on globally.I can't think of a use case where it would be useful to only turn on semantics for a particular pipeline owner and fixing
PipelineOwner.ensureSemanticswould get pretty messy with performance implications even if semantics are turned off. So, this PR deprecates that functionality and moves theSemanticsDebuggerto the global semantics API.Fixes #147665.