Skip to content

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented May 1, 2024

For #147609 to unblock the tree.

@gspencergoog @jason-simmons

@zanderso zanderso requested a review from johnmccutchan May 1, 2024 14:33
@zanderso zanderso added warning: land on red to fix tree breakage autosubmit Merge PR when tree becomes green via auto submit App labels May 1, 2024
@zanderso
Copy link
Member Author

zanderso commented May 1, 2024

Landing without waiting for all presubs to finish since this change only makes the two noted tests non-blocking.

@zanderso zanderso merged commit cb2197e into master May 1, 2024
@zanderso zanderso deleted the zanderso-patch-1 branch May 1, 2024 14:41
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 1, 2024
flutter/flutter@b597dd2...d33bb8f

2024-05-01 sokolovskyi.konstantin@gmail.com Add tests for single_activator.0.dart API example. (flutter/flutter#147426)
2024-05-01 Dhankechakishan@gmail.com Added missing code block language in docs (flutter/flutter#147481)
2024-05-01 zanderso@users.noreply.github.com Move docs_test and docs_publish to bringup (flutter/flutter#147645)
2024-05-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix memory leak in `TabPageSelector`  (#147403)" (flutter/flutter#147622)
2024-04-30 47866232+chunhtai@users.noreply.github.com Revert "add a new PopScope.onPopWithResultInvoke widget to replace Po� (flutter/flutter#147597)
2024-04-30 andrewrkolos@gmail.com include exception details in tool exit displayed when adb call fails (flutter/flutter#147498)
2024-04-30 32538273+ValentinVignal@users.noreply.github.com Fix memory leak in `TabPageSelector`  (flutter/flutter#147403)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot pushed a commit that referenced this pull request May 3, 2024
## Description

This moves the snippets package back into the Flutter repo so that API documentation generation can happen without the use of `dart pub global run` because `pub run` doesn't handle concurrency well.

The change modifies the dartdoc building process to include building an executable from the snippets tool and installing that in the cache directory for use during docs generation.

The snippets tool will reside in dev/snippets, where it originally resided before being moved to https://github.com/flutter/assets-for-api-docs.

The snippets code itself is unchanged from the code that is in https://github.com/flutter/assets-for-api-docs/packages/snippets.

## Related Issues
 - #144408
 - #147609
 - #147645

## Tests
 - Added snippets tests to the overall testing build.
auto-submit bot pushed a commit that referenced this pull request May 7, 2024
…l. (#147893)

## Description

This fixes the API doc generation that I broke when I moved the snippets tool into the framework.

It removes the last of the template support (properly this time), and makes sure all of the tests pass.

## Related Issues
 - #144408
 - #147609
 - #147645

## Tests
 - Fixed tests, including smoke test of doc generation.
gspencergoog added a commit to gspencergoog/flutter that referenced this pull request May 7, 2024
This reverts commit cb2197e to move
docs_test and docs_publish back to normal mode after being fixed.
auto-submit bot pushed a commit that referenced this pull request May 7, 2024
## Description

This reverts commit cb2197e to move `docs_test` and `docs_publish` back to normal mode after being fixed.

## Related Issues
 - #147609
 - #147645
itsjustkevin pushed a commit to itsjustkevin/flutter that referenced this pull request May 8, 2024
This moves the snippets package back into the Flutter repo so that API documentation generation can happen without the use of `dart pub global run` because `pub run` doesn't handle concurrency well.

The change modifies the dartdoc building process to include building an executable from the snippets tool and installing that in the cache directory for use during docs generation.

The snippets tool will reside in dev/snippets, where it originally resided before being moved to https://github.com/flutter/assets-for-api-docs.

The snippets code itself is unchanged from the code that is in https://github.com/flutter/assets-for-api-docs/packages/snippets.

 - flutter#144408
 - flutter#147609
 - flutter#147645

 - Added snippets tests to the overall testing build.
itsjustkevin pushed a commit to itsjustkevin/flutter that referenced this pull request May 8, 2024
…l. (flutter#147893)

## Description

This fixes the API doc generation that I broke when I moved the snippets tool into the framework.

It removes the last of the template support (properly this time), and makes sure all of the tests pass.

## Related Issues
 - flutter#144408
 - flutter#147609
 - flutter#147645

## Tests
 - Fixed tests, including smoke test of doc generation.
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
flutter/flutter@b597dd2...d33bb8f

2024-05-01 sokolovskyi.konstantin@gmail.com Add tests for single_activator.0.dart API example. (flutter/flutter#147426)
2024-05-01 Dhankechakishan@gmail.com Added missing code block language in docs (flutter/flutter#147481)
2024-05-01 zanderso@users.noreply.github.com Move docs_test and docs_publish to bringup (flutter/flutter#147645)
2024-05-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix memory leak in `TabPageSelector`  (#147403)" (flutter/flutter#147622)
2024-04-30 47866232+chunhtai@users.noreply.github.com Revert "add a new PopScope.onPopWithResultInvoke widget to replace Po� (flutter/flutter#147597)
2024-04-30 andrewrkolos@gmail.com include exception details in tool exit displayed when adb call fails (flutter/flutter#147498)
2024-04-30 32538273+ValentinVignal@users.noreply.github.com Fix memory leak in `TabPageSelector`  (flutter/flutter#147403)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants